On Wed, 2 Dec 2020 22:04:17 GMT, Erik Joelsson wrote:
>> We are indeed missing the macos-version-min argument when linking
>> libjvm.dylib. This is a bug.
>
> Filed https://bugs.openjdk.java.net/browse/JDK-8257633
Thanks for taking care of those issues. To be clear, there is no real need to
bu
On Thu, 3 Dec 2020 01:08:18 GMT, Stuart Marks wrote:
> Some small doc changes. The changes are to `@apiNote` text, which is
> non-normative, so no CSR is required.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1585
On Thu, 3 Dec 2020 01:08:18 GMT, Stuart Marks wrote:
> Some small doc changes. The changes are to `@apiNote` text, which is
> non-normative, so no CSR is required.
+1
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1585
On Thu, 3 Dec 2020 01:08:18 GMT, Stuart Marks wrote:
> Some small doc changes. The changes are to `@apiNote` text, which is
> non-normative, so no CSR is required.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1585
Some small doc changes. The changes are to `@apiNote` text, which is
non-normative, so no CSR is required.
-
Commit messages:
- 8228615: Optional.empty() doc should suggest isEmpty() instead of isPresent()
Changes: https://git.openjdk.java.net/jdk/pull/1585/files
Webrev: https://w
On Tue, 1 Dec 2020 19:30:45 GMT, Calvin Cheung wrote:
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an archive.
>
> - Not passing the `initialize` (same as `
On Wed, 2 Dec 2020 22:00:55 GMT, Erik Joelsson wrote:
>> The current intention is to be consistent with the min system version and
>> it's currently set to 10.9. If libjvm.dylib gets a different value, then
>> that would be a bug, but note that this could also vary depending on how the
>> buil
On Wed, 2 Dec 2020 21:57:15 GMT, Erik Joelsson wrote:
>> Interesting, I still able to run the build after this change on macOS
>> 10.9.5. I use jdk image and there is no LC_VERSION_MIN_MACOSX in libjvm.
>> libjli, libjava have one, and it's 10.9
>
> The current intention is to be consistent wit
On Wed, 2 Dec 2020 21:32:46 GMT, Anton Kozlov wrote:
>> I wonder if we should be "upping" that to something later.
>> 10.9 is over 7 years old and has been out of support for what - 4 years ?
>
> Interesting, I still able to run the build after this change on macOS 10.9.5.
> I use jdk image and
On Thu, 26 Nov 2020 13:13:43 GMT, Vladimir Ivanov wrote:
> Introduce sharing of `LambdaForms` for `VarHandle` linkers and invokers.
> It reduces the number of LambdaForms needed at runtime.
>
> Testing: tier1-4
This pull request has now been integrated.
Changeset: 7104400a
Author:Vladimir
On Wed, 2 Dec 2020 20:19:54 GMT, Phil Race wrote:
>> Unfortunately, no. AFAIK, the minimum target version is 10.9
>> https://github.com/openjdk/jdk/blob/master/make/autoconf/flags.m4#L133, so I
>> had to keep indirection.
>
> I wonder if we should be "upping" that to something later.
> 10.9 is
On Mon, 30 Nov 2020 17:44:13 GMT, Roger Riggs wrote:
>> Ivan Šipka has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits si
> @iignatev could you please review? Thank you.
>
> note to self:
> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
> test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java
> test
On Wed, 2 Dec 2020 18:47:10 GMT, Maurizio Cimadamore
wrote:
> The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
> annotations. This causes odd behavior on certain benchmarks, especially if
> these methods are called many times in the body of a single method.
Marked a
On Mon, 30 Nov 2020 21:10:13 GMT, Igor Ignatyev wrote:
>> Ivan Šipka has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8257516: removing trailing space
>
> @frkator, you will need to open a new JBS ticket for this change.
> @iignatev as f
On Mon, 30 Nov 2020 21:10:13 GMT, Igor Ignatyev wrote:
>> Ivan Šipka has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8257516: removing trailing space
>
> @frkator, you will need to open a new JBS ticket for this change.
@iignatev as for
Refactor `test/jdk/java/lang/SecurityManager/modules/CustomSecurityManager.sh`
as java test.
-
Commit messages:
- 8166026: Refactor java/lang shell tests to java
Changes: https://git.openjdk.java.net/jdk/pull/1579/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1579&ra
> On Dec 2, 2020, at 12:22 PM, Phil Race wrote:
>
> On Wed, 2 Dec 2020 20:04:12 GMT, Anton Kozlov wrote:
>
>>> Surely these days you can just call [NSProcessInfo operatingSystemVersion]
>>> directly ?
>>> If I read the doc below it is in the 10.10 SDK and later.
>>> https://developer.apple.com
On Mon, 30 Nov 2020 17:53:07 GMT, Roger Riggs wrote:
>> @iignatev could you please review? Thank you.
>>
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
>> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
>> test/jdk/java/lang/
On Mon, 30 Nov 2020 21:32:35 GMT, Igor Ignatyev wrote:
>> @iignatev could you please review? Thank you.
>>
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
>> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
>> test/jdk/java/lan
Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test.
-
Commit messages:
- 8166026: Refactor java/lang shell tests to java
Changes: https://git.openjdk.java.net/jdk/pull/1578/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1578&range=00
Issue: https
Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java test.
-
Commit messages:
- 8166026: Refactor java/lang shell tests to java
Changes: https://git.openjdk.java.net/jdk/pull/1577/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1577&range=00
Issue
On Mon, 30 Nov 2020 21:36:40 GMT, Igor Ignatyev wrote:
>> @iignatev could you please review? Thank you.
>>
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
>> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
>> test/jdk/java/lan
On Wed, 2 Dec 2020 20:04:12 GMT, Anton Kozlov wrote:
>> Surely these days you can just call [NSProcessInfo operatingSystemVersion]
>> directly ?
>> If I read the doc below it is in the 10.10 SDK and later.
>> https://developer.apple.com/documentation/foundation/nsprocessinfo/1410906-operatingsys
On Wed, 2 Dec 2020 19:27:25 GMT, Phil Race wrote:
>> Please review a small change that replaces use of objc_msgSend_stret in
>> macOS platform code with pure ObjC code. It's also a prerequisite for
>> macOS/AArch64 support, where objc_msgSend_stret is not available.
>
> Surely these days you ca
On Wed, 2 Dec 2020 17:57:22 GMT, Mandy Chung wrote:
> I suggest `Class::getPermittedSubclasses` to return a `non-null` array if
> this `Class` is sealed, i.e. this class is derived from a `class` file with
> the presence of `PermittedSubclasses` attribute regardless of its content
> (the attri
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote:
> Please review a small change that replaces use of objc_msgSend_stret in macOS
> platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
> support, where objc_msgSend_stret is not available.
Surely these days you can j
On Sat, 21 Nov 2020 08:32:17 GMT, Christoph Langer wrote:
> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to
> leaking socket resources after JDK-8224829.
>
> The close method calls duplexCloseOutput() and duplexCloseInput(). In case of
> an exception in any of these m
On Wed, 2 Dec 2020 18:47:10 GMT, Maurizio Cimadamore
wrote:
> The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
> annotations. This causes odd behavior on certain benchmarks, especially if
> these methods are called many times in the body of a single method.
Marked a
On Wed, 2 Dec 2020 18:45:52 GMT, Daniel Fuchs wrote:
>> The attribute_length of known Module attributes in the module-info.class
>> is currently ignored. It should be checked and the class rejected if the
>> attribute length doesn't exactly match the length of the info in the
>> attribute.
On Wed, 2 Dec 2020 18:42:36 GMT, Christoph Langer wrote:
>> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 37:
>>
>>> 35: * will not leave leaking socket file descriptors
>>> 36: * @library /test/lib
>>> 37: * @run main/othervm SSLSocketLeak
>>
>> See bellow comment
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote:
>> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to
>> leaking socket resources after JDK-8224829.
>>
>> The close method calls duplexCloseOutput() and duplexCloseInput(). In case
>> of an exception in any of th
The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
annotations. This causes odd behavior on certain benchmarks, especially if
these methods are called many times in the body of a single method.
-
Commit messages:
- Add new benchmarks
- Add @ForceInline ann
On Tue, 24 Nov 2020 10:58:43 GMT, Alan Bateman wrote:
> The attribute_length of known Module attributes in the module-info.class
> is currently ignored. It should be checked and the class rejected if the
> attribute length doesn't exactly match the length of the info in the
> attribute.
>
On Wed, 2 Dec 2020 18:01:04 GMT, Xue-Lei Andrew Fan wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small test improvement
>
> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 37:
>
>> 35: *
The attribute_length of known Module attributes in the module-info.class is
currently ignored. It should be checked and the class rejected if the attribute
length doesn't exactly match the length of the info in the attribute.
There are several ways to fix this. I initially limited the readin
On Tue, 24 Nov 2020 10:58:43 GMT, Alan Bateman wrote:
> The attribute_length of known Module attributes in the module-info.class
> is currently ignored. It should be checked and the class rejected if the
> attribute length doesn't exactly match the length of the info in the
> attribute.
>
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote:
>> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to
>> leaking socket resources after JDK-8224829.
>>
>> The close method calls duplexCloseOutput() and duplexCloseInput(). In case
>> of an exception in any of th
On Wed, 2 Dec 2020 17:39:59 GMT, Jan Lahoda wrote:
> Additional changes may be needed to Class.permittedSubclasses() and/or
> Class.isSealed() as part of fixing bug JDK-8256867. The JVM is being changed
> to treat classes with empty PermittedSubclasses attributes as sealed classes
> that canno
On Wed, 2 Dec 2020 17:39:59 GMT, Jan Lahoda wrote:
> ...
> Uh, I just realized it may be necessary to implement `Class.isSealed()`
> differently. Consider:
>
> ```
> sealed class Sealed permits Unknown {}
> ```
>
> Where `Unknown` does not exist at runtime. So getPermittedSubclasses0()
> retu
Please review a small change that replaces use of objc_msgSend_stret in macOS
platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
support, where objc_msgSend_stret is not available.
-
Commit messages:
- Do not use objc_msgSend_stret to get macOS version
C
On Wed, 2 Dec 2020 14:28:00 GMT, Harold Seigel wrote:
> Additional changes may be needed to Class.permittedSubclasses() and/or
> Class.isSealed() as part of fixing bug JDK-8256867. The JVM is being changed
> to treat classes with empty PermittedSubclasses attributes as sealed classes
> that ca
On Mon, 30 Nov 2020 19:38:56 GMT, Paul Sandoz wrote:
>> Introduce sharing of `LambdaForms` for `VarHandle` linkers and invokers.
>> It reduces the number of LambdaForms needed at runtime.
>>
>> Testing: tier1-4
>
> Marked as reviewed by psandoz (Reviewer).
Thanks for the reviews, Claes, Vladimi
On Thu, 26 Nov 2020 21:23:16 GMT, Vladimir Ivanov wrote:
> Concurrent updates may lead to redundant LambdaForms created and unnecessary
> class loading when those are compiled.
>
> Most notably, it severely affects MethodHandle customization: when a
> MethodHandle is called from multiple thre
On Mon, 30 Nov 2020 19:32:54 GMT, Paul Sandoz wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> comm
On Wed, 2 Dec 2020 17:28:15 GMT, Vladimir Ivanov wrote:
>> Marked as reviewed by psandoz (Reviewer).
>
> Thanks for the reviews, Claes, Paul, and Peter.
\integrate
-
PR: https://git.openjdk.java.net/jdk/pull/1472
On Wed, 2 Dec 2020 15:30:07 GMT, Peter Levart wrote:
>>> Would it make a difference if MH.form was not final and each read access to
>>> it was done via appropriate Unsafe.getReferenceXXX()?
>>
>> It would break inlining through MH calls. JITs trust `MH.form` and
>> aggressively inline through
On Wed, 2 Dec 2020 01:12:17 GMT, Calvin Cheung wrote:
>> Please review this change which includes:
>>
>> - If the `jdk.internal.lambda.disableEagerInitialization`property is
>> enabled, the `InnerClassLambdaMetafactory` will not involve CDS to archive
>> lambda proxy classes or to find them fr
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
On Wed, 2 Dec 2020 14:51:23 GMT, Julia Boes wrote:
> Now that the changes for record serialization are integrated into the Java
> Object Serialization Specification, this change updates the serialization
> javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
> java.lang.Record.
On Wed, 2 Dec 2020 14:55:18 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified paramet
On Wed, 2 Dec 2020 14:51:23 GMT, Julia Boes wrote:
> Now that the changes for record serialization are integrated into the Java
> Object Serialization Specification, this change updates the serialization
> javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
> java.lang.Record.
On Wed, 2 Dec 2020 15:24:47 GMT, Vladimir Ivanov wrote:
>> Would it make a difference if MH.form was not final and each read access to
>> it was done via appropriate Unsafe.getReferenceXXX()?
>
>> Would it make a difference if MH.form was not final and each read access to
>> it was done via app
On Wed, 2 Dec 2020 14:36:16 GMT, Peter Levart wrote:
> Would it make a difference if MH.form was not final and each read access to
> it was done via appropriate Unsafe.getReferenceXXX()?
It would break inlining through MH calls. JITs trust `MH.form` and aggressively
inline through it.
>I was
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
Now that the changes for record serialization are integrated into the Java
Object Serialization Specification, this change updates the serialization
javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
java.lang.Record. Additionally, the suppression of preview related warnings is
On Wed, 2 Dec 2020 14:30:57 GMT, Peter Levart wrote:
>> Thanks for the review, Peter.
>> The contract of `updateForm` clearly states that there are no guarantees
>> provided about visibility:
>> /**
>> * Replace the old lambda form of this method handle with a new one.
>> * The new
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference conversion to allow for stricter
>> checking of cast c
On Wed, 2 Dec 2020 11:37:07 GMT, Vladimir Ivanov wrote:
>> I mean, is it possible that some threads that concurrently use the old
>> uncustomized form while one thread is customizing it, trigger JIT
>> compilation and because `form` field is trusted final, the JITed code will
>> be using the u
On Tue, 1 Dec 2020 23:16:45 GMT, Mandy Chung wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing ref
On Wed, 2 Dec 2020 11:14:18 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Increased memory to 4G for the test and add diagnostic info for OOME
>
> Changes requested by dfuchs (Reviewer).
@dfuch
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
On Wed, 2 Dec 2020 12:11:16 GMT, Jan Lahoda wrote:
>> Yes, would be a surprise if getPermittedSubclasses returned Class objects
>> for classes that are not subclasses. I think it should be okay to separate
>> that out to a separate issue so that it can be further re-examined after JEP
>> 397 g
On Wed, 2 Dec 2020 12:08:09 GMT, Alan Bateman wrote:
>> @lahodaj It is okay with me if `getPermittedSubclasses` returns the
>> permitted subtypes matching the runtime view (that matches the current
>> specification to me) and revisit this API as a follow up.
>
> Yes, would be a surprise if get
On Tue, 1 Dec 2020 23:19:41 GMT, Mandy Chung wrote:
>> I was investigating a little today. One thing to note is that there is a
>> difference between the JLS and JVMS[1] restrictions - the JVMS restrictions
>> only require the classes to be in the same module, but they can be in any
>> package
> Concurrent updates may lead to redundant LambdaForms created and unnecessary
> class loading when those are compiled.
>
> Most notably, it severely affects MethodHandle customization: when a
> MethodHandle is called from multiple threads, every thread starts
> customization which takes enoug
On Tue, 1 Dec 2020 15:55:36 GMT, Peter Levart wrote:
>> It seems that I was right. See `ciField.cpp`:
>>
>> static bool trust_final_non_static_fields(ciInstanceKlass* holder) {
>> if (holder == NULL)
>> return false;
>> if (holder->name() == ciSymbol::java_lang_System())
>> // Never
On Tue, 1 Dec 2020 22:50:19 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified paramet
On Tue, 1 Dec 2020 16:08:05 GMT, Roger Riggs wrote:
> This is a private method, documented more than is usual.
Sorry - my comment was misplaced. I was mostly concerned with the *public*
methods that follow.
(` public int fromHexDigits(CharSequence string)` and friends)
They all say that `* The
Hello, I'd like to raise awareness for
https://bugs.openjdk.java.net/browse/JDK-8180352
https://bugs.openjdk.java.net/browse/JDK-8072984
https://bugs.openjdk.java.net/browse/JDK-8065554
These all ask for MatchResult.group(String name). What they don't
mention is that this is more urgent in ligh
On Tue, 1 Dec 2020 21:04:34 GMT, Mandy Chung wrote:
> `{@link ... final}` should be `@linkplain`. Otherwise, looks good.
Oops! Yes, changed.
-
PR: https://git.openjdk.java.net/jdk/pull/1543
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a Record Attribute. Since these checks are not performed
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a Record Attribute. Since these checks are not performed
74 matches
Mail list logo
