On Fri, 11 Dec 2020 17:58:33 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with RecordComponents attributes.
>
> See the discussion at
> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
>
>
On Thu, Dec 10, 2020 at 9:25 PM Brian Burkhalter
wrote:
>
> Hi Philippe,
>
> On Dec 10, 2020, at 12:03 PM, Philippe Marschall
> wrote:
>
> ...
>
>
> I think that core-libs-dev (CCed) would be more appropriate as java.io
> package changes are usually discussed there.
Thank you.
> Do you have
Awesome, I'll work on a PR for this then.
Cheers
Philippe
On Thu, Dec 10, 2020 at 10:04 PM Pavel Rappo wrote:
>
> I found this relevant issue created 17 years ago:
> https://bugs.openjdk.java.net/browse/JDK-4926314
>
> > On 10 Dec 2020, at 20:23, Brian Burkhalter
> > wrote:
> >
> > Hi
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
This pull request has now been integrated.
Changeset: 74b79c6e
Author:Naoto Sato
URL:
> jaxp.library.SimpleHttpServer
> https://bugs.openjdk.java.net/browse/JDK-8212035
Mahendra Chhipa has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-8212035' of https://github.com/mahendrachhipa/jdk into
JDK-8212035
-
On Tue, 8 Dec 2020 18:01:20 GMT, Daniel Fuchs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/lib/jdk/test/lib/net/SimpleHttpServer.java line 83:
>
>> 81:
> jaxp.library.SimpleHttpServer
> https://bugs.openjdk.java.net/browse/JDK-8212035
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemnted the review comments.
-
Changes:
- all:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with RecordComponents attributes.
>
> See the discussion at
> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
>
> That fixes trusting final fields of records to align
On Fri, 11 Dec 2020 19:29:09 GMT, Mandy Chung wrote:
>> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
>> classes with RecordComponents attributes.
>>
>> See the discussion at
>> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
On Fri, 11 Dec 2020 19:29:09 GMT, Mandy Chung wrote:
>> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
>> classes with RecordComponents attributes.
>>
>> See the discussion at
>> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with RecordComponents attributes.
>
> See the discussion at
> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
>
> That fixes trusting final fields of records to align
On Fri, 11 Dec 2020 17:58:33 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with RecordComponents attributes.
>
> See the discussion at
> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
>
>
On Fri, 11 Dec 2020 05:02:25 GMT, Vicente Romero wrote:
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote:
> increase retries and timeout increasing in runMsiexecWithRetries
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/1676
On Fri, 11 Dec 2020 17:58:33 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with RecordComponents attributes.
>
> See the discussion at
> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
>
>
On Thu, 10 Dec 2020 22:59:16 GMT, Mandy Chung wrote:
>> Hi Remi,
>>
>>> For me, it's backout JDK-8247444, as i said on the amber-spec-expert, i
>>> prefer VM to be oblivious about java.lang.Record.
>>> And in the future, the real fix is to change the spec of Field.set() to say
>>> that it's
On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with `RecordComponents` attributes. That introduces a regression in
> `InstanceKlass::is_record` that returns true on a non-record class which has
>
This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
classes with RecordComponents attributes.
See the discussion at
https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-December/002670.html
That fixes trusting final fields of records to align with the JLS
On Fri, 11 Dec 2020 15:52:13 GMT, Vicente Romero wrote:
>> Please review this patch which modifies the spec for method
>> java.lang.Record::equals. It states that the implementation of this method
>> should use the record fields for the comparison instead of the accessors.
>>
>> TIA,
>>
On Fri, 11 Dec 2020 01:28:59 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleProvidersRun.java line 177:
>>
>>> 175:
>>> 176: //testing 8257964 fix. (macOS/Windows only)
>>> 177: testRun("HOST", "bug8257964Test", "", "", "");
>>
>> This test runs only if the platform
On Tue, 8 Dec 2020 16:51:02 GMT, Mahendra Chhipa
wrote:
>> jaxp.library.SimpleHttpServer
>> https://bugs.openjdk.java.net/browse/JDK-8212035
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review
Hello,
> On Dec 11, 2020, at 8:31 AM, Philippe Marschall
> wrote:
>
>> Do you have the ability to file an issue? If not, I can do so.
>
> I don't have the ability to file an issue. The bug that Pavel found is
> enough for me to work on for now. If you believe pursuing two other
> improvements
On Wed, 9 Dec 2020 16:46:54 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
Vicente Romero has updated the pull request incrementally
On Fri, 11 Dec 2020 09:44:33 GMT, Chris Hegarty wrote:
> The change and test look good to me. Thanks Vicente.
>
> I have just one minor comment on the location of the test. I know there is
> not always a clear and clean separation across component areas, but another
> possible location, for
On Wed, 9 Dec 2020 18:41:02 GMT, Pavel Rappo wrote:
>> Martin Buchholz has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> JDK-8234131
>
> The changes to doc comments look good.
>
> Thanks for incorporating my
On Wed, 2 Dec 2020 20:45:11 GMT, Ivan Šipka wrote:
> Refactor
> `test/jdk/java/lang/SecurityManager/modules/CustomSecurityManager.sh` as java
> test.
This pull request has now been integrated.
Changeset: 82735140
Author:Ivan Šipka
Committer: Igor Ignatyev
URL:
On Wed, 9 Dec 2020 15:19:58 GMT, Ivan Šipka wrote:
>> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java
>> test.
>
> Ivan Šipka has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8166026: Refactor java/lang shell
On Fri, 11 Dec 2020 05:02:25 GMT, Vicente Romero wrote:
> Please review this patch which modifies the spec for method
> java.lang.Record::equals. It states that the implementation of this method
> should use the record fields for the comparison instead of the accessors.
>
> TIA,
> Vicente
On Fri, 11 Dec 2020 07:42:19 GMT, Nick Gasson wrote:
>> This is more-or-less a straight port of the x86 code to AArch64.
>> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
>> to generate a blob that jumps to the native function entry point. This
>> simply switches the
30 matches
Mail list logo
