Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Naoto Sato
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote: > Please review a patch to add an explicit control over whether a newline > should be added after the XML header. This is done by adding a DOM > LSSerializer property "jdk-is-standalone" and System property > "jdk.xml.isStandalone". > > This

Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Naoto Sato
On Wed, 13 Jan 2021 00:17:57 GMT, Joe Wang wrote: >> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/DOMConstants.java >> line 131: >> >>> 129: >>> 130: // Corresponding System property >>> 131: public static final String SP_IS_STANDALONE = >>>

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2021-01-12 Thread David Holmes
Hi Severin, On 13/01/2021 12:31 am, Severin Gehwolf wrote: On Tue, 15 Dec 2020 12:57:12 GMT, Severin Gehwolf wrote: @bobvandette Please review when you've got some cycles to spare. Much appreciated! Ping? Anyone? Anybody willing to review this? FYI Bob retired at the end of last year.

Re: RFR: 8259498: Reduce overhead of MD5 and SHA digests

2021-01-12 Thread Valerie Peng
On Thu, 7 Jan 2021 18:50:05 GMT, Claes Redestad wrote: >> Removing the UUID clone cache and running the microbenchmark along with the >> changes in #1933: >> >> Benchmark (size) Mode >> CntScoreError Units >>

Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Joe Wang
On Tue, 12 Jan 2021 23:56:12 GMT, Naoto Sato wrote: >> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >>

Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Naoto Sato
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote: > Please review a patch to add an explicit control over whether a newline > should be added after the XML header. This is done by adding a DOM > LSSerializer property "jdk-is-standalone" and System property > "jdk.xml.isStandalone". > > This

Integrated: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

2021-01-12 Thread Martin Balao
On Wed, 6 Jan 2021 15:33:59 GMT, Martin Balao wrote: > As described in JDK-8259319 [1], this fix proposal is to set proper access > permissions so the SunPKCS11 provider can create instances of SunJCE classes > when a Security Manager is installed and the fallback scheme is used. > > No

Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Joe Wang
On Tue, 12 Jan 2021 21:25:54 GMT, Roger Riggs wrote: >> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >>

Re: RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Roger Riggs
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote: > Please review a patch to add an explicit control over whether a newline > should be added after the XML header. This is done by adding a DOM > LSSerializer property "jdk-is-standalone" and System property > "jdk.xml.isStandalone". > > This

[jdk16] Integrated: 8259636: Check for buffer backed by shared segment kicks in in unexpected places

2021-01-12 Thread Maurizio Cimadamore
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore wrote: > When support for shared segment was added, we decided to disable support for > buffers derived from shared segment in certain async operations, as there's > currently no way to make sure that the memory won't be reclaimed while

Integrated: 8226810: Failed to launch JVM because of NullPointerException occured on System.props

2021-01-12 Thread Evan Whelan
On Tue, 12 Jan 2021 16:26:27 GMT, Evan Whelan wrote: > Hi, > > Please review this small change which enables the GB18030 charset to be built > into java.base > > Thanks This pull request has now been integrated. Changeset: 5f7ccce0 Author:Evan Whelan Committer: Alan Bateman URL:

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v6]

2021-01-12 Thread Mahendra Chhipa
On Tue, 12 Jan 2021 16:52:20 GMT, Daniel Fuchs wrote: > Approved provided that tier2 tests are passing. All tier2 tests related to changes are passing. Here is the Mach5 result link: https://mach5.us.oracle.com/mdash/jobs/mahendrachhipa-jdk-20210112-1759-17354032?search=result.status%3APAS

RFR: 8255531: MethodHandles::permuteArguments throws NPE when duplicating dropped arguments

2021-01-12 Thread Jorn Vernee
Hi, This small patch fixes the NPE in the following case: MethodHandle mh = MethodHandles.empty(MethodType.methodType(void.class, int.class, int.class)); MethodHandles.permuteArguments(mh, MethodType.methodType(void.class, int.class), 0, 0); If a parameter name was changed by a

RFR: 8249867: xml declaration is not followed by a newline

2021-01-12 Thread Joe Wang
Please review a patch to add an explicit control over whether a newline should be added after the XML header. This is done by adding a DOM LSSerializer property "jdk-is-standalone" and System property "jdk.xml.isStandalone". This change addresses an incompatibility introduced during 7u4 as an

Re: RFR: 8226810: Failed to launch JVM because of NullPointerException occured on System.props

2021-01-12 Thread Naoto Sato
On Tue, 12 Jan 2021 16:26:27 GMT, Evan Whelan wrote: > Hi, > > Please review this small change which enables the GB18030 charset to be built > into java.base > > Thanks Looks fine. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2053

Re: [jdk16] RFR: 8259636: Check for buffer backed by shared segment kicks in in unexpected places [v2]

2021-01-12 Thread Maurizio Cimadamore
> When support for shared segment was added, we decided to disable support for > buffers derived from shared segment in certain async operations, as there's > currently no way to make sure that the memory won't be reclaimed while the IO > operation is still taking place. > > After looking at

[jdk16] Integrated: 8259298: broken link in Stream::toList spec

2021-01-12 Thread Stuart Marks
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote: > Just fixing a broken link. This pull request has now been integrated. Changeset: 8a81cf15 Author:Stuart Marks URL: https://git.openjdk.java.net/jdk16/commit/8a81cf15 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod

[jdk16] Integrated: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds

2021-01-12 Thread Maurizio Cimadamore
On Tue, 12 Jan 2021 15:28:20 GMT, Maurizio Cimadamore wrote: > The byte buffers created from heap segments do not honor the javadoc - which > says that the resulting buffer size should be equal to > MemorySegment::byteSize, and that the buffer position should be zero. > > The issue is that

Re: [jdk16] RFR: 8259636: Check for buffer backed by shared segment kicks in in unexpected places

2021-01-12 Thread Chris Hegarty
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore wrote: > When support for shared segment was added, we decided to disable support for > buffers derived from shared segment in certain async operations, as there's > currently no way to make sure that the memory won't be reclaimed while

Re: [jdk16] RFR: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds

2021-01-12 Thread Chris Hegarty
On Tue, 12 Jan 2021 15:28:20 GMT, Maurizio Cimadamore wrote: > The byte buffers created from heap segments do not honor the javadoc - which > says that the resulting buffer size should be equal to > MemorySegment::byteSize, and that the buffer position should be zero. > > The issue is that

Re: RFR: 8226810: Failed to launch JVM because of NullPointerException occured on System.props

2021-01-12 Thread Alan Bateman
On Tue, 12 Jan 2021 16:26:27 GMT, Evan Whelan wrote: > Hi, > > Please review this small change which enables the GB18030 charset to be built > into java.base > > Thanks Including GB18030 in java.base rather than jdk.charsets on Windows is fine. It does increase the size of java.base but

Re: RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v6]

2021-01-12 Thread Daniel Fuchs
On Wed, 6 Jan 2021 16:26:10 GMT, Mahendra Chhipa wrote: >> jaxp.library.SimpleHttpServer >> https://bugs.openjdk.java.net/browse/JDK-8212035 > > Mahendra Chhipa has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains ten commits: > > -

Re: [jdk16] RFR: 8259636: Check for buffer backed by shared segment kicks in in unexpected places

2021-01-12 Thread Alan Bateman
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore wrote: > When support for shared segment was added, we decided to disable support for > buffers derived from shared segment in certain async operations, as there's > currently no way to make sure that the memory won't be reclaimed while

Re: Is SharedSecrets thread-safe?

2021-01-12 Thread some-java-user-99206970363698485155
Hello Peter, feel free to consider these issues one at a time, or not at all, if you don't think that it is worth it. However, please note that I will unsubscribe from this mailing list in the next days again due to the high degree of activity. (Related:

Re: [jdk16] RFR: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds

2021-01-12 Thread Alan Bateman
On Tue, 12 Jan 2021 15:28:20 GMT, Maurizio Cimadamore wrote: > The byte buffers created from heap segments do not honor the javadoc - which > says that the resulting buffer size should be equal to > MemorySegment::byteSize, and that the buffer position should be zero. > > The issue is that

Re: [jdk16] RFR: 8259636: Check for buffer backed by shared segment kicks in in unexpected places

2021-01-12 Thread Athijegannathan Sundararajan
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore wrote: > When support for shared segment was added, we decided to disable support for > buffers derived from shared segment in certain async operations, as there's > currently no way to make sure that the memory won't be reclaimed while

[jdk16] RFR: 8259636: Check for buffer backed by shared segment kicks in in unexpected places

2021-01-12 Thread Maurizio Cimadamore
When support for shared segment was added, we decided to disable support for buffers derived from shared segment in certain async operations, as there's currently no way to make sure that the memory won't be reclaimed while the IO operation is still taking place. After looking at the code, it

[jdk16] RFR: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds

2021-01-12 Thread Maurizio Cimadamore
The byte buffers created from heap segments do not honor the javadoc - which says that the resulting buffer size should be equal to MemorySegment::byteSize, and that the buffer position should be zero. The issue is that the NIO routine we have added to create heap buffers is using the wrong

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2021-01-12 Thread Severin Gehwolf
On Tue, 15 Dec 2020 12:57:12 GMT, Severin Gehwolf wrote: >> @bobvandette Please review when you've got some cycles to spare. Much >> appreciated! > > Ping? Anyone? Anybody willing to review this? - PR: https://git.openjdk.java.net/jdk/pull/1393

Withdrawn: JDK-8223322: Improve concurrency in jpackage instances

2021-01-12 Thread Andy Herrick
On Thu, 17 Dec 2020 20:46:50 GMT, Andy Herrick wrote: > Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. This pull request has been closed without being