Re: RFR: 8260329: Update references to TAOCP to latest edition

2021-01-24 Thread Alan Bateman
On Mon, 25 Jan 2021 06:10:29 GMT, Joe Darcy wrote: > Updating and regularizing several references to Knuth's The Art of Computer > Programming. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2215

RFR: 8260329: Update references to TAOCP to latest edition

2021-01-24 Thread Joe Darcy
Updating and regularizing several references to Knuth's The Art of Computer Programming. - Commit messages: - 8260329 Changes: https://git.openjdk.java.net/jdk/pull/2215/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2215&range=00 Issue: https://bugs.openjdk.java.ne

Re: jpackage problem submitting to Apple Store

2021-01-24 Thread Michael Hall
> On Jan 24, 2021, at 8:28 AM, John Crowley wrote: > > Hi All, > > Have been having a problem trying to use jpackage to sign an app and submit > it to the Apple Store. > > Attached are the following: No attachments that I’m seeing.

jpackage problem submitting to Apple Store

2021-01-24 Thread John Crowley
Hi All, Have been having a problem trying to use jpackage to sign an app and submit it to the Apple Store. Attached are the following: — the script which invokes jpackage. Note that the attached ’…txt’ files show the values for all of the variables. — the output of this script — the output of t

Re: RFR: JDK-8260273: DataOutputStream writeChars optimization

2021-01-24 Thread Hamlin Li
On Sat, 23 Jan 2021 07:52:55 GMT, Alan Bateman wrote: >> this is minor optimization following JDK-8254078. >> based on my tests with jmh, it has better performance when apply following >> patch: >> >> diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java >> b/src/java.base/sha

Integrated: JDK-8260273: DataOutputStream writeChars optimization

2021-01-24 Thread Hamlin Li
On Fri, 22 Jan 2021 02:57:36 GMT, Hamlin Li wrote: > this is minor optimization following JDK-8254078. > based on my tests with jmh, it has better performance when apply following > patch: > > diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java > b/src/java.base/share/classe

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v2]

2021-01-24 Thread David Holmes
Alex, On 20/01/2021 11:47 am, Alex Menkov wrote: On Tue, 19 Jan 2021 23:16:30 GMT, David Holmes wrote: What do you mean by this? The -J args are not "translated" here but later in TranslateApplicationArgs. I meant that they are translated in TranslateApplicationArgs. Looks like it's not c

Re: bug jpackage in JDK 15

2021-01-24 Thread Andy Herrick
I can reproduce with simple app using current JDK17 repository. I have files bug https://bugs.openjdk.java.net/browse/JDK-8260335 and will look into this week /Andy On 1/22/2021 2:31 PM, Brian Schlining wrote: Hi everyone, I'm running into a bug with jpackage. I have a mac app that builds j

Re: bug jpackage in JDK 15

2021-01-24 Thread Andy Herrick
Can you try with ea version of JDK16 from https://download.java.net/java/early_access/alpine/32/binaries/openjdk-16-ea+32_linux-x64-musl_bin.tar.gz ? /Andy On 1/24/2021 1:46 AM, Brian S

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Sun, 24 Jan 2021 20:14:04 GMT, Martin Buchholz wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typo, clarify asserts disabled, test prefGrowth==0 > > Marked as reviewed by martin (Reviewer). The new docs an

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Fri, 4 Dec 2020 17:31:20 GMT, Stuart Marks wrote: >> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 654: >> >>> 652: return SOFT_MAX_ARRAY_LENGTH; >>> 653: } else { >>> 654: return minLength; >> >> Isn't this last `else if... then.. else

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Wed, 9 Dec 2020 00:32:37 GMT, Paul Sandoz wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typo, clarify asserts disabled, test prefGrowth==0 > > src/java.base/share/classes/jdk/internal/util/ArraysSupport.ja

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

2021-01-24 Thread Martin Buchholz
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Vladimir Kempik
On Sat, 23 Jan 2021 11:43:31 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/macroAsse

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Sat, 23 Jan 2021 11:42:48 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/interpret

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Sat, 23 Jan 2021 11:10:17 GMT, Andrew Haley wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > src/hotspot/cpu/aarch64/interpret

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
On Fri, 22 Jan 2021 20:18:51 GMT, Erik Joelsson wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > make/autoconf/flags-cflags.m4 li

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

2021-01-24 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: bug jpackage in JDK 15

2021-01-24 Thread Michael Hall
> On Jan 24, 2021, at 7:37 AM, Michael Hall wrote: > > > --name 'VARS Annotation’ > > You are using a name with an embedded blank but that didn’t seem to cause me > any problems. > > I didn’t recreate, maybe if I get a chance I’ll try to see if anything else > in your invocation seems to

Re: bug jpackage in JDK 15

2021-01-24 Thread Michael Hall
--name 'VARS Annotation’ You are using a name with an embedded blank but that didn’t seem to cause me any problems. I didn’t recreate, maybe if I get a chance I’ll try to see if anything else in your invocation seems to trigger what you’re seeing.