On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
>>> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
>>> framework
>>> ie:
>>> `--with-extra-ldflags='-F
>>> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fram
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This change addresses an incompatibility introduced durin
On Wed, 27 Jan 2021 03:18:09 GMT, Stuart Marks wrote:
> Fix a typo, and change an example to use Stream.toList().
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2249
On Wed, 27 Jan 2021 00:44:51 GMT, Doug Lea wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new commi
> 8260461: Modernize jsr166 tck tests
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last revision
> 8260461: Modernize jsr166 tck tests
Martin Buchholz has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
JDK-8260461
-
Changes: https://git.openjdk.java.net/jdk/pull/2245/files
Webrev: https://webrevs.openjdk
Fix a typo, and change an example to use Stream.toList().
-
Commit messages:
- 8259816: Typo in java.util.stream package description
Changes: https://git.openjdk.java.net/jdk/pull/2249/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2249&range=00
Issue: https://bugs.o
>
> When I open the built dmg there is an application icon, a drag to indicating
> arrow, but no application folder icon as the drag target.
>
> Possibly related…
>
> Running [osascript,
> /var/folders/dh/91wmrk0n6lzfmr4tjhjmcfp4gn/T/jdk.incubator.jpackage15947685185521368596/config/Blac
On Tue, 26 Jan 2021 21:23:25 GMT, Martin Buchholz wrote:
> 8260461: Modernize jsr166 tck tests
Marked as reviewed by dl (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2245
On Tue, 26 Jan 2021 18:20:00 GMT, Paul Sandoz wrote:
> Hi Jie, Thanks for the detailed analysis. I suspect the difference outside of
> loops is because of expression "length - (vlen - 1)”. We need to make
> intrinsic Objects.checkFromIndexSize. Is that something you might be
> interested in pu
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/java/lang/Class/for
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
I like keeping the changes w
On Tue, 26 Jan 2021 22:30:03 GMT, Mandy Chung wrote:
>> To avoid the Checkstyle warnings, I added them.
>
> Is it from your IDE configurations? You can turn off Checkstyle warnings.
> This just adds noise.
I also assume some of the formatting changes are changed by your IDE
suggestion. Can
On Mon, 25 Jan 2021 19:33:08 GMT, Mahendra Chhipa
wrote:
>> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 103:
>>
>>> 101: createAndWriteEnclosingClasses(enclosingPath, pkg2File,
>>> "pkg1.pkg2");
>>> 102:
>>> 103: String javacPath = JDKToolFinder.get
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/java/lang/Class/for
On Tue, 26 Jan 2021 09:23:18 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> make/autoconf/build-aux/autoconf-confi
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
8260461: Modernize jsr166 tck tests
-
Commit messages:
- JDK-8260461
Changes: https://git.openjdk.java.net/jdk/pull/2245/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2245&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260461
Stats: 7535 lines in 70 fil
On Tue, 26 Jan 2021 19:33:28 GMT, Weijun Wang wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert harfbuzz changes, disable warnings for it
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 48:
>
>
On Mon, 25 Jan 2021 17:43:35 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
On Tue, 26 Jan 2021 18:42:02 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 26 Jan 2021 16:35:54 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm This and other harfbuzz changes came from MS, could you please
>> comment here ?
>
> This looks like a merge fix mistake:
> https://github.com/openjdk/jdk/commit/051357ef977ecab77fa9b2b1e61f94f288e716f9#diff-e3815f37244
On 2021-01-26 04:44, Magnus Ihse Bursie wrote:
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt
JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 26 Jan 2021 13:24:57 GMT, Jie Fu wrote:
>> The intrinsic enables C2 to more reliably elide bounds checks. I don't know
>> the exact details but at a high-level it transforms signed values into
>> unsigned values (and therefore the signed comparisons become unsigned
>> comparisons), whi
> Implement three optimiztations for Reader.read(CharBuffer)
>
> * Add a code path for heap buffers in Reader#read to use the backing array
> instead of allocating a new one.
> * Change the code path for direct buffers in Reader#read to limit the
> intermediate allocation to `TRANSFER_BUFFER_SIZ
On Tue, 19 Jan 2021 07:22:49 GMT, Philippe Marschall
wrote:
>> src/java.base/share/classes/java/io/Reader.java line 207:
>>
>>> 205: target.put(cbuf, 0, n);
>>> 206: nread += n;
>>> 207: remaining -= n;
>>
>> Wouldn't ther
> The ByteBuffers micro benchmark seems to be a little dated.
>
> It should be a useful resource to leverage when analysing the performance
> impact of any potential implementation changes in the byte buffer classes.
> More specifically, the impact of such changes on the performance of sharp
>
On Thu, 10 Dec 2020 14:01:56 GMT, Jorn Vernee wrote:
>> While the updated set of scenarios covered by this benchmark is
>> reasonably (and vastly improves coverage), I find myself reluctant to
>> add the last remaining buffer property - read-only views. It's time to
>> template the generation of
On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>
>>> 111:
>>> 112: #define HB_TAG(c1,c2,c3,c4)
>>> ((hb_tag_t)uint32_t)(c1)&0xFF)<<24)|(((uint32_t)(c2)&0xFF)<<16)|(((uint32_t)(c3)&0xFF)<<8)|((uint32_t)(c4)&0xFF))
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
On Tue, 26 Jan 2021 11:47:54 GMT, Claes Redestad wrote:
> This patch removes the unused StringCoding::err method, and the associated
> native code.
This pull request has now been integrated.
Changeset: b07797c2
Author:Claes Redestad
URL: https://git.openjdk.java.net/jdk/commit/b0779
On Tue, 26 Jan 2021 13:53:53 GMT, Aleksey Shipilev wrote:
>> This patch removes the unused StringCoding::err method, and the associated
>> native code.
>
> Looks fine.
@shipilev, @RogerRiggs, thanks for reviewing!
-
PR: https://git.openjdk.java.net/jdk/pull/2236
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 10:00:20 GMT, Andrew Haley wrote:
>> I like the suggestion. For the defense, new functions were made this way
>> intentionally, to match existing `pass_int`, `pass_long`,.. I take your
>> comment as a blessing to fix all of them. But I feel that refactoring of
>> existing c
On Tue, 26 Jan 2021 11:47:54 GMT, Claes Redestad wrote:
> This patch removes the unused StringCoding::err method, and the associated
> native code.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2236
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating $(@F)
On Tue, 26 Jan 2021 11:47:54 GMT, Claes Redestad wrote:
> This patch removes the unused StringCoding::err method, and the associated
> native code.
Looks fine.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2236
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating $(@F)
On Mon, 25 Jan 2021 11:55:42 GMT, Jan Lahoda wrote:
> The enum constant is unused, and can be removed. The class is not an API.
This pull request has now been integrated.
Changeset: 5e8e0ada
Author:Jan Lahoda
URL: https://git.openjdk.java.net/jdk/commit/5e8e0ada
Stats: 7 lines in
On Thu, 21 Jan 2021 16:54:36 GMT, Paul Sandoz wrote:
> The intrinsic enables C2 to more reliably elide bounds checks. I don't know
> the exact details but at a high-level it transforms signed values into
> unsigned values (and therefore the signed comparisons become unsigned
> comparisons), wh
On Mon, 25 Jan 2021 19:12:17 GMT, Coleen Phillimore wrote:
>> I've tried to do something like this initially. The idea was to use Write in
>> VM state and Exec in Java and Native states. However, for example, JIT runs
>> in the Native state and needs Write access. So instead, W^X is managed on
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework
On Tue, 26 Jan 2021 12:06:28 GMT, Vladimir Kempik wrote:
> > AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> > framework
> > ie:
> > `--with-extra-ldflags='-F
> > /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fr
On Tue, 26 Jan 2021 11:31:18 GMT, Anton Kozlov wrote:
>> This could be a follow-up RFE.
>
> I assume a WXVerifier class that tracks W^X mode in debug mode and does
> nothing in release mode. I've considered to do this, it's relates to small
> inefficiencies, while this patch brings zero overhea
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> framework
> ie:
> `--with-extra-ldflags='-F
> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Frameworks/'`
On Tue, 26 Jan 2021 09:23:23 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> Changes requested by ihse (Reviewer).
On Tue, 26 Jan 2021 11:47:54 GMT, Claes Redestad wrote:
> This patch removes the unused StringCoding::err method, and the associated
> native code.
Testing: tier1+2
-
PR: https://git.openjdk.java.net/jdk/pull/2236
This patch removes the unused StringCoding::err method, and the associated
native code.
-
Commit messages:
- Remove StringCoding::err
Changes: https://git.openjdk.java.net/jdk/pull/2236/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2236&range=00
Issue: https://bugs
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating $(@F)
On Mon, 25 Jan 2021 14:40:42 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.hpp line 915:
>>
>>> 913: verify_wx_state(WXExec);
>>> 914: }
>>> 915: };
>>
>> Rather than add all this to thread.hpp, can you make a wxVerifier.hpp and
>> just add the class instance as
For java.base gensrc we do the following:
# Copy two Java files that need no preprocessing.
$(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
$(CHARACTERDATA_TEMPLATES)/%.java.template
$(call LogInfo, Generating $(@F))
$(call install-file)
GENSRC_CHARACTERDATA +=
$(SUPPORT_OUTPUTDIR)/gens
On Sat, 23 Jan 2021 07:55:09 GMT, Alan Bateman wrote:
> We should create a separate issue to rename them and get rid of the copying
> in the make file.
I opened https://bugs.openjdk.java.net/browse/JDK-8260406.
-
PR: https://git.openjdk.java.net/jdk/pull/1611
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
55 matches
Mail list logo
