On Fri, 29 Jan 2021 01:13:30 GMT, Alexander Matveev
wrote:
>> Duplicated messages are not much help in understanding control flow. I'd
>> change the new message or merge conditions. Whatever you prefer.
>
> It is fine with me to have two separate messages for display and desktop, but
> it is b
> If you run x86 configuration (cross-compiled on x86_64), then many tests
> would fail with:
>
> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
> ...
> can not load libgnomevfs-2.so
> Exception in thread "main" java.lang.ExceptionInInitializerError
> Caused by: java.l
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- fix an issue of double printing error message.
- fix jcmd jmap issue and add test in BascJMapTest and code refine
--
On Fri, 29 Jan 2021 05:33:19 GMT, Serguei Spitsyn wrote:
> You are right.
> So, in my suggestion just replace this block:
>
> ```
> if (gzlevel <= 0 || gzlevel > 9) {
> err.println("Invalid "gz=" option: " + option);
>
On Fri, 29 Jan 2021 05:14:31 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>
>> Thank you for the update.
>>
>> The list of possible commands must include one more variant with no
>> arguments:
>> + * Possi
Hi Stuart,
On 1/28/2021 7:19 PM, Stuart Marks wrote:
On Thu, 28 Jan 2021 07:15:05 GMT, Joe Darcy wrote:
Great, let me know if you'd like me to provide some text for any particular
topics in this area.
Great, let me know if you'd like me to provide some text for any particular
topics in thi
On Thu, 28 Jan 2021 07:15:05 GMT, Joe Darcy wrote:
>> Great, let me know if you'd like me to provide some text for any particular
>> topics in this area.
>
>>
>>
>> Great, let me know if you'd like me to provide some text for any particular
>> topics in this area.
>
> Before sending out anot
On Thu, 28 Jan 2021 23:41:44 GMT, Alexey Semenyuk wrote:
>> I would prefer to have separate messages for "headless" and "desktop
>> capable". I can merge these, if you insist.
>
> Duplicated messages are not much help in understanding control flow. I'd
> change the new message or merge conditio
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2260
On Mon, 18 Jan 2021 16:45:00 GMT, Jim Laskey wrote:
>> This PR is to introduce a new random number API for the JDK. The primary API
>> is found in RandomGenerator and RandomGeneratorFactory. Further description
>> can be found in the JEP https://openjdk.java.net/jeps/356 .
>>
>> javadoc can be
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This change addresses an incompatibility introduced durin
On Thu, 28 Jan 2021 22:05:17 GMT, Aleksey Shipilev wrote:
>> test/jdk/tools/jpackage/apps/image/Hello.java line 166:
>>
>>> 164: }
>>> 165:
>>> 166: if (!Desktop.isDesktopSupported()) {
>>
>> Would it make more sense to replace
>> `if (GraphicsEnvironment.isHeadless())`
>> with
On Thu, 28 Jan 2021 20:13:23 GMT, Alexey Semenyuk wrote:
>> If you run x86 configuration (cross-compiled on x86_64), then many tests
>> would fail with:
>>
>> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
>> ...
>> can not load libgnomevfs-2.so
>> Exception in threa
On Thu, 28 Jan 2021 14:33:35 GMT, Aleksey Shipilev wrote:
> If you run x86 configuration (cross-compiled on x86_64), then many tests
> would fail with:
>
> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
> ...
> can not load libgnomevfs-2.so
> Exception in thread "mai
On Thu, 28 Jan 2021 14:33:35 GMT, Aleksey Shipilev wrote:
> If you run x86 configuration (cross-compiled on x86_64), then many tests
> would fail with:
>
> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
> ...
> can not load libgnomevfs-2.so
> Exception in thread "mai
> - Remove unused code
> - Inline and simplify the bootstrap method invocation code (remove pointless
> reboxing checks etc)
> - Apply pattern matching to make some code more readable
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
- Remove unused code
- Inline and simplify the bootstrap method invocation code (remove pointless
reboxing checks etc)
- Apply pattern matching to make some code more readable
-
Commit messages:
- Avoid unnecessary reboxing checks, inline and simplify class/mt invokes
- j.l.invoke
I like the text it’s good to mix object and value identities. I would only miss
unequal behavior of NaN in the description.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: core-libs-dev im Auftrag von Joe
Darcy
Gesendet: Thursday, January 28, 2021 8:17:39 AM
A
On Tue, 26 Jan 2021 21:23:25 GMT, Martin Buchholz wrote:
> 8260461: Modernize jsr166 tck tests
This pull request has now been integrated.
Changeset: 81e9e6a7
Author:Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/81e9e6a7
Stats: 7616 lines in 71 files changed: 318 in
On Thu, 28 Jan 2021 17:19:53 GMT, Poonam Bajaj wrote:
> > > I'm curious: What config is this to actually trigger the NPE? How does
> > > `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like?
> >
> >
> > > > I'm curious: What config is this to actually trigger the NPE? How
On Thu, 28 Jan 2021 16:19:41 GMT, Weijun Wang wrote:
> Fix some small errors.
This pull request has now been integrated.
Changeset: 2b166d81
Author:Weijun Wang
URL: https://git.openjdk.java.net/jdk/commit/2b166d81
Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
8260596: Co
On Thu, 28 Jan 2021 16:00:36 GMT, Severin Gehwolf wrote:
> > I'm curious: What config is this to actually trigger the NPE? How does
> > `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like?
>
> > > I'm curious: What config is this to actually trigger the NPE? How does
> >
On Thu, 28 Jan 2021 16:19:41 GMT, Weijun Wang wrote:
> Fix some small errors.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2292
Fix some small errors.
-
Commit messages:
- 8260596: Comment cleanup in BigInteger
Changes: https://git.openjdk.java.net/jdk/pull/2292/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2292&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260596
Stats: 5 line
On Thu, 28 Jan 2021 15:01:11 GMT, Poonam Bajaj wrote:
>> I'm curious: What config is this to actually trigger the NPE? How does
>> `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like?
>
>> I'm curious: What config is this to actually trigger the NPE? How does
>> `/proc/sel
On Wed, 27 Jan 2021 21:10:16 GMT, Poonam Bajaj wrote:
> Please review this simple change that adds null checks for memory in
> CgroupV1Subsystem.java.
>
> Problem: After the backport of JDK-8250984, there are places where
> memory.isSwapEnabled() is called. For example:
>
> public long g
On Thu, 28 Jan 2021 14:36:36 GMT, Severin Gehwolf wrote:
> I'm curious: What config is this to actually trigger the NPE? How does
> `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like?
I don't have access to the config. The issue was reported by a customer.
-
On Wed, 27 Jan 2021 21:10:16 GMT, Poonam Bajaj wrote:
> Please review this simple change that adds null checks for memory in
> CgroupV1Subsystem.java.
>
> Problem: After the backport of JDK-8250984, there are places where
> memory.isSwapEnabled() is called. For example:
>
> public long g
If you run x86 configuration (cross-compiled on x86_64), then many tests would
fail with:
$ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage
...
can not load libgnomevfs-2.so
Exception in thread "main" java.lang.ExceptionInInitializerError
Caused by: java.lang.UnsupportedO
On Wed, 27 Jan 2021 21:10:16 GMT, Poonam Bajaj wrote:
> Please review this simple change that adds null checks for memory in
> CgroupV1Subsystem.java.
>
> Problem: After the backport of JDK-8250984, there are places where
> memory.isSwapEnabled() is called. For example:
>
> public long g
Fixing FileUtils.dirname() to skip over "/.".
-
Commit messages:
- JDK-8260335: [macos] Running app using relative path causes problems on MacOS
Changes: https://git.openjdk.java.net/jdk/pull/2260/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2260&range=00
Issue: ht
On Wed, 20 Jan 2021 01:47:54 GMT, Alex Menkov wrote:
>> The fix adds NMT handling for non-java launchers
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated comment
Sorry, I overlooked some of details. Final change look
On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote:
>> Ping? Anyone?
>
> Anybody willing to review this?
PING?
-
PR: https://git.openjdk.java.net/jdk/pull/1393
On Tue, 12 Jan 2021 16:58:45 GMT, Jorn Vernee wrote:
> Hi,
>
> This small patch fixes the NPE in the following case:
>
> MethodHandle mh = MethodHandles.empty(MethodType.methodType(void.class,
> int.class, int.class));
> MethodHandles.permuteArguments(mh, MethodType.methodType(void.cla
On Wed, 27 Jan 2021 12:15:43 GMT, Claes Redestad wrote:
> Some small modernizations and cleanups that ultimately help startup of apps
> using JNDI/InitialContext
This pull request has now been integrated.
Changeset: ecde52ec
Author:Claes Redestad
URL: https://git.openjdk.java.net/jd
On Wed, 27 Jan 2021 15:32:58 GMT, Alan Bateman wrote:
>> Some small modernizations and cleanups that ultimately help startup of apps
>> using JNDI/InitialContext
>
> Marked as reviewed by alanb (Reviewer).
@AlanBateman @dfuch @AlekseiEfimov - thanks for reviewing!
-
PR: https://gi
36 matches
Mail list logo
