Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Alan Bateman
On 01/02/2021 22:13, Daniel D.Daugherty wrote: A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). Something fishy here, Sundar ran the test 500 times on the 3 main platforms before integrating. I ask

Re: Why does Set.of disallow duplicate elements?

2021-02-01 Thread dfranken . jdk
Okay, so to summarize this discussion a bit: Set.of is, like its counterpart Map.ofEntries, only to be used with explicit varargs, not an array which happens to be accepted as a varargs parameter, this would only confuse things. And if it is called with varargs, the intention is to catch programmi

[jdk16] Integrated: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote: > Before RC phase we need to ensure we have the final set of manpage updates > published in OpenJDK. This pull request has now been integrated. Changeset: ed1a7755 Author:Magnus Ihse Bursie URL: https://git.openjdk.java.net/

Re: [jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 22:46:15 GMT, David Holmes wrote: >> Before RC phase we need to ensure we have the final set of manpage updates >> published in OpenJDK. > > Thanks for doing this Magnus! I had overlooked the fact we would need to > re-run this in 2021 regardless of whether there were any con

Re: RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

2021-02-01 Thread Alexander Matveev
On Tue, 2 Feb 2021 00:29:39 GMT, Alexey Semenyuk wrote: >> We did not able to run "hdiutil convert" due to hdiutil did not able to >> acquire lock on DMG image file. In this condition we got "Resource busy" >> from "hdiutil detach" and on repeated attempt we was getting "File Not >> Found" err

Re: RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy' [v2]

2021-02-01 Thread Alexander Matveev
> We did not able to run "hdiutil convert" due to hdiutil did not able to > acquire lock on DMG image file. In this condition we got "Resource busy" from > "hdiutil detach" and on repeated attempt we was getting "File Not Found" > error. According to some research "Resource Busy" is normal error

Re: RFR: 8259074: regex benchmarks and tests [v5]

2021-02-01 Thread Martin Buchholz
> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: fix imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/1940/files - new: https://git.openjdk.java.net/jdk/pull/194

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Martin Buchholz
On Tue, 2 Feb 2021 01:40:09 GMT, Martin Buchholz wrote: >> @cl4es I agree pruning is a good idea. I settled on 3 data points with 16x >> separations as good enough to clearly show the difference between O(1) O(N) >> O(N^2) and O(2^N) (although O(2^N) would "run forever"). >> >> (although ... p

Re: RFR: 8259074: regex benchmarks and tests [v4]

2021-02-01 Thread Martin Buchholz
> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: add annotations for sensible defaults - Changes: - all: https://git.openjdk.java.net/jdk/pull/1940/files - new: https://git.ope

Re: RFR: 8260401: StackOverflowError on open WindowsPreferences

2021-02-01 Thread Brian Burkhalter
On Tue, 2 Feb 2021 02:31:09 GMT, Jaikiran Pai wrote: >> Hello Brian, >> >> Thank you for the review. >> >>> It would be better if there were a test, but apparently this might depend >>> on the user who runs the test not having registry access rights. >> >> That's correct. Looking at the code,

Integrated: JDK-8257086: Clarify differences between {Float, Double}.equals and ==

2021-02-01 Thread Joe Darcy
On Tue, 8 Dec 2020 16:29:49 GMT, Joe Darcy wrote: > Updates to the specifications of Double.{equals, compareTo} to explain more > explicitly why the obvious wrappers around "==" and "<"/"==" are not > sufficient for floating-point values. > > Once the wording is worked out, I'll replicate it f

Re: RFR: 8260401: StackOverflowError on open WindowsPreferences

2021-02-01 Thread Jaikiran Pai
On Tue, 2 Feb 2021 02:25:04 GMT, Jaikiran Pai wrote: > > The code change looks all right. > > Should I go ahead and integrate this? Actually, I didn't notice that this PR wasn't marked as reviewed. I'll wait for the review(s) then. - PR: https://git.openjdk.java.net/jdk/pull/2326

Re: RFR: JDK-8257086: Clarify differences between {Float, Double}.equals and == [v6]

2021-02-01 Thread Joe Darcy
> Updates to the specifications of Double.{equals, compareTo} to explain more > explicitly why the obvious wrappers around "==" and "<"/"==" are not > sufficient for floating-point values. > > Once the wording is worked out, I'll replicate it for the analogous methods > on Float. Joe Darcy has

Re: RFR: 8260401: StackOverflowError on open WindowsPreferences

2021-02-01 Thread Jaikiran Pai
On Mon, 1 Feb 2021 19:21:23 GMT, Brian Burkhalter wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8260401? >> >> As noted in that issue, when the constructor of >> `java.util.prefs.WindowsPreferences` r

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Martin Buchholz
On Mon, 1 Feb 2021 20:52:12 GMT, Martin Buchholz wrote: >> The assertion discussion aside, the micros look fine to me. >> >> With an eye towards reducing total run time I'd ask you to consider if all >> parameter combinations are useful or if we can get the same value after some >> pruning. >

Re: RFR: 8259074: regex benchmarks and tests [v2]

2021-02-01 Thread Martin Buchholz
On Mon, 1 Feb 2021 00:23:56 GMT, Martin Buchholz wrote: >> test/micro/org/openjdk/bench/java/util/regex/Trim.java line 119: >> >>> 117: assert ! lookBehind_find(); >>> 118: assert ! find_loop_two_matchers(); >>> 119: assert ! find_loop_usePattern(); >> >> At a risk of mu

Re: RFR: 8259074: regex benchmarks and tests [v3]

2021-02-01 Thread Martin Buchholz
> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with two additional commits since the last revision: - refactor correctness checking as suggested by @shipilev - prune @Param values as suggested by Claes - Changes: - all: https://

Re: RFR: JDK-8257086: Clarify differences between {Float, Double}.equals and == [v5]

2021-02-01 Thread Stuart Marks
On Sat, 30 Jan 2021 01:58:02 GMT, Joe Darcy wrote: >> Updates to the specifications of Double.{equals, compareTo} to explain more >> explicitly why the obvious wrappers around "==" and "<"/"==" are not >> sufficient for floating-point values. >> >> Once the wording is worked out, I'll replicat

Re: Why does Set.of disallow duplicate elements?

2021-02-01 Thread Stuart Marks
Indeed it's the case that a varargs method can't determine whether it was called with several explicit arguments or whether it was called with an array. However, that doesn't have any bearing on whether or not Set.of rejects duplicates. The model for Set.of is to support a collection-literal-li

Re: RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 23:41:38 GMT, Alexander Matveev wrote: > We did not able to run "hdiutil convert" due to hdiutil did not able to > acquire lock on DMG image file. In this condition we got "Resource busy" from > "hdiutil detach" and on repeated attempt we was getting "File Not Found" > error

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v4]

2021-02-01 Thread Mandy Chung
On Thu, 28 Jan 2021 00:34:08 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 158:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v4]

2021-02-01 Thread Brent Christian
On Mon, 1 Feb 2021 23:43:25 GMT, Brent Christian wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > Changes requested by bchristi (Reviewer). (I think my comments may no have b

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v10]

2021-02-01 Thread Brent Christian
On Mon, 1 Feb 2021 22:23:02 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > throwing the specific exceptions. test/jdk/java/lang/Class/get

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v4]

2021-02-01 Thread Brent Christian
On Wed, 27 Jan 2021 22:44:00 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Changes requested by bchrist

RFR: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'

2021-02-01 Thread Alexander Matveev
We did not able to run "hdiutil convert" due to hdiutil did not able to acquire lock on DMG image file. In this condition we got "Resource busy" from "hdiutil detach" and on repeated attempt we was getting "File Not Found" error. According to some research "Resource Busy" is normal error message

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v9]

2021-02-01 Thread Mandy Chung
On Mon, 1 Feb 2021 21:54:50 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > Marked as reviewed by mchung (Reviewer). I think Brent wants to review it. I wi

Re: Why does Set.of disallow duplicate elements?

2021-02-01 Thread Aaron Scott-Boddendijk
Dave, || Dave said... || Okay, I understand this reasoning, but when you want to construct a Set from an array, you might be tempted to use Set.of(...) because it looks like it supports an || array and indeed, you can do Set.of(new int[] {1, 2 }) I believe? || || Maybe this is just a quirk becaus

Integrated: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). This pull request has now been integrated. Changeset: 9880c4cd Author:Daniel D.

Re: [jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread David Holmes
On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote: > Before RC phase we need to ensure we have the final set of manpage updates > published in OpenJDK. Thanks for doing this Magnus! I had overlooked the fact we would need to re-run this in 2021 regardless of whether there were any cont

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:21:06 GMT, David Holmes wrote: >> A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on >> the >> ProblemList. It was removed in error (see the bug for the details). > > LGTM @dholmes-ora - Thanks for the fast review! - PR: https://git.op

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Claes Redestad
On 2021-02-01 21:54, Martin Buchholz wrote: On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote: @amalloy - you are invited to comment on regex content @cl4es @shipilev - you are invited to point out my jmh bad practices The assertion discussion aside, the micros look fine to me. With

Re: RFR: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues [v2]

2021-02-01 Thread David Holmes
On Mon, 1 Feb 2021 11:41:43 GMT, Alan Bateman wrote: >> Athijegannathan Sundararajan has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Removed CompressorPluginTest.java from ProblemList.txt > > Marked as reviewed by alanb (Reviewer). Note

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread David Holmes
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). LGTM - Marked as reviewed by dholmes (Reviewer). PR: https://git.openj

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v10]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: throwing the specific exceptions. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: https:

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). @JimLaskey or @sundararajana - If either if you are on-line and can review this, I w

RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). - Commit messages: - 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.java.net/jdk/pull/2

Re: JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle

2021-02-01 Thread Johannes Kuhn
Thanks Mandy. Yes, the 3 prototypes I mentioned were yours, Peter Levart's, and my own. (My prototype is at https://github.com/DasBrain/jdk/tree/reflection-MHaccessors - I hit an boostrap problem, build a workaround that I don't really like, so I stopped working on that.) I agree on your goa

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v9]

2021-02-01 Thread Mandy Chung
On Mon, 1 Feb 2021 21:46:00 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Marked as reviewed by mchung

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v9]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: https:/

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

2021-02-01 Thread Ioi Lam
On Mon, 1 Feb 2021 20:29:10 GMT, Gerard Ziemski wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed macos build > > src/java.base/share/native/libjava/check_version.c line 33: > >> 31: DEF_JNI_OnLoad(JavaVM *vm, void

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Martin Buchholz
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote: >> @amalloy - you are invited to comment on regex content >> @cl4es @shipilev - you are invited to point out my jmh bad practices > > The assertion discussion aside, the micros look fine to me. > > With an eye towards reducing total run tim

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v8]

2021-02-01 Thread Mandy Chung
On Mon, 1 Feb 2021 20:27:00 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Thanks for the update. This

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

2021-02-01 Thread Gerard Ziemski
On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam wrote: >> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which >> allowed the same JDK library to use different version of HotSpot. However, >> HSX is no longer supported so this API should be removed. >> - Implementations of APIs such a

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2021-02-01 Thread Andrew John Hughes
On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote: > Anybody willing to review this? I can have a go. I have two main concerns: 1. There seems to be little documentation on the new additions. I'm particularly concerned about things like CgroupV1Subsystem.java where a big chunk of docum

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v8]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: https:/

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v7]

2021-02-01 Thread Mahendra Chhipa
> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new: https:/

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

2021-02-01 Thread Ioi Lam
> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed > the same JDK library to use different version of HotSpot. However, HSX is no > longer supported so this API should be removed. > - Implementations of APIs such as JVM_DTraceActivate, were removed in > [JDK-8068976]

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX

2021-02-01 Thread Lois Foltan
On Mon, 1 Feb 2021 18:40:54 GMT, Ioi Lam wrote: > - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed > the same JDK library to use different version of HotSpot. However, HSX is no > longer supported so this API should be removed. > - Implementations of APIs such as JV

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX

2021-02-01 Thread Alan Bateman
On Mon, 1 Feb 2021 18:40:54 GMT, Ioi Lam wrote: > - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed > the same JDK library to use different version of HotSpot. However, HSX is no > longer supported so this API should be removed. > - Implementations of APIs such as JV

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Martin Buchholz
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote: >> @amalloy - you are invited to comment on regex content >> @cl4es @shipilev - you are invited to point out my jmh bad practices > > The assertion discussion aside, the micros look fine to me. > > With an eye towards reducing total run tim

Re: RFR: 8260401: StackOverflowError on open WindowsPreferences

2021-02-01 Thread Brian Burkhalter
On Sat, 30 Jan 2021 14:35:50 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8260401? > > As noted in that issue, when the constructor of > `java.util.prefs.WindowsPreferences` runs into

Re: JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle

2021-02-01 Thread Johannes Kuhn
On 01-Feb-21 15:58, Remi Forax wrote: - Mail original - De: "Johannes Kuhn" À: "core-libs-dev" Envoyé: Lundi 1 Février 2021 15:50:51 Objet: JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle While implementing a prototype for JDK-8242888 (Convert dynam

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread erik . joelsson
On 2021-02-01 10:38, Alexey Semenyuk wrote: On Mon, 1 Feb 2021 18:24:23 GMT, Erik Joelsson wrote: "common" was perfectly enough until this change. Unfortunately we cant just drop new C sources in "common" dir because we don't want them to be compiled with g++. That is why need new common d

Comment on 8259896: Base64 MIME decoder should allow unrecognised characters within padding

2021-02-01 Thread Raffaello Giulietti
Hi, in my opinion, the reporter of [1] is right in requiring that extraneous characters be discarded, even inside the padding. Indeed, the first full paragraph on [2] reads: "Any characters outside of the base64 alphabet are to be ignored in base64-encoded data." where "the base64 alphabet"

JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle

2021-02-01 Thread Johannes Kuhn
While implementing a prototype for JDK-8242888 (Convert dynamic proxy to hidden classes) I came across the problem that hidden classes can't be mentioned in the constant pool, breaking the constructor for serialization. To remedy that problem, I used a MHConstructorAccessor which delegates the

RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX

2021-02-01 Thread Ioi Lam
- JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed the same JDK library to use different version of HotSpot. However, HSX is no longer supported so this API should be removed. - Implementations of APIs such as JVM_DTraceActivate, were removed in [JDK-8068976](https://b

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-02-01 Thread Andrew Haley
On Sun, 31 Jan 2021 20:14:01 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 18:24:23 GMT, Erik Joelsson wrote: >> "common" was perfectly enough until this change. Unfortunately we cant just >> drop new C sources in "common" dir because we don't want them to be compiled >> with g++. That is why need new common directory (applauncherlibcommon) for C >

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Erik Joelsson
On Mon, 1 Feb 2021 16:17:35 GMT, Alexey Semenyuk wrote: > "common" was perfectly enough until this change. Unfortunately we cant just > drop new C sources in "common" dir because we don't want them to be compiled > with g++. That is why need new common directory (applauncherlibcommon) for C >

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v3]

2021-02-01 Thread Alexey Semenyuk
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ code from app launcher. > At startup app launcher loads launc

Re: Comment on 8260692: Matematically wrong implementations of RoundingMode.HALF_UP and .HALF_DOWN

2021-02-01 Thread Joe Darcy
Hi Raffaello, I agree with your analysis and closed the bug noting some additional history. Cheers, -Joe On 2/1/2021 8:10 AM, Raffaello Giulietti wrote: Hi, in my opinion, and contrary to the report [1], the described issue is not a bug. While the wording used in the spec of java.math.R

Re: JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle

2021-02-01 Thread Mandy Chung
Hi Johannes, I believe you are aware of the prototype I'm working on:     https://github.com/mlchung/jdk/tree/method-invoke My prototype so far replaces method and fields but not constructors yet.   You are welcome to contribute. My main motivation of doing this is to get rid of the old clunk

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 12:19:56 GMT, Magnus Ihse Bursie wrote: >> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one

Comment on 8260692: Matematically wrong implementations of RoundingMode.HALF_UP and .HALF_DOWN

2021-02-01 Thread Raffaello Giulietti
Hi, in my opinion, and contrary to the report [1], the described issue is not a bug. While the wording used in the spec of java.math.RoundingMode could be improved, it is nonetheless clear enough to avoid any confusion about what HALF_DOWN and HALF_UP mean in this context. The actual values

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 12:16:09 GMT, Magnus Ihse Bursie wrote: >> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one

Re: jpackage problem submitting to Apple Store

2021-02-01 Thread Michael Hall
> On Feb 1, 2021, at 9:02 AM, Andy Herrick wrote: > > This step is required to post app on web where it can be downloaded and run > on other machines running MacOS Catalina or later. This is probably all I’d be looking at for now. I’m looking at an app I wrote a year or two back with downl

Re: jpackage problem submitting to Apple Store

2021-02-01 Thread Andy Herrick
Sorry to take so long to get back to you - I read this a week ago and I postponed reply till I could investigate some of the many points here.  Now a week later I still haven't found the time to do that so I will at least reply to what I do know now : First question is what OS version are you

Re: JDK-6824466 java.lang.reflect.Method should use java.lang.invoke.MethodHandle

2021-02-01 Thread Remi Forax
- Mail original - > De: "Johannes Kuhn" > À: "core-libs-dev" > Envoyé: Lundi 1 Février 2021 15:50:51 > Objet: JDK-6824466 java.lang.reflect.Method should use > java.lang.invoke.MethodHandle > While implementing a prototype for JDK-8242888 (Convert dynamic proxy to > hidden classes) I ca

Re: [jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Erik Joelsson
On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote: > Before RC phase we need to ensure we have the final set of manpage updates > published in OpenJDK. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/142

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 12:35:05 GMT, Alan Hayward wrote: > > Hello, hsdis is a separate out-of-tree project and is not part of this jep. > > Unless there's something I'm missing it only requires a few lines of change > to src/utils/hsdis/makefile (it already has support for macos x86_64) I agree

Integrated: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues

2021-02-01 Thread Athijegannathan Sundararajan
On Fri, 15 Jan 2021 05:19:44 GMT, Athijegannathan Sundararajan wrote: > Fixed compilation issues with the test. Test compiles and runs fine locally. This pull request has now been integrated. Changeset: c0cde7dc Author:Athijegannathan Sundararajan URL: https://git.openjdk.java.net/j

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Alan Hayward
On Mon, 1 Feb 2021 11:19:34 GMT, Vladimir Kempik wrote: > Hello, hsdis is a separate out-of-tree project and is not part of this jep. Unless there's something I'm missing it only requires a few lines of change to src/utils/hsdis/makefile (it already has support for macos x86_64) >support for l

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Magnus Ihse Bursie
On Fri, 29 Jan 2021 23:06:20 GMT, Alexey Semenyuk wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C+

Re: RFR: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues [v2]

2021-02-01 Thread Alan Bateman
On Mon, 1 Feb 2021 09:32:00 GMT, Athijegannathan Sundararajan wrote: >> Fixed compilation issues with the test. Test compiles and runs fine locally. > > Athijegannathan Sundararajan has updated the pull request incrementally with > one additional commit since the last revision: > > Removed C

Re: [jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote: > Before RC phase we need to ensure we have the final set of manpage updates > published in OpenJDK. These updates have been made automatically from the markdown source files (which unfortunately is still closed-only). -

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Vladimir Kempik
On Mon, 1 Feb 2021 09:31:31 GMT, Alan Hayward wrote: > You need add macos arm64 to hsdis. Having it working is fairly essential for > debugging. > > Inside src/utils/hsdis, After cloning binutils > > ``` > make; make demo; ./build/macosx-arm64/hsdis-demo > ``` > > Results in: > > ``` > Hell

[jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Magnus Ihse Bursie
Before RC phase we need to ensure we have the final set of manpage updates published in OpenJDK. - Commit messages: - 8258378: Final nroff manpage update for JDK 16 Changes: https://git.openjdk.java.net/jdk16/pull/142/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=1

Re: RFR: 8259074: regex benchmarks and tests

2021-02-01 Thread Claes Redestad
On Sat, 30 Jan 2021 21:32:27 GMT, Martin Buchholz wrote: >> 8259074: regex benchmarks and tests > > @amalloy - you are invited to comment on regex content > @cl4es @shipilev - you are invited to point out my jmh bad practices The assertion discussion aside, the micros look fine to me. With an

Re: RFR: 8260605: Various java.lang.invoke cleanups [v4]

2021-02-01 Thread Claes Redestad
> - Remove unused code > - Inline and simplify the bootstrap method invocation code (remove pointless > reboxing checks etc) > - Apply pattern matching to make some code more readable Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Alan Hayward
On Wed, 27 Jan 2021 14:58:27 GMT, Vladimir Kempik wrote: >> Build changes per se now looks okay. However, I agree with Erik that unless >> this PR can wait for the JNF removal, at the very least the build docs needs >> to be updated to explain how to successfully build for this platform. (I can

Re: RFR: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues [v2]

2021-02-01 Thread Athijegannathan Sundararajan
> Fixed compilation issues with the test. Test compiles and runs fine locally. Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: Removed CompressorPluginTest.java from ProblemList.txt - Changes: - all: ht

Re: RFR: 8260605: Various java.lang.invoke cleanups [v3]

2021-02-01 Thread Claes Redestad
> - Remove unused code > - Inline and simplify the bootstrap method invocation code (remove pointless > reboxing checks etc) > - Apply pattern matching to make some code more readable Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

Integrated: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base"

2021-02-01 Thread Johannes Kuhn
On Fri, 8 Jan 2021 09:38:40 GMT, Johannes Kuhn wrote: > Simple fix - one line change: > https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0. > > Most of the changes come from an additional test that fails without this fix: > > Error: Unable to load main class somelib.test.Tes