On Thu, 4 Feb 2021 02:08:12 GMT, Joe Darcy wrote:
> Recent revisions of the IEEE 754 floating-point standard have added guidance
> on how typical math library methods (sin, cos, tan, etc.) should behave in
> terms of their general quality of implementation as well as on special values.
>
>
Recent revisions of the IEEE 754 floating-point standard have added guidance on
how typical math library methods (sin, cos, tan, etc.) should behave in terms
of their general quality of implementation as well as on special values.
Other than the pow methods, for the recommended operations
On Thu, 4 Feb 2021 01:17:48 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 16 -> JDK 17
This pull request has now been integrated.
Changeset: 9b7a8f19
Author:Jesper Wilhelmsson
URL: https://git.openjdk.java.net/jdk/commit/9b7a8f19
Stats: 2645 lines in 56 files changed: 2497
Forwardport JDK 16 -> JDK 17
-
Commit messages:
- Merge
- 8259794: Remove EA from JDK 16 version string starting with Initial RC
promotion on Feb 04, 2021(B35)
- 8260704: ParallelGC: oldgen expansion needs release-store for _end
- 8260927: StringBuilder::insert is incorrect
On Wed, 3 Feb 2021 22:17:02 GMT, Bernhard Urban-Forster
wrote:
>> To answer my own question, it seems that code is still needed on `x86_64`
>> for `lldb` with `EXC_MASK_BAD_ACCESS` or we keep tripping over
>> `EXC_BAD_ACCESS`
>>
>> Remaining questions:
>>
>> a) why we need
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
This pull request has now been integrated.
Changeset: f279ff9d
Author:Sergey Bylokhov
URL: https://git.openjdk.java.net/jdk/commit/f279ff9d
Stats:
On Wed, 3 Feb 2021 22:48:33 GMT, Gerard Ziemski wrote:
>> I don't like the idea of using masks on architectures that do not require
>> them. How about something like this?
>>
>> `#if defined(__APPLE__)`
>> ` // lldb (gdb) installs both standard BSD signal handlers, and mach
>> exception`
>>
On Wed, 3 Feb 2021 23:13:12 GMT, Bernhard Urban-Forster
wrote:
>> No idea how to insert spaces and make text align :-(
>
> using ` ```c `
> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
>
> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's
On Wed, 3 Feb 2021 22:44:18 GMT, Gerard Ziemski wrote:
>> Thanks for your questions Gerard.
>>
>>> Part of the comment said This work-around is not necessary for 10.5+, as
>>> CrashReporter no longer intercedes on caught fatal signals.
>>
>> That comment can probably be deleted since
> This moves the tracing methods added to GenerateJLIClassesHelper in
> JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code
> meant for jlink.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Remove
Updating the specification to reflect well-established behavior in Formatter
when incorrect flags used for `%`.
-
Commit messages:
- Changing docs to reflect behavior
Changes: https://git.openjdk.java.net/jdk/pull/2389/files
Webrev:
On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote:
> 8260664: Phaser.arrive() memory consistency effects
Marked as reviewed by dl (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2388
> This patch refactors CleanerFactory and InnocuousThread so that we need to
> load fewer PrivilegedActions. This slightly reduce the number of classes we
> always load on bootstrap, slightly reducing static and dynamic footprint
> (default CDS archive -4Kb).
Claes Redestad has updated the
On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote:
> 8260664: Phaser.arrive() memory consistency effects
@DougLea
-
PR: https://git.openjdk.java.net/jdk/pull/2388
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing
On Wed, 3 Feb 2021 20:29:48 GMT, Gerard Ziemski wrote:
>> Part of the comment said `This work-around is not necessary for 10.5+, as
>> CrashReporter no longer intercedes on caught fatal signals.` so I thought it
>> was no longer needed, but it sounds like the part about `gdb` still applies
>>
8260664: Phaser.arrive() memory consistency effects
-
Commit messages:
- JDK-8260664
Changes: https://git.openjdk.java.net/jdk/pull/2388/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2388=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260664
Stats: 6 lines in 1
On Wed, 3 Feb 2021 18:40:15 GMT, Mandy Chung wrote:
>> JDK-8013527: calling MethodHandles.lookup on itself leads to errors
>> JDK-8257874: MethodHandle injected invoker doesn't have necessary private
>> access
>>
>> Johannes Kuhn is also a contributor to this patch.
>>
>> A caller-sensitive
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing
On Wed, 3 Feb 2021 20:04:18 GMT, Gerard Ziemski wrote:
>> See comment above about `gdb`, the same applies to `lldb` today. The AArch64
>> backend uses `SIGILL` (~= `EXC_MASK_BAD_INSTRUCTION`) to initiate a
>> deoptimization. Without this change you cannot continue debugging once you
>> the
On Wed, 3 Feb 2021 14:08:46 GMT, Igor Ignatyev wrote:
>> Ivan Šipka has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8166026: Refactor java/lang shell tests to java
>
> test/jdk/java/lang/ProcessBuilder/InheritIOTest.java line 2:
>
>>
> @iignatev could you please review? Thank you.
>
> note to self:
> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
> test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java
>
On Wed, 3 Feb 2021 09:14:24 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>>
>>> 5269: //
>>> 5270: void MacroAssembler::get_thread(Register dst) {
>>> 5271: RegSet saved_regs = RegSet::range(r0, r1) +
>>> BSD_ONLY(RegSet::range(r2, r17)) + lr -
On Tue, 26 Jan 2021 12:50:22 GMT, Anton Kozlov wrote:
>> Yes, that's why I thought it should be added to the classes
>> ThreadInVMfromNative, etc like:
>> class ThreadInVMfromNative : public ThreadStateTransition {
>> ResetNoHandleMark __rnhm;
>>
>> We can look at it with cleaning up the
On Tue, 26 Jan 2021 12:01:30 GMT, Coleen Phillimore wrote:
>> I assume a WXVerifier class that tracks W^X mode in debug mode and does
>> nothing in release mode. I've considered to do this, it's relates to small
>> inefficiencies, while this patch brings zero overhead (in release) for a
>>
On Tue, 2 Feb 2021 19:23:16 GMT, Bernhard Urban-Forster
wrote:
>> src/hotspot/os/posix/signals_posix.cpp line 1297:
>>
>>> 1295: kern_return_t kr;
>>> 1296: kr = task_set_exception_ports(mach_task_self(),
>>> 1297: EXC_MASK_BAD_ACCESS |
>>>
On Tue, 2 Feb 2021 18:00:06 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 390:
>
>> 388:
On Tue, 2 Feb 2021 23:03:45 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/runtime/thread.cpp line 3991:
>
>> 3989: JavaThread*
On Wed, 3 Feb 2021 19:57:24 GMT, Anton Kozlov wrote:
>> For platform files that were copied from other ports to this port, if the
>> file wasn't
>> changed I presume the copyright years are left alone. If the file required
>> changes
>> for this port, I expect the year to be updated to 2021.
On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote:
>> Thank you all for your comments regarding W^X implementation. I've made a
>> change that reduces the footprint of the implementation, also addressing
>> most of the comments. I'll revisit them individually to make sure nothing is
>>
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> For platform files that were copied from other ports to this port, if the
>
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
>
On 17.01.21 18:48, Philippe Marschall wrote:
...
To be honest backing out of the StreamDecoder changes looks like a good
comprise to me to reduce the risk while still improving throughput and
reducing allocation rate, especially in the on-heap path.
I gave it some more thought and propose
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Wed, 3 Feb 2021 19:42:16 GMT, Johannes Kuhn
wrote:
>> `MethodHandle -> Method.invoke -> MethodHandles.lookup() ` is a corner case
>> that can be fixed easily using the class data approach. See the new commit.
>
> The security issue I mentioned was in an other branch, method-invoke.
>
>
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
I'm unsure the benefit of moving the check done by `checkName` to the VM but
`preDefineClass` still calls `checkName`.
On Wed, 3 Feb 2021 18:34:55 GMT, Mandy Chung wrote:
>> You are right, got it confused with the future use.
>>
>> With this fix, MethodHandle -> Method.invoke -> MethodHandles.lookup() will
>> still return a lookup on the injected invoker.
>> I somehow missed that this is not part of the fix,
On Wed, 3 Feb 2021 17:35:30 GMT, Johannes Kuhn
wrote:
>> Last night, I had a second thought that the fix for these two JBS issues
>> does not need the class data. It's more for a future use. I plan to revise
>> it and drop class data in this fix anyway.
>
> You are right, got it confused
> JDK-8013527: calling MethodHandles.lookup on itself leads to errors
> JDK-8257874: MethodHandle injected invoker doesn't have necessary private
> access
>
> Johannes Kuhn is also a contributor to this patch.
>
> A caller-sensitive method can behave differently depending on the identity
> of
On Wed, 3 Feb 2021 16:11:08 GMT, Claes Redestad wrote:
>> This patch refactors CleanerFactory and InnocuousThread so that we need to
>> load fewer PrivilegedActions. This slightly reduce the number of classes we
>> always load on bootstrap, slightly reducing static and dynamic footprint
>>
On Wed, 3 Feb 2021 12:08:58 GMT, Claes Redestad wrote:
> This moves the tracing methods added to GenerateJLIClassesHelper in
> JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code
> meant for jlink.
Marked as reviewed by mchung (Reviewer).
On Wed, 3 Feb 2021 17:25:04 GMT, Mandy Chung wrote:
>> Only `Lookup` with the original access can access `MethodHandles.classData`.
>> A hidden class `HC$$InjectedInvoker/0x1234` can access private members of
>> another class `C` in the same nest but not `C`'s class data.
>>
>> I don't
On Wed, 3 Feb 2021 17:20:40 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java line 1205:
>>
>>> 1203: Class invokerClass = new Lookup(targetClass)
>>> 1204: .makeHiddenClassDefiner(name,
>>> INJECTED_INVOKER_TEMPLATE,
On Wed, 3 Feb 2021 10:52:41 GMT, Johannes Kuhn
wrote:
>> JDK-8013527: calling MethodHandles.lookup on itself leads to errors
>> JDK-8257874: MethodHandle injected invoker doesn't have necessary private
>> access
>>
>> Johannes Kuhn is also a contributor to this patch.
>>
>> A
> This patch refactors CleanerFactory and InnocuousThread so that we need to
> load fewer PrivilegedActions. This slightly reduce the number of classes we
> always load on bootstrap, slightly reducing static and dynamic footprint
> (default CDS archive -4Kb).
Claes Redestad has updated the
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java
> test.
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
trying to manipulate effective jtreg classpath
-
Changes:
- all:
Remove lines in WixSourceBuilder that adds directive to rm-rf the parent dir(s)
of the install-dir. These directories get removed anyway if they are empty
without these lines, and should be left alone if not empty after removing the
install dir itself.
-
Commit messages:
-
On Fri, 29 Jan 2021 00:15:16 GMT, Mark Reinhold wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update package info to credit LMX algorithm
>
> src/java.base/share/classes/java/util/random/RandomGenerator.java line
On Thu, 3 Dec 2020 19:46:14 GMT, Ivan Šipka wrote:
>> @iignatev could you please review? Thank you.
>>
>> note to self:
>> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java
>> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java
>>
On Wed, 2 Dec 2020 20:28:19 GMT, Ivan Šipka wrote:
> Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test.
This pull request has now been integrated.
Changeset: 0ef93feb
Author:Ivan Šipka
Committer: Igor Ignatyev
URL:
> This patch refactors CleanerFactory and InnocuousThread so that we need to
> load fewer PrivilegedActions. This slightly reduce the number of classes we
> always load on bootstrap, slightly reducing static and dynamic footprint
> (default CDS archive -4Kb).
Claes Redestad has updated the
This patch refactors CleanerFactory and InnocuousThread so that we need to load
fewer PrivilegedActions. This slightly reduce the number of classes we always
load on bootstrap, slightly reducing static and dynamic footprint (default CDS
archive -4Kb).
-
Commit messages:
- Reduce
This patch moves some sanity checking done in ClassLoader.java to the
corresponding endpoints in native or VM code.
-
Commit messages:
- Copyrights
- Move class name checking for findBootstrapClass/findLoadedClass into
native/VM
Changes:
This moves the tracing methods added to GenerateJLIClassesHelper in JDK-8252725
to MethodHandleStatics, which avoids loading at runtime some code meant for
jlink.
-
Commit messages:
- Remove unused import, copyrights
- Move tracing methods and constants from
On Fri, 29 Jan 2021 00:54:46 GMT, Claes Redestad wrote:
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate
On Tue, 2 Feb 2021 22:55:59 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor out specific ZipException from checkedHash
>
> Thank you for the update Claes, the changes look fine
On Wed, 3 Feb 2021 01:50:36 GMT, Mandy Chung wrote:
> JDK-8013527: calling MethodHandles.lookup on itself leads to errors
> JDK-8257874: MethodHandle injected invoker doesn't have necessary private
> access
>
> Johannes Kuhn is also a contributor to this patch.
>
> A caller-sensitive method
On Tue, 2 Feb 2021 18:03:50 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>
>> 5269: //
>>
On Tue, 2 Feb 2021 21:49:36 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 323:
>
>> 321:
59 matches
Mail list logo
