On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
> But I don't understand why this error can happen. It seems like jtreg would
> allow two test cases to interfere with each other.
The root cause seems to be
https://bugs.openjdk.java.net/browse/CODETOOLS-7902847
-
PR:
On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
> `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
>
On Fri, 12 Mar 2021 16:44:38 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and removes
>
Hi all,
could you please review this dull patch that replaces `ClassFileInstaller` w/
`jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
ensure we won't get split testlibrary, and removes
`jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used).
from
On Sat, 13 Mar 2021 00:52:44 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by almatvee (Committer).
>
> Since you are removing the problem listing, would it be better to use the
> parent bug ID -- 8263474 -- rather than a sub-task? How do you plan to
> resolve the parent bug? Manually as
On Sat, 13 Mar 2021 00:42:13 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
> 8263536: Add missing @compile tags to jpackage tests
Alexey Semenyuk has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
8263536: Add missing @compile tags to jpackage tests
-
Changes:
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
On Fri, 12 Mar 2021 17:52:30 GMT, Alexey Semenyuk wrote:
> 8263536: Add missing @compile tags to jpackage tests
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2975
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/ just `main` method
On Fri, 12 Mar 2021 02:08:09 GMT, Mikhailo Seledtsov
wrote:
>> Hi all,
>>
>> could you please review the patch which moves `ClassFileInstaller` class to
>> `jdk.test.lib.helpers` package?
>> to reduce changes in the tests, `ClassFileInstaller` in the default package
>> is kept w/ just
8263536: Add missing @compile tags to jpackage tests
-
Commit messages:
- 8263536: Add missing @compile tags to jpackage tests
Changes: https://git.openjdk.java.net/jdk/pull/2975/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2975=00
Issue:
On Fri, 12 Mar 2021 13:27:39 GMT, Claes Redestad wrote:
> Remove unused methods.
LGTM
-
Marked as reviewed by jkuhn (Author).
PR: https://git.openjdk.java.net/jdk/pull/2969
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
>
On Thu, 11 Mar 2021 16:42:24 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Tue, 9 Mar 2021 18:01:11 GMT, Anton Kozlov wrote:
>> src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp line 62:
>>
>>> 60:
>>> 61: #if defined(__APPLE__) || defined(_WIN64)
>>> 62: #define R18_RESERVED
>>
>> #define R18_RESERVED true```
>
> We always check for `R18_RESERVED` with
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Fri, 12 Mar 2021 13:25:31 GMT, Aleksey Shipilev wrote:
> SonarCloud rightfully says:
> The length of "values" is always ">=0", so update this test to either "==0"
> or ">0".
>
> // make sure at least one value was returned
> if(values.length < 0) { // <--- here
>
On Tue, 9 Mar 2021 16:12:36 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
implementation of
JDK-8256145: JEP 398: Deprecate the Applet API for Removal
-
Commit messages:
- 8189198: Add "forRemoval = true" to Applet API deprecations
Changes: https://git.openjdk.java.net/jdk/pull/2920/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2920=00
On Fri, 12 Mar 2021 13:25:31 GMT, Aleksey Shipilev wrote:
> SonarCloud rightfully says:
> The length of "values" is always ">=0", so update this test to either "==0"
> or ">0".
>
> // make sure at least one value was returned
> if(values.length < 0) { // <--- here
>
SonarCloud rightfully says:
The length of "values" is always ">=0", so update this test to either "==0"
or ">0".
// make sure at least one value was returned
if(values.length < 0) { // <--- here
throw new InvalidAttributeValueException("no values for " +
On Fri, 12 Mar 2021 13:23:39 GMT, Peter Levart wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Follow Peter Levart's review suggestion - remove volatile
>
> This looks good to me. Maybe if you wanted the previous
Remove unused methods.
-
Commit messages:
- Revert assertSame removal (used from InvokerByteCodeGenerator)
- Remove dead code in MethodHandleImpl
Changes: https://git.openjdk.java.net/jdk/pull/2969/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2969=00
Issue:
On Wed, 10 Mar 2021 02:15:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed patch for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8263108?
>>
>> As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
>>
On Thu, 11 Mar 2021 20:28:46 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8262903: [macos_aarch64] Thread::current() called on detached thread
>
> Marked as reviewed by stefank (Reviewer).
On Tue, 2 Mar 2021 08:12:10 GMT, Anton Kozlov wrote:
>> I wasn't able to replicate JDK-8020753 and JDK-8186286. So will remove these
>> workaround
>> @gerard-ziemski, 8020753 was originally your fix, do you know if it still
>> needed on intel-mac ?
>
> The x86_bsd still carries the workaround
On Mar 12, 2021, at 6:32 AM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
On 11/03/2021 15:25, Lance Andersen wrote:
The only reason I included it is for completeness with tar which the jar
options were originally derived from.
I think it would be surprising to have two GNU-style
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
This pull request has been closed without being integrated.
-
PR:
On Fri, 12 Feb 2021 22:48:51 GMT, Mandy Chung wrote:
>> This more limited cleanup looks good.
>
> This patch changes `JVM_FindLoadedClass` interface to only accept a binary
> name. It used to accept both a binary name and internal form. Most, if not
> all, JVM entry points take the name of
On 11/03/2021 15:25, Lance Andersen wrote:
The only reason I included it is for completeness with tar which the
jar options were originally derived from.
I think it would be surprising to have two GNU-style long options so I
think we should pick one. "--dir" seems okay to me and is
37 matches
Mail list logo
