Integrated: 8261673: Move javadoc for the lookup mechanism to module-info

2021-03-22 Thread Joe Wang
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote: > Consolidate and move javadoc for the lookup mechanism to the module summary. This pull request has now been integrated. Changeset: 289d48ae Author:Joe Wang URL: https://git.openjdk.java.net/jdk/commit/289d48ae Stats: 602 lines i

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v3]

2021-03-22 Thread Alan Bateman
On Tue, 23 Mar 2021 01:03:55 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Alan Bateman
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread David Holmes
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v3]

2021-03-22 Thread David Holmes
On Tue, 23 Mar 2021 01:03:55 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v3]

2021-03-22 Thread Kim Barrett
> Please review this change to java.util.Timer, replacing the use of deprecated > finalization-based cleanup with use of java.lang.ref.Cleaner. > > In addition, Timer.cancel now cancels any later execution of the the no > longer relevant cleanup. > > Testing: > mach5 tier1 > New AutoStop test v

Re: RFR: JDK-8259926: Error in jpackage sample usage in the help text

2021-03-22 Thread Naoto Sato
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote: > JDK-8259926: Error in jpackage sample usage in the help text Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3132

Re: RFR: JDK-8259926: Error in jpackage sample usage in the help text

2021-03-22 Thread Alexander Matveev
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote: > JDK-8259926: Error in jpackage sample usage in the help text Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3132

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v2]

2021-03-22 Thread Brent Christian
On Mon, 22 Mar 2021 07:19:28 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: JDK-8259926: Error in jpackage sample usage in the help text

2021-03-22 Thread Alexey Semenyuk
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote: > JDK-8259926: Error in jpackage sample usage in the help text Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3132

Re: RFR: JDK-8263887: Re-create default icons

2021-03-22 Thread Alexey Semenyuk
On Mon, 22 Mar 2021 13:03:10 GMT, Andy Herrick wrote: > JDK-8263887: Re-create default icons Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3118

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-22 Thread Lance Andersen
On Fri, 19 Mar 2021 08:19:58 GMT, Lin Zang wrote: >> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional >> GZIP fields > > Lin Zang has updated the pull request incrementally with two additional > commits since the last revision: > > - update copyright > - reuse argu

Re: RFR: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices

2021-03-22 Thread Rafael Winterhalter
On Mon, 22 Mar 2021 07:52:45 GMT, Tagir F. Valeev wrote: >> *ejc* issues the same constructor that prefixes a `String` and an `int` >> parameter. I agree that the solution is not perfect, but I would prefer it >> over the reflection API throwing an `IndexOutOfBoundsException` upon calling >> `

Re: RFR: JDK-8263887: Re-create default icons

2021-03-22 Thread Alexander Matveev
On Mon, 22 Mar 2021 13:03:10 GMT, Andy Herrick wrote: > JDK-8263887: Re-create default icons Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3118

RFR: JDK-8259926: Error in jpackage sample usage in the help text

2021-03-22 Thread Andy Herrick
JDK-8259926: Error in jpackage sample usage in the help text - Commit messages: - JDK-8259926: Error in jpackage sample usage in the help text Changes: https://git.openjdk.java.net/jdk/pull/3132/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3132&range=00 Issue: http

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Ioi Lam
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Aleksei Voitylov
With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. After JDK-8253081 with CDS enabled two instances of empty layer appear in the runtime. One comes from default initialization of java/lang/ModuleLayer.EMPTY_LAYER, another one comes from CDS archive and is returned by Mo

8214761: Bug in parallel Kahan summation implementation

2021-03-22 Thread Chris Dennis
I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient. Thanks, Chris

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v34]

2021-03-22 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v8]

2021-03-22 Thread Mandy Chung
On Mon, 22 Mar 2021 17:47:10 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request w

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v8]

2021-03-22 Thread Daniel Fuchs
On Mon, 22 Mar 2021 17:47:10 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request w

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v8]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webre

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

2021-03-22 Thread Patrick Concannon
On Mon, 15 Mar 2021 13:49:56 GMT, Pavel Rappo wrote: >> yes, >> javac should emit a warning in that case, that also the answer of Brian. >> >> https://mail.openjdk.java.net/pipermail/amber-spec-experts/2021-March/002925.html > > Then we should use an unbounded wildcard here and in similar places

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v5]

2021-03-22 Thread Patrick Concannon
On Tue, 16 Mar 2021 19:26:35 GMT, Daniel Fuchs wrote: >> `declaringClass` is a string representing the class name (not the `Class` >> object). The variable name indeed causes confusion. > > Doh. My mistake. Was thinking about `StackFrame`. Thanks Mandy! I've reordered the checks as suggested

Withdrawn: JDK-8263154: [macos] DMG builds have finder errors

2021-03-22 Thread Andy Herrick
On Sat, 13 Mar 2021 14:39:40 GMT, Andy Herrick wrote: > JDK-8263154: [macos] DMG builds have finder errors This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2987

RFR: 8203359: Container level resources events

2021-03-22 Thread Jaroslav Bachorik
With this change it becomes possible to surface various cgroup level metrics (available via `jdk.internal.platform.Metrics`) as JFR events. Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is turned into JFR events to start with. * CPU related metrics * Memory related metr

Integrated: 8261785: Calling "main" method in anonymous nested class crashes the JVM

2021-03-22 Thread Henry Jen
On Sun, 14 Mar 2021 23:34:55 GMT, Henry Jen wrote: > This patch ensure launcher won't crash JVM for the new static Methods from > local/anonymous class on MacOS. > > As @dholmes-ora pointed out in the analysis, this is a MacOS specific bug > when the launcher trying to grab class name to be di

Integrated: 8263729: [test] divert spurious output away from stream under test in ProcessBuilder Basic test

2021-03-22 Thread Roger Riggs
On Wed, 17 Mar 2021 14:16:36 GMT, Roger Riggs wrote: > Intermittent failures on Windows in a test of destroying the child warrant > extending the time the parent waits after starting the child before > destroying the child. This pull request has now been integrated. Changeset: 0abbfb2f Author

Re: RFR: 8263729: [test] divert spurious output away from stream under test in ProcessBuilder Basic test [v4]

2021-03-22 Thread Roger Riggs
On Sat, 20 Mar 2021 05:55:08 GMT, Thomas Stuefe wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clarify modification of argument list after creating ProcessBuilder > > Looks good to me, if the intent was to fix pote

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v32]

2021-03-22 Thread Jim Laskey
On Thu, 18 Mar 2021 21:43:16 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 67 commits: >> >> - Merge branch 'master' into 8248862 >> - Review revisions >> - Missing @since >> - Review revi

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v33]

2021-03-22 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at > http://cr.openjdk.java.net/~jlaskey/prng/doc/a

Integrated: 8263855: Use the blessed modifier order in java.management/naming

2021-03-22 Thread Alex Blewitt
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. This pull request has now been integrated. Changeset: 5262d95b Author:Alex Blewitt Co

RFR: JDK-8263887: Re-create default icons

2021-03-22 Thread Andy Herrick
JDK-8263887: Re-create default icons - Commit messages: - JDK-8263887: Re-create default icons Changes: https://git.openjdk.java.net/jdk/pull/3118/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3118&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263887 S

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-22 Thread Daniel Fuchs
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]

2021-03-22 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-22 Thread Aleksei Efimov
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v2]

2021-03-22 Thread Alan Bateman
On Mon, 22 Mar 2021 07:19:28 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v7]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 826

RFR: JDK-8064681 : Jaxp unit test need to be improved

2021-03-22 Thread Mahendra Chhipa
https://bugs.openjdk.java.net/browse/JDK-8064681 - Commit messages: - JDK-8064681 : Jaxp unit test need to be improved Changes: https://git.openjdk.java.net/jdk/pull/3115/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3115&range=00 Issue: https://bugs.openjdk.java.ne

Re: java.io.File#toPath() on Windows doesn't understand "NUL:" (null device)?

2021-03-22 Thread Jaikiran Pai
On 22/03/21 2:36 pm, Alan Bateman wrote: On 20/03/2021 07:16, Jaikiran Pai wrote: : I received some inputs on that Ant bugzilla issue. Based on that, I was able to reproduce the exception and IMO it's a bug in Files.newOutputStream() API. I have opened https://bugs.openjdk.java.net/browse/

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v6]

2021-03-22 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webre

Re: java.io.File#toPath() on Windows doesn't understand "NUL:" (null device)?

2021-03-22 Thread Alan Bateman
On 20/03/2021 07:16, Jaikiran Pai wrote: : I received some inputs on that Ant bugzilla issue. Based on that, I was able to reproduce the exception and IMO it's a bug in Files.newOutputStream() API. I have opened https://bugs.openjdk.java.net/browse/JDK-8263898 with the relevant details. I co

Re: RFR: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices

2021-03-22 Thread Tagir F . Valeev
On Fri, 19 Mar 2021 14:34:00 GMT, Rafael Winterhalter wrote: >> A general comment, the enum constructor situation is a bit tricky as >> >> 1) There is no 100% reliable way to determine which of a enum constructor's >> args are synthetic. >> >> 2) How a Java compiler generates enum constructor

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v2]

2021-03-22 Thread David Holmes
On Mon, 22 Mar 2021 07:19:28 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v2]

2021-03-22 Thread Kim Barrett
On Mon, 22 Mar 2021 07:15:24 GMT, Kim Barrett wrote: >> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevan

Re: RFR: 8263903: Use Cleaner instead of finalize to auto stop Timer thread [v2]

2021-03-22 Thread Kim Barrett
> Please review this change to java.util.Timer, replacing the use of deprecated > finalization-based cleanup with use of java.lang.ref.Cleaner. > > In addition, Timer.cancel now cancels any later execution of the the no > longer relevant cleanup. > > Testing: > mach5 tier1 > New AutoStop test v