Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote: > One special case is the **public field** in `WriteAbortedException`. This is > really bad and something ought to be done about this, including deprecation, > and maybe more. This implies that the exception is mutable, right? Hrrmph. >

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

On Mon, 29 Mar 2021 08:38:59 GMT, Andrew Haley wrote: > > With an intial implemention, we can have almost half of the code size > > reduced (1312B -> 748B). Sounds OK to you? > > Sounds great, but I'm still somewhat concerned that the non-SIMD case only > offers 3-12% performance gain. Make

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic [v2]

> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. > Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea > can be found at > http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. > > Patch passed jtreg tier1-3 tests with

Re: Proposal for Decimal64 and Decimal128 value-based classes

This would be interesting to have. It would be better if the full set of numbers b16-256 and d32-128 are implemented so there is full coverage of all IEEE 754 numbers. On Tue, 30 Mar 2021 at 01:45, Raffaello Giulietti < raffaello.giulie...@gmail.com> wrote: > Hello, > > I'm experimenting with

Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

On Mon, 29 Mar 2021 21:09:56 GMT, Alex Blewitt wrote: > 8264397: Use the blessed modifier order in jdk.incubator.foreign This one should probably be fixed in the upstream repo over at https://github.com/openjdk/panama-foreign (I believe). /ping @JornVernee @mcimadamore - PR:

Re: Comment on CSR 8251991: Hex formatting and parsing utility

HI Raffaello, Which methods and what did you have in mind? (There may be good reasons for them as they are.) Thanks, Roger On 3/29/21 5:07 PM, Raffaello Giulietti wrote: Thanks, I noticed. There are a couple of other methods that can be simplified, require a couple of minutes to review and

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote: >> 8264148: Update spec for exceptions retrofitted for exception chaining > > The removal of the obsolescent "As of release 1.4, this exception has been > retrofitted..." is good. Changing the calls from the other exception-getting >

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining The removal of the obsolescent "As of release 1.4, this exception has been retrofitted..." is good. Changing the calls from the other exception-getting methods to

RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

8264148: Update spec for exceptions retrofitted for exception chaining - Commit messages: - Respond to review feedback. - Respond to review feedback. - Merge branch 'master' into 8264148 - Merge branch 'master' into 8264148 - 8264148: Update spec for exceptions retrofitted for

RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

8264397: Use the blessed modifier order in jdk.incubator.foreign - Commit messages: - 8264397: Use the blessed modifier order in jdk.incubator.foreign Changes: https://git.openjdk.java.net/jdk/pull/3253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3253=00 Issue:

Re: Comment on CSR 8251991: Hex formatting and parsing utility

Thanks, I noticed. There are a couple of other methods that can be simplified, require a couple of minutes to review and which don't have any impact on the API. If you agree, I'll prepare a PR with all the changes and the bug narrative for you to add to bugs.openjdk.org (I only have read

Integrated: 8263754: HexFormat 'fromHex' methods should be static

On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote: > A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and

Proposal for Decimal64 and Decimal128 value-based classes

Hello, I'm experimenting with an implementation of Decimal64 and Decimal128, two standard IEEE 754-2019 formats supporting, well, decimal floating point numbers of up to 16 resp 34 decimal digits. While BigDecimal can simulate most finite number computations on these formats by passing

Integrated: 8248418: jpackage fails to extract main class and version from app module linked in external runtime

On Mon, 29 Mar 2021 18:11:26 GMT, Alexey Semenyuk wrote: > Remove the test for failing jpackage use case scenario that we don't intent > to fix This pull request has now been integrated. Changeset: 128c0c97 Author:Alexey Semenyuk URL:

Re: RFR: 8248418: jpackage fails to extract main class and version from app module linked in external runtime

On Mon, 29 Mar 2021 18:11:26 GMT, Alexey Semenyuk wrote: > Remove the test for failing jpackage use case scenario that we don't intent > to fix Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3249

Re: RFR: 8248418: jpackage fails to extract main class and version from app module linked in external runtime

On Mon, 29 Mar 2021 18:11:26 GMT, Alexey Semenyuk wrote: > Remove the test for failing jpackage use case scenario that we don't intent > to fix Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3249

RFR: 8248418: jpackage fails to extract main class and version from app module linked in external runtime

Remove the test for failing jpackage use case scenario that we don't intent to fix - Commit messages: - 8248418: jpackage fails to extract main class and version from app module linked in external runtime Changes: https://git.openjdk.java.net/jdk/pull/3249/files Webrev:

Re: RFR: 8173970: jar tool should have a way to extract to a directory [v3]

> Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > The commit in this PR introduces the `-o` and `--output-dir` option to the > `jar` command. The option takes a path to a destination

Integrated: 8264332: Use the blessed modifier order in jdk.charsets

On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt wrote: > 8264332: Use the blessed modifier order in jdk.charsets This pull request has now been integrated. Changeset: 364cce14 Author:Alex Blewitt Committer: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk/commit/364cce14

Re: RFR: 8264332: Use the blessed modifier order in jdk.charsets

On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt wrote: > 8264332: Use the blessed modifier order in jdk.charsets Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3236

Integrated: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

On Wed, 10 Mar 2021 19:47:00 GMT, Andrey Turbanov wrote: > Found by IntelliJ IDEA inspection `Java | Java language level migration aids > | Java 5 | 'StringBuffer' may be 'StringBuilder'` > As suggested in > https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created >

Re: RFR: 8173970: jar tool should have a way to extract to a directory

On 28/03/21 9:52 pm, Lance Andersen wrote: On Mar 28, 2021, at 9:24 AM, Jaikiran Pai > wrote: Now when the user explicitly specifies the new -C or --dir option with the -P option for extract, something like: jar -xfP foo.jar -C /tmp/hello/ Given the

Re: RFR: 8264332: Use the blessed modifier order in jdk.charsets

On Sun, 28 Mar 2021 13:56:00 GMT, Alex Blewitt wrote: > 8264332: Use the blessed modifier order in jdk.charsets Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3236

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

On Mon, 29 Mar 2021 03:28:54 GMT, Dong Bo wrote: > I think I can rewrite this part as loops. > With an intial implemention, we can have almost half of the code size reduced > (1312B -> 748B). Sounds OK to you? Sounds great, but I'm still somewhat concerned that the non-SIMD case only offers

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

On Mon, 29 Mar 2021 03:15:57 GMT, Nick Gasson wrote: > > There's a lot of unrolling, particularly in the non-SIMD case. Please > > consider taking out some of the unrolling; I suspect it'd not increase time > > by very much but would greatly reduce the code cache pollution. It's very > >

Re: RFR: 8264334: Use the blessed modifier order in jdk.jpackage

On Sun, 28 Mar 2021 13:53:27 GMT, Alex Blewitt wrote: > 8264334: Use the blessed modifier order in jdk.jpackage Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3234

Integrated: 8264334: Use the blessed modifier order in jdk.jpackage

On Sun, 28 Mar 2021 13:53:27 GMT, Alex Blewitt wrote: > 8264334: Use the blessed modifier order in jdk.jpackage This pull request has now been integrated. Changeset: 30b4b17c Author:Alex Blewitt Committer: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk/commit/30b4b17c