On Thu, 6 May 2021 16:34:04 GMT, Peter Levart wrote:
>> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and
>> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class`
>> expressions like
>>
>> String str = baseName.replace('.', '/') + '/' + name;
>>
>> are
RandomAccessFile.length() method for block device return always 0
-
Commit messages:
- JDK-8266610: Method RandomAccessFile#length() returns 0 for block devices on
linux.
Changes: https://git.openjdk.java.net/jdk/pull/3914/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p
On Thu, 6 May 2021 08:05:12 GMT, Jason Zaugg wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 1235:
>>
>>> 1233: synchronized(ch) {
>>> 1234: return ch.position(pos).read(bb);
>>> 1235: }
>>
>> I think it's okay to include the u
> If the given Path represents a file, use the overload of read defined
> in FileChannel that accepts an explicit position and avoid serializing
> reads.
>
> Note: The underlying NIO implementation is not required to implement
> FileChannel.read(ByteBuffer, long) concurrently; Windows still appear
- Replaced direct TKit.run() calls with Test annotation.
- Increased timeout for SigningPackageTest from default to 360 due to timeout.
This is regression from JDK-8248904 due to changes done in signing and
--remove-signature adds additional time since it is run per file.
- Fixed issue with jtr
On Thu, 6 May 2021 21:59:32 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove tab space
>
> The latest version LGTM
@iklam @calvinccheung Thanks for review!
-
PR: https://git.openjdk.ja
On Thu, 6 May 2021 21:37:35 GMT, Yumin Qi wrote:
>> Hi, Please review
>> When using jcmd to dump shared archive, if the archive name exists, it
>> will be deleted first. If exception happens during dumping process, there is
>> no new archive created. This PR changes to first dump the archiv
On Fri, 7 May 2021 00:02:56 GMT, Yumin Qi wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java line 78:
>>
>>> 76: print2ln(test_count++ + " Set target dir not writable, do
>>> dynamic dump");
>>> 77: setKeepArchive(true);
>>> 78: outputDirFile.se
On Thu, 6 May 2021 23:59:21 GMT, Calvin Cheung wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove tab space
>
> test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java line 78:
>
>> 76: print2ln
On Thu, 6 May 2021 21:37:35 GMT, Yumin Qi wrote:
>> Hi, Please review
>> When using jcmd to dump shared archive, if the archive name exists, it
>> will be deleted first. If exception happens during dumping process, there is
>> no new archive created. This PR changes to first dump the archiv
This is a proposal to add a new interface to java.time.*
public interface TimeSource {
public static TimeSource system() { ... }
public abstract Instant instant();
public default long millis() {
return instant().toEpochMilli();
}
public default Clock withZone(ZoneId zon
https://openjdk.java.net/jeps/415
Summary: Allow applications to configure context-specific and
dynamically-selected deserialization filters via a JVM-wide filter
factory that is invoked to select a filter for each individual
deserialization operation.
- Mark
On Thu, 6 May 2021 21:37:35 GMT, Yumin Qi wrote:
>> Hi, Please review
>> When using jcmd to dump shared archive, if the archive name exists, it
>> will be deleted first. If exception happens during dumping process, there is
>> no new archive created. This PR changes to first dump the archiv
> Hi, Please review
> When using jcmd to dump shared archive, if the archive name exists, it
> will be deleted first. If exception happens during dumping process, there is
> no new archive created. This PR changes to first dump the archive with a
> temporary file name. With successful dump,
> Hi, Please review
> When using jcmd to dump shared archive, if the archive name exists, it
> will be deleted first. If exception happens during dumping process, there is
> no new archive created. This PR changes to first dump the archive with a
> temporary file name. With successful dump,
> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removing preview
> related comments from APIs plus options in test cases. Please
On Thu, 6 May 2021 11:52:09 GMT, Ignasi Marimon-Clos
wrote:
>> @ignasi35 I have created JDK-8266578. Please change the name of this PR to:
>>
>> `8266578: Disambiguate BigDecimal description of scale`
>>
>> Please resolve any conflicts and commit the updated file. Once the update is
>> availa
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
> Hi, please find here a trivial test change that adds some diagnostic (time
> stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
removed unused import statement
-
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
Please review the change to jarsigner so it uses certpath security property in
order to properly display the weakness of the certificate algorithms.
-
Commit messages:
- 8266225:jarsigner is using incorrect security property to show weakness of
certs
Changes: https://git.openjdk.j
On Thu, 29 Apr 2021 21:13:38 GMT, Paul Sandoz wrote:
> This PR contains API and implementation changes for [JEP-414 Vector API
> (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for
> when targeted.
>
> Enhancements are made to the API for the support of operations on cha
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last
> Hi, please find here a trivial test change that adds some diagnostic (time
> stamps) to the LoggerFinder/modules subprocess test logs.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Use + Instant.now(); Instant.toString() uses the
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs wrote:
> Hi, please find here a trivial test change that adds some diagnostic (time
> stamps) to the LoggerFinder/modules subprocess test logs.
Oh - good point Naoto! Thanks for the suggestion. Done.
-
PR: https://git.openjdk.java.net/
> Please consider this request to override the `java.io.InputStream` methods
> `readAllBytes()` and `readNBytes(int)` in `FileInputStream` with more
> performant implementations. The method overrides attempt to read all
> requested bytes into a single array of the required size rather than
> co
On Thu, 6 May 2021 15:20:23 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and
> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class`
> expressions like
>
> String str = baseName.replace('.', '/') + '/' + name;
>
> are not
> Hi, Please review
> When using jcmd to dump shared archive, if the archive name exists, it
> will be deleted first. If exception happens during dumping process, there is
> no new archive created. This PR changes to first dump the archive with a
> temporary file name. With successful dump,
On 5/6/2021 5:21 AM, Carlos O'Donell wrote:
On Thu, 15 Apr 2021 08:33:47 GMT, gregcawthorne
wrote:
Glibc 2.29 onwards provides optimised versions of log,log10,exp.
These functions have an accuracy of 0.9ulp or better in glibc
2.29.
Therefore this patch adds code to parse, store and check
t
On Thu, 6 May 2021 15:25:10 GMT, Daniel Fuchs wrote:
> Hi, please find here a trivial test change that adds some diagnostic (time
> stamps) to the LoggerFinder/modules subprocess test logs.
Could those be replaced with just `Instant.now()`? `Instant.toString()` uses
the same formatter as `ISO_
Hi, please find here a trivial test change that adds some diagnostic (time
stamps) to the LoggerFinder/modules subprocess test logs.
-
Commit messages:
- 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules
Changes: https://git.openjdk.java.net/jdk/pull/3904/files
Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 it appears,
that in `j.l.Class` expressions like
String str = baseName.replace('.', '/') + '/' + name;
are not compiled into invokedynamic-based code, but into one using
`StringBuilder`.
This happens due to some bootstraping is
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote:
> Hi all,
>
> This fix addresses a change in TestNG behavior for the Before/AfterGroups
> annotations that was introduced via
> https://github.com/cbeust/testng/pull/2167. The tests have been verified
> against the latest TestNG relea
On Wed, 5 May 2021 19:10:21 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which updates
> test/jdk/java/lang/ProcessHandle/PermissionTest.java &
> test/jdk/java/sql/testng/util/TestPolicy.java to include :
>
> `new PropertyPermission("testng.memory.friendly", "read");
>
On Tue, 4 May 2021 20:13:20 GMT, Brian Burkhalter wrote:
>> On `/proc/cpuinfo` for example, `fstat()` succeeds but `st_size` in `struct
>> stat` is zero. The correct position is however returned by `lseek()`.
>> Apparently this proposal needs to be reworked to expect size zero when the
>> size
On Thu, 15 Apr 2021 08:33:47 GMT, gregcawthorne
wrote:
> Glibc 2.29 onwards provides optimised versions of log,log10,exp.
> These functions have an accuracy of 0.9ulp or better in glibc
> 2.29.
>
> Therefore this patch adds code to parse, store and check
> the runtime glibcs version in os_linux
On Wed, 5 May 2021 20:29:59 GMT, Brian Burkhalter wrote:
>>> @ignasi35 Do you wish to continue this PR? If so I will file an issue.
>>> Thanks.
>>
>> Hi @bplb, this completely fell through the cracks. If you could file the
>> issue for me I'd really appreciate it. Thanks.
>
> @ignasi35 I have
On Thu, 29 Apr 2021 06:54:33 GMT, Yasumasa Suenaga wrote:
> We can see following compiler warning in check_code.c on GCC 11.
This pull request has now been integrated.
Changeset: 0f9852c6
Author:Yasumasa Suenaga
URL:
https://git.openjdk.java.net/jdk/commit/0f9852c63b12c43b52615ea003
On Tue, 12 Jan 2021 14:07:23 GMT, Ignasi Marimon-Clos
wrote:
>> The `jcheck` test fails because "The commit message does not reference any
>> issue. To add an issue reference to this PR, edit the title to be of the
>> format `issue number: message`."
>
> Thanks @bplb. I'm afraid I'm not an
>
On Mon, 3 May 2021 16:45:22 GMT, Ignasi Marimon-Clos
wrote:
>> Thanks @bplb. I'm afraid I'm not an
>> [author](http://openjdk.java.net/bylaws#author) or have access to create or
>> read the issues in
>> [JIRA](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1).
>>
>
On Tue, 12 Jan 2021 14:07:23 GMT, Ignasi Marimon-Clos
wrote:
>> The `jcheck` test fails because "The commit message does not reference any
>> issue. To add an issue reference to this PR, edit the title to be of the
>> format `issue number: message`."
>
> Thanks @bplb. I'm afraid I'm not an
>
On Mon, 4 Jan 2021 19:31:40 GMT, Brian Burkhalter wrote:
>> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
>> writeup can be missleading when presenting the meaning of a `scale` value
>> that's negative. Hopefully, with this PR, the sentence is more clear.
>>
>> Th
The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
writeup can be missleading when presenting the meaning of a `scale` value
that's negative. Hopefully, with this PR, the sentence is more clear.
The ambiguity is on this sentence:
> If negative, the unscaled value of the
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos
wrote:
> The API Docs for `BigDecimal` introduce the meaning of `scale`. The current
> writeup can be missleading when presenting the meaning of a `scale` value
> that's negative. Hopefully, with this PR, the sentence is more clear.
>
> The
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
On Mon, 3 May 2021 15:37:44 GMT, Jorn Vernee wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/macos/StackVaList.java
>> line 131:
>>
>>> 129: MemorySegment struct = allocator.allocate(layout);
>>> 130: struct.copyFrom(seg
On Thu, 6 May 2021 07:41:00 GMT, Alan Bateman wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant cast from previous commit.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 1235:
>
On Thu, 6 May 2021 00:03:20 GMT, Jason Zaugg wrote:
>> If the given Path represents a file, use the overload of read defined
>> in FileChannel that accepts an explicit position and avoid serializing
>> reads.
>>
>> Note: The underlying NIO implementation is not required to implement
>> FileChann
On Thu, 29 Apr 2021 06:54:33 GMT, Yasumasa Suenaga wrote:
> We can see following compiler warning in check_code.c on GCC 11.
LGTM.
I am not aware of any platform where sizeof(char) is not 1, but good to be
prepared :)
-
Marked as reviewed by stuefe (Reviewer).
PR: https://git.op
On 06/05/2021 04:47, buddyliao(廖彬) wrote:
Dear all,
Would you help me to review the following backport from jdk-master?
I think you are looking for jdk-updates-dev, the folks there will guide
you through how to get approval for these serviceability and GC changes.
-Alan
On Thu, 29 Apr 2021 06:54:33 GMT, Yasumasa Suenaga wrote:
> We can see following compiler warning in check_code.c on GCC 11.
Ping: Could you review this PR? We still see this warning with GCC 11.1.
-
PR: https://git.openjdk.java.net/jdk/pull/3787
60 matches
Mail list logo
