On Wed, 19 May 2021 06:20:59 GMT, Erik Gahlin wrote:
> This looks useful, but I am worried about the performance impact:
>
> * The added allocation for every object that is finalized.
> * The event being enabled in the default configuration.
>
> The default configuration must be safe to use eve
On Tue, 18 May 2021 23:01:05 GMT, Mark Reinhold wrote:
>> Please review this implementation of JEP 403
>> (https://openjdk.java.net/jeps/403).
>> Alan Bateman is the original author of almost all of it. Passes tiers 1-3
>> on
>> {linux,macos,windows}-x64 and {linux,macos}-aarch64.
>
> Mark Re
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Tue, 18 May 2021 23:35:12 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleTest.java line 683:
>>
>>> 681: * @bug 4052404 4778440 8263202
>>> 682: */
>>> 683: public void TestChangedISO639Codes() {
>>
>> Could probably be simplified with a DataProvider.
>
> That would
On Tue, 18 May 2021 23:39:37 GMT, Naoto Sato wrote:
>> Please review the changes to the subject issue. java.util.Locale class has a
>> long-standing issue for those obsolete ISO 639 languages where its
>> normalization ends up in the obsolete codes. This change intends to flip the
>> normaliza
On Mon, 3 May 2021 13:16:06 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turne
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Mon, 17 May 2021 16:53:24 GMT, Vicente Romero wrote:
> This is a very small patch that is just rewording the spec for
> DynamicCallSiteDesc::withArgs. Basically adding that NPE can also be thrown
> if the content of the argument is `null`
>
> TIA for the review
ping
-
PR: htt
On Wed, 19 May 2021 00:58:15 GMT, Sandhya Viswanathan
wrote:
>> This PR contains Short Vector Math Library support related changes for
>> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
>> in preparation for when targeted.
>>
>> Intel Short Vector Math Library (SVM
On Wed, 19 May 2021 00:58:15 GMT, Sandhya Viswanathan
wrote:
>> This PR contains Short Vector Math Library support related changes for
>> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
>> in preparation for when targeted.
>>
>> Intel Short Vector Math Library (SVM
On Wed, 19 May 2021 00:26:48 GMT, Vladimir Kozlov wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jcheck fixes
>
> This is much much better! Thank you for changing it. I am only asking now to
> add comment
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Fri, 14 May 2021 23:58:38 GMT, Sandhya Viswanathan
wrote:
> Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and
> IS_NEGATIVE) are computed in three steps:
> 1) reinterpreting the floating point vectors as integral vectors (int/long)
> 2) perform the test in integer do
On Tue, 18 May 2021 23:59:28 GMT, Sandhya Viswanathan
wrote:
>> This PR contains Short Vector Math Library support related changes for
>> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
>> in preparation for when targeted.
>>
>> Intel Short Vector Math Library (SVM
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Tue, 18 May 2021 23:43:13 GMT, Sandhya Viswanathan
wrote:
>> This PR contains Short Vector Math Library support related changes for
>> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
>> in preparation for when targeted.
>>
>> Intel Short Vector Math Library (SVM
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
> normalization towards the current codes, providing a system propert
On Tue, 18 May 2021 22:22:06 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Locale's class description modification
>
> src/java.base/share/classes/java/util/Locale.java line 462:
>
>> 460: * backwar
> This PR contains Short Vector Math Library support related changes for
> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414),
> in preparation for when targeted.
>
> Intel Short Vector Math Library (SVML) based intrinsics in native x86
> assembly provide optimized imple
On Tue, 18 May 2021 21:04:18 GMT, Naoto Sato wrote:
>> Stephen Colebourne has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8266846: Add java.time.InstantSource
>
> test/jdk/java/time/test/java/time/TestInstantSource.java line 86:
>
>> 84
On Sun, 16 May 2021 07:39:21 GMT, Peter Levart wrote:
>> Stephen Colebourne has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8266846: Add java.time.InstantSource
>
> src/java.base/share/classes/java/time/Clock.java line 487:
>
>> 485:
> 8266846: Add java.time.InstantSource
Stephen Colebourne has updated the pull request incrementally with one
additional commit since the last revision:
8266846: Add java.time.InstantSource
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4016/files
- new: https://git.
On Fri, 14 May 2021 08:54:23 GMT, Alan Bateman wrote:
>> Mark Reinhold has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove now-unnecessary uses and mentions of the --illegal-access option
>
> test/jdk/tools/launcher/modules/illegalacc
> Please review this implementation of JEP 403
> (https://openjdk.java.net/jeps/403).
> Alan Bateman is the original author of almost all of it. Passes tiers 1-3 on
> {linux,macos,windows}-x64 and {linux,macos}-aarch64.
Mark Reinhold has updated the pull request incrementally with one additiona
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
> normalization
> Please review this enhancement to add a new JFR event, generated whenever a
> finalizer is run.
> (The makeup is similar to the Deserialization event,
> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>
> The event's only datum (beyond those common to all jfr events) is the c
On Tue, 18 May 2021 21:40:57 GMT, Istvan Neuwirth
wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The e
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.security.manager=allow` when launched. This PR covers such
On Tue, 18 May 2021 20:55:10 GMT, Brent Christian wrote:
> Please review this enhancement to add a new JFR event, generated whenever a
> finalizer is run.
> (The makeup is similar to the Deserialization event,
> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>
> The event's
Please review this enhancement to add a new JFR event, generated whenever a
finalizer is run.
(The makeup is similar to the Deserialization event,
[JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
The event's only datum (beyond those common to all jfr events) is the class of
the
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Tue, 18 May 2021 18:38:52 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/AccessController.java line 877:
>>
>>> 875: @CallerSensitive
>>> 876: public static T doPrivileged(PrivilegedExceptionAction
>>> action,
>>> 877: @Supp
Using a switch expression instead of a (read-only) static `HashMap` reduces
initialization overhead of `VarHandle$AccessMode`. This gets loaded earlier
after JDK-8265079, so it started showing up in a few lambda startup tests.
This also obsoletes a jtreg test that only verified that this map was
On Mon, 17 May 2021 17:19:19 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
src/java.base/share/classes/ja
> JEP 415: Context-specific Deserialization Filters extends the deserialization
> filtering mechanisms with more flexible and customizable protections against
> malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
> The `java.io.ObjectInputFilter` and `java.io.ObjectInputSt
On Fri, 14 May 2021 23:58:38 GMT, Sandhya Viswanathan
wrote:
> Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and
> IS_NEGATIVE) are computed in three steps:
> 1) reinterpreting the floating point vectors as integral vectors (int/long)
> 2) perform the test in integer do
On Mon, 17 May 2021 14:39:05 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Mon, 17 May 2021 14:39:05 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Tue, 18 May 2021 17:36:55 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e3
On Mon, 17 May 2021 17:19:19 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Changes requested by plevart (
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Classes in the i18n area look good.
-
Marked
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Tue, 18 May 2021 15:19:21 GMT, Alan Bateman wrote:
>> It includes both:
>> 
>
> Thanks for checking, I assumed that was the case so wondering if it
On Tue, 18 May 2021 12:42:08 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/lang/SecurityManager.java line 315:
>>
>>> 313: *
>>> 314: * @since 1.0
>>> 315: * @deprecated The Security Manager is deprecated and subject to
>>> removal in a
>>
>> Javadoc will prefix, in bold, "D
On Tue, 18 May 2021 05:48:56 GMT, Alan Bateman wrote:
> The changes look okay but a bit inconsistent on where -Djava...=allow is
> inserted for tests that already set other system properties or other
> parameters. Not a correctness issue, just looks odd in several places, e.g.
>
> test/jdk/jav
On Tue, 18 May 2021 11:12:00 GMT, Daniel Fuchs wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>> `-Dja
I'll go ahead with this enhancement, and make sure the wording is open
to adding validation logic not related to multi-release jars in the future.
Jorn
On 12/05/2021 14:47, Jorn Vernee wrote:
On 12/05/2021 14:41, Alan Bateman wrote:
On 12/05/2021 11:58, Jorn Vernee wrote:
Hi,
I see that the
On Tue, 18 May 2021 06:31:06 GMT, Alan Bateman wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e3
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Because we still make jdk11-compatible test-release java.u
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
You may need to coordinate with @DougLea on the changes to
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Changes look good.
-
Marked as reviewed by l
Hi,
Could someone please review my code for updating the code in the `java.util`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- 8267110: Update java.util to use instanceof pattern variable
Changes: https://git.openjdk.java.net
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
>
> A
62 matches
Mail list logo
