On Wed, 11 Aug 2021 21:40:52 GMT, Claes Redestad wrote:
>> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
>> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
>> this optimization cause a regression since `StringUTF16.charAt(..)` checks
>> `
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
On Thu, 12 Aug 2021 01:16:04 GMT, Brian Burkhalter wrote:
> Please consider this request to add an override
> `java.io.FileInputStream.transferTo(OutputStream)` with improved performance
> if the parameter is a `FileOutputStream`.
Invoking `transferTo()` on a `FileInputStream` will use the sup
Please consider this request to add an override
`java.io.FileInputStream.transferTo(OutputStream)` with improved performance if
the parameter is a `FileOutputStream`.
-
Commit messages:
- 8272297: FileInputStream should override transferTo() for better performance
Changes: https:/
On Sun, 1 Aug 2021 22:01:33 GMT, Markus KARG
wrote:
>> This PR-*draft* is **work in progress** and an invitation to discuss a
>> possible solution for issue
>> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
>> yet* intended for a final review.
>>
>> As proposed i
On Mon, 9 Aug 2021 17:02:55 GMT, Alexey Semenyuk wrote:
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/t
On Wed, 11 Aug 2021 21:40:52 GMT, Claes Redestad wrote:
>> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
>> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
>> this optimization cause a regression since `StringUTF16.charAt(..)` checks
>> `
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
> `index` against the length of the `value` array and not `count`
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
> `index` against the length of the `value` array and not `count`
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/tools/jpackage/apps/Hello.java.
Alexey Semenyuk has update
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote:
> Restart window app launcher to make changes made to `PATH` env variable
> visible to JLI code in
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
This pull request has now been integrated.
Change
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote:
> Restart window app launcher to make changes made to `PATH` env variable
> visible to JLI code in
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
Marked as reviewed by almatvee (Reviewer).
--
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
> `index` against the length of the `value` array and not `count`
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote:
> Restart window app launcher to make changes made to `PATH` env variable
> visible to JLI code in
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
Marked as reviewed by herrick (Reviewer).
---
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
On Tue, 10 Aug 2021 18:41:04 GMT, Claes Redestad wrote:
> Yes, while I don't know exactly which changes resolved JDK-6764325, it's
> clear from the microbenchmarks added for #2102 that it's no longer an issue -
> at least not in the mainline.
Thanks for checking and for closing that issue.
--
8271302: Regex Test Refresh
-
Commit messages:
- Migrating regular expression tests to TestNG
Changes: https://git.openjdk.java.net/jdk/pull/5092/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5092&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8271302
St
On Wed, 11 Aug 2021 18:22:42 GMT, Ian Graves wrote:
> 8271302: Regex Test Refresh
This PR migrates all regular expression tests in the jdk/java/util/regex
directory to use TestNG assertions and annotations. The assertions utilized for
this refresh are shared in common with standard ones from J
On Wed, 11 Aug 2021 11:27:53 GMT, Alan Bateman wrote:
> I've looked through the latest revision. Is there any way that we could drop
> most of the changes to ChannelInputStream and focus on one or two specific
> cases? I'm asking because there are several issues, inconsistencies, and it
> is t
Restart window app launcher to make changes made to `PATH` env variable visible
to JLI code in
https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
-
Commit messages:
- 8272328: java.library.path is not set properly by Windows jpackage app
launcher
On Wed, 11 Aug 2021 15:20:00 GMT, Alexey Semenyuk wrote:
>> Added jtreg test to verify jpackage launcher adds app dir to
>> `java.library.path` system property.
>> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
>> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
>> test
On Wed, 11 Aug 2021 14:26:32 GMT, Claes Redestad wrote:
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
> `inde
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/tools/jpackage/apps/Hello.java.
Alexey Semenyuk has update
On Wed, 11 Aug 2021 14:26:32 GMT, Claes Redestad wrote:
> In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
> avoid potentially getting two bounds checks in the UTF-16 case. Problem is
> this optimization cause a regression since `StringUTF16.charAt(..)` checks
> `inde
In #4738 we removed the `checkIndex(value, count)` call in `ASB.charAt` to
avoid potentially getting two bounds checks in the UTF-16 case. Problem is this
optimization cause a regression since `StringUTF16.charAt(..)` checks `index`
against the length of the `value` array and not `count`.
A cor
On Mon, 9 Aug 2021 18:10:52 GMT, Alan Bateman wrote:
> I think I fixed all requested changes. Anymore comments on this PR?
I've looked through the latest revision. Is here any way that we could drop
most of the changes to ChannelInputStream and focus on one or two specific
cases? I'm asking be
On Tue, 10 Aug 2021 08:59:59 GMT, Per Liden wrote:
>> While fixing JDK-8270626 it was discovered that the C2 intrinsic for
>> `Reference.refersTo()` is not used as often as one would think. Instead C2
>> often prefers using the native implementation, which is much slower which
>> defeats the p
On Mon, 9 Aug 2021 13:13:33 GMT, Per Liden wrote:
> While fixing JDK-8270626 it was discovered that the C2 intrinsic for
> `Reference.refersTo()` is not used as often as one would think. Instead C2
> often prefers using the native implementation, which is much slower which
> defeats the purpos
On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov wrote:
> This is the continuation of JDK-8233884 and JDK-8271456. This change affects
> fewer cases so I fix all "java." modules at once.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("U
On Wed, 4 Aug 2021 12:22:24 GMT, Thomas Stuefe wrote:
> We should not leak the handle to the jimage file (lib/modules) to childs.
>
> JDK-8194734 did solve this for windows. We should use FD_CLOEXEC on Posix as
> well.
>
> Note that this only poses a problem when a child process is spawned off
On Wed, 4 Aug 2021 12:22:24 GMT, Thomas Stuefe wrote:
> We should not leak the handle to the jimage file (lib/modules) to childs.
>
> JDK-8194734 did solve this for windows. We should use FD_CLOEXEC on Posix as
> well.
>
> Note that this only poses a problem when a child process is spawned off
34 matches
Mail list logo
