On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent
On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov
wrote:
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested".
> The initial intent was to
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested".
> The initial intent was to extend the buildJdkDockerImage() API of
> DockerTestUtils to
On Tue, 17 Aug 2021 20:30:04 GMT, Harold Seigel wrote:
>> Mikhailo Seledtsov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing review feedback
>
> test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java line 175:
>
>> 173:
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent
On Mon, 9 Aug 2021 12:28:23 GMT, CC007
wrote:
> create Streamable and ParallelStreamable interface and use them in Collection
> and Optional
I believe that the accompanying JBS issue (JDK-8272137) can be closed. Maybe a
mention of how the discussion in this PR was resolved (with code examples
Hi Don,
On 2021-08-17 19:05, Donald Raab wrote:
Hi Claes,
so the win comes from forEach on the synchronized collection implicitly
being synchronized atomically, whereas foreach will synchronize on
each iterator operation and thus allow racy modification of elements
in between iteration, right?
This provides an opportunity for me to promote what I believe is a much more
important missing interface, namely, an interface that supports a semantic
replacement for type casting.
Using type casting (instanceof) is a really bad way to test an object for an
optional capability.
The reason is
On Mon, 9 Aug 2021 12:28:23 GMT, CC007
wrote:
> create Streamable and ParallelStreamable interface and use them in Collection
> and Optional
Ah ok, I see your point. In the case that you want to have something be only
`Streamable`, you can create an interface like this (fixed missing method t
On Tue, 17 Aug 2021 17:39:49 GMT, Harold Seigel wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3
>> when splitting self cgroup lines by ':' so that Cgroup paths won't get
>> truncated if they contain embedded ':'s. For example, an entry of
>> "11:memory:/user
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For example, an entry of
> "11:memory:/user.sli
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For example, an entry of
> "11:memory:/user.sli:ce" in a /proc/self/cgroup file will now result in a
>
On Tue, 17 Aug 2021 02:48:35 GMT, Brian Burkhalter wrote:
> This change proposes to exclude `/run/user` mounts from the test when run on
> Linux as they can "disappear" while the test is running.
This pull request has now been integrated.
Changeset: a68b5b9c
Author:Brian Burkhalter
URL:
Hi Claes,
> so the win comes from forEach on the synchronized collection implicitly
> being synchronized atomically, whereas foreach will synchronize on
> each iterator operation and thus allow racy modification of elements
> in between iteration, right?
Yes, this win will be applied to any type
On Tue, 17 Aug 2021 16:03:47 GMT, Brian Burkhalter wrote:
>> This change proposes to exclude `/run/user` mounts from the test when run on
>> Linux as they can "disappear" while the test is running.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit sinc
> This change proposes to exclude `/run/user` mounts from the test when run on
> Linux as they can "disappear" while the test is running.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8272369: On Linux, do not filter /run/user
On Mon, 16 Aug 2021 12:32:34 GMT, Jim Laskey wrote:
> RandomTestMoments.java and RandomTestChiSquared.java expect successive calls
> to nextLong to reproduce the same sequence of values. SecureRandom, by its
> nature, does not follow this requirement. The patch filters out SecureRandom
> from
On Tue, 17 Aug 2021 02:48:35 GMT, Brian Burkhalter wrote:
> This change proposes to exclude `/run/user` mounts from the test when run on
> Linux as they can "disappear" while the test is running.
There is no other occurrence of `df` in the `java/io` or the `java/nio` tests
that I can find. The
On Tue, 17 Aug 2021 02:48:35 GMT, Brian Burkhalter wrote:
> This change proposes to exclude `/run/user` mounts from the test when run on
> Linux as they can "disappear" while the test is running.
Marked as reviewed by alanb (Reviewer).
The change looks okay but I suspect a similar change will
On Mon, 16 Aug 2021 12:32:34 GMT, Jim Laskey wrote:
> RandomTestMoments.java and RandomTestChiSquared.java expect successive calls
> to nextLong to reproduce the same sequence of values. SecureRandom, by its
> nature, does not follow this requirement. The patch filters out SecureRandom
> from
On Tue, 17 Aug 2021 02:48:35 GMT, Brian Burkhalter wrote:
> This change proposes to exclude `/run/user` mounts from the test when run on
> Linux as they can "disappear" while the test is running.
That's correct, it's
[pam_systemd](https://www.man7.org/linux/man-pages/man8/pam_systemd.8.html).
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent
On Mon, 16 Aug 2021 12:32:34 GMT, Jim Laskey wrote:
> RandomTestMoments.java and RandomTestChiSquared.java expect successive calls
> to nextLong to reproduce the same sequence of values. SecureRandom, by its
> nature, does not follow this requirement. The patch filters out SecureRandom
> from
On Tue, 17 Aug 2021 09:07:17 GMT, Severin Gehwolf wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3
>> when splitting self cgroup lines by ':' so that Cgroup paths won't get
>> truncated if they contain embedded ':'s. For example, an entry of
>> "11:memory:/us
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested".
> The initial intent was to extend the buildJdkDockerImage() API of
> DockerTestUtils to
On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272124. The fix puts a limit of 3 when
> splitting self cgroup lines by ':' so that Cgroup paths won't get truncated
> if they contain embedded ':'s. For example, an entry of
> "11:memory:/user.sli
Hi Don,
so the win comes from forEach on the synchronized collection implicitly
being synchronized atomically, whereas foreach will synchronize on
each iterator operation and thus allow racy modification of elements
in between iteration, right?
Seems reasonable to consider, though it'd have to p
On Thu, 8 Jul 2021 11:51:18 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
>
> As Mandy suggested, I create this PR for changes involvin
On Mon, 16 Aug 2021 20:59:55 GMT, TatWai Chong
wrote:
> This patch implements string_compare intrinsic in SVE.
> It supports all LL, LU, UL and UU comparisons.
>
> As we haven't found an existing benchmark to measure performance impact,
> we created a benchmark derived from the test [1] for thi
29 matches
Mail list logo
