Re: RFR: 8264322: Generate CDS archive when creating custom JDK image [v2]

2021-08-19 Thread Mandy Chung
On Thu, 19 Aug 2021 23:59:32 GMT, Calvin Cheung wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CDSPlugin.java >> line 121: >> >>> 119: @Override >>> 120: public ResourcePool transform(ResourcePool in, ResourcePoolBuilder >>> out) { >>> 121:

Re: RFR: 8264322: Generate CDS archive when creating custom JDK image [v2]

2021-08-19 Thread Mandy Chung
On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung wrote: >> Please review this change for adding a `jlink` command line option >> `--generate-cds-archive` for generating CDS archives as a post processing >> step during the creation of a custom JDK image. >> >> Details can be found in the

Re: RFR: 8264322: Generate CDS archive when creating custom JDK image [v2]

2021-08-19 Thread Mandy Chung
On Thu, 19 Aug 2021 23:56:00 GMT, Calvin Cheung wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java >> line 89: >> >>> 87: private final List args; >>> 88: private final Set modules; >>> 89: private Platform platform; >> >> Can

Re: RFR: 8264322: Generate CDS archive when creating custom JDK image [v2]

2021-08-19 Thread Calvin Cheung
> Please review this change for adding a `jlink` command line option > `--generate-cds-archive` for generating CDS archives as a post processing > step during the creation of a custom JDK image. > > Details can be found in the corresponding CSR >

Re: RFR: 8264322: Generate CDS archive when creating custom JDK image [v2]

2021-08-19 Thread Calvin Cheung
On Wed, 18 Aug 2021 23:55:25 GMT, Mandy Chung wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @mlchung comments > > src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java > line 89: > >>

Re: RFR: 8266936: Add a finalization JFR event [v6]

2021-08-19 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and

Re: RFR: 8266936: Add a finalization JFR event [v5]

2021-08-19 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and

Re: RFR: JDK-8272639: jpackaged applications using microphone on mac

2021-08-19 Thread Sergey Bylokhov
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick wrote: > JDK-8272639: jpackaged applications using microphone on mac src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template line 37: > 35: true > 36: NSMicrophoneUsageDescription > 37: The application is

what does the spec say about file paths that are too long?

2021-08-19 Thread Alan Snyder
I’ve been looking for some specification of what happens when a file request is made using a path that is too long (whatever that means to the underlying system). I have not found one. Is there one? My opinion is that silent truncation should not happen. Instead, an exception should be thrown.

Re: RFR: JDK-8272639: jpackaged applications using microphone on mac

2021-08-19 Thread Alexander Matveev
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick wrote: > JDK-8272639: jpackaged applications using microphone on mac Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5186

Re: RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math [v3]

2021-08-19 Thread Brian Burkhalter
On Thu, 5 Aug 2021 18:57:42 GMT, Brian Burkhalter wrote: >> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to >> `java.lang.Math` and `java.lang.StrictMath`. > > Brian Burkhalter has updated the pull request with a new target base due to a > merge or a rebase. The pull

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-08-19 Thread Paul Sandoz
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote: > See the bug report for more details. I would appreciate if people with their > corporate testing systems would run this through their systems to avoid > surprises. (ping @RealCLanger, @iignatev). Struggling to recall all the details.

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-08-19 Thread Alan Bateman
On 19/08/2021 17:10, Igor Ignatyev wrote: On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote: See the bug report for more details. I would appreciate if people with their corporate testing systems would run this through their systems to avoid surprises. (ping @RealCLanger,

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-08-19 Thread Igor Ignatyev
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote: > See the bug report for more details. I would appreciate if people with their > corporate testing systems would run this through their systems to avoid > surprises. (ping @RealCLanger, @iignatev). Hi @shipilev , I've submitted

Integrated: 8272616: Strange code in java.text.DecimalFormat#applyPattern

2021-08-19 Thread Andrey Turbanov
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov wrote: > remove redundant if This pull request has now been integrated. Changeset: 51c1b9a6 Author:Andrey Turbanov Committer: Brian Burkhalter URL: https://git.openjdk.java.net/jdk/commit/51c1b9a6870bd9644e92227e47082a53e2d1c066

RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-08-19 Thread Aleksey Shipilev
See the bug report for more details. I would appreciate if people with their corporate testing systems would run this through their systems to avoid surprises. (ping @RealCLanger, @iignatev). - Commit messages: - Drop stream tests exclusivity Changes:

RFR: JDK-8272639: jpackaged applications using microphone on mac

2021-08-19 Thread Andy Herrick
JDK-8272639: jpackaged applications using microphone on mac - Commit messages: - JDK-8272639: jpackaged applications using microphone on mac Changes: https://git.openjdk.java.net/jdk/pull/5186/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5186=00 Issue:

Process for adding default method to javax.naming.Context?

2021-08-19 Thread Laird Nelson
Hello; I am new to this mailing list and its conventions; if I misstep I am happy to be pointed in the right direction. Disclaimer in case it matters: I work for Oracle on project Helidon. I would like to understand how to request an enhancement to the javax.naming.Context interface. A prior

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

2021-08-19 Thread Сергей Цыпанов
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

[A linked list data structure running some operations in O(sqrt(n)) time instead of O(n)]

2021-08-19 Thread Rodion Efremov
Hello, I was kindly directed to this mailing list in order to discuss this data structure: https://github.com/coderodde/LinkedList The README of that repository contains a table of running times for different methods and different List implementations (ArrayList, LinkedList, my version of the

Re: RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform [v2]

2021-08-19 Thread Masanori Yano
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote: >> Hi all, >> >> Could you please review the 8269373 bug fixes? >> >> These tests call java.lang.ProcessBuilder in direct, so not used jtreg >> command option. To run non-localized tests, -Duser.language=en and >> -Duser.country=US

Re: [(Much) faster java.util.LinkedList]

2021-08-19 Thread -
Oh, just fyi, remember to send to core-libs-dev@openjdk.java.net as well; gmail removes the mailing list when you reply by default, so our discussion like these are not shared there. We might need to check the common use cases of linked list in other places (since jdk has largely eliminated it);

Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-19 Thread Simon Nash
On 19/08/2021 07:40, Alan Bateman wrote: Yes, if there is code that really wants to use the native encoding and run of wide range of JDK releases without the using COMPAT then it can read the value of native.encoding and use Charset.defaultCharset if the property is not set. -Alan. Thanks

Re: JEP proposed to target JDK 18: 400: UTF-8 by Default

2021-08-19 Thread Alan Bateman
On 18/08/2021 22:44, Naoto Sato wrote: On 8/18/21 2:03 PM, Simon Nash wrote: I am the developer of a fairly large application that uses file I/O extensively. In most cases, the charset should be UTF-8 and I have used an explicit charset parameter on all method invocations where this applies.

Re: RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]

2021-08-19 Thread Markus KARG
On Sun, 15 Aug 2021 13:37:23 GMT, Markus KARG wrote: > I think the best course of action is to reduce the scope of this PR to the > file channel cases. There is no reason why future PRs can't build on this and > add implementations for other channel types. I have split up this PR so that