Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

On 21/09/2021 20:49, Scott Palmer wrote: : The agent is needed in my real app only to get an instance of the Instrumentation interface. As a general point, the Instrumentation object should never be leaked to applications or libraries. I have no idea what the agent does here but you should b

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

On Mon, 13 Sep 2021 11:06:15 GMT, Сергей Цыпанов wrote: > Currently the method is implemented like > > public List> parameterList() { > return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); > } > > This seems to be excessive, as three objects are allocated here. Instead we > c

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

On Sep 13, 2021, at 10:24 AM, Vladimir Ivanov mailto:vliva...@openjdk.java.net>> wrote: BTW it can be improved even further by caching the immutable List view of parameters. I would go further: If I were writing MethodType.java today I would probably use List.of as the backing store for the pa

Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v6]

On Tue, 21 Sep 2021 13:10:57 GMT, Roger Riggs wrote: >> test/jdk/java/lang/ProcessBuilder/Basic.java line 2217: >> >>> 2215: // A unique (59s) time is needed to avoid killing >>> other sleep processes. >>> 2216: final String[] cmd = { "/bin/bash", "-c", >>> "(/b

Re: RFR: 8273546: DecimalFormat documentation contains literal HTML character references

On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote: > Simple doc fix. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5620

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

I’ve uploaded a project that reproduces the problem to JDK-8274087 Regards, Scott > On Sep 21, 2021, at 3:49 PM, Scott Palmer wrote: > > I have discovered that I have to have my Java Agent configured in the .cfg > file for it to happen: >

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote: >> Fixing an AIOOBE on normalizing the month value. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Removed the unnecessary space Marked as reviewed by iris (Reviewer). --

Re: RFR: 8273546: DecimalFormat documentation contains literal HTML character references

On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote: > Simple doc fix. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5620

Re: RFR: 8273546: DecimalFormat documentation contains literal HTML character references

On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote: > Simple doc fix. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5620

Re: RFR: 8273546: DecimalFormat documentation contains literal HTML character references

On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote: > Simple doc fix. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5620

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote: >> Fixing an AIOOBE on normalizing the month value. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Removed the unnecessary space Marked as reviewed by joehw (Reviewer). -

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

> Fixing an AIOOBE on normalizing the month value. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Removed the unnecessary space - Changes: - all: https://git.openjdk.java.net/jdk/pull/5611/files - new: https://git.ope

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

On Tue, 21 Sep 2021 22:03:30 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the unnecessary space > > src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281: > >> 279:

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote: > Fixing an AIOOBE on normalizing the month value. Marked as reviewed by joehw (Reviewer). src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281: > 279: month = 13 - (xm % 12); > 280: if (month == 13

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 17:52:31 GMT, Brian Burkhalter wrote: >> We can either revert this part of the change or rephrase it. Mind you, >> rephrasing might prove tricky because of non-local changes it might >> introduce. There's one more occurrence of "wrapped exception" in this file: >> https://g

RFR: 8273546: DecimalFormat documentation contains literal HTML character references

Simple doc fix. - Commit messages: - 8273546: DecimalFormat documentation contains literal HTML character references Changes: https://git.openjdk.java.net/jdk/pull/5620/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5620&range=00 Issue: https://bugs.openjdk.java.net

Re: Unused HashMap's in ThaiBuddhistChronology

Indeed, they seem unused... Stephen, do you recall their original use? Thanks, Roger On 9/21/21 5:09 PM, Andrey Turbanov wrote: Hello. Today I discovered 3 static HashMap's in ThaiBuddhistChronology class: ERA_NARROW_NAMES, ERA_SHORT_NAMES, ERA_FULL_NAMES static initializer put some values i

Unused HashMap's in ThaiBuddhistChronology

Hello. Today I discovered 3 static HashMap's in ThaiBuddhistChronology class: ERA_NARROW_NAMES, ERA_SHORT_NAMES, ERA_FULL_NAMES static initializer put some values into them. But their content seems unused after that. Do I miss something and they are used somewhere? Andrey Turbanov

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

On Tue, 21 Sep 2021 19:33:05 GMT, Roger Riggs wrote: > The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using the hidden link: >`/System/Librar

RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

The Mac OS specific code to determine the os.version property in java_props_macosx.c is updated to replace the code extracting the version from the SystemVersion.plist by reading the version using the hidden link: `/System/Library/CoreServices/.SystemVersionPlatform.plist` Its contents are no

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

I have discovered that I have to have my Java Agent configured in the .cfg file for it to happen: [JavaOptions] java-option=-javaagent:$APPDIR\libs\MyAgent.jar The agent is needed in my real app only to get an instance of the Instrumentation interface. In my test code, where I have reproduced

Integrated: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported

On Sun, 19 Sep 2021 15:34:44 GMT, Lance Andersen wrote: > Hi all, > > Please review this patch which addresses the issue where Zip FS will throw a > UOE instead of returning null when Files.getFileAttributeView() is invoked > and the view not supported. > > Mach5 tiers1 - tier3 are clean.

Re: RFR: 8274003: ProcessHandleImpl.Info toString has an if check which is always true

On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote: > Correct the check if any field has been appended to the StringBuilder in > ProcessHandleImpl.Info.toString(). Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5618

Re: RFR: 8274003: ProcessHandleImpl.Info toString has an if check which is always true

On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote: > Correct the check if any field has been appended to the StringBuilder in > ProcessHandleImpl.Info.toString(). Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5618

Re: RFR: 8274003: ProcessHandleImpl.Info toString has an if check which is always true

On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote: > Correct the check if any field has been appended to the StringBuilder in > ProcessHandleImpl.Info.toString(). Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5618

RFR: 8274003: ProcessHandleImpl.Info toString has an if check which is always true

Correct the check if any field has been appended to the StringBuilder in ProcessHandleImpl.Info.toString(). - Commit messages: - 8274003: ProcessHandleImpl.Info toString has an if check which is always true Changes: https://git.openjdk.java.net/jdk/pull/5618/files Webrev: https://

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 17:39:41 GMT, Pavel Rappo wrote: >> Would "wrappER" be better? > > We can either revert this part of the change or rephrase it. Mind you, > rephrasing might prove tricky because of non-local changes it might > introduce. There's one more occurrence of "wrapped exception" in

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 16:56:03 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/lang/Throwable.java line 68: >> >>> 66: * Further, doing so would tie the API of the upper layer to the >>> details of >>> 67: * its implementation, assuming the lower layer's exception was a >>> chec

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 17:14:31 GMT, Pavel Rappo wrote: >> Subjectively, "wrapping exception" would seem to be an exception in the >> process of wrapping something. > > Would "wrappER" be better? We can either revert this part of the change or rephrase it. Mind you, rephrasing might prove tricky

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 17:10:02 GMT, Brian Burkhalter wrote: >> If we have two exceptions A and B, such that B is the cause of A, then A is >> the wrapping exception (the one that wraps or the wrapper) and B is the >> wrapped exception (the one that is being wrapped or the wrappee). >> >> I notic

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 17:07:45 GMT, Pavel Rappo wrote: >> It does seem a bit strange to say "Throwing a wrapping" > > If we have two exceptions A and B, such that B is the cause of A, then A is > the wrapping exception (the one that wraps or the wrapper) and B is the > wrapped exception (the

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Tweak wording for Throwable constructor parameters Overall looks like a g

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 16:48:53 GMT, Brian Burkhalter wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweak wording for Throwable constructor parameters > > src/java.base/share/classes/java/lang/Throwable.java line 68:

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote: > Fixing an AIOOBE on normalizing the month value. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Tweak wording for Throwable constructor parameters src/java.base/share/cl

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 16:18:54 GMT, Daniel Fuchs wrote: >> The problem I was referring to was not about printing to the console. I >> hadn't thought about that, I agree the default locale should be used there. >> I was referring to `Last-modified` HTTP headers with a non-English date >> value, e

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Tweak wording for Throwable constructor parameters Marked as reviewed by

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 16:03:28 GMT, Hannes Wallnöfer wrote: >> Hmm... When printing messages on the console don't we want a localized date? >> Or are you referring to other usages of the date formatter? Worth double >> checking in any case. > > The problem I was referring to was not about printi

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v8]

On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

I thought I could create a reproduction scenario by using an app with "-splash:" arg then moving the jre as you did, but I have not yet been able make it fail. /Andy On 9/21/2021 11:43 AM, Scott Palmer wrote: On Sep 21, 2021, at 11:40 AM, Alan Bateman wrote: On 21/09/2021 15:54, Andy Herri

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 15:27:12 GMT, Daniel Fuchs wrote: >> I just realized I commented on a test file, while the actual culprit is in >> `FileServerHandler.java`. But I guess it applies to all usages of this class >> and method. > > Hmm... When printing messages on the console don't we want a loc

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Tweak wording for Throwable constructor parameters Marked as reviewed by

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 15:06:09 GMT, Hannes Wallnöfer wrote: >> test/jdk/com/sun/net/httpserver/simpleserver/SecurityManagerTest.java line >> 198: >> >>> 196: >>> 197: static final DateTimeFormatter HTTP_DATE_FORMATTER = >>> 198: DateTimeFormatter.ofPattern("EEE, dd MMM HH:mm

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

> On Sep 21, 2021, at 11:40 AM, Alan Bateman wrote: > > On 21/09/2021 15:54, Andy Herrick wrote: >> >> I found the problem in >> open/src/jdk.jpackage/windows/native/applauncher/WinLauncher.cpp >> >> we call SetDllDirectory() with the path to the bin dir in the default >> runtime directory

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v8]

On Tue, 21 Sep 2021 15:06:49 GMT, Claes Redestad wrote: > > If you look at "Poly" results, spinning MHInvoker/VHInvoker classes for > > each instance of Method/Field does not help at all. > > The added indirection in the "Poly" test might cause the code to fall off the > inlining cliff, so tha

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

On 21/09/2021 15:54, Andy Herrick wrote: I found the problem in open/src/jdk.jpackage/windows/native/applauncher/WinLauncher.cpp we call SetDllDirectory() with the path to the bin dir in the default runtime directory, not the actual runtime directory. since on Windows we never use other th

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

I filed:     JDK-8274087: Windows DLL path not set correctly. for this, and will work on a fix for JDK18 and backport to JDK17.0.2. /Andy On 9/21/2021 10:54 AM, Andy Herrick wrote: I found the problem in open/src/jdk.jpackage/windows/native/applauncher/WinLauncher.cpp we call SetDllDirectory

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:59:18 GMT, Hannes Wallnöfer wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch 'origin/simple

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v8]

On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

I found the problem in open/src/jdk.jpackage/windows/native/applauncher/WinLauncher.cpp we call SetDllDirectory() with the path to the bin dir in the default runtime directory, not the actual runtime directory. since on Windows we never use other than the default runtime location - we had no

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v4]

On Mon, 20 Sep 2021 16:16:10 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java >> line 340: >> >>> 338: } >>> 339: } >>> 340: return false; >> >> This will start checking from the root of

Re: What causes java.lang.InternalError: platform encoding not initialized ?

This is on Windows 10 Pro. using JDK 17 for jpackage and I'm pretty sure for jimage (though the image was made shortly after 17 GA and is being reused).. There are no libraries directly in $APPDIR, though there are plenty in other sibling folders to the 'app' folder (in addition to those in app\

Re: RFR: 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module

On Thu, 16 Sep 2021 19:03:26 GMT, Andrey Turbanov wrote: > Pass "cause" exception as constructor parameter is shorter and easier to read. Looks fine. Thanks. - Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5551

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is th

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: RFR: 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module

On Thu, 16 Sep 2021 19:03:26 GMT, Andrey Turbanov wrote: > Pass "cause" exception as constructor parameter is shorter and easier to read. This will need to be thoroughly tested to make sure there were no implicit dependencies on now-removed happens-before edges (`initCause` is synchronized).

Re: What causes java.lang.InternalError: platform encoding not initialized ?

On 21/09/2021 14:21, Andy Herrick wrote: I don't see anything wrong with this offhand. the runtime should be able to be anywhere if the cfg files "app.runtime" line points to it. Is this on windows ? Is the the released JDK17 used both for the jlinked runtime and the jpackage tool ? Are ther

RFR: 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module

Pass "cause" exception as constructor parameter is shorter and easier to read. - Commit messages: - [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.base module Changes: https://git.openjdk.java.net/jdk/pull/5551/files Webrev: https://webrevs.openjdk.java.net/?re

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote: > Fixing an AIOOBE on normalizing the month value. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: What causes java.lang.InternalError: platform encoding not initialized ?

I don't see anything wrong with this offhand. the runtime should be able to be anywhere if the cfg files "app.runtime" line points to it. Is this on windows ? Is the the released JDK17 used both for the jlinked runtime and the jpackage tool ? Are there any libraries in $APPDIR (which is added

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

> 8274075: Fix miscellaneous typos in java.base Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Tweak wording for Throwable constructor parameters - Changes: - all: https://git.openjdk.java.net/jdk/pull/5610/files - n

Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v6]

On Tue, 21 Sep 2021 04:54:24 GMT, David Holmes wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> The switch from a Java child to /bin/sleep caused another test >> to fail on Linux. The cleanup for a test used /usr/

RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

Fixing an AIOOBE on normalizing the month value. - Commit messages: - 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() Changes: https://git.openjdk.java.net/jdk/pull/5611/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5611&ran

Re: RFR: 8274075: Fix miscellaneous typos in java.base

On Tue, 21 Sep 2021 12:26:25 GMT, Pavel Rappo wrote: > 8274075: Fix miscellaneous typos in java.base Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5610

RFR: 8274075: Fix miscellaneous typos in java.base

8274075: Fix miscellaneous typos in java.base - Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/5610/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5610&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274075 Stats: 21 line

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v8]

On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

RFR: 8274071: Clean up java.lang.ref comments and documentation

This PR fixes an inline comment typo and reduces "overlinking" in a doc comment in `java.lang.ref.Reference`. Overlinking happens because the `reachabilityFence` method: * Links `package-summary.html#reachability` twice. * Refers to JLS 12.6 twice: once from a block tag and once from an inline

Integrated: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote: > This is a GUI test, and it should be `@headful`. > > Additional testing: > - [x] Test still runs in default, and does not run with `!headful` This pull request has now been integrated. Changeset: 7acec3f1 Author:Aleksey Shipilev

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote: > This is a GUI test, and it should be `@headful`. > > Additional testing: > - [x] Test still runs in default, and does not run with `!headful` Thank you! - PR: https://git.openjdk.java.net/jdk/pull/5544

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v8]

On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote: >> This reimplements core reflection with method handles. >> >> For `Constructor::newInstance` and `Method::invoke`, the new implementation >> uses `MethodHandle`. For `Field` accessor, the new implementation uses >> `VarHandle`.For the

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote: > This is a GUI test, and it should be `@headful`. > > Additional testing: > - [x] Test still runs in default, and does not run with `!headful` Marked as reviewed by jlahoda (Reviewer). - PR: https://git.openjdk.java.net/j

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote: > This is a GUI test, and it should be `@headful`. > > Additional testing: > - [x] Test still runs in default, and does not run with `!headful` Any takers? ;) - PR: https://git.openjdk.java.net/jdk/pull/5544

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

Re: RFR: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported [v3]

On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review this patch which addresses the issue where Zip FS will throw a >> UOE instead of returning null when Files.getFileAttributeView() is invoked >> and the view not supported. >> >> Mach5 tiers1 - tier3 are