Re: How can I trigger a @Serial warning?

2021-09-23 Thread Tagir Valeev
Hello, Cay! By the way, in IntelliJ IDEA we have the inspection that warns you about wrong use of Serial: [image: image.png] It also suggests adding this annotation where it's appropriate: [image: image.png] Both inspections are turned on by default. With best regards, Tagir Valeev. On Thu, S

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-23 Thread wxiang
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > I have changed > > ENABLE_JAR_INDEX = p != null ? p.equals("true") : false; > > to > > ENABLE_JAR_INDEX

Re: RFR: 8266936: Add a finalization JFR event [v11]

2021-09-23 Thread Coleen Phillimore
On Mon, 13 Sep 2021 17:12:49 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info

Re: RFR: JDK-8274087: Windows DLL path not set correctly.

2021-09-23 Thread Alexey Semenyuk
On Thu, 23 Sep 2021 20:03:29 GMT, Andy Herrick wrote: > JDK-8274087: Windows DLL path not set correctly. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5663

Re: RFR: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset

2021-09-23 Thread Brian Burkhalter
On Thu, 23 Sep 2021 19:47:51 GMT, Andrey Turbanov wrote: > Usages of methods Integer.valueOf, Byte.valueOf, Short.valueOf, > Float.valueOf, Double.valueOf, Long.valueOf often can be simplified by using > their pair methods parseInt/parseLong/parseShort/parseByte/parseFloat. Marked as reviewed

Re: RFR: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset

2021-09-23 Thread Lance Andersen
On Thu, 23 Sep 2021 19:47:51 GMT, Andrey Turbanov wrote: > Usages of methods Integer.valueOf, Byte.valueOf, Short.valueOf, > Float.valueOf, Double.valueOf, Long.valueOf often can be simplified by using > their pair methods parseInt/parseLong/parseShort/parseByte/parseFloat. Marked as reviewed

Re: RFR: JDK-8274087: Windows DLL path not set correctly.

2021-09-23 Thread Alexander Matveev
On Thu, 23 Sep 2021 20:03:29 GMT, Andy Herrick wrote: > JDK-8274087: Windows DLL path not set correctly. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5663

RFR: JDK-8274087: Windows DLL path not set correctly.

2021-09-23 Thread Andy Herrick
JDK-8274087: Windows DLL path not set correctly. - Commit messages: - JDK-8274087: Windows DLL path not set correctly. Changes: https://git.openjdk.java.net/jdk/pull/5663/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5663&range=00 Issue: https://bugs.openjdk.jav

Integrated: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

2021-09-23 Thread Andrey Turbanov
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov wrote: > There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read a

Re: RFR: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

2021-09-23 Thread Andrey Turbanov
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov wrote: > There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read a

RFR: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset

2021-09-23 Thread Andrey Turbanov
Usages of methods Integer.valueOf, Byte.valueOf, Short.valueOf, Float.valueOf, Double.valueOf, Long.valueOf often can be simplified by using their pair methods parseInt/parseLong/parseShort/parseByte/parseFloat. - Commit messages: - [PATCH] Remove unnecessary boxing via primitive w

Re: RFR: 8177814: jdk/editpad is not in jdk TEST.groups

2021-09-23 Thread Sergey Bylokhov
On Thu, 23 Sep 2021 08:54:48 GMT, Aleksey Shipilev wrote: > @prrace notices this here: > https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think > it is the already open issue that this patch is fixing. While the original > patch added the test in `jdk_other`, Phil suggest

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since t

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Mandy Chung
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since t

RFR: 8273682: Upgrade Jline to 3.20.0

2021-09-23 Thread Jan Lahoda
I'd like to upgrade the internal JLine to 3.20.0, to support the rxvt terminal (see JDK-8270943), and to generally use a newer version of the library. This patch is basically a application of relevant parts of the diff between JLine 3.14.0 and 3.20.0, with merge fixes as needed. Thanks! --

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Lance Andersen
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since t

Integrated: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

2021-09-23 Thread Roger Riggs
On Wed, 22 Sep 2021 15:00:59 GMT, Roger Riggs wrote: > The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using t\ > he hidden link: This pull reque

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 [v2]

2021-09-23 Thread Roger Riggs
On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs wrote: >> The Mac OS specific code to determine the os.version property in >> java_props_macosx.c is updated >> to replace the code extracting the version from the SystemVersion.plist by >> reading the version using t\ >> he hidden link: > > Roger R

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Christian Stein
> This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Add JBS issue `8262944` to the `@bug` list an

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v2]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 13:40:30 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since t

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-23 Thread Andy Herrick
I also had a JDK16 bin dir on my path ... I can get the error you show below (Error occurred during initialization of VM) if I clear my PATH, which is different from the error I get when running without moved runtime, so I can reproduce problem and test the fix. I am using a script like: .

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v2]

2021-09-23 Thread Christian Stein
> This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Assert that only the name of the JAR file (wi

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Christian Stein
On Thu, 23 Sep 2021 11:26:26 GMT, Alan Bateman wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > src/java.base/share/classes/jdk/internal/module/ModulePath.java line 554: > >> 552:

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 [v2]

2021-09-23 Thread Christoph Langer
On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs wrote: >> The Mac OS specific code to determine the os.version property in >> java_props_macosx.c is updated >> to replace the code extracting the version from the SystemVersion.plist by >> reading the version using t\ >> he hidden link: > > Roger R

Integrated: 8273546: DecimalFormat documentation contains literal HTML character references

2021-09-23 Thread Naoto Sato
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote: > Simple doc fix. This pull request has now been integrated. Changeset: c4345285 Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/c43452859d7211f0d6537d71bd0df89412d4ff6f Stats: 14 lines in 3 files changed: 0 ins;

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-23 Thread Alan Bateman
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > I have changed > > ENABLE_JAR_INDEX = p != null ? p.equals("true") : false; > > to > > ENABLE_JAR_INDEX

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Alan Bateman
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. src/java.base/share/classes/jdk/internal/module/ModulePath.java line 554: > 552:

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Jorn Vernee
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Marked as reviewed by jvernee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Daniel Fuchs
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. The proposed change looks reasonable to me. - Marked as reviewed by dfuchs (Reviewer).

Re: RFR: 8231640: (prop) Canonical property storage [v22]

2021-09-23 Thread Magnus Ihse Bursie
On Wed, 22 Sep 2021 10:27:45 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in `Pro

RFR: 8177814: jdk/editpad is not in jdk TEST.groups

2021-09-23 Thread Aleksey Shipilev
@prrace notices this here: https://github.com/openjdk/jdk/pull/5544#issuecomment-925396869. And I think it is the already open issue that this patch is fixing. While the original patch added the test in `jdk_other`, Phil suggests it to be added to `jdk_desktop`. Additional testing: - [x] `jdk_

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

2021-09-23 Thread Aleksey Shipilev
On Wed, 22 Sep 2021 23:19:50 GMT, Phil Race wrote: > You'd need to add it to the desktop test group. Right. See #5648. - PR: https://git.openjdk.java.net/jdk/pull/5544

Integrated: 8274075: Fix miscellaneous typos in java.base

2021-09-23 Thread Pavel Rappo
On Tue, 21 Sep 2021 12:26:25 GMT, Pavel Rappo wrote: > 8274075: Fix miscellaneous typos in java.base This pull request has now been integrated. Changeset: 87998565 Author:Pavel Rappo URL: https://git.openjdk.java.net/jdk/commit/8799856528f5804b616b734caed3fc4ba9811bfa Stats: 26