On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Wed, 20 Oct 2021 09:28:30 GMT, Leslie Zhai wrote:
> requires jtreg version 6.1 b1 or higher
This confused me a bit too; I was using jtreg-6+1.tar.gz from [Adoption Group
build](https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jtreg/),
and ap
On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Fri, 22 Oct 2021 19:01:27 GMT, Phil Race wrote:
> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests
>
> The jtreg javax.sound tests are written in such a way that if a needed audio
> device
> or other platform resource is not available, they just exit with a "pass
On Wed, 30 Jun 2021 20:08:27 GMT, Sergei Ustimenko
wrote:
> Change #3294 helps to avoid `AnnotaionFormatException` in
> `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`.
> While it fixes the case with e.g. `Runnable` that generates the synthetic
> method without
On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
This fix adds "headful sound" keywords to a number of javax/sound jtreg tests
The jtreg javax.sound tests are written in such a way that if a needed audio
device
or other platform resource is not available, they just exit with a "pass" for
the test.
It is as if headful tests just swallowed Headl
On Fri, 22 Oct 2021 04:54:35 GMT, Glavo wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the null sentence into @param tag.
>
> Oh, I found that I checked the outdated source code. Now this problem does
> not e
On Fri, 22 Oct 2021 02:07:44 GMT, Sergey Bylokhov wrote:
>> I first thought of swallowing all exceptions in 2-arg forName(), but decided
>> not to do that. Because `IllegalArgumentException` and
>> `IllegalCharsetNameException` are for the validity of the passed
>> `charsetName`, like detectin
> During the review of JEP 400, a proposal to provide an overloaded method to
> `Charset.forName()` was suggested
> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
> PR is to implement the proposal. A CSR is also drafted as
> https://bugs.openjdk.java.net/browse/JDK-
On Wed, 1 Sep 2021 06:45:26 GMT, Wu Yan wrote:
> Hi,
> Please help me review the change to enhance getting time zone ID from
> /etc/localtime on linux.
>
> We use `realpath` instead of `readlink` to obtain the link name of
> /etc/localtime, because `readlink` can only read the value of a symb
On Tue, 19 Oct 2021 04:08:12 GMT, Wu Yan wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value of
On Wed, 20 Oct 2021 15:41:35 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change InetAddressResolver method names
>
> Marked as reviewed by dfuchs (Reviewer).
@dfuch @AlanBateman
fa655be2bb
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
> -
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
On Tue, 12 Oct 2021 16:47:04 GMT, Andy Herrick wrote:
> JDK-8263155: Allow additional contents for DMG
This pull request has now been integrated.
Changeset: b2128a96
Author:Andy Herrick
URL:
https://git.openjdk.java.net/jdk/commit/b2128a96670daeca93aca84ee7613b2b337ddfa4
Stats:
> Can I please get a review for this change which fixes the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8275509?
>
> The `ModuleDescriptor.hashCode()` method uses the hash code of its various
> components to compute the final hash code. While doing so it ends up calling
> hashC
On Fri, 22 Oct 2021 10:17:13 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - drop final
>> - no need to check for null values
>
> src/java.base/share/classes/java/lang/module/ModuleDescriptor.j
> Can I please get a review for this change which fixes the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8275509?
>
> The `ModuleDescriptor.hashCode()` method uses the hash code of its various
> components to compute the final hash code. While doing so it ends up calling
> hashC
On Fri, 22 Oct 2021 09:33:35 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8275509?
>
> The `ModuleDescriptor.hashCode()` method uses the hash code of its various
> components to compute the fin
Can I please get a review for this change which fixes the issue reported in
https://bugs.openjdk.java.net/browse/JDK-8275509?
The `ModuleDescriptor.hashCode()` method uses the hash code of its various
components to compute the final hash code. While doing so it ends up calling
hashCode() on (co
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
Hello Ioi,
On 22/10/21 12:29 pm, Ioi Lam wrote:
On 10/21/21 9:09 PM, Jaikiran Pai wrote:
Hello Ioi,
This is my initial analysis of the problem.
>>> Can anyone think of similar problems that may happen elsewhere?
The static constructors of enum classes are executed at both CDS
dump
On 10/21/21 9:09 PM, Jaikiran Pai wrote:
Hello Ioi,
This is my initial analysis of the problem.
>>> Can anyone think of similar problems that may happen elsewhere?
The static constructors of enum classes are executed at both CDS dump
time and run time. E.g.,
public enum Modifi
25 matches
Mail list logo
