On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Wed, 24 Nov 2021 17:06:41 GMT, Mandy Chung wrote:
>> jdeps intends to report an error if there are multiple versions of the same
>> class being parsed. module-info.class should be excluded from such
>> detection.
>>
>> This patch also fixes a data race in `VersionHelper::set` and also
On Wed, 24 Nov 2021 15:04:35 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
On Mon, 13 Sep 2021 05:35:23 GMT, Jaikiran Pai wrote:
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Looks good.
src/jdk.compiler/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java
line 63:
> 61: * Helper class to generate stable
On Thu, 18 Nov 2021 19:18:24 GMT, Jonathan Gibbons wrote:
> Remarkable to have not been noticed for so long!
Remarkable, but not too surprising: the PR consists of source files and tests
that are not part of the API Documentation.
-
PR: https://git.openjdk.java.net/jdk/pull/6443
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
>
On Wed, 24 Nov 2021 21:27:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined wording
>
> src/java.base/share/classes/java/time/format/DateTimeFormatter.java line 509:
>
>> 507: * parsed from
> This fix intends to honor the type (std/dst/generic) of parsed zone name for
> selecting the offset at the overlap. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with two additional
commits since the last revision:
- Replaced integer
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6443
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Remarkable to have not been noticed for so long!
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6443
JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
-
Commit messages:
- Fixed @code and @link in some javadoc for JDK-8276674
Changes: https://git.openjdk.java.net/jdk/pull/6443/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6443=00
Issue:
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Wed, 24 Nov 2021 20:08:50 GMT, Lance Andersen wrote:
> HI all,
>
> Attached is a patch for 4 failing MR tests due the issue that was resolved
> via JDK-8272728
>
> Best
> Lance
This pull request has now been integrated.
Changeset: b5841ba3
Author:Lance Andersen
URL:
On Wed, 24 Nov 2021 20:08:50 GMT, Lance Andersen wrote:
> HI all,
>
> Attached is a patch for 4 failing MR tests due the issue that was resolved
> via JDK-8272728
>
> Best
> Lance
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6546
On Wed, 24 Nov 2021 20:08:50 GMT, Lance Andersen wrote:
> HI all,
>
> Attached is a patch for 4 failing MR tests due the issue that was resolved
> via JDK-8272728
>
> Best
> Lance
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6546
HI all,
Attached is a patch for 4 failing MR tests due the issue that was resolved via
JDK-8272728
Best
Lance
-
Commit messages:
- Fix for JDK-8272728
Changes: https://git.openjdk.java.net/jdk/pull/6546/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6546=00
Issue:
On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
Add two new cross-lane vector operations, `compress` and `expand`.
An example of such usage might be code that selects elements from array `a` and
stores those selected elements in array `z`:
int[] a = ...;
int[] z = ...;
int ai = 0, zi = 0;
while (ai < a.length) {
IntVector av =
On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Wed, 24 Nov 2021 17:06:41 GMT, Mandy Chung wrote:
>> jdeps intends to report an error if there are multiple versions of the same
>> class being parsed. module-info.class should be excluded from such
>> detection.
>>
>> This patch also fixes a data race in `VersionHelper::set` and also
> jdeps intends to report an error if there are multiple versions of the same
> class being parsed. module-info.class should be excluded from such
> detection.
>
> This patch also fixes a data race in `VersionHelper::set` and also unwraps
> the `ExecutionException` when FutureTask of parsing
On 11/24/2021 8:35 AM, Andy Herrick wrote:
Wait - the original change, 'addArgument("-J-Djlink.debug=true");'
adds "-D-J..." as a jpackage arg. This is not a supported command
line option, I'm not sure why it is not throwing an error all the
time, but you need to use
On Wed, 24 Nov 2021 10:05:11 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor fix to avoid casting
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/DependencyFinder.java line
> 277:
>
>>
On Wed, 24 Nov 2021 15:20:42 GMT, kabutz wrote:
>> BigInteger currently uses three different algorithms for multiply. The
>> simple quadratic algorithm, then the slightly better Karatsuba if we exceed
>> a bit count and then Toom Cook 3 once we go into the several thousands of
>> bits. Since
On Wed, 24 Nov 2021 15:04:35 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
On Tue, 23 Nov 2021 23:07:08 GMT, Stuart Marks wrote:
>> Most configurations of `jdk.serialFilter` and` jdk.serialFilterFactory` will
>> be valid.
>> If they are not valid, the cause must be clear and useful suggestion made to
>> correct the command line
>> or security properties.
>>
>> It
On Wed, 24 Nov 2021 15:04:35 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
> BigInteger currently uses three different algorithms for multiply. The simple
> quadratic algorithm, then the slightly better Karatsuba if we exceed a bit
> count and then Toom Cook 3 once we go into the several thousands of bits.
> Since Toom Cook 3 is a recursive algorithm, it is trivial to
On Mon, 15 Nov 2021 17:28:30 GMT, Roger Riggs wrote:
> The ObjectInputStream.GetField.get(String name, Object val) method is
> returning null instead of throwing an exception when the class of the object
> is not found. The caller is not able to correctly handle the case where the
> class is
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp of a `module-info.class`
> descriptor.
>
> This commit
> BigInteger currently uses three different algorithms for multiply. The simple
> quadratic algorithm, then the slightly better Karatsuba if we exceed a bit
> count and then Toom Cook 3 once we go into the several thousands of bits.
> Since Toom Cook 3 is a recursive algorithm, it is trivial to
On Wed, 24 Nov 2021 14:06:29 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
Hello Andy,
On 24/11/21 7:23 pm, Andy Herrick wrote:
never mind my previous email, addArgument("--java-option ...") ,
would be for argument to the java launching the app.
you are right to use -J-Djlink.debug=true . It must be interpreted in
the standard launcher used for jpackage, because
On Wed, 24 Nov 2021 14:06:29 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
On Mon, 22 Nov 2021 14:37:47 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp of a `module-info.class`
> descriptor.
>
> This commit
never mind my previous email, addArgument("--java-option ...") , would
be for argument to the java launching the app.
you are right to use -J-Djlink.debug=true . It must be interpreted in
the standard launcher used for jpackage, because the -J-D arg never gets
to the jpackage java code and
Wait - the original change, 'addArgument("-J-Djlink.debug=true");' adds
"-D-J..." as a jpackage arg. This is not a supported command line
option, I'm not sure why it is not throwing an error all the time, but
you need to use addArgument("--java-option -Djlink.debug=true" ); instead.
I'll
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into account the part
> On Nov 24, 2021, at 5:51 AM, Michael Hall wrote:
>
>
>
>> On Nov 24, 2021, at 2:55 AM, Alan Bateman wrote:
>>
>> On Wed, 24 Nov 2021 01:12:01 GMT, Mandy Chung wrote:
>>
>>> This changes jdeps -cp to ignore files/directories with no permission to
>>> access. This is consistent with
On Tue, 12 Oct 2021 11:16:51 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] -
> On Nov 24, 2021, at 2:55 AM, Alan Bateman wrote:
>
> On Wed, 24 Nov 2021 01:12:01 GMT, Mandy Chung wrote:
>
>> This changes jdeps -cp to ignore files/directories with no permission to
>> access. This is consistent with the runtime behavior.
>
>
On Mon, 22 Nov 2021 14:37:47 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified
On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch milliseconds) option to jar and
>> jmod to allow specification of time to use for created/updated jar/jmod
>> entries. This then allows the ability to make the content deterministic.
>>
>>
On Tue, 23 Nov 2021 19:23:40 GMT, Joe Darcy wrote:
>> The time to get JDK 19 underway draws nigh, please review this usual set of
>> start-of-release updates, including CSRs for the javac and javax.lang.model
>> updates:
>>
>> JDK-8277512: Add SourceVersion.RELEASE_19
>>
On Tue, 23 Nov 2021 20:54:55 GMT, Mandy Chung wrote:
> jdeps intends to report an error if there are multiple versions of the same
> class being parsed. module-info.class should be excluded from such
> detection.
>
> This patch also fixes a data race in `VersionHelper::set` and also unwraps
Can I please get a review of this change which adds `jlink.debug=true` system
property while launching `jpackage` tests?
The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
take into account the part where the `jpackage` tool gets launched as a
`ToolProvider` from some
On Wed, 24 Nov 2021 01:12:01 GMT, Mandy Chung wrote:
> This changes jdeps -cp to ignore files/directories with no permission to
> access. This is consistent with the runtime behavior.
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ClassFileReader.java line 235:
> 233:
50 matches
Mail list logo
