On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from GetModuleHandle("zip.dll"),
On Tue, 25 Jan 2022 05:25:12 GMT, Joe Darcy wrote:
>> Making the exception message friendlier to users.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Looks good.
I see Mandy has suggested the sa
On Tue, 25 Jan 2022 05:25:12 GMT, Joe Darcy wrote:
>> Making the exception message friendlier to users.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by iris (Reviewer).
-
On Tue, 25 Jan 2022 03:51:43 GMT, David Holmes wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/jdk/internal/reflect/Reflection.java line 387:
>
>> 385:
> Making the exception message friendlier to users.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7208/files
- new: https://git.openj
On Tue, 25 Jan 2022 01:59:56 GMT, David Holmes wrote:
> * The jimage code was using the OS code (dlopen/loadlibrary etc) to try and
> load the zip library when needed.
Yes. The zip library has to be in PATH.
> * The VM, which is always loaded first, always used to load the zip library
> uncondi
On Tue, 25 Jan 2022 02:42:45 GMT, Joe Darcy wrote:
> Making the exception message friendlier to users.
src/java.base/share/classes/jdk/internal/reflect/Reflection.java line 387:
> 385: msg += "a member of " + memberClass + memberSuffix +
> 386: (packageAccess ?
> 387
Making the exception message friendlier to users.
-
Commit messages:
- JDK-8279242: Reflection newInstance() error message when constructor has no
access modifiers could use improvement
Changes: https://git.openjdk.java.net/jdk/pull/7208/files
Webrev: https://webrevs.openjdk.java.
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from GetModuleHandle("zip.dll"),
Hi Naoto,
Nice use of regular expression! Saves a lot of description if I would
just follow the regex pattern.
Question:
The 2nd and 3rd statements defined the requestedTemplate, does
it imply the characters listed in the snippet are the only ones that are
valid, in other words, can o
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from GetModuleHandle("zip.dll"),
On Mon, 24 Jan 2022 21:31:37 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 24 Jan 2022 21:31:37 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 24 Jan 2022 22:11:51 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
Updated the CSR (https://bugs.openjdk.java.net/browse/JDK-8243445), by
adding a regular expression for the requested template. This way, it is
less depending on the LDML specification.
Naoto
On 1/21/22 2:39 PM, Naoto Sato wrote:
Thanks, Joe.
Good point. I will elaborate the pattern template
On Mon, 24 Jan 2022 23:02:52 GMT, Johannes Kuhn wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - revert MethodHandlesProxiesTest change
>> - Add new regression test
>> - Should not perform access check on the i
> The MethodHandle of a default method should be made as a fixed arity method
> handle because it is invoked via Proxy's invocation handle with a non-vararg
> array of arguments. On the other hand, the `InvocationHandle::invokeDefault`
> method was added in Java 16 to invoke a default method o
On Mon, 24 Jan 2022 23:03:49 GMT, Mandy Chung wrote:
>> The MethodHandle of a default method should be made as a fixed arity method
>> handle because it is invoked via Proxy's invocation handle with a non-vararg
>> array of arguments. On the other hand, the
>> `InvocationHandle::invokeDefault
On Sat, 22 Jan 2022 21:48:38 GMT, Johannes Kuhn wrote:
>> The MethodHandle of a default method should be made as a fixed arity method
>> handle because it is invoked via Proxy's invocation handle with a non-vararg
>> array of arguments. On the other hand, the
>> `InvocationHandle::invokeDefau
> The MethodHandle of a default method should be made as a fixed arity method
> handle because it is invoked via Proxy's invocation handle with a non-vararg
> array of arguments. On the other hand, the `InvocationHandle::invokeDefault`
> method was added in Java 16 to invoke a default method o
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
This pull request has now been integrated.
Changeset: e3076552
Author:Ian Graves
URL:
https://git.openjdk.java.net/jdk/commit
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Mon, 24 Jan 2022 21:51:13 GMT, Rémi Forax wrote:
> toIdentityString is a better name than toDefaultString.
>
> It's fine for me but given that "identity" has a slightly different meaning
> in the context of Valhalla that in System.identityHashCode(), it may be good
> to ask Brian about that
On Mon, 24 Jan 2022 21:27:06 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
>> 295:
>>
>>> 293: assert(isObjectMethod(m)) : m;
>>> 294: return switch (m.getName()) {
>>> 295: case "toString" -> java.util.Objects.to
On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote:
> Class DeferredCloseInputStream is unused since removing of Solaris support
> https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81
Marked as reviewed by
On Mon, 24 Jan 2022 19:51:08 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 52ddbe2d
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/52ddbe2dcdb2fa52d85c987443ffa14522ace729
Stats: 62 li
On Mon, 24 Jan 2022 21:31:37 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Thanks @turbanoff , left off the JBS ID in the comment.
-
PR: https://git.openjdk.java.net/jdk/pull/7201
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Fixing docs and dates
-
Changes:
- all: https://git.openjdk.java.n
On Fri, 21 Jan 2022 11:04:22 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
On Mon, 24 Jan 2022 19:56:55 GMT, Stuart Marks wrote:
> I'm wondering if we want to have `toDefaultString` at all, and whether we
> should have just `toIdentityString`. The primary use case, it seems to me, is
> the ability to get a string representation for some object, without involving
> an
On Mon, 24 Jan 2022 19:19:21 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains six additional commits
>> sin
> While it is strongly recommend to not use the default toString for a class,
> at times it is the least-bad alternative. When that alternative needs to be
> used, it would be helpful to have the implementation already available, such
> as in Objects.toDefaultString(). This method is analagous t
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
test/jdk/java/util/regex/RegExTest.java line 4551:
> 4549: }
> 4550:
> 4551: //This test is for
This comment is confusing. Shou
On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote:
> Class DeferredCloseInputStream is unused since removing of Solaris support
> https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81
Marked as reviewed by
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
This pull request has now been integrated.
Changeset: 8e82d002
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d
Stat
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7201
> Use presumed syntax that will be introduced by JDK-8280488.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits since t
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
- 8280441: Missing "classpath exception" in several files from jdk.httpserver
- 8279179: Update nroff pages in JDK 18 before RC
The webrevs contain the adjustments done w
On Sat, 22 Jan 2022 19:29:45 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote:
> Reported by clang-tidy. Verified manually by running
>
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH,
> Calendar.SHORT_STANDALONE, Locale.getDefault()));
>
> with `-Djava.
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7201
On Sat, 22 Jan 2022 19:29:45 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 24 Jan 2022 15:54:01 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/security/util/TlsChannelBinding.java line
>> 100:
>>
>>> (failed to retrieve contents of file, check the PR for context)
>> I think this method should stay here. Suppose one day the CBT type is
>> confi
On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote:
> Class DeferredCloseInputStream is unused since removing of Solaris support
> https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81
Marked as reviewed by
Class DeferredCloseInputStream is unused since removing of Solaris support
https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81
-
Commit messages:
- [PATCH] Remove unused DeferredCloseInputStream
C
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7201
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote:
> > Use presumed syntax that will be introduced by JDK-8280488.
>
> Is that a wrong bug? If you are talking about module-prefix syntax for links,
> then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
> @link and @link
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote:
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
> PatternSyntaxException
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7201
On Thu, 20 Jan 2022 21:10:39 GMT, Andrey Turbanov wrote:
> Test `test/java/io/File/GetXSpace.java` always failed on my machine with this
> output:
>
> --System.out:(12/489)--
> --- Testing df
> C:/Programs/cygwin64 292848636 49695320 243153316 17% /
> D: 59672 59672 0 100% /cygd
Replacing a buggy NullPointerException in `Pattern.compile()` with the proper
PatternSyntaxException
-
Commit messages:
- 8280403: RegEx: String.split can fail with NPE in
Pattern.CharPredicate::match
Changes: https://git.openjdk.java.net/jdk/pull/7201/files
Webrev: https://webre
On Mon, 24 Jan 2022 16:22:08 GMT, Ian Graves wrote:
> Replacing a buggy NPE with a PatternSyntaxException for cases with a bad
> intersection operator.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/7199
Replacing a buggy NPE with a PatternSyntaxException for cases with a bad
intersection operator.
-
Commit messages:
- 8280403: RegEx: String.split can fail with NPE in
Pattern.CharPredicate::match
Changes: https://git.openjdk.java.net/jdk/pull/7199/files
Webrev: https://webrevs.op
On Mon, 24 Jan 2022 15:23:44 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> comm
On Mon, 24 Jan 2022 13:54:12 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> com
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Fri, 21 Jan 2022 15:40:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more tidy-up
>
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 144:
>
>> 142:
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Fri, 21 Jan 2022 19:48:02 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added root cause to NamingException
>
> src/java.base/share/classes/java/net/doc-files/net-properties.html line 220:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Thu, 20 Jan 2022 21:10:39 GMT, Andrey Turbanov wrote:
> Test `test/java/io/File/GetXSpace.java` always failed on my machine with this
> output:
>
> --System.out:(12/489)--
> --- Testing df
> C:/Programs/cygwin64 292848636 49695320 243153316 17% /
> D: 59672 59672 0 100% /cygd
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Is that a wrong bug? If you are talking about module-prefix syntax for links,
then it was introduced in JDK 15; JDK-8164408: Add module support for @see,
@link and @linkplain javado
On Mon, 24 Jan 2022 11:00:37 GMT, Daniel Fuchs wrote:
> LGTM. I hope in the future IDEs will pick that rule up and offer some help
> when writing `{@link }` `@see`...
They will do it quicker, if you create new or support existing bugs in their
bug trackers.
-
PR: https://git.open
On Mon, 17 Jan 2022 20:56:56 GMT, Andrey Turbanov wrote:
> Method `Thread.dispatchUncaughtException` (called by VM) uses result of of
> `getUncaughtExceptionHandler`. Field `uncaughtExceptionHandler` is volatile
> and can be changed by another Thread. Which could lead to NPE.
> https://github.c
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by dfuchs (Reviewer).
LGTM. I hope in the future IDEs will pick that rule up and offer some help when
writing `{@link }` `@see`...
-
PR: https://git
On Fri, 21 Jan 2022 16:19:07 GMT, Leonid Mesnik wrote:
> Please update copyright years.
Updated, thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/7132
> While working on JDK-8280003, I noticed that
> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays
> with more than 1-byte size elements, and no large arrays (past 4G limit) are
> tested either. It would be better to add those test cases.
>
> Additional testing:
> - [
On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev wrote:
> Found by Sonar. See details in the bug.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug `tier1`
> - [x] Linux x86_64 fastdebug `java/util/Hashtable`
Thanks for reviews!
-
PR: https://git.openjdk.java.net/jdk/pull
On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev wrote:
> Found by Sonar. See details in the bug.
>
> Additional testing:
> - [x] Linux x86_64 fastdebug `tier1`
> - [x] Linux x86_64 fastdebug `java/util/Hashtable`
This pull request has now been integrated.
Changeset: d1569111
Author:Al
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote:
> Reported by clang-tidy. Verified manually by running
>
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH,
> Calendar.SHORT_STANDALONE, Locale.getDefault()));
>
> with `-Djava.
71 matches
Mail list logo
