On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote:
> Class DeferredCloseInputStream is unused since removing of Solaris support
> https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81
This pull request has
On Tue, 25 Jan 2022 17:22:54 GMT, Yumin Qi wrote:
>> I'm curious, under what circumstances would, before
>> https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the
>> LoadLibrary in imageDecompressor.cpp? Did this ever work? Was there ever a
>> scenario where the JVM was not involved
Use floating-point library methods to nudge down the result if needed. The
nextAfter(r, origin) call return the next value in the direction of origin,
handling cases for negative values, etc.
Changing to call nextDown for the origin is bounded at zero is just a
refactoring that is clearer to re
On Fri, 21 Jan 2022 22:49:38 GMT, Mandy Chung wrote:
> The MethodHandle of a default method should be made as a fixed arity method
> handle because it is invoked via Proxy's invocation handle with a non-vararg
> array of arguments. On the other hand, the `InvocationHandle::invokeDefault`
> me
On Tue, 25 Jan 2022 15:22:30 GMT, Maurizio Cimadamore
wrote:
> This patch fixes some inconsistencies in the foreign API javadoc. The main
> fix is to make javadoc of all predicate methods consistent, and to use the
> `@return` tag where appropriate, as to avoid duplication.
>
> There were als
On Wed, 26 Jan 2022 00:06:25 GMT, liach wrote:
> They will probably accept a MethodHandles.Lookup object to define a class for
> such a single-interface instance plus calling the default methods beyond the
> restrictions.
Yes, that's one option. Such library should take a Lookup parameter to
Hi, could i get a review on this implementation proposed by Stuart Marks, i
decided to use the
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
interface to create the default method `asRandom()` that wraps around the
newer algorithms to be used
On Thu, 16 Dec 2021 17:44:04 GMT, Vicente Romero wrote:
> Hi,
>
> Please review this change that is fixing a bug in reflection in particular in
> `sun.reflect.annotation.TypeAnnotationParser::buildAnnotatedTypes` the
> current code is assuming that for inner class constructors, there are only
> Update the java.lang.{Math, StrictMath} regression test helper library to
> accept method references. This allows the test programs to be DRY-er as the
> inputs to the method under test don't have to be repeated. The float test
> method were not updated due to limitations in type inference if
On Tue, 25 Jan 2022 22:01:22 GMT, Johannes Kuhn wrote:
> My question was for when a library wants to implement something similar to
> `MethodHandleProxies.asInterfaceInstace`, and for example supports Interfaces
> with more than a single abstract method. Currently, such a library would also
>
Hi Naoto,
Looks good to me, and thanks for the explanation. I agree, AIOOBE would
be a separate bug with ofPattern.
Thanks,
Joe
On 1/25/22 2:30 PM, Naoto Sato wrote:
Hi Joe,
On 1/24/22 5:50 PM, Joe Wang wrote:
The 2nd and 3rd statements defined the requestedTemplate,
does it imply
Hi Joe,
On 1/24/22 5:50 PM, Joe Wang wrote:
The 2nd and 3rd statements defined the requestedTemplate, does
it imply the characters listed in the snippet are the only ones that are
valid, in other words, can other characters under the Patterns section
be used? It may be helpful to elabo
On Tue, 25 Jan 2022 21:35:27 GMT, Mandy Chung wrote:
>> The MethodHandle of a default method should be made as a fixed arity method
>> handle because it is invoked via Proxy's invocation handle with a non-vararg
>> array of arguments. On the other hand, the
>> `InvocationHandle::invokeDefault
Update the java.lang.{Math, StrictMath} regression test helper library to
accept method references. This allows the test programs to be DRY-er as the
inputs to the method under test don't have to be repeated. The float test
method were not updated due to limitations in type inference if both flo
On Tue, 25 Jan 2022 17:00:34 GMT, Paul Sandoz wrote:
>> This patch fixes some inconsistencies in the foreign API javadoc. The main
>> fix is to make javadoc of all predicate methods consistent, and to use the
>> `@return` tag where appropriate, as to avoid duplication.
>>
>> There were also mi
> The MethodHandle of a default method should be made as a fixed arity method
> handle because it is invoked via Proxy's invocation handle with a non-vararg
> array of arguments. On the other hand, the `InvocationHandle::invokeDefault`
> method was added in Java 16 to invoke a default method o
On Tue, 18 Jan 2022 15:57:58 GMT, Roger Riggs wrote:
> The thread factory used to create the process reaper threads unnecessarily
> inherits the callers thread context classloader.
> The result is retention of the class loader.
>
> The thread factory used for the pool of process reaper threads
On Tue, 25 Jan 2022 17:20:50 GMT, Mandy Chung wrote:
> What about this:
Looks okay, main thing is to have it be consistent with the existing methods.
-
PR: https://git.openjdk.java.net/jdk/pull/7185
On Tue, 25 Jan 2022 02:42:45 GMT, Joe Darcy wrote:
> Making the exception message friendlier to users.
This pull request has now been integrated.
Changeset: 295c0474
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/295c0474c43484e793b67a70af316aaae49fe361
Stats: 19
> Making the exception message friendlier to users.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Improve formatting.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7208/files
- new: https://git.openjdk.java.
On Tue, 18 Jan 2022 18:33:29 GMT, Aleksey Shipilev wrote:
> While working on JDK-8280003, I noticed that
> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays
> with more than 1-byte size elements, and no large arrays (past 4G limit) are
> tested either. It would be bett
On Fri, 14 Jan 2022 19:27:18 GMT, Aleksey Shipilev wrote:
> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
> issues with it:
> - The cache cannot disambiguate between cleared SoftReference and the
> accidental passing of `null` value; in that case, the retry loop
On Tue, 25 Jan 2022 16:33:10 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
On Tue, 25 Jan 2022 18:25:14 GMT, Joe Darcy wrote:
>> Making the exception message friendlier to users.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
Looks good.
-
Marked as reviewed by mchung (Revie
On Tue, 25 Jan 2022 18:25:14 GMT, Joe Darcy wrote:
>> Making the exception message friendlier to users.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
Marked as reviewed by iris (Reviewer).
-
PR: http
On Tue, 25 Jan 2022 08:33:21 GMT, Matthias Baesken wrote:
>> After 8270492
>> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
>> has been pushed, we should adjust
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
>
On Tue, 25 Jan 2022 17:10:33 GMT, Mandy Chung wrote:
> There is another `newIllegalAccessException(Class memberClass, int
> modifiers)` method that also needs to be updated.
Updated accordingly and refactored slightly to pull out the string suffix
construction into a new method.
-
> Making the exception message friendlier to users.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7208/files
- new: https://git.openjdk.java.net/jdk/pu
> Making the exception message friendlier to users.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7208/files
- new: https://git.openj
On Tue, 18 Jan 2022 23:15:20 GMT, Joe Darcy wrote:
> While it is strongly recommend to not use the default toString for a class,
> at times it is the least-bad alternative. When that alternative needs to be
> used, it would be helpful to have the implementation already available, such
> as in
> While it is strongly recommend to not use the default toString for a class,
> at times it is the least-bad alternative. When that alternative needs to be
> used, it would be helpful to have the implementation already available, such
> as in Objects.toDefaultString(). This method is analagous t
On Tue, 25 Jan 2022 10:29:48 GMT, Thomas Stuefe wrote:
> I'm curious, under what circumstances would, before
> https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the LoadLibrary
> in imageDecompressor.cpp? Did this ever work? Was there ever a scenario where
> the JVM was not involve
On Tue, 25 Jan 2022 14:36:26 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix accident argument ordering after edit
>
> src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java
On Tue, 25 Jan 2022 16:33:10 GMT, Aleksey Shipilev wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry
On Tue, 25 Jan 2022 05:25:12 GMT, Joe Darcy wrote:
>> Making the exception message friendlier to users.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
There is another `newIllegalAccessException(C
On Tue, 25 Jan 2022 15:22:30 GMT, Maurizio Cimadamore
wrote:
> This patch fixes some inconsistencies in the foreign API javadoc. The main
> fix is to make javadoc of all predicate methods consistent, and to use the
> `@return` tag where appropriate, as to avoid duplication.
>
> There were als
On Tue, 25 Jan 2022 16:12:11 GMT, Aleksey Shipilev wrote:
> > This looks good, although I don't know whether the additional check for
> > strongReferent != null is needed in clearStrong(). This is all racy code
> > and you have already got a non-null return from getStrong() in case you are
> >
> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
> issues with it:
> - The cache cannot disambiguate between cleared SoftReference and the
> accidental passing of `null` value; in that case, the retry loop would spin
> indefinitely;
> - If retry loop would spin
On Tue, 18 Jan 2022 19:36:18 GMT, Chris Plummer wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
On Tue, 18 Jan 2022 20:07:10 GMT, Roger Riggs wrote:
>> JDK-8277072 introduced java.io.ClassCache, but there seem to be at least two
>> issues with it:
>> - The cache cannot disambiguate between cleared SoftReference and the
>> accidental passing of `null` value; in that case, the retry loop
On Mon, 24 Jan 2022 21:32:16 GMT, Peter Levart wrote:
> This looks good, although I don't know whether the additional check for
> strongReferent != null is needed in clearStrong(). This is all racy code and
> you have already got a non-null return from getStrong() in case you are
> calling cle
On Fri, 21 Jan 2022 17:07:37 GMT, Mark Sheppard wrote:
>> Good point. I think its better to deal with the casts at the edges since the
>> timeout handling will use long by default.
>
> yes a redeclaration of timeout with a type long across the component would
> be a consistent approach, also
This patch fixes some inconsistencies in the foreign API javadoc. The main fix
is to make javadoc of all predicate methods consistent, and to use the
`@return` tag where appropriate, as to avoid duplication.
There were also minor fixes in the package-level javadoc (one typo) and in
`ValueLayout
On Mon, 24 Jan 2022 23:13:24 GMT, Mandy Chung wrote:
> To invoke the default method, the caller will need access to the declaring
> interface of the default method (via bytecode invocation or reflection). The
> bug I had was because java.base (the module of the invocation handler) does
> not h
On Mon, 24 Jan 2022 21:31:37 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 24 Jan 2022 23:18:41 GMT, Mandy Chung wrote:
>> The MethodHandle of a default method should be made as a fixed arity method
>> handle because it is invoked via Proxy's invocation handle with a non-vararg
>> array of arguments. On the other hand, the
>> `InvocationHandle::invokeDefault
On Tue, 25 Jan 2022 12:47:26 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 150:
>>
>>> 148: * "domain:a,c.d,*.e.f" (sent to host a, or c.d or to the domain
>>> e.f and any of its subdomains). This is
>>> 149: * a comma separated list
On Tue, 25 Jan 2022 11:34:57 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> final review update (pre CSR)
>
> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 150:
>
>> 148
On Tue, 25 Jan 2022 10:30:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Tue, 25 Jan 2022 10:47:41 GMT, Masanori Yano wrote:
> I have removed the duplicate property keys.
> Could you please review the fix?
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7212
On Tue, 25 Jan 2022 10:30:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
I have removed the duplicate property keys.
Could you please review the fix?
-
Commit messages:
- 8266974: duplicate property key in java.sql.rowset resource bundle
Changes: https://git.openjdk.java.net/jdk/pull/7212/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7212&
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from GetModuleHandle("zip.dll"),
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
> After 8270492
> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
> has been pushed, we should adjust
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
> getAbsoluteURI to what has been done in 8270492 to
> src/java
On Thu, 20 Jan 2022 23:32:33 GMT, Joe Wang wrote:
> Thanks Alan for the reminder. The change looks good. Please add a copyright
> header and the LastModified tag as the other class did.
Hi, I added the header and LastModified.
Best regards, Matthias
-
PR: https://git.openjdk.java.
> After 8270492
> https://github.com/openjdk/jdk/commit/78b2c8419bc69436873e6fc9c542480949d140c5
> has been pushed, we should adjust
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java
> getAbsoluteURI to what has been done in 8270492 to
> src/java
On Mon, 24 Jan 2022 21:31:37 GMT, Joe Darcy wrote:
>> While it is strongly recommend to not use the default toString for a class,
>> at times it is the least-bad alternative. When that alternative needs to be
>> used, it would be helpful to have the implementation already available, such
>> as
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
59 matches
Mail list logo
