- Fixed by adding missing ']'.
- I changed '()' to '[]', since other error messages use '[]' and not '()'.
-
Commit messages:
- 8282407: Missing ')' in MacResources.properties
Changes: https://git.openjdk.java.net/jdk/pull/7797/files
Webrev:
On Fri, 11 Mar 2022 19:40:39 GMT, Stuart Marks wrote:
> I think we can rely on the monotonicity of these functions. If populating a
> map both with 49 and with 96 mappings results in a table length of 128, we
> don't need to test that all the intermediate inputs also result in a table
>
On Fri, 11 Mar 2022 19:40:39 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - change KeyStructure to String
>> - fix test
>
> Regarding the number of test cases for `tableSizeForCases` and
>
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new:
On Fri, 11 Mar 2022 19:09:25 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - change KeyStructure to String
>> - fix test
>
> test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 61:
>
>> 59:
On Fri, 11 Mar 2022 01:25:28 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote:
>> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
>> decimal/grouping separator symbols. Fix is straightforward to use the
>> correct symbols depending on the formatter type.
>
> Naoto Sato has updated the pull request
Implementation of [JDK-8275062: "Allow jpackage create installers for
services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
CSR
-
Commit messages:
- Whitespace cleanup
- Whitespace cleanup
- JDK-8236128: Allow jpackage create installers for services
- Sync l10n files.
Background, from JBS:
src/java.base/share/native/libverify/check_code.c: In function 'read_all_code':
src/java.base/share/native/libverify/check_code.c:942:5: error: 'lengths' may
be used uninitialized [-Werror=maybe-uninitialized]
942 | check_and_push(context, lengths, VM_MALLOC_BLK);
On Fri, 11 Mar 2022 22:49:25 GMT, Mandy Chung wrote:
>> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
>> receiver check rather than NPE thrown by `Object::getClass`. The message of
>> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>>
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
> helpful but not in this case.
Mandy Chung has updated the
> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
> decimal/grouping separator symbols. Fix is straightforward to use the correct
> symbols depending on the formatter type.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last
On Thu, 3 Mar 2022 05:42:23 GMT, Jatin Bhateja wrote:
>> The testing for this PR doesn't look adequate to me. I don't see any testing
>> for the values where the behavior of round has been redefined at points in
>> the last decade. See JDK-8010430 and JDK-6430675, both of which have
>>
`DecimalFormat.toLocalizedPattern()` was not honoring the monetary
decimal/grouping separator symbols. Fix is straightforward to use the correct
symbols depending on the formatter type.
-
Commit messages:
- 8282929: Localized monetary symbols are not reflected in
On Fri, 11 Mar 2022 01:25:28 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Fri, 11 Mar 2022 15:56:26 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - change KeyStructure to String
> - fix test
On Fri, 11 Mar 2022 19:07:59 GMT, Daniel Fuchs wrote:
>> Carter Kozak has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add 8283049 to LoggerFinderLoaderTest @bug docs
>
>
> 8283049: Fix non-singleton LoggerFinder error message: s/on/one
Carter Kozak has updated the pull request incrementally with one additional
commit since the last revision:
Add 8283049 to LoggerFinderLoaderTest @bug docs
-
Changes:
- all:
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH
On Thu, 10 Mar 2022 14:29:36 GMT, Joe Darcy wrote:
>> Hi @jddarcy ,
>>
>> Test has been modified on the same lines using generic options which
>> manipulate compilation thresholds and agnostic to target platforms.
>>
>> * @run main/othervm -XX:Tier3CompileThreshold=100
>>
On Thu, 10 Mar 2022 22:28:14 GMT, Carter Kozak wrote:
> 8283049: Fix non-singleton LoggerFinder error message: s/on/one
I changed the bug title to match the PR title.
test/jdk/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/LoggerFinderLoaderTest.java
line 233:
> 231:
On Thu, 10 Mar 2022 22:28:14 GMT, Carter Kozak wrote:
> 8283049: Fix non-singleton LoggerFinder error message: s/on/one
Unfortunately I lack the permissions to create an issue for this. @dfuch is
there any chance you could help me create the issue?
-
PR:
8283049: Fix non-singleton LoggerFinder error message: s/on/one
-
Commit messages:
- 8283049: Fix non-singleton LoggerFinder error message: s/on/one
Changes: https://git.openjdk.java.net/jdk/pull/7780/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7780=00
Issue:
Hi Carter,
I have created https://bugs.openjdk.java.net/browse/JDK-8283049
I will sponsor the changed after it's been reviewed and integrated.
best regards,
-- daniel
On 11/03/2022 15:42, Carter Kozak wrote:
When multiple LoggerFinder implementations are found, a ServiceConfigurationError
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Fri, 11 Mar 2022 15:17:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Fri, 11 Mar 2022 15:56:26 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - change KeyStructure to String
> - fix test
On Fri, 11 Mar 2022 15:44:49 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Use long array for primitives
>> - Use long arrays for primitives
>
>
On Fri, 11 Mar 2022 15:53:08 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/runtime/Carrier.java line 380:
>>
>>> 378: }
>>> 379:
>>> 380: return Unsafe.ARRAY_LONG_BASE_OFFSET +
>>
>> Shouldn't you add the offset of the first `int`
On Wed, 9 Mar 2022 22:52:41 GMT, Mandy Chung wrote:
> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
> receiver check rather than NPE thrown by `Object::getClass`. The message of
> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>
On Fri, 11 Mar 2022 15:17:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Fri, 11 Mar 2022 15:17:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- change KeyStructure to String
- fix test
-
Changes:
- all:
On Fri, 11 Mar 2022 15:48:37 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Use long array for primitives
>> - Use long arrays for primitives
>
>
Hello,
I'd be grateful if someone could help me create an issue for a typo in
LoggerFinderLoader.
When multiple LoggerFinder implementations are found, a
ServiceConfigurationError is thrown with message "More than on LoggerFinder
implementation" rather than "More than one LoggerFinder
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
The security related changes look
On Fri, 11 Mar 2022 10:58:23 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Leave public for the time being
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 48:
>
>>
On Thu, 10 Mar 2022 22:53:39 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/runtime/Carrier.java line 346:
>>
>>> 344: * Carrier for longs and integers.
>>> 345: */
>>> 346: private final int[] integers;
>>
>> I believe (@rose00 correct me
> We propose to provide a runtime anonymous carrier class object generator;
> java.lang.runtime.Carrier. This generator class is designed to share
> anonymous classes when shapes are similar. For example, if several clients
> require objects containing two integer fields, then Carrier will
On Fri, 11 Mar 2022 10:42:02 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Leave public for the time being
>
> src/java.base/share/classes/java/lang/runtime/Carrier.java line 57:
>
>>
On Fri, 11 Mar 2022 08:28:32 GMT, Ioi Lam wrote:
>> Is reproducibility also a topic for users calling -Xdump with custom JNI
>> coding? Or maybe having the VM instrumented somehow? Since it seems such an
>> easy fix, I would prevent attaching too. At least the user would get a clear
>> error
On Thu, 10 Mar 2022 02:30:35 GMT, Brian Burkhalter wrote:
> Add a statement to the `java.io` package documentation clarifying how a
> `String` representing a _pathname string_ is interpreted in the package.
Marked as reviewed by lancea (Reviewer).
-
PR:
On Thu, 10 Mar 2022 19:35:16 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>>
On Fri, 11 Mar 2022 10:16:33 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 192:
>>
>>> 190:
>>> 191: /**
>>> 192: * {@return locale used to create this instance}
>>
>> Hello Jim, the opening and closing `{`, I think aren't needed for a
On Fri, 11 Mar 2022 04:28:00 GMT, Jaikiran Pai wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> commits
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal sub-classes
> -
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal sub-classes
> -
On Fri, 11 Mar 2022 07:13:35 GMT, Thomas Stuefe wrote:
> Is reproducibility also a topic for users calling -Xdump with custom JNI
> coding? Or maybe having the VM instrumented somehow? Since it seems such an
> easy fix, I would prevent attaching too. At least the user would get a clear
>
52 matches
Mail list logo
