> On May 4, 2022, at 8:29 PM, Xiaohong Gong wrote:
>
> The offset check could save the `checkMaskFromIndexSize` for cases that
> offset are in the valid array bounds, which also improves the performance.
> @rose00 , do you think this part of change is ok at least?
That part is ok, yes. I wi
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
>
> 1) Extends the scope of existing lanewise API for fo
On Thu, 5 May 2022 03:17:35 GMT, Xiaohong Gong wrote:
>> src/hotspot/share/opto/vectorIntrinsics.cpp line 1363:
>>
>>> 1361: // Use the vector blend to implement the masked store. The
>>> biased elements are the original
>>> 1362: // values in the memory.
>>> 1363: Node* mem_v
On Thu, 5 May 2022 02:09:39 GMT, Xiaohong Gong wrote:
>> Currently the vectorization of masked vector store is implemented by the
>> masked store instruction only on architectures that support the predicate
>> feature. The compiler will fall back to the java scalar code for
>> non-predicate su
On Thu, 5 May 2022 02:27:03 GMT, John R Rose wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> 8284050: [vectorapi] Optimize masked store for non-predicated architectures
>
> src/hotspot/s
On Thu, 5 May 2022 02:09:39 GMT, Xiaohong Gong wrote:
>> Currently the vectorization of masked vector store is implemented by the
>> masked store instruction only on architectures that support the predicate
>> feature. The compiler will fall back to the java scalar code for
>> non-predicate su
On Wed, 4 May 2022 12:12:48 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default an
On Thu, 31 Mar 2022 02:15:26 GMT, Quan Anh Mai wrote:
>> I'm afraid not. "Load + Blend" makes the elements of unmasked lanes to be
>> `0`. Then a full store may change the values in the unmasked memory to be 0,
>> which is different with the mask store API definition.
>
> The blend should be wi
On Thu, 28 Apr 2022 00:13:49 GMT, Sandhya Viswanathan
wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename the "usePred" to "offsetInRange"
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 1232:
>
>> 1230:
> Currently the vectorization of masked vector store is implemented by the
> masked store instruction only on architectures that support the predicate
> feature. The compiler will fall back to the java scalar code for
> non-predicate supported architectures like ARM NEON. However, for these
> s
Currently the vectorization of masked vector store is implemented by the masked
store instruction only on architectures that support the predicate feature. The
compiler will fall back to the java scalar code for non-predicate supported
architectures like ARM NEON. However, for these systems, the
On Thu, 5 May 2022 01:42:48 GMT, Xiaohong Gong wrote:
> > > Yeah, I agree that it's not good by adding a branch checking for
> > > `offsetInRange`. But actually I met the constant issue that passing the
> > > values all the way cannot guarantee the argument a constant in compiler
> > > at the
On Thu, 5 May 2022 01:21:40 GMT, Paul Sandoz wrote:
> > Yeah, I agree that it's not good by adding a branch checking for
> > `offsetInRange`. But actually I met the constant issue that passing the
> > values all the way cannot guarantee the argument a constant in compiler at
> > the compile ti
On Wed, 4 May 2022 17:09:32 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same k
On Thu, 5 May 2022 01:13:23 GMT, Xiaohong Gong wrote:
> Yeah, I agree that it's not good by adding a branch checking for
> `offsetInRange`. But actually I met the constant issue that passing the
> values all the way cannot guarantee the argument a constant in compiler at
> the compile time. Do
On Fri, 29 Apr 2022 21:34:13 GMT, Paul Sandoz wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename the "usePred" to "offsetInRange"
>
> IIUC when the hardware does not support predicated loads then any false
>
On Wed, 4 May 2022 23:29:53 GMT, Maurizio Cimadamore
wrote:
>> Good points. Regarding `ClassLoader` being null, I think we can still return
>> something using the `BootLoader`'s `NativeLibraries` object - that would
>> allow this method to be called internally. @mlchung Can you please confirm?
On Wed, 4 May 2022 23:20:21 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 153:
>>
>>> 151: static SymbolLookup loaderLookup() {
>>> 152: Class caller = Reflection.getCallerClass();
>>> 153: ClassLoader loader =
>>> O
On Wed, 4 May 2022 22:27:48 GMT, Paul Sandoz wrote:
> The changes to `Float` and `Double` look good. I don't think we need
> additional tests, see test/jdk/java/lang/Math/IeeeRecommendedTests.java.
Thank you, Paul for pointing the test. It means we need to run tier4 (which
runs these tests wit
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Wed, 4 May 2022 16:47:28 GMT, ExE Boss wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 57 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Update
>> src/java.base/share/classes/j
On Wed, 4 May 2022 19:32:41 GMT, Vladimir Kozlov wrote:
>> Hi,
>>
>> This patch optimises the matching rules for floating-point comparison with
>> respects to eq/ne on x86-64
>>
>> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
>> is always set, so we don't need `
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please a
On Wed, 4 May 2022 01:59:17 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch optimises the matching rules for floating-point comparison with
> respects to eq/ne on x86-64
>
> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
> is always set, so we don't need `cmpOpUCF2`
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Tue, 3 May 2022 01:20:10 GMT, Joe Darcy wrote:
>> In the latest push, to address the concerns raised updated the proposed
>> wording to, in plain text:
>>
>> Java Runtime Environment specification maintenance version, not defined
>> before the specification implemented by this runtime has u
On Wed, 4 May 2022 01:59:17 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch optimises the matching rules for floating-point comparison with
> respects to eq/ne on x86-64
>
> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF`
> is always set, so we don't need `cmpOpUCF2`
On Wed, 4 May 2022 12:30:53 GMT, Doug Lea wrote:
> This is the revised jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR
> removes the unrelated commits from original version.
This p
On Wed, 4 May 2022 18:46:20 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Wed, 27 Apr 2022 11:03:48 GMT, Jatin Bhateja wrote:
> Hi All,
>
> Patch adds the planned support for new vector operations and APIs targeted
> for [JEP 426: Vector API (Fourth
> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173)
>
> Following is the brief summary of changes:-
>
On Wed, 4 May 2022 14:55:25 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assertions over return values. Some refinement of equals() testing.
>> - Add comment about Map.Entry identity not gua
On Wed, 4 May 2022 15:02:43 GMT, liach wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 500:
>>
>>> 498: Box newKey = new Box(k1a);
>>> 499: Box newVal = new Box(v1a);
>>> 500: Box r = map.computeIfAbsent(newKey, k -> { called[0] = true;
>>> return newVal; })
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Wed, 4 May 2022 17:42:05 GMT, Sandhya Viswanathan
wrote:
>> Tyler Steele has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright header year
>
> Marked as reviewed by sviswanathan (Reviewer).
Thank you @sviswa7.
> src/jdk.
> Adds missing classpath exception to the header of two GPLv2 files.
>
> Requested
> [here](https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-April/013988.html).
Tyler Steele has updated the pull request incrementally with one additional
commit since the last revision:
Update copy
On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method
On Mon, 2 May 2022 20:05:36 GMT, Tyler Steele wrote:
> Adds missing classpath exception to the header of two GPLv2 files.
>
> Requested
> [here](https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-April/013988.html).
src/jdk.incubator.vector/linux/native/libjsvml/globals_vectorApiSupp
On Mon, 2 May 2022 20:05:36 GMT, Tyler Steele wrote:
> Adds missing classpath exception to the header of two GPLv2 files.
>
> Requested
> [here](https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-April/013988.html).
Marked as reviewed by sviswanathan (Reviewer).
-
PR: h
Adds missing classpath exception to the header of two GPLv2 files.
Requested
[here](https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-April/013988.html).
-
Commit messages:
- Add classpath excemption to copyright header
Changes: https://git.openjdk.java.net/jdk/pull/850
On Mon, 2 May 2022 12:32:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` spe
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave t
On Tue, 26 Apr 2022 21:17:34 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Thanks for
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind of issue.
Ichiroh Takiguchi has updated the pull request incr
On Wed, 4 May 2022 12:30:53 GMT, Doug Lea wrote:
> This is the revised jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR
> removes the unrelated commits from original version.
Marked
On Tue, 3 May 2022 10:40:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Wed, 4 May 2022 12:12:48 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default an
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the default method `asRandom()` that wraps around the
> newer algorithms
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Wed, 4 May 2022 14:57:19 GMT, Jaikiran Pai wrote:
>> Stuart Marks has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assertions over return values. Some refinement of equals() testing.
>> - Add comment about Map.Entry identity not gua
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
This pull request has now been integrated.
Changeset: 7424f475
Author:
On Wed, 4 May 2022 12:30:53 GMT, Doug Lea wrote:
> This is the revised jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR
> removes the unrelated commits from original version.
Marked
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
Hi Roger and Martin, thanks for the reviews !
-
PR: https://
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
Marked as reviewed by mdoerr (Reviewer).
-
PR: https://git.o
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.o
This is the revised jsr166 refresh for jdk19. See
https://bugs.openjdk.java.net/browse/JDK-8285450 and
https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR
removes the unrelated commits from original version.
-
Commit messages:
- Redoing JDK-8277090 to avoid s
On Sun, 1 May 2022 10:53:55 GMT, Doug Lea wrote:
> This is the jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090
This pull request has been closed without being integrated.
-
PR: https://git.ope
On Tue, 3 May 2022 23:10:44 GMT, Doug Lea wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since t
> This is the implementation of JEP 425: Virtual Threads (Preview).
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with `--enable-preview` to enable.
>
>
A couple a tests like java/lang/ProcessBuilder/Basic.java#id0.Basic_id0 and
jdk/jshell/ExternalEditorTest.java.ExternalEditorTest try to start small shell
scripts without #! at the first line of the script. This fails with error=8,
Exec format error when running on Alpine 3.15 .
Looks like this
There is one TestLibrary.bomb call in
sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
exception to bomb, that should be improved.
-
Commit messages:
- JDK-8286114
Changes: https://git.openjdk.java.net/jdk/pull/8533/files
Webrev: https://webrevs.openjdk.
On Tue, 3 May 2022 12:07:50 GMT, Jan Lahoda wrote:
> 8262889: Compiler implementation for Record Patterns
>
> A first version of a patch that introduces record patterns into javac as a
> preview feature. For the specification, please see:
> http://cr.openjdk.java.net/~gbierman/jep427+405/jep427
On Wed, 4 May 2022 09:59:33 GMT, Maurizio Cimadamore
wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>> http://cr.openjdk.java.net/~gbierman/je
On Wed, 4 May 2022 09:46:00 GMT, Сергей Цыпанов wrote:
>> `Class.getInterfaces(false)` does not clone underlying array and can be used
>> in cases when the returned array is only read from.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last
> `Class.getInterfaces(false)` does not clone underlying array and can be used
> in cases when the returned array is only read from.
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8282701: Revert some irrelevant changes
-
On Wed, 4 May 2022 01:37:27 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memo
On Wed, 4 May 2022 08:34:43 GMT, David Holmes wrote:
> I'm confused.
> `src\jdk.crypto.mscapi\windows\native\libsunmscapi\security.cpp` doesn't set
> _WIN32_WINNT so how is that later API being enabled? Does this mean that not
> setting _WIN32_WINNT means :any API is allowed" ?
I found this i
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winv
On Tue, 3 May 2022 13:27:41 GMT, David Holmes wrote:
> I agree with Erik - the source locations need to be modified to not define
> it. If we want to keep a record perhaps add an assertion that the value is
> what was expected?
>
> I still feel we have a disconnect between this and an actual c
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Fri, 22 Apr 2022 12:16:07 GMT, Sibabrata Sahoo wrote:
> A new API to support replacing selective lines with desired content.
This pull request has now been integrated.
Changeset: 0462d5a2
Author:Sibabrata Sahoo
URL:
https://git.openjdk.java.net/jdk/commit/0462d5a25258458ec7f40d76
73 matches
Mail list logo