Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v6]

2022-05-09 Thread Shruthi
> Removing the Duplicate keys present in XSLTErrorResources.java and > XPATHErrorResources.java > > The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097 Shruthi has updated the pull request incrementally with one additional commit since the last revision: update copy

Integrated: JDK-8285730: unify _WIN32_WINNT settings

2022-05-09 Thread Matthias Baesken
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-09 Thread Alan Bateman
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v2]

2022-05-09 Thread Joe Darcy
On Mon, 9 May 2022 09:26:58 GMT, Raffaello Giulietti wrote: >> Add a family of "safe" cast methods. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

RFR: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()

2022-05-09 Thread Ioi Lam
The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified. It's unlikely such a mode will be requ

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v11]

2022-05-09 Thread Joe Darcy
On Mon, 9 May 2022 12:38:48 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Integrated: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote: > 8282351: jpackage does not work if class file has `$$` in the name on windows This pull request has now been integrated. Changeset: 29395534 Author:Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/commit/29395534d9683a80

RFR: 8286279: [vectorapi] Only check index of masked lanes if offset is out of array boundary for masked store

2022-05-09 Thread Xiaohong Gong
Checking whether the indexes of masked lanes are inside of the valid memory boundary is necessary for masked vector memory access. However, this could be saved if the given offset is inside of the vector range that could make sure no IOOBE (IndexOutOfBoundaryException) happens. The masked load A

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v3]

2022-05-09 Thread Xiaohong Gong
On Mon, 9 May 2022 21:55:27 GMT, Paul Sandoz wrote: > I modified the code of this PR to avoid the conversion of `boolean` to `int`, > so a constant integer value is passed all the way through, and the masked > load is made intrinsic from the method at which the constants are passed as > argume

Re: RFR: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot [v2]

2022-05-09 Thread Leonid Mesnik
> Test executes method recursively and works too long. > > It the same issue as > [JDK-8139875](https://bugs.openjdk.java.net/browse/JDK-8139875) > > The test shouldn't be run with DeoptimizeALot Leonid Mesnik has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected

2022-05-09 Thread Uwe Schindler
On Mon, 9 May 2022 18:59:43 GMT, Naoto Sato wrote: > This is to extend the `Custom ID`s in `java.util.TimeZone` class to support > second-level resolution, enabling round trips with `java.time.ZoneOffset`s. > Corresponding CSR is also being drafted. Marked as reviewed by uschindler (Author).

Re: RFR: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause

2022-05-09 Thread Christoph Langer
On Mon, 9 May 2022 22:10:54 GMT, Christoph Langer wrote: > After https://bugs.openjdk.java.net/browse/JDK-8251329, javac throws errors > when the classpath > contains jar files with . or .. in its name. The error message, however, does > not help to find > the culprit. This could be improved.

RFR: 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause

2022-05-09 Thread Christoph Langer
After https://bugs.openjdk.java.net/browse/JDK-8251329, javac throws errors when the classpath contains jar files with . or .. in its name. The error message, however, does not help to find the culprit. This could be improved. - Commit messages: - JDK-8286444 Changes: https://git.

Re: RFR: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexander Matveev
On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote: > 8282351: jpackage does not work if class file has `$$` in the name on windows Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8613

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v3]

2022-05-09 Thread Paul Sandoz
On Thu, 5 May 2022 08:56:07 GMT, Xiaohong Gong wrote: >> Currently the vector load with mask when the given index happens out of the >> array boundary is implemented with pure java scalar code to avoid the IOOBE >> (IndexOutOfBoundaryException). This is necessary for architectures that do >> n

HttpClient has no explicit way of releasing threads

2022-05-09 Thread Rafael Winterhalter
Hello, looking at thread dumps, I realized that the HttpClient implementation does not offer an explicit way to release its threads. Currently, the client: 1. maintains a cached thread pool with a retention size of 60 seconds. If many such clients are created for short lived application, these th

RFR: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
8282351: jpackage does not work if class file has `$$` in the name on windows - Commit messages: - Fix regression - 8282351: jpackage does not work if class file has `$$` in the name on windows Changes: https://git.openjdk.java.net/jdk/pull/8613/files Webrev: https://webrevs.openj

Re: RFR: 8262889: Compiler implementation for Record Patterns [v4]

2022-05-09 Thread Vicente Romero
On Mon, 9 May 2022 14:37:35 GMT, Jan Lahoda wrote: >> 8262889: Compiler implementation for Record Patterns >> >> A first version of a patch that introduces record patterns into javac as a >> preview feature. For the specification, please see: >> http://cr.openjdk.java.net/~gbierman/jep427+405/j

RFR: 8286438: Add jhsdb jstack processing without --mixed in efh

2022-05-09 Thread Leonid Mesnik
The default is required only to set the same depth level in the tree on HTML page for default and mixed mode. - Commit messages: - 8286438: Add jhsdb jstack processing without --mixed in efh Changes: https://git.openjdk.java.net/jdk/pull/8610/files Webrev: https://webrevs.openjdk.

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v43]

2022-05-09 Thread Maurizio Cimadamore
On Mon, 9 May 2022 18:09:51 GMT, ExE Boss wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix crashes in heap segment benchmarks due to misaligned access > > test/micro/org/openjdk/bench/java/lang/foreign/Lo

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-05-09 Thread Joe Darcy
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand o

Re: RFR: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

2022-05-09 Thread Chris Plummer
On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out test/failure_handler/src/share/conf/common.properties line 67: > 65: > 66: jhsdb.app=jhsdb > 67: jhsdb.jstack.live.args=jstack --mixed --pid %p What is the plan to address th

Re: RFR: 8286368: Cleanup problem lists after loom integration

2022-05-09 Thread Alan Bateman
On Mon, 9 May 2022 18:17:13 GMT, Leonid Mesnik wrote: > 8286368: Cleanup problem lists after loom integration Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8604

RFR: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected

2022-05-09 Thread Naoto Sato
This is to extend the `Custom ID`s in `java.util.TimeZone` class to support second-level resolution, enabling round trips with `java.time.ZoneOffset`s. Corresponding CSR is also being drafted. - Commit messages: - 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all Zone

Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Joe Wang
On Mon, 9 May 2022 07:00:34 GMT, Shruthi wrote: >> Removing the Duplicate keys present in XSLTErrorResources.java and >> XPATHErrorResources.java >> >> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097 > > Shruthi has refreshed the contents of this pull request, and

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType [v2]

2022-05-09 Thread Mandy Chung
On Mon, 9 May 2022 10:12:36 GMT, Claes Redestad wrote: >> A few untested and unused methods in `VerifyType` which can be removed. >> (Possibly used by native JSR 292 implementations in JDK 7). > > Claes Redestad has updated the pull request incrementally with one additional > commit since the l

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

2022-05-09 Thread Phil Race
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

RFR: 8286368: Cleanup problem lists after loom integration

2022-05-09 Thread Leonid Mesnik
8286368: Cleanup problem lists after loom integration - Commit messages: - 8286368: Cleanup problem lists after loom integration Changes: https://git.openjdk.java.net/jdk/pull/8604/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8604&range=00 Issue: https://bugs.openj

Integrated: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

2022-05-09 Thread Leonid Mesnik
On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out This pull request has now been integrated. Changeset: 40470d83 Author:Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/40470d83e4d8d4a48eb87e6bf4d221460bd

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v43]

2022-05-09 Thread ExE Boss
On Mon, 9 May 2022 17:41:10 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

RFR: 8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot

2022-05-09 Thread Leonid Mesnik
Test executes method recursively and works too long. It the same issue as [JDK-8139875](https://bugs.openjdk.java.net/browse/JDK-8139875) The test shouldn't be run with DeoptimizeALot - Commit messages: - copyrights fixed - 8284980: Test vmTestbase/nsk/stress/except/except010.jav

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-09 Thread Phil Race
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Withdrawn: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

2022-05-09 Thread Leonid Mesnik
On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8588

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-05-09 Thread Phil Race
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand o

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v43]

2022-05-09 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: Why does we still need StrictMath?

2022-05-09 Thread Joseph D. Darcy
On 5/8/2022 4:10 AM, Martin Desruisseaux wrote: Le 08/05/2022 à 10:56, Andrew Haley a écrit : Some targets (x86, in particular) have intrinsics (log, trig) that are faster than StrictMath and also more accurate. StrictMath is not about accuracy, but cross-architecture down-to-the-last bit rep

Re: RFR: 8286363: BigInteger.parallelMultiply missing @since 19

2022-05-09 Thread Joe Darcy
On Mon, 9 May 2022 15:26:20 GMT, Brian Burkhalter wrote: > Add missing `@since 19` tag. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8598

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-05-09 Thread Erik Joelsson
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand o

Re: RFR: 8238373: Punctuation should be same in jlink help usage on Japanese language [v2]

2022-05-09 Thread Naoto Sato
On Mon, 9 May 2022 06:38:29 GMT, KIRIYAMA Takuya wrote: >> When showing help for the jlink command in a Japanese locale, delimiters of >> option's aliases are a mixture of "," and \u3001. Delimiter should be >> unified to ",". >> As the same, there is a inconsistency of delimiters in the jar co

Re: RFR: 8286163: micro-optimize Instant.plusSeconds

2022-05-09 Thread Naoto Sato
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote: > Provide micro-benchmark for comparison Looks good to me. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8542

RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-05-09 Thread Adam Sotona
Please review this patch adding new lint option, **lossy-conversions**, to javac to warn about type casts in compound assignments with possible lossy conversions. The new lint warning is shown if the type of the right-hand operand of a compound assignment is not assignment compatible with the t

Re: RFR: 8286363: BigInteger.parallelMultiply missing @since 19

2022-05-09 Thread Alan Bateman
On Mon, 9 May 2022 15:26:20 GMT, Brian Burkhalter wrote: > Add missing `@since 19` tag. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8598

RFR: 8286363: BigInteger.parallelMultiply missing @since 19

2022-05-09 Thread Brian Burkhalter
Add missing `@since 19` tag. - Commit messages: - 8286363: BigInteger.parallelMultiply missing @since 19 Changes: https://git.openjdk.java.net/jdk/pull/8598/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8598&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Shruthi
On Mon, 9 May 2022 07:00:34 GMT, Shruthi wrote: >> Removing the Duplicate keys present in XSLTErrorResources.java and >> XPATHErrorResources.java >> >> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097 > > Shruthi has refreshed the contents of this pull request, and

Re: RFR: 8262889: Compiler implementation for Record Patterns [v4]

2022-05-09 Thread Vicente Romero
On Mon, 9 May 2022 14:37:35 GMT, Jan Lahoda wrote: >> 8262889: Compiler implementation for Record Patterns >> >> A first version of a patch that introduces record patterns into javac as a >> preview feature. For the specification, please see: >> http://cr.openjdk.java.net/~gbierman/jep427+405/j

Re: RFR: 8262889: Compiler implementation for Record Patterns [v4]

2022-05-09 Thread Vicente Romero
On Fri, 6 May 2022 17:40:25 GMT, Jan Lahoda wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 4217: >> >>> 4215: } >>> 4216: ListBuffer outBindings = new ListBuffer<>(); >>> 4217: List recordTypes = expectedRecordTypes; >> >> nit: probably

Integrated: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

2022-05-09 Thread Raffaello Giulietti
On Tue, 19 Apr 2022 08:40:51 GMT, Raffaello Giulietti wrote: > Please review these small changes to address intermittent failures, as of > JDK-8274517. > > - Usage of jdk.test.lib.RandomFactory for reproducible random generation. > - Slightly less restrictive assertion about badParallelStreamE

Re: RFR: 8262889: Compiler implementation for Record Patterns [v4]

2022-05-09 Thread Jan Lahoda
> 8262889: Compiler implementation for Record Patterns > > A first version of a patch that introduces record patterns into javac as a > preview feature. For the specification, please see: > http://cr.openjdk.java.net/~gbierman/jep427+405/jep427+405-20220426/specs/patterns-switch-record-patterns-j

Re: RFR: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] [v2]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 09:25:15 GMT, Raffaello Giulietti wrote: >> Please review these small changes to address intermittent failures, as of >> JDK-8274517. >> >> - Usage of jdk.test.lib.RandomFactory for reproducible random generation. >> - Slightly less restrictive assertion about badParallelStr

Re: RFR: 8282274: Compiler implementation for Pattern Matching for switch (Third Preview) [v10]

2022-05-09 Thread Jan Lahoda
> This is a (preliminary) patch for javac implementation for the third preview > of pattern matching for switch (type patterns in switches). > > Draft JLS: > http://cr.openjdk.java.net/~gbierman/PatternSwitchPlusRecordPatterns/PatternSwitchPlusRecordPatterns-20220407/specs/patterns-switch-jls.htm

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v11]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 12:34:20 GMT, limck599 wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 4511638: Double.toString(double) sometimes produces incorrect results > > Marked as reviewed by limck...@github.com (

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v11]

2022-05-09 Thread limck599
On Mon, 9 May 2022 12:34:20 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v10]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 09:26:20 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v11]

2022-05-09 Thread Raffaello Giulietti
> Hello, > > here's a PR for a patch submitted on March 2020 > [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a > thing. > > The patch has been edited to adhere to OpenJDK code conventions about > multi-line (block) comments. Nothing in the code proper has changed,

Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v7]

2022-05-09 Thread Ichiroh Takiguchi
> On JDK19 with Linux ja_JP.eucjp locale, > System.getenv() returns unexpected value if environment variable has Japanese > EUC characters. > It seems this issue happens because of JEP 400. > Arguments for ProcessBuilder have same kind of issue. Ichiroh Takiguchi has updated the pull request with

Integrated: 8286294 : ForkJoinPool.commonPool().close() spins

2022-05-09 Thread Doug Lea
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote: > Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool This pull request has now been integrated. Changeset: 4f5d73f2 Author:Doug Lea URL: https://git.openjdk.java.net/jdk/commit/4f5d73f2d411aa

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v5]

2022-05-09 Thread Alan Bateman
On Sun, 8 May 2022 12:08:14 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Test improvements Marked as rev

Re: RFR: 8283689: Update the foreign linker VM implementation [v7]

2022-05-09 Thread Jorn Vernee
> Hi, > > This PR updates the VM implementation of the foreign linker, by bringing over > commits from the panama-foreign repo. > > This is split off from the main JEP integration for 19, since we have limited > resources to handle this. As such, this PR might fall over to 20. > > I've written

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType [v2]

2022-05-09 Thread Claes Redestad
> A few untested and unused methods in `VerifyType` which can be removed. > (Possibly used by native JSR 292 implementations in JDK 7). Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Inline isNullReferenceConversion at sole call s

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v10]

2022-05-09 Thread Volker Simonis
On Mon, 9 May 2022 09:56:19 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream` spe

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v10]

2022-05-09 Thread Volker Simonis
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to > highlight that it might write more bytes than the returned number of > inflated bytes into the buffer `b`. > > The superclass `java.io.InputStream` specifies that `read(byte[] b, int off, > int len)` will leave t

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v2]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 09:26:58 GMT, Raffaello Giulietti wrote: >> Add a family of "safe" cast methods. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

Re: RFR: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] [v2]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 09:25:15 GMT, Raffaello Giulietti wrote: >> Please review these small changes to address intermittent failures, as of >> JDK-8274517. >> >> - Usage of jdk.test.lib.RandomFactory for reproducible random generation. >> - Slightly less restrictive assertion about badParallelStr

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v10]

2022-05-09 Thread Raffaello Giulietti
On Mon, 9 May 2022 09:26:20 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 8279986: methods Math::asXExact for safely checked primitive casts [v2]

2022-05-09 Thread Raffaello Giulietti
> Add a family of "safe" cast methods. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revis

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v10]

2022-05-09 Thread Raffaello Giulietti
> Hello, > > here's a PR for a patch submitted on March 2020 > [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a > thing. > > The patch has been edited to adhere to OpenJDK code conventions about > multi-line (block) comments. Nothing in the code proper has changed,

Re: RFR: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] [v2]

2022-05-09 Thread Raffaello Giulietti
> Please review these small changes to address intermittent failures, as of > JDK-8274517. > > - Usage of jdk.test.lib.RandomFactory for reproducible random generation. > - Slightly less restrictive assertion about badParallelStreamError on L94 > (former L88). > - Verbatim copy of computeFinalSu

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v42]

2022-05-09 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8262889: Compiler implementation for Record Patterns [v3]

2022-05-09 Thread Maurizio Cimadamore
On Sat, 7 May 2022 12:03:04 GMT, Jan Lahoda wrote: >> 8262889: Compiler implementation for Record Patterns >> >> A first version of a patch that introduces record patterns into javac as a >> preview feature. For the specification, please see: >> http://cr.openjdk.java.net/~gbierman/jep427+405/j

Re: Why does we still need StrictMath?

2022-05-09 Thread Andrew Haley
On 5/8/22 13:14, Victor Williams Stafusa da Silva wrote: Sure, there are the x86 intrinsics. But since JEP 306 was delivered, is this still valid? The Motivation section of the JEP 306 seems to imply that this is not the case anymore. Of course, I could just be grossly misunderstanding what is/

Re: Why does we still need StrictMath?

2022-05-09 Thread Andrew Haley
On 5/8/22 13:44, Martin Desruisseaux wrote: Le 08/05/2022 à 14:15, Victor Williams Stafusa da Silva a écrit : Was that using Java 17+, which included JEP 306 delivered? No, but my understanding is that JEP 306 does not apply to Math versus StrictMath behavior. In my understanding, the strictf

Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Shruthi
> Removing the Duplicate keys present in XSLTErrorResources.java and > XPATHErrorResources.java > > The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097 Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental view