Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

On 8/17/2011 2:04 PM, Sebastian Sickelmann wrote: Am 17.08.2011 16:58, schrieb Alexandre Boulgakov: Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've file

Re: Request for review 6237353: Remove sun.io package from j2se binary

an/6237353/webrev/ <http://cr.openjdk.java.net/%7Esherman/6237353/webrev/> -Sherman On 08/17/2011 05:54 AM, Alexandre Boulgakov wrote: Hello Sherman, Can you check if any deprecation warnings are generated from the other classes built by java/sun_nio/Makefile? Suppressing deprecation warnin

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to InternalError" for it. Thanks Joe, and to help this along

Re: Request for review 6237353: Remove sun.io package from j2se binary

Hello Sherman, Can you check if any deprecation warnings are generated from the other classes built by java/sun_nio/Makefile? Suppressing deprecation warnings might no longer be necessary now that sun.io is gone, and then you can change lines 34-35 in the makefile to "JAVAC_MAX_WARNINGS = true

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

what you're referring to? In the sdiff of the changes, the paragraph breaks are roughly the same. (I did reformat some paragraphs for line breaks, etc.) -Joe Alexandre Boulgakov wrote: Hello Joe, It looks like you have added multiple spaces between some sentences. Is this intent

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

Hello Joe, It looks like you have added multiple spaces between some sentences. Is this intentional? Cheers, Sasha On 8/15/2011 12:17 PM, Joe Darcy wrote: Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about getProperty

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

ew TypeName[...]" in place of "new TypeName[...]" and removed associated SuppressWarnings annotations; and * changed TypeVariable to TypeVariable since the conversion would otherwise be unchecked. Thanks, Sasha On 8/11/2011 9:19 AM, Joe Darcy wrote: Alexandre Boulgakov wrot

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

throw new IllegalStateException( "No method definition for javax.rmi.CORBA.Stub.connect(org.omg.CORBA.ORB)"); On 8/11/2011 12:07 PM, Alexandre Boulgakov wrote: Please review the attached patch to fix a build break. The fix changes new Class<>[] to new Class[] in two places. Thanks, Sasha

Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

Please review the attached patch to fix a build break. The fix changes new Class<>[] to new Class[] in two places. Thanks, Sasha diff -r 18329abcdb7c src/share/classes/com/sun/jndi/ldap/Obj.java --- a/src/share/classes/com/sun/jndi/ldap/Obj.java Wed Aug 10 13:44:58 2011 -0700 +++ b/src/sha

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Hello Remi, Thanks for the feedback! On 8/10/2011 1:22 PM, Rémi Forax wrote: On 08/10/2011 09:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Hello Joe, Thanks for reviewing and responding so quickly! On 8/10/2011 12:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http

Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7077389 webrev: http://cr.openjdk.java.net/~mduigou/7077389/0/webrev/

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 8/9/2011 2:53 AM, Xuelei Fan wrote: On 8/9/2011 3:55 PM, Alexandre Boulgakov wrote: That makes sense. I'll do that with automatic refactoring in Netbeans. Do you want me to send another webrev afterwards? Just to confirm, you will change LdapNameClassPairEnumeration ba

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

Sent: Monday, August 8, 2011 7:30:09 PM GMT -08:00 US/Canada Pacific Subject: Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror] On Aug 9, 2011, at 10:16 AM, Alexandre Boulgakov wrote: > I can change it back to LdapNamingEnumeration. I just thought

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

t; Thanks to everyone who reviewed the last version! > > Thanks, > Sasha > > On 8/4/2011 2:00 PM, Alexandre Boulgakov wrote: >> >> On 8/3/2011 10:44 PM, Joe Darcy wrote: >>> David Holmes wrote: >>>> Joe Darcy said the following on 08/04/11 12:33:

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

a few of their consumers; * Made a few additional small changes that were discussed. Thanks to everyone who reviewed the last version! Thanks, Sasha On 8/4/2011 2:00 PM, Alexandre Boulgakov wrote: On 8/3/2011 10:44 PM, Joe Darcy wrote: David Holmes wrote: Joe Darcy said the following on 08/04/11

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 8/3/2011 10:44 PM, Joe Darcy wrote: David Holmes wrote: Joe Darcy said the following on 08/04/11 12:33: David Holmes wrote: Using wildcards makes the subtyping work along the type argument axis. So what is the right fix here? To declare the underlying Vector as a Vector and cast it to s

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

eason not to include such a utility class, but it could certainly be confusing. -Sasha On 8/3/2011 2:09 PM, Neil Richards wrote: On Wed, 2011-08-03 at 11:03 -0700, Alexandre Boulgakov wrote: Please see my responses inline. Thanks! -Sasha On 8/2/2011 9:13 PM, Xuelei Fan wrote: . com/sun/jndi/to

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 8/3/2011 10:51 AM, Dr Andrew John Hughes wrote: On 09:24 Wed 03 Aug , Joe Darcy wrote: On 8/3/2011 12:42 AM, David Holmes wrote: Alexandre Boulgakov said the following on 08/03/11 04:44: On 8/2/2011 2:19 AM, Xuelei Fan wrote: 3017 Vector temp = (Vector)extractURLs(res.errorMessage

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

Please see my responses inline. Thanks! -Sasha On 8/2/2011 9:13 PM, Xuelei Fan wrote: . com/sun/jndi/toolkit/dir/SearchFilter.java 451 for (NamingEnumeration ve = attr.getAll(); 452 ve.hasMore(); 453) { The update is OK. But the coding style looks un

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

Thanks for reviewing! See my responses inline. I'll wait on sending another webrev until I've received the rest of your comments. -Sasha On 8/2/2011 2:19 AM, Xuelei Fan wrote: Please review these JNDI changes. Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353 webrev: htt

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

Thanks for reviewing! Please see my responses inline. I'll wait on sending another webrev until I've received the rest of your comments. -Sasha On 8/2/2011 2:19 AM, Xuelei Fan wrote: Please review these JNDI changes. Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353 webr

Code review request: 7072523 java.math should be built with javac -Xlint:all -Werror

Hello Joe, Could you review the attached two-line update to ensure that no javac warnings are introduced into java.math? Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072523 Thanks, Sasha diff -r 7525866a4046 make/java/math/Makefile --- a/make/java/math/Makefile Thu Jul 28

Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror

Hello, Please review these JNDI changes. Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7072353 webrev: http://cr.openjdk.java.net/~mduigou/7072353/0/webrev/ Thanks, Sasha

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

On 7/28/2011 4:43 PM, Dr Andrew John Hughes wrote: On 21:44 Thu 28 Jul , jonathan.gibb...@oracle.com wrote: Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7525866a4046 7068616: NIO libraries do not build with j