How does IS_JNI_TRUE sound?
--
best regards,
Anthony
On 3/23/2014 10:10 PM, Alan Bateman wrote:
On 21/03/2014 15:22, Sergey Bylokhov wrote:
On 3/21/14 7:10 PM, roger riggs wrote:
The macro would just as useful (if I understand the cases) without
the cast.
How useful is a simple definition as
Personally, I'd call it to_jboolean(obj), but IS_TRUE(obj) sounds good
to me too. Either way, I'm fine with the fix.
--
best regards,
Anthony
On 3/17/2014 7:01 PM, Sergey Bylokhov wrote:
Hello.
This review request is for the new macro, which simplify conversion to
jboolean. It will be useful f
Hi Petr,
The fix looks fine to me.
--
best regards,
Anthony
On 2/24/2014 4:21 PM, Petr Pchelko wrote:
Hello, Alan.
Thank you for the review.
This looks okay to me. One suggestion is to use #endif /* __cplusplus */ so
that it's consistent with the other usages (also makes it a bit easier wh
Hi Petr,
The fix looks good to me. We still need a review from someone who
maintains the Launcher code. Kumar?
Also, you could use the @autoreleasepool directive to simplify it a bit,
although I'm fine with the explicit syntax, too.
One comment regarding your remark:
c. We would have lost
Thanks Laurent. The fix looks fine to me, too. I've just pushed it to
the repository:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4490ef60ecd3
Currently it's in the AWT forest. I expect it to be integrated to the
Master JDK8 repository in a week or two.
--
best regards,
Anthony
On 4/11/2013
Laurent, I'm not subscribed to those mailing list, too. So you could
send/forward your review request to the lists yourself - no difference
here. Note that I tried sending your message to net-dev@ in the past,
and even contacted the maintainer of the mailing list via a private
email, but I neve
Le 4 avr. 2013 14:08, "Laurent Bourgès"
mailto:bourges.laur...@gmail.com>>
a écrit :
Ok, I can provide an updated patch after finding / fixing
all usages.
Probably in 1 or 2 days,
Laurent
2013/4/4 An
es between FINE / FINER log statements:
- XScrollbarPeer
- XWindowPeer
Laurent
2013/4/2 Anthony Petrov mailto:anthony.pet...@oracle.com>
<mailto:anthony.petrov@oracle.__com
<mailto:anthony.pet...@oracle.com>>>
Hi Dan,
Changes to awt code look fine to me.
--
best regards,
Anthony
On 4/2/2013 2:16, Dan Xu wrote:
Hi All,
In this fix, I have updated files in JDK libraries to use @Native
annotation instead of @GenerateNativeHeader to mark classes that
contain no native methods but constants used by
rlier OS.
In my opinion that is better to use the function based on fact of
present (here the question is more about
Shell32.dll version, not OS version but they are in relation).
Alan, that do you think about it?
Regards,
-uta
On 22.01.2013 19:45, Anthony Petrov wrote:
Hi Alexey,
The fix
Hi Alexey,
The fix looks good from code logic perspective.
I'm only concerned with whether we should use the __try/__except magic,
or would it rather make sense to define:
#define IS_WINVISTA (LOBYTE(LOWORD(::GetVersion())) >= 6)
and guard the call to SHGetKnownFolderPath() with this check?
LAG_DONT_VERIFY/||KF_FLAG_DONT_VERIFY
flags for the |fix?
Regards,
-uta
On 22.01.2013 15:14, Anthony Petrov wrote:
On 1/22/2013 13:48, Alexey Utkin wrote:
One thing on SHGetKnownFolderPath is that you specify KF_FLAG_CREATE
and I'm not sure if that is right because we don't want the
On 1/22/2013 13:48, Alexey Utkin wrote:
One thing on SHGetKnownFolderPath is that you specify KF_FLAG_CREATE
and I'm not sure if that is right because we don't want the JDK
creating the user's directory if it doesn't exist.
That is a corner case. In the latest versions of OS, MS is trying to
fo
(bcc'ing core-libs-dev@)
Looks like this is related to 6981400. I'm CC'ing Anton to take a look
at it.
--
best regards,
Anthony
On 11/7/2012 2:58 PM, Weijun Wang wrote:
I've just synced with jdk7u-dev and now it does not build.
symbol: class TimedWindowEvent
location: class SunToolkit
62111/webrev.01/
Thanks,
Jason
On 06/25/2012 06:19 AM, Anthony Petrov wrote:
Hi Alan and Jason,
On 06/23/12 11:28, Alan Bateman wrote:
On 23/06/2012 02:01, Jason Uh wrote:
This fix was for regression tests failing on Mac OS X on remotely
executed environments. The changed tests now run in headless
Hi Alan and Jason,
On 06/23/12 11:28, Alan Bateman wrote:
On 23/06/2012 02:01, Jason Uh wrote:
This fix was for regression tests failing on Mac OS X on remotely
executed environments. The changed tests now run in headless mode and
have been taken off the Problem List.
Webrev: http://cr.openjdk
Hi Jonathan,
Let's consider e.g.
src/share/native/sun/awt/splashscreen/java_awt_SplashScreen.c mentioned
by you below.
It #includes splashscreen_impl.h. This file #includes
splashscreen_config.h. And finally,
src/solaris/native/sun/awt/splashscreen/splashscreen_config.h #includes
the stdli
Changes to the splashscreen_config.h look fine. Thanks.
--
best regards,
Anthony
On 10/12/2011 11:36 AM, David Holmes wrote:
On 12/10/2011 5:23 PM, Charles Lee wrote:
On 10/12/2011 03:12 PM, David Holmes wrote:
On 12/10/2011 4:26 PM, Charles Lee wrote:
sys/unistd.h, sys/fcntl.h are not suppor
[ bcc'ing core-libs-dev@, and cc'ing awt-dev@ instead ]
Hi Christian,
I don't recall exactly this problem reported. Let's ask Andrei (CC'ed)
about that.
--
best regards,
Anthony
On 11/10/2010 6:58 PM, Christian Thalinger wrote:
While testing one of my changes with CompileTheWorld I hit a pr
On 11/10/2010 1:48 PM, Rémi Forax wrote:
The soft way to kill a process on windows to send a WM_CLOSE/WM_QUIT.
http://stackoverflow.com/questions/2055753/how-to-gracefully-terminate-a-process
This only works for GUI applications that process window messages (e.g.
AWT or Swing apps). If an appl
Hi David,
According to the SCCS history, the ALT_OPENWIN_HOME has been introduced
with CR 2154143 (which is a 6u10 SubCR of 6613871). The CR is marked as
delivered to 7b65 as well, however the ALT_OPENWIN_HOME changes in
make/common/shared/Defs-linux.gmk have been lost for some reason.
I thi
Hello,
Please review the next version of the fix contributed by Damjan Jovanovic:
RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094
There you can also find some latest comments regarding the fix.
webrev:
http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.1/
Since the patch
On 09/17/2009 03:32 PM, Oleg Sukhodolsky wrote:
imho removing dependency on j.u.logging for me looks as strange as
removing
dependency on j.l.Object or java.util.* :)
For example, if the libraries are broken up into a
set of fine grain modules then why would I need to have a logging module
ins
On 09/17/2009 12:56 PM, Alan Bateman wrote:
I haven't seen any proposals to eliminate the logging but rather the
suggestion is that this logging should be re-examined because there are
way too many loggers created at startup. For example, one of the
suggestions that Mandy has put in 6880089 [1]
Hi Mandy,
On 09/15/2009 10:43 PM, Mandy Chung wrote:
> Is it really that unlikely that fine() will be
> called that we need not initialise this early?
AWT team, can you confirm?
I didn't examine this particular AWTEvent class. I can confirm that in
many places we call the fine() method dir
Hi Damjan,
On 07/30/2009 02:24 PM, Anthony Petrov wrote:
Damjan, have you by the way tested the fix with a GUI Java
application that
does not display a top-level window, but rather creates a tray icon
only?
Does the notification get correctly removed from the task bar in that
case?
It
On 07/29/2009 11:10 PM, Damjan Jovanovic wrote:
Damjan, have you by the way tested the fix with a GUI Java application that
does not display a top-level window, but rather creates a tray icon only?
Does the notification get correctly removed from the task bar in that case?
It doesn't :-(.
The
Hello,
Please review the fix contributed by Damjan Jovanovic:
RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094
webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.0/
Since the patch includes changes to the src/solaris/bin/java_md.c, I'm
CC'ing Kumar and Core Libs a
wrote:
Anthony Petrov wrote:
Do the following instead:
[extensions]
hgext.fetch =
[defaults]
fetch = -m Merge
OK, ta.
Andrew.
Do the following instead:
[extensions]
hgext.fetch =
[defaults]
fetch = -m Merge
--
best regards,
Anthony
On 06/02/2009 06:43 PM, Andrew Haley wrote:
I can't get the fetch extension to work properly.
I was told that I need to add
[extensions]
hgext.fetch = -m Merge
but that doesn't work:
Hi Zhang,
First of all, I believe that the nb-projects-dev@ mailing list is more
appropriate for such questions.
AFAIK the NetBeans projects are currently supported by the NetBeans 6
beta only. They might not work in the current stable versions of the
NetBeans. Please install the latest beta
Hello folks,
Some time ago Diego Pettenò sent out a couple of patches that allow JDK
use an external zlib library. A number of other fixes from this author
sent to the awt-dev@ alias depend on the mentioned zlib patches, and
cannot be easily applied without the zlib-patch applied first.
Coul
32 matches
Mail list logo
