Re: Review Request: JDK-8019227: JDK-8010325 broke the old build

2013-06-27 Thread Brad Wetmore
The old build has not produced usable bits for several months, it may not have been failing but if you look closely (or run the tests) then you'll see that there are several things missing. On build-dev then you'll probably have seen a mail or two from me where I was trying to encourage the

Review Request: JDK-8019227: JDK-8010325 broke the old build

2013-06-26 Thread Brad Wetmore
Brent/Alan/Mike, Hashing.java was removed from the JDK workspace, but was not removed from the old java/java/FILES_java.gmk. Things that still depend on the old build (JCE/deploy) are currently broken. http://cr.openjdk.java.net/~wetmore/8019227/webrev.00/ Brad P.S. I'm very aware that we

Re: 8016701: JAXP Build failure

2013-06-14 Thread Brad Wetmore
Approved. Brad On 6/14/2013 5:31 PM, Joe Darcy wrote: Looks fine Rob; approved. -Joe On 6/14/2013 5:28 PM, Rob McKenna wrote: Hi folks, As per the bug: JAXP must be buildable using JDK7 as the bootdir. Unfortunately http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-22 Thread Brad Wetmore
On 3/22/2013 1:34 AM, Alan Bateman wrote: On 21/03/2013 22:12, Brad Wetmore wrote: : The codereview is here: http://cr.openjdk.java.net/~wetmore/8009517/webrev.00/ I plan to push through the deploy gate, as they have an integration next week. Thomas Ng will do the push for us. Any

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-21 Thread Brad Wetmore
gate, as they have an integration next week. Thomas Ng will do the push for us. Any objections, please speak now. Brad On 3/18/2013 6:29 PM, Brad Wetmore wrote: Sorry for the delay in response, I've been pulled in yet another direction, and this has come back up in priority. On 3/9/2013 12

Re: RFR 8009517: Disable fatal compiler warning in the old build

2013-03-08 Thread Brad Wetmore
I responded in another thread (wasn't aware of this one, sorry), there is an alternate to completely disabling -Werror. On 3/8/2013 7:58 AM, Chris Hegarty wrote: On 08/03/2013 15:49, Mike Duigou wrote: Looks fine to me. Thanks Mike. Do we have an issue open for restoring warnings to

Re: PKCS11 support on 64bit sun java

2013-03-07 Thread Brad Wetmore
Are you talking about windows-64 bit? All the other platforms should have 64-bit support. JDK 8 does have windows-x64 support for PKCS11. http://openjdk.java.net/jeps/131 I don't know of any plans to backport. Brad On 3/6/2013 9:16 PM, mohankumar kanaka wrote: Hi, This is

Re: Code review request for 6935997 Please add a nested throwable constructor to AssertionError

2010-06-08 Thread Brad Wetmore
As we discussed here, this looks fine. Brad On 6/8/2010 8:31 AM, Joe Darcy wrote: Thanks Martin and RĂ©mi for the quick reviews! Upon further consideration, before doing the push I decided to look for instances in the jdk repo where this new constructor could be used and I found one in

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Brad Wetmore
Oh, I agree. I just thought I'd use the opportunity to point out to everyone that a) there is some documentation of this and, more importantly, b) it needs updating. Kelly's been following this thread, but I haven't seen the note about the webrev here. His latest webrev (posted to

Re: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ...

2008-12-19 Thread Brad Wetmore
If you want to see the source change now, check out the changeset: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b89ba9a6d9a6 This change will not be seen immediately in the JDK7 snapshot source and binaries. As you may know, we use a series of subgates to make development and testing easier,

JSN Gate is being EOL'd.

2008-10-16 Thread Brad Wetmore
As you may know, I have been the gatekeeper for the JSN (Java Security Networking) gate for the last 4 or so years. As many of JSN and TL (Tools Libraries) changes are interrelated, we have been combining/testing/integrating the JSN TL changes together into the MASTER workspaces. JSN