On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
LGTM.
-
Marked as reviewed by chegar (Re
On Sat, 26 Mar 2022 12:51:04 GMT, liach wrote:
>>> You probably wanna allow for a non-NEW instance for the corner case where
>>> the given size is 0 - no elements.
>>
>> @ChrisHegarty I guess we shouldn't.
>>
>> I want to make it 100% equals to `new HashMap()` constructor, thus migrate
>> all
On Thu, 24 Mar 2022 17:43:31 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update jmh
> - refine javadoc; refine implement when expectedSize < 0
T
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too https://bugs.openjdk.java.net/browse/JDK-8
On Mon, 28 Feb 2022 11:12:17 GMT, Chris Hegarty wrote:
> The module finder implementation incorrectly uses the path-separator
> character from the default file system, when mapping the relative path
> of an entry in an exploded module to a package name. This causes
> problems on Wind
Info.read(ModuleInfo.java:129)
> at
> java.base/jdk.internal.module.ModulePath.readExplodedModule(ModulePath.java:689)
> at
> java.base/jdk.internal.module.ModulePath.readModule(ModulePath.java:320)
> ... 36 more
Chris Hegarty has updated the pull request
On Mon, 28 Feb 2022 14:34:43 GMT, Alan Bateman wrote:
> we should create another issue to create more tests for custom file systems.
Yeah, that's a good point. I'll take a closer look at this and see how best to
expand the coverage (separately).
> I assume you'll update the date in the copyrig
Info.read(ModuleInfo.java:129)
> at
> java.base/jdk.internal.module.ModulePath.readExplodedModule(ModulePath.java:689)
> at
> java.base/jdk.internal.module.ModulePath.readModule(ModulePath.java:320)
> ... 36 more
Chris Hegarty has updated the pull re
The module finder implementation incorrectly uses the path-separator
character from the default file system, when mapping the relative path
of an entry in an exploded module to a package name. This causes
problems on Windows [*] when using a module finder with a custom file
system that has a path-s
On Wed, 3 Nov 2021 13:23:36 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 24 Aug 2021 03:03:48 GMT, Vicente Romero wrote:
>> Please review this simple PR along with the associated CSR. The PR is
>> basically adding a line the the specification of method
>> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
>> NPE will be thrown.
>>
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Trivially, looks ok to me.
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote:
> Please find here a trivial fix for:
>
> 8269772: [macos-aarch64] test compilation failed with "SocketException: No
> buffer space available"
>
> Running several of the websocket tests concurrently on some of the CI
> machines is causing r
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote:
> Hi, can I have a review of this change that adds two new utility methods for
> java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of
> ByteOrder.nativeOrder() is to check if the underlying platform is
> little-endian/big-en
On Thu, 24 Jun 2021 18:42:23 GMT, Mandy Chung wrote:
> `Lookup::accessClass` should determine the accessibility of the element type.
> An array class is accessible if and only if its element type is accessible.
>
> This also fixes a spec bug to document `@throws NullPointerException` if the
>
> On 24 Jun 2021, at 22:27, Mandy Chung wrote:
>
> On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
> wrote:
>
>> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
>> against JDK17.
>>
>> This fixes the deadlock in ClassLoader between the two lock objects - a lock
>
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
> Clas
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401: Pri
On Tue, 22 Jun 2021 16:18:11 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401: Pri
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Wed, 16 Jun 2021 10:59:59 GMT, Stephen Colebourne
wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote:
> In the methods in question, `RejectedExecutionException` is an expected
> exception that was previously unhandled (it is a `RuntimeException`, not a
> subclass of `ExecutionException`). This change adds
> `RejectedExecutionException` to the
On Fri, 11 Jun 2021 15:26:50 GMT, Chris Hegarty wrote:
> There is the possibility for a race in the test, where the outbound socket
> buffer is still being filled, after 5 seconds, when the main test thread
> tries to close the resource scope.
>
> The test has been updated
On Fri, 11 Jun 2021 16:27:07 GMT, Daniel Fuchs wrote:
>> There is the possibility for a race in the test, where the outbound socket
>> buffer is still being filled, after 5 seconds, when the main test thread
>> tries to close the resource scope.
>>
>> The test has been updated to set the send/
There is the possibility for a race in the test, where the outbound socket
buffer is still being filled, after 5 seconds, when the main test thread tries
to close the resource scope.
The test has been updated to set the send/receive buffer sizes in an
attempt/hint to limit the accepted/connecte
On Tue, 8 Jun 2021 14:26:43 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415.
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Mon, 31 May 2021 14:07:54 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Thu, 27 May 2021 14:31:59 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
On Tue, 25 May 2021 18:54:48 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Tue, 25 May 2021 11:49:18 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch expres
On Tue, 25 May 2021 14:53:44 GMT, Patrick Concannon
wrote:
>> src/java.base/share/classes/java/io/StreamTokenizer.java line 795:
>>
>>> 793: * case statements
>>> 794: */
>>> 795: if (ttype < 256 && ((ctype[ttype] & CT_QUOTE) != 0)) {
>>
>> May
On Tue, 25 May 2021 14:57:22 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/io/Stre
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/io/Obje
On Mon, 24 May 2021 21:57:50 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Mon, 24 May 2021 21:57:50 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Mon, 24 May 2021 15:09:26 GMT, Roger Riggs wrote:
> i) is too limiting. It should be possible for an application to check whether
> a filter factory has been provided on the command line (by calling
> getSerialFilterFactory) and if not setting the factory itself. It may also
> want to insta
On Sat, 22 May 2021 20:16:37 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Sat, 22 May 2021 20:16:37 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Sat, 22 May 2021 20:16:37 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Fri, 21 May 2021 17:09:00 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/ObjectInputFilter.java line 365:
>>
>>> 363: * A utility class to set and get the JVM-wide deserialization
>>> filter factory,
>>> 364: * the static JVM-wide filter, or to create a filter from
On Fri, 21 May 2021 17:21:15 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/ObjectInputFilter.java line 107:
>>
>>> 105: * Note that the filter may be used directly or combined with
>>> other filters by the
>>> 106: * {@linkplain Config#setSerialFilterFactory(BinaryOpe
On Thu, 20 May 2021 16:10:11 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Fri, 21 May 2021 17:25:07 GMT, Roger Riggs wrote:
> The static is intended to distinguish that single filter from the others. The
> static vs current distinction is part of JEP 290 from which this evolved.
I can kinda grok that now, I see "current filter" in JEP 290. I think that the
new t
On Thu, 20 May 2021 16:10:11 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Thu, 20 May 2021 16:10:11 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Fri, 21 May 2021 03:02:43 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify factory interface to BinaryOperator and
>> cleanup the example
>
> src/java.base/share/classes/java/io/Obje
On Thu, 20 May 2021 16:10:11 GMT, Roger Riggs wrote:
>> JEP 415: Context-specific Deserialization Filters extends the
>> deserialization filtering mechanisms with more flexible and customizable
>> protections against malicious deserialization. See JEP 415:
>> https://openjdk.java.net/jeps/415
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Thu, 13 May 2021 10:49:21 GMT, Lance Andersen wrote:
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the current jtreg as well as the
> upcomin
On Tue, 11 May 2021 13:10:30 GMT, Aleksei Voitylov
wrote:
> Please review this PR which fixes the deadlock in ClassLoader between the two
> lock objects - a lock object associated with the class being loaded, and the
> ClassLoader.loadedLibraryNames hash map, locked during the native library
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by chegar (Reviewer).
--
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by chegar (Reviewer).
src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788:
> 6786: }
> 6787:
> 6788: /**
I think the import of Collectors c
On Wed, 28 Apr 2021 15:29:20 GMT, Brian Burkhalter wrote:
>> Please consider this request to modify `Reader.read(CharBuffer)` to check
>> whether the buffer is read-only before reading any characters from the
>> character stream. This can happen now if the buffer is read-only. Character
>> are
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Tue, 27 Apr 2021 18:40:24 GMT, Alan Bateman wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.n
On Fri, 23 Apr 2021 15:38:53 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> This PR was split into two parts due to the large number of files affected.
>
On Fri, 23 Apr 2021 10:44:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> This PR was split into two parts due to the large number of files affected.
>
> Ki
On Wed, 21 Apr 2021 11:06:16 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request w
On Mon, 12 Apr 2021 14:09:55 GMT, Conor Cleary wrote:
>> ### Description
>> This fix is part of a previous effort to both cleanup/modernise JNDI code,
>> the details of which can be seen in
>> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
>> JNDI methods under `java
On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote:
> Avoid overflow when calculating the number of pages for large mapped segment
> sizes.
This pull request has now been integrated.
Changeset: 3c9858dd
Author: Chris Hegarty
URL: https://git.openjdk.java.net/jdk/commit/3c
> Avoid overflow when calculating the number of pages for large mapped segment
> sizes.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Skip testing on 32-bit systems
-
Changes:
- all: https://git.openjdk.ja
On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote:
> Avoid overflow when calculating the number of pages for large mapped segment
> sizes.
Note for reviewers on the test. A 3GB file is sufficient to demonstrate the
issue in the old code, as follows (with a 4K page size, since the nar
Avoid overflow when calculating the number of pages for large mapped segment
sizes.
-
Commit messages:
- Test update
- Initial changes
Changes: https://git.openjdk.java.net/jdk/pull/3378/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3378&range=00
Issue: https://bu
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote:
> A number of HexFormat methods converting from strings to numbers do not use
> delimiter, prefix, suffix, and uppercase parameters and would be more
> convenient if the methods were static.
>
> These APIs were added early in JDK 17 and are
On Tue, 9 Mar 2021 21:37:16 GMT, Roger Riggs wrote:
> ObjectStreamPrinter is a Formatter plugin to the test library HexPrinter.
>
> A binary stream of serialized java objects is converted into a textual form
> by parsing the header, typecodes, and interpreting the stream contents. The
> format
On Tue, 16 Mar 2021 14:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed patch for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8263108?
>>
>> As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
>> `java.lang.constant.Consta
On Mon, 15 Mar 2021 21:47:28 GMT, Сергей Цыпанов
wrote:
>> Hello,
>>
>> as of now `java.util.StringJoiner` still uses `char[]` as a storage for
>> joined Strings.
>>
>> This applies for the cases when all joined Strings as well as delimiter,
>> prefix and suffix contain only ASCII symbols.
>
On Mon, 15 Mar 2021 08:53:43 GMT, Jaikiran Pai wrote:
> If you and others think that we can ignore this case, then your proposed
> approach of using this lazy holder for initialization, IMO, is much cleaner
> and natural to read and I will go ahead and update this PR to use it.
For me, at leas
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов
wrote:
> This is a very simple and trivial improvement about getting rid of pointless
> char wrapping into array
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2660
On Mon, 15 Mar 2021 09:21:22 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request i
On Thu, 11 Mar 2021 16:42:24 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> package to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request i
On Fri, 12 Mar 2021 13:23:39 GMT, Peter Levart wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Follow Peter Levart's review suggestion - remove volatile
>
> This looks good to me. Maybe if you wanted the previous p
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes wrote:
> This change removes some instances of superfluous boxing in
> java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.
LGTM.
Optionally (and trivially), you could update the JIRA description, from
"Examine" to "Remove superfluous use of .
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов
wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8261880: Remove s
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy wrote:
> Noticed by some of Jon Gibbons's doc linting & checking tooling, this
> changeset fixes two javadoc issues for BigDecimal's serialization-related
> methods, improving the serial form page.
Marked as reviewed by chegar (Reviewer).
-
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
On Thu, 11 Feb 2021 16:02:09 GMT, Roger Riggs wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Filter **C**onfigured
>
> Marked as reviewed by rriggs (Reviewer).
Speaking to Erik
alled or not. The event
> also captures the filter status, if there is one.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Split exception into type and message
-
Changes:
- all: https://git.openjdk.java.net/jdk/
On Thu, 11 Feb 2021 15:45:33 GMT, Daniel Fuchs wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing test
>
> src/jdk.jfr/share/classes/jdk/jfr/events/DeserializationEvent.
alled or not. The event
> also captures the filter status, if there is one.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Filter **C**onfigured
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2479/files
alled or not. The event
> also captures the filter status, if there is one.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2479/files
On Thu, 11 Feb 2021 14:27:19 GMT, Roger Riggs wrote:
>> Marked as reviewed by rriggs (Reviewer).
>
> As proposed, events are only created if there is a serialFilter in effect
> (and enabled by JFR configuration).
> Being able to create the events without a serialFilter in effect would be
> usef
alled or not. The event
> also captures the filter status, if there is one.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2479/files
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
This issue adds a new event to improve diagnostic information of Java
deserialization. The event captures the details of deserialization activity
from ObjectInputStream. The event details are similar to that of the serial
filter, but is agnostic of whether a filter is installed or not. The event
On Thu, 4 Feb 2021 16:14:57 GMT, Claes Redestad wrote:
>> This patch resolves a potential memory leak in
>> Java_java_lang_ClassLoader_defineClass0
>>
>> I've not figured a good way to write a regression test. A crude way to
>> manually verify the leak and the fix is provided by the added micr
On Wed, 25 Nov 2020 12:41:40 GMT, Chris Hegarty wrote:
> The ByteBuffers micro benchmark seems to be a little dated.
>
> It should be a useful resource to leverage when analysing the performance
> impact of any potential implementation changes in the byte buffer classes.
> Mo
; parameter was not always considered - this is now fixed.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains ten additional
commits since the
On Thu, 10 Dec 2020 14:01:56 GMT, Jorn Vernee wrote:
>> While the updated set of scenarios covered by this benchmark is
>> reasonably (and vastly improves coverage), I find myself reluctant to
>> add the last remaining buffer property - read-only views. It's time to
>> template the generation of
On Tue, 19 Jan 2021 00:35:51 GMT, Claes Redestad wrote:
> This patch improves `UnixPath.encode` by reusing `JLA.getBytesNoRepl` (which
> has fast-paths for common encoding) and avoiding a `toCharArray` call on the
> input by refactoring the `normalizeNativePath` code to operate on `String`.
>
On Tue, 12 Jan 2021 15:48:18 GMT, Maurizio Cimadamore
wrote:
> When support for shared segment was added, we decided to disable support for
> buffers derived from shared segment in certain async operations, as there's
> currently no way to make sure that the memory won't be reclaimed while the
On Tue, 12 Jan 2021 15:28:20 GMT, Maurizio Cimadamore
wrote:
> The byte buffers created from heap segments do not honor the javadoc - which
> says that the resulting buffer size should be equal to
> MemorySegment::byteSize, and that the buffer position should be zero.
>
> The issue is that th
On Fri, 8 Jan 2021 13:20:38 GMT, Aleksei Efimov wrote:
>> This issue is blocked by [8258657][1]. It should not be integrated until
>> after 8258657 has been resolved. The JIRA issues have been linked up to
>> reflect this.
>>
>> [1]: https://bugs.openjdk.java.net/browse/JDK-8258657
>
> [JDK-82
1 - 100 of 2214 matches
Mail list logo
