Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-05 Thread Erik Helin
On 10/4/18 2:31 PM, Magnus Ihse Bursie wrote:>> 4 okt. 2018 kl. 10:57 skrev Martijn Verburg : I like this initiative. I'm wondering if some of these rules can be easily codified or written into a jcheck style checker (ccheck?) so that Authors can adhere to the conventions and not rely on a Human

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
On 2013-09-27, Joel Borggren-Franck wrote: > Hi > > Looks good. I've run the jdk_tools tests and these gets excluded. > > I'll sponsor this for you. Thanks! Erik > > cheers > /Joel > > On 2013-09-27, Erik Helin wrote: > > Hi all, > > &g

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
Hi all, Joel found a small issue with the patch, the paths were slightly wrong. An updated webrev is located at: http://cr.openjdk.java.net/~ehelin/8025427/webrev.01/ Thanks, Erik On 2013-09-27, Erik Helin wrote: > On 2013-09-26, Kumar Srinivasan wrote: > > Hi Erik, > > > &

Re: RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-27 Thread Erik Helin
On 2013-09-26, Kumar Srinivasan wrote: > Hi Erik, > > Looks good!, the bug must be tagged with keyword "noreg-build". Thanks! I've added the label to the bug. Erik > Kumar > > >Hi all, > > > >I need to exclude some tests due a recent change to jstat that caused to > >jstat to output the \ufff

RFR: 8025502: Exclude tests due to JDK-8025427

2013-09-26 Thread Erik Helin
Hi all, I need to exclude some tests due a recent change to jstat that caused to jstat to output the \ufffd for Double.NaN, which confused the tests. I am working on a solution to this, but in the meantime I would like to exclude the tests in order not cause unexpected failures. Webrev: http://cr

Re: RFR: 8014659: NPG: performance counters for compressed klass space

2013-09-17 Thread Erik Helin
m adding them as part this email to let everyone at serviceability-dev have a look. Thanks, Erik > /Staffan > > > On 10 sep 2013, at 18:56, Erik Helin wrote: > > > Hi all, > > > > this is the JDK part of the fix for 8014659 [0]. I've added the output > >

RFR: 8014659: NPG: performance counters for compressed klass space

2013-09-10 Thread Erik Helin
Hi all, this is the JDK part of the fix for 8014659 [0]. I've added the output of the compressed class space performance counters next to the metaspace output. I've also updated the jstat and jstatd tests to take the new output into account. Webrev: http://cr.openjdk.java.net/~ehelin/8014659/webr

Re: RFR: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace

2013-07-06 Thread Erik Helin
Thanks! Erik On 2013-07-05, Alan Bateman wrote: > On 05/07/2013 15:08, Erik Helin wrote: > >Hi all, > > > >still looking for a review for this testfix. Looping in > >hotspot-gc-...@openjdk.java.net as well. > > > It looks like okay to me and the comments make

Re: RFR: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace

2013-07-05 Thread Erik Helin
Hi all, still looking for a review for this testfix. Looping in hotspot-gc-...@openjdk.java.net as well. Thanks, Erik On 2013-07-01, Erik Helin wrote: > Hi all, > > this change updates MemoryTest.java to take the newly added Metaspace > and Compressed Class Space MemoryMXBeans into

Re: RFR: 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration

2013-07-02 Thread Erik Helin
On 2013-07-02, Alan Bateman wrote: > On 01/07/2013 16:32, Erik Helin wrote: > >Hi all, > > > >this change excludes the following two MemoryMXBean tests: > >- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh > >- java/lang/management/MemoryMXBean/MemoryTest.j

RFR: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace

2013-07-01 Thread Erik Helin
Hi all, this change updates MemoryTest.java to take the newly added Metaspace and Compressed Class Space MemoryMXBeans into account, as well as the new Metaspace Memory Manager. This change also removes the following two tests from ProblemList.txt since they are now passing again: -java/lang/mana

RFR: 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration

2013-07-01 Thread Erik Helin
Hi all, this change excludes the following two MemoryMXBean tests: - java/lang/management/MemoryMXBean/MemoryTestAllGC.sh - java/lang/management/MemoryMXBean/MemoryTest.java This is needed since a change in hotspot added a new memory pool for metaspace: > hg log hotspot-main/hotspot: > changese