On Thu, 2 Jun 2022 20:01:33 GMT, Claes Redestad wrote:
>> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 116:
>>
>>> 114: String CC = "string" + c;
>>> 115: String CCS= "string" + c + s;
>>> 116: String CSCC = "string" + s + "string" + c;
>>
On Thu, 2 Jun 2022 10:57:37 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the ro
On Wed, 1 Jun 2022 13:03:38 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the ro
On Wed, 1 Jun 2022 05:01:33 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/reflect/Member.java line 96:
>>
>>> 94: */
>>> 95: public default Set accessFlags() {
>>> 96: return Set.of();
>>
>> Is is not better
On Tue, 31 May 2022 17:26:35 GMT, Rémi Forax wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 32 additional commits
>> since
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Sun, 29 May 2022 14:46:39 GMT, Alan Bateman wrote:
> This patch adds an alternative virtual thread implementation where each
> virtual thread is backed by an OS thread. It doesn't scale but it can be used
> by ports that don't have continuations support in the VM. Aside from
> scalability,
On Fri, 27 May 2022 16:08:03 GMT, liach wrote:
> If `parameterList` is too slow for `List.of` copies the backing parameter
> types array, wouldn't calling
> `JavaUtilCollectionAccess::listFromTrustedArray` a better alternative, as it
> only allocates one wrapper and has better performance on `
On Tue, 24 May 2022 21:37:52 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add test for newHashSet and newLinkedHashSet
test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 360:
> 358:
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote:
> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>
> This is a non-final API that provides a gentle on-ramp to structure a task as
> a family of concurrent subtasks, and to coordinate the subtasks as a unit.
src/
On Fri, 20 May 2022 04:06:19 GMT, liach wrote:
>> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
>> `Class.forName(String)`. `make test
>> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
>> `LazyInitializationTest` failing the eager initialization c
On Fri, 13 May 2022 14:18:04 GMT, Roger Riggs wrote:
>> Well spotted, I don't think that change was intentionally.
>
> Ouch; Will fix:
>
> I took Alan's earlier comment literally:
>
> "This one can also be changed to:
>
> to =- (int) TimeUnit.NANOSECONDS.toMillis(adjust);"
@RogerRiggs
This al
On Fri, 13 May 2022 12:19:25 GMT, Сергей Цыпанов wrote:
>> Usually a method declares either no exception, or a couple of them. In the
>> first case `List.of()` doesn't allocate, in the second it allocates an
>> object with 1-2 fields but without an array, so `List.of()` is likely to be
>> more
On Thu, 10 Mar 2022 08:52:17 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of `Arrays.asList(
On Wed, 11 May 2022 16:30:41 GMT, Roger Riggs wrote:
>> PR#8599 8244681: proposes to add compiler warnings for possible lossy
>> conversions
>> From the CSR:
>>
>> "If the type of the right-hand operand of a compound assignment is not
>> assignment compatible with the type of the variable, a c
On Tue, 10 May 2022 14:46:56 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
On Mon, 9 May 2022 17:41:10 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Fri, 6 May 2022 06:39:59 GMT, XenoAmess wrote:
> > It would be nice if such a test could be written, but as it stands I think
> > that `Wrappers.java` test is too simplistic.
>
> Would adding `Wrappers.java` a method-name white-list mechanism suitable in
> this situation?
It should really
On Fri, 6 May 2022 11:51:46 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> co
Update
> src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template
>
>Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com>
> - Tweak support for Linker lookup
>Improve javadoc of SymbolLookup
> - Tweak Addressable javadoc
> -
On Fri, 29 Apr 2022 08:15:32 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 27 Apr 2022 03:28:09 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 77:
>>
>>> 75: E[] contents = (E[]) c.toArray();
>>> 76:
>>> 77: assertEquals(c.size(), given.length);
>>
>> I believe testng has the expected values in front in the `ass
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request incrementall
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Sat, 19 Mar 2022 19:46:19 GMT, ExE Boss wrote:
>> liach has updated the pull request incrementally with two additional commits
>> since the last revision:
>>
>> - merge branch 'identityhashmap-bench' of
>> https://github.com/liachmodded/jd
On Wed, 13 Apr 2022 14:21:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Tue, 12 Apr 2022 13:18:14 GMT, Jan Lahoda wrote:
>> This is a (preliminary) patch for javac implementation for the third preview
>> of pattern matching for switch (type patterns in switches).
>>
>> Draft JLS:
>> http://cr.openjdk.java.net/~gbierman/PatternSwitchPlusRecordPatterns/PatternSwit
On Fri, 15 Apr 2022 05:58:32 GMT, liach wrote:
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote:
>> I've stared at the javadoc for Class.isAssignableFrom and Class.isInstance
>> and if a non-null instance is used to get a non-null class they are PROBABLY
>> the same but it is far from clear. The implementations of both are at least
On Sat, 5 Mar 2022 19:54:44 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dist
On Tue, 12 Apr 2022 19:09:32 GMT, Daniel Jeliński wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 13 Apr 2022 09:49:04 GMT, Daniel Fuchs wrote:
>>> Not sure if that even matters - but there will be a slight change of
>>> behaviour here if `InternalLock.CAN_USE_INTERNAL_LOCK` is ever `false`.
>>> Instead of synchronizing on `in`, the `BufferedReader` will synchronize on
>>> `this`.
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote:
> 8284637: Improve String.join performance
The issue is now [JDK‑8284637](https://bugs.openjdk.java.net/browse/JDK-8284637
"[JDK‑8284637] Improve String.join performance").
-
PR: https://git.openjdk.java.net/jdk/pull/8169
On Mon, 11 Apr 2022 09:53:31 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/VarHandle.java line 2075:
>>
>>> 2073:
>>> 2074: @DontInline
>>> 2075: final void
>>> throwWrongMethodTypeException(VarHandle.AccessDescriptor ad) {
>>
>> This can actually be `priv
ns/op
>> VarHandleExact.generic_exactInvocationavgt 30 374.512 ? 3.154 ns/op
>> VarHandleExact.generic_genericInvocation avgt 30 757.054 ? 1.237 ns/op
>>
>>
>> No significant performance difference in normal mode.
>
> Claes Redestad has updated
On Mon, 11 Apr 2022 07:12:09 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/StructureViolationExceptions.java
>> line 81:
>>
>>> 79: Constructor ctor;
>>> 80: try {
>>> 81: Class exClass =
>>> Class.forName("jdk.incubator.concurrent.Struct
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote:
> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
> JDK version to target.
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot
ns/op
>> VarHandleExact.generic_exactInvocationavgt 30 374.512 ? 3.154 ns/op
>> VarHandleExact.generic_genericInvocation avgt 30 757.054 ? 1.237 ns/op
>>
>>
>> No significant performance difference in normal mode.
>
> Claes Redestad has updated the
On Wed, 30 Mar 2022 20:59:34 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 29 Mar 2022 15:56:37 GMT, Jim Laskey wrote:
>> doesn't the compiler (either javac or hotspot) automatically do that?
>
> Yes, the compilers handle this. I did however switch to
>
>
> primitiveCount != 0 ? new long[(primitiveCount + 1) /
> LONG_SLOTS] : null;
> do
On Tue, 29 Mar 2022 13:49:37 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require obje
On Mon, 28 Mar 2022 18:09:29 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require obje
On Fri, 25 Mar 2022 22:51:23 GMT, Naoto Sato wrote:
>> Proposing to deprecate the constructors in the `java.util.Locale` class.
>> There is already a factory method and a builder to return singletons, so
>> there is no need to have constructors anymore unless one purposefully wants
>> to creat
On Fri, 4 Mar 2022 17:44:44 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
>>
On Tue, 22 Mar 2022 13:32:18 GMT, liach wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix spacing on if(
>
> Just curious, when valhalla is out, does the specification of Carrier allow
> the implementation to move
On Tue, 22 Mar 2022 17:55:13 GMT, Mandy Chung wrote:
>> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
>> receiver check rather than NPE thrown by `Object::getClass`. The message of
>> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>> he
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote:
> Method `isAssignableFrom` is opposite: it brings unnecessary complexity in
> the code. And it's easy to confuse orders of parameters. Even JBS confirms
> that:
Maybe we should add `Class::isSubclassOf(Class that)` that performs
`that.
On Sun, 20 Mar 2022 21:31:15 GMT, Joe Darcy wrote:
> Small refactoring to use sealed classes in the MethodHandle implementation
> hierarchy.
>
> DelegatingMethodHandle is non-sealed rather than sealed since it has two
> subclasses, one defined as a nested class and only a separate type in the
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require obje
On Mon, 21 Mar 2022 06:29:53 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/lang/runtime/Carrier.java line 309:
>>
>>> 307: static {
>>> 308: LOOKUP = MethodHandles.lookup();
>>> 309: UNSAFE = Unsafe.getUnsafe();
>>
>> It might be better to use `java.
On Fri, 18 Mar 2022 16:16:31 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require obje
On Mon, 21 Feb 2022 23:36:19 GMT, liach wrote:
>> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
>> `merge` would throw CME if the functions modified the map itself, and there
>> are corresponding specification changes.
>
> liach has updated the pull request incrementall
On Fri, 18 Mar 2022 22:12:10 GMT, liach wrote:
>> Change `CallSite` to a sealed class, as `CallSite` is an abstract class
>> which does not allow direct subclassing by users per its documentation.
>> Since I don't have a JBS account, I posted the content for the CSR in a
>> GitHub Gist at http
On Sat, 19 Mar 2022 00:45:14 GMT, Stuart Marks wrote:
>> @stuart-marks Could you help me with this?
>>
>> In my JMH benchmark runs, I often find that ambient differences (from the
>> jdk processes, the random test data generated, etc.) hide the actual
>> performance difference caused by the pa
On Fri, 18 Mar 2022 15:22:48 GMT, Tyler Steele wrote:
>> src/java.base/share/native/libjava/ClassLoader.c line 104:
>>
>>> 102: // On AIX malloc(0) returns NULL which looks like an out-of-memory
>>> condition; so adjust it to malloc(1)
>>> 103: #ifdef _AIX
>>> 104: body = (jbyte *)m
On Mon, 14 Mar 2022 21:27:29 GMT, Joe Darcy wrote:
>> Improving the exception messages for out-of-supported-range array types.
>>
>> I'll update copyrights before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respo
On Tue, 15 Mar 2022 07:50:29 GMT, Peter Levart wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 179:
>
>> 177:
On Fri, 11 Mar 2022 22:49:25 GMT, Mandy Chung wrote:
>> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null
>> receiver check rather than NPE thrown by `Object::getClass`. The message of
>> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be
>> he
On Mon, 7 Mar 2022 11:22:29 GMT, Peter Levart wrote:
>>> It does because of the AccessFlags.MODULE constant.
>>
>> But that’s exactly what the unqualified `MODULE` identifier refers to, and
>> there’s no other bare `MODULE` identifier in scope that would shadow the
>> `AccessFlag.MODULE` const
On Tue, 1 Mar 2022 02:11:26 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dist
On Tue, 1 Mar 2022 02:22:49 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> `Objects.requireNonNull` may fail to be inlined. The call is expensive and
>> may lead to objects escaping to the heap while the null check is cheap and
>> is often elided. I have observed this when using the vector API when a c
On Fri, 25 Feb 2022 22:59:05 GMT, liach wrote:
>> src/java.base/share/classes/java/util/Random.java line 298:
>>
>>> 296: */
>>> 297: public static Random from(RandomGenerator random) {
>>> 298: return RandomWrapper.wrap(random);
>>
>> Might be good to check here or in the call
On Fri, 25 Feb 2022 23:27:45 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default me
On Thu, 24 Feb 2022 01:17:23 GMT, Joe Darcy wrote:
> It does because of the AccessFlags.MODULE constant.
But that’s exactly what the unqualified `MODULE` identifier refers to, and
there’s no other bare `MODULE` identifier in scope that would shadow the
`AccessFlag.MODULE` constant from the POV
On Wed, 23 Feb 2022 02:13:21 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Sat, 19 Feb 2022 05:51:52 GMT, Quan Anh Mai wrote:
> Should the other `requireNonNull` be `ForceInline` as well?
Probably yes.
-
PR: https://git.openjdk.java.net/jdk/pull/7543
On Thu, 17 Feb 2022 19:26:13 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Tue, 15 Feb 2022 21:09:57 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
On Mon, 14 Feb 2022 22:47:53 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Tue, 15 Feb 2022 06:56:51 GMT, Adam Sotona wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 55:
>
>> 53: */
>
74 matches
Mail list logo
