On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Mon, 3 Jan 2022 19:37:03 GMT, Naoto Sato wrote:
>> The proposed fix is to address the performance degradation caused by the fix
>> to JDK-8275721. Some amount of the degradation cannot be avoided as the
>> lookup now falls back up to the bundles at Locale.ROOT. However, by lowering
>> the
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote:
> This is a doc fix to `StringTokenizer`, where the original spec does not
> account for the delimiter's length in the case of a supplementary character.
> Corresponding CSR has been drafted:
>
On Mon, 6 Dec 2021 20:32:55 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for
On Sat, 4 Dec 2021 22:34:50 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for
On Tue, 30 Nov 2021 18:53:26 GMT, Joe Wang wrote:
> The result of Util.baseName(systemId) can be empty, causing the compiler to
> set an empty classname. Add a check to make sure it will not set the empty
> classname.
>
> Alternatively, it may report an error, but that woul
On Tue, 2 Nov 2021 17:31:40 GMT, Joe Wang wrote:
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
This pull request has now been integrated.
Changeset: b226ab99
Author: Joe Wang
URL:
https://git.openjdk.java.net/jdk/
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
Marked as reviewed by joehw (Reviewer).
-
PR:
On Tue, 30 Nov 2021 18:53:26 GMT, Joe Wang wrote:
> The result of Util.baseName(systemId) can be empty, causing the compiler to
> set an empty classname. Add a check to make sure it will not set the empty
> classname.
>
> Alternatively, it may report an error, but that woul
thout the provided classname (by using the default),
> adding a check is better than reporting an error.
>
> I've verified the patch with the proposed fix for JDK-8276241. Harold has
> also confirmed it fixes the tests in his builds.
Joe Wang has updated the pull request incrementa
The result of Util.baseName(systemId) can be empty, causing the compiler to set
an empty classname. Add a check to make sure it will not set the empty
classname.
Alternatively, it may report an error, but that would be disruptive. As the
transform can proceed without the provided classname (by
On Tue, 30 Nov 2021 18:00:38 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
&
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Add a statement to clarify the space of the properties
-
C
On Mon, 29 Nov 2021 18:48:45 GMT, Naoto Sato wrote:
> Fixing tests that fail at DST->STD offset transition. Simply skipping the
> tests on that occasion.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6598
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
>
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Wed, 10 Nov 2021 17:28:05 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update as commented
-
Changes:
- all:
On Thu, 18 Nov 2021 12:33:06 GMT, Alan Bateman wrote:
>> The wording is adjusted accordingly. Thanks.
>
>> The wording is adjusted accordingly. Thanks.
>
> Thanks for the update. The API additions (and clarification) look good to me.
> Do you have other reviewers for the impl change and tests?
On Fri, 12 Nov 2021 15:06:35 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source code in java.xml and
> java.xml.crypto. This scripts verifies that modifiers are in the "blessed"
> order, and fixes it otherwise. I have manually checked the changes made by
> the
On Wed, 10 Nov 2021 11:26:11 GMT, Alan Bateman wrote:
>> Yes. Made a clarification to the javadoc, and while we are here, to
>> setFeature method as well.
>
> One other suggestion for wording is to change:
> "A property set on the factory is effective to the XPath object created
> thereafter"
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
adjust wording
-
Changes:
- all: https://git.openjdk.ja
On Tue, 9 Nov 2021 19:34:50 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc clarification for setFeature and setProperty
>
> src/java.xml/share/classes/javax/xm
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Update as commented
-
Changes:
- all:
On Mon, 8 Nov 2021 11:38:52 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing IAE from the method signature; Update impl and test.
>
> src/java.xml
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
javadoc clarification for setFeature and setProperty
-
C
On Fri, 5 Nov 2021 20:46:42 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exception: changed from XPathFactoryConfigurationException to
>> IllegalArgumentException
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Removing IAE from the method signature; Update impl an
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Exception: changed from XPathFactoryConfigurationExc
On Fri, 5 Nov 2021 17:08:02 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 412:
>>
>>> 410: *
>>> 411: * @throws XPathFactoryConfigurationException if the property name
>>> is not
>>
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Exception: changed from XPathFactoryConfigurationExc
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Do you need to add test?
-
Marked as reviewed by joehw (Reviewer).
PR:
On Fri, 5 Nov 2021 11:02:37 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add default impl; Add tests.
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFa
On Fri, 5 Nov 2021 10:59:44 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add default impl; Add tests.
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFa
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
drop: in the XPath API
-
Changes:
- all:
On Tue, 2 Nov 2021 19:06:09 GMT, Anirvan Sarkar wrote:
> This fixes Properties.loadFromXML/storeToXML so that it works correctly for
> supplementary characters.
Looks good to me. Thanks Anirvan for fixing the issue.
-
Marked as reviewed by joehw (Reviewer).
PR:
On Wed, 3 Nov 2021 01:10:46 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
&g
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Add default impl; Add tests.
-
Changes:
- all:
Add setProperty/getProperty methods to the XPath API so that properties can be
supported in the future.
-
Commit messages:
- 8276141: XPathFactory set/getProperty method
Changes: https://git.openjdk.java.net/jdk/pull/6215/files
Webrev:
Hi Anirvan,
The change looks good to me. Please go ahead with creating a pull
request. It would be easier for reviewers to pull the patch and look at
it. On first glance, test "testStoreWithSupplementaryCharacters" may be
a bit sensitive to file format. It may be solved with a roundtrip
On Mon, 1 Nov 2021 18:31:17 GMT, Naoto Sato wrote:
> This is a leftover document fix to `String` class for the JEP 400.
> Corresponding CSR has also been drafted:
> https://bugs.openjdk.java.net/browse/JDK-8276238
Marked as reviewed by joehw (Reviewer).
-
PR:
On Sat, 23 Oct 2021 22:13:35 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is
On Wed, 20 Oct 2021 17:23:36 GMT, Naoto Sato wrote:
> During the review of JEP 400, a proposal to provide an overloaded method to
> `Charset.forName()` was suggested
> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
> PR is to implement the proposal. A CSR is also
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Wed, 13 Oct 2021 04:49:22 GMT, Joe Darcy wrote:
> After a refinement to the checks under development in
> https://github.com/openjdk/jdk/pull/5709, the new checks examine array types
> of serial fields and warn if the underlying component type is not
> serializable. Per the JLS, all array
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote:
> While working on tzdata2021c update, I noticed there is a dead code in
> `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for
> `endOfDay` for certain cases. These are no longer needed as JDK's code is
> already capable
On Thu, 30 Sep 2021 18:32:17 GMT, Alex Kasko wrote:
> I was working on backporting JDK-8268457 and found minor problems with the
> test introduced there:
>
> 1. `compareWith*` helper methods are used without `Assert.assertTrue()`
> wrapping, so they are effectively ignored
>
> 2.
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. There are more modern
> alternatives which perform better:
> 1. Plain String concatenation should be preferred
> 2. StringBuilder is a direct replacement to StringBuffer which generally have
On Tue, 28 Sep 2021 07:07:37 GMT, Joe Darcy wrote:
> Augmentations to javac's Xlint:serial checking are out for review (#5709) and
> the java.xml module would need some changes to pass under the expanded checks.
>
> The changes are to suppress warnings where non-transient fields in
>
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote:
>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed the unnecessary space
Marked as reviewed by joehw (Reviewer).
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
Marked as reviewed by joehw (Reviewer).
src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:
> 279: month = 13 - (xm % 12);
> 280: if (month ==
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line
>> 120:
>>
>>> 118: * the locale sensitive services separated by a comma. It is only read
>>> and cached at
>>> 119: * the initialization of this class, so the
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote:
>> Small spec clarification. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecting review comment.
Marked as reviewed by
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
> 118: * the locale sensitive services separated by a comma. It is only read
> and cached at
On Thu, 9 Sep 2021 12:25:17 GMT, Jovan Stevanovic
wrote:
>> GraalVM Native Image supports loading classes at runtime if they are known
>> during image build (class predefinition). This is achieved by the JVMTI
>> agent that registers dynamically generated classes in a regular HotSpot run.
>>
On Wed, 1 Sep 2021 13:28:34 GMT, Jovan Stevanovic
wrote:
> GraalVM Native Image supports loading classes at runtime if they are known
> during image build (class predefinition). This is achieved by the JVMTI agent
> that registers dynamically generated classes in a regular HotSpot run. The
>
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one
On Wed, 1 Sep 2021 13:28:34 GMT, Jovan Stevanovic
wrote:
> GraalVM Native Image supports loading classes at runtime if they are known
> during image build (class predefinition). This is achieved by the JVMTI agent
> that registers dynamically generated classes in a regular HotSpot run. The
>
On Tue, 7 Sep 2021 20:29:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one
On Wed, 1 Sep 2021 13:28:34 GMT, Jovan Stevanovic
wrote:
> GraalVM Native Image supports loading classes at runtime if they are known
> during image build (class predefinition). This is achieved by the JVMTI agent
> that registers dynamically generated classes in a regular HotSpot run. The
>
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Thu, 12 Aug 2021 19:27:42 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8263940 to address an issues when the default
>> file system provider is packaged as JAR file on class path.
>>
>> The patch also addresses the `@bug` line for JDK-8271194
>>
>> Mach5 Tier1
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. The root cause of this problem is
> that the currency for the country code `XK` is undefined because the country
> code is user-defined in the ISO 3166 standard. However, it is commonly used
> to
On Fri, 23 Jul 2021 17:27:27 GMT, Naoto Sato wrote:
> Please review this PR to introduce `java.time.Duration.isPositive()` method.
> A CSR is also drafted.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4892
On Fri, 2 Jul 2021 19:08:09 GMT, Brian Burkhalter wrote:
>> Right. I understand. The intention was, unlike the overridden method that
>> returns 0 if len == 0 and -1 if at the end of the stream, this method
>> returns -1 in both cases. A careful reader, after comparing both methods,
>> would
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 17:40:08 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 161:
>>
>>> 159: * Unlike the {@link InputStream#read(byte[],int,int) overridden
>>> method}
>>> 160: * of {@code InputStream}, this method returns {@code
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Wed, 30 Jun 2021 21:38:43 GMT, Naoto Sato wrote:
> A trivial typo fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/187
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
On Mon, 28 Jun 2021 18:45:31 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined wording.
>
> src/java.base/share/classes/java/util/Locale.java line 460:
>
>> 458: * back to that of before
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote:
> Fix a regression caused by the previous BCEL update. The issue was fixed in
> the current BCEL repo with a reversal of the previous code, adding back
> "gos.close();". Note however, doing so will result in a warning: [tr
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Fri, 25 Jun 2021 00:04:48 GMT, Brian Burkhalter wrote:
> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
> `read(byte[],int,int)` to return zero per the `InputStream` specification
> when the byte array actual or specified length is zero.
Marked as reviewed by joehw
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote:
> Fix a regression caused by the previous BCEL update. The issue was fixed in
> the current BCEL repo with a reversal of the previous code, adding back
> "gos.close();". Note however, doing so will result in a warning: [tr
ble resource. This fix calls
> finish() instead.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update LastModified
-
Changes:
- all: https://git.openjdk.java.net/jdk17/pull/141/files
- new: https://git.openjdk.java
Fix a regression caused by the previous BCEL update. The issue was fixed in the
current BCEL repo with a reversal of the previous code, adding back
"gos.close();". Note however, doing so will result in a warning: [try] explicit
call to close() on an auto-closeable resource. This fix calls
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Fri, 18 Jun 2021 20:27:13 GMT, Naoto Sato wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect the review comments
>
> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
On Thu, 17 Jun 2021 16:13:49 GMT, Joe Wang wrote:
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
This pull request has now been integrated.
Changeset: 7e03cf29
Author: Joe Wang
URL:
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
>
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
>
> The issue was that the attribute was processed before the variable was set
> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Thanks Naoto. Updated accor
The issue was that the attribute was processed before the variable was set
(e.g. m_preserveSpaces.push). Reversing the order fixed it.
-
Commit messages:
- 8265073: XML transformation and indentation when using xml:space
Changes: https://git.openjdk.java.net/jdk17/pull/89/files
On Fri, 11 Jun 2021 12:42:35 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else
On Mon, 7 Jun 2021 18:49:19 GMT, Joe Wang wrote:
> Fixes the addVariable/addParam methods in the SymbolTable to check types
> before casting.
This pull request has now been integrated.
Changeset: 1c3932f3
Author: Joe Wang
URL:
https://git.openjdk.java.net/jdk/
On Mon, 7 Jun 2021 18:49:19 GMT, Joe Wang wrote:
> Fixes the addVariable/addParam methods in the SymbolTable to check types
> before casting.
Thanks Naoto!
Yeah, we're trying to keep the code level at 8 at the moment unless necessary
(e.g. the optional elements for Deprecated), p
Fixes the addVariable/addParam methods in the SymbolTable to check types before
casting.
-
Commit messages:
- 8264766: ClassCastException during template compilation (Variable cannot be
cast to Param)
Changes: https://git.openjdk.java.net/jdk/pull/4398/files
Webrev:
On Fri, 4 Jun 2021 05:14:13 GMT, Joe Wang wrote:
> Revert changes in StreamResult.java made through
> https://github.com/openjdk/jdk/pull/4318 since it was creating a file stream
> on behalf of the Transformer, which resulted in a leaking file handle because
> the Transformer woul
On Fri, 4 Jun 2021 08:50:09 GMT, Daniel Fuchs wrote:
>> Revert changes in StreamResult.java made through
>> https://github.com/openjdk/jdk/pull/4318 since it was creating a file stream
>> on behalf of the Transformer, which resulted in a leaking file handle
>> because the Transformer would
Revert changes in StreamResult.java made through
https://github.com/openjdk/jdk/pull/4318 since it was creating a file stream on
behalf of the Transformer, which resulted in a leaking file handle because the
Transformer would only close files it opened.
This change instead replace the
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
This pull request has
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
Than
On Wed, 2 Jun 2021 18:17:43 GMT, Joe Wang wrote:
> Special characters are different in File and URI. Treat File input as File
> using FileInputStream instead of converting to an URI, but fall back to URI
> in case of error for compatibility (in error handling).
I tried, but g
Special characters are different in File and URI. Treat File input as File
using FileInputStream instead of converting to an URI, but fall back to URI in
case of error for compatibility (in error handling).
-
Commit messages:
- 8266019: StreamResult(File) writes to incorrect file
101 - 200 of 897 matches
Mail list logo
