On Fri, 13 Nov 2020 22:14:47 GMT, Michael Edgar
wrote:
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method s
(constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStreamFilterImpl`).
Michael Edgar has updated the pull request incrementally with one additional
commit since the last revision:
Apply comment, naming, and formatting suggestions
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1209/files
- new: https://gi
On Thu, 10 Dec 2020 02:07:14 GMT, Joe Wang wrote:
>> @JoeWang-Java - thanks for the additional feedback - all good. Do you
>> suggest I make them now in this PR? Just confirming before pushing the
>> change and dismissing your approval.
>
> Yes, please make the changes. Approval will be quick :
On Wed, 9 Dec 2020 21:39:26 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional test class clean-up
>
> Looks good! Some minor comments below.
@JoeWang-Ja
(constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStreamFilterImpl`).
Michael Edgar has updated the pull request incrementally with one additional
commit since the last revision:
Additional test class clean-up
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1209/files
- new: https://git.openjdk.java
On Mon, 7 Dec 2020 17:58:09 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Correct comments/annotations
>> - Update XML stream filter
(constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStreamFilterImpl`).
Michael Edgar has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains five commits:
- Correct comments/annotations
- Update XML stream filter test and comments
- Update JavaDoc code comment, move unit te
On Fri, 13 Nov 2020 22:14:47 GMT, Michael Edgar
wrote:
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method s
(constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStreamFilterImpl`).
Michael Edgar has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains two commits:
- Update test for jtreg
- 8255918: Throw XMLStreamExceptions from XMLStreamFilterImpl constructor
---
Allow `XMLStreamException` to be thrown to the application when a filtered
`XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
`XMLStreamReader`.
Note, this PR includes a method signature change (constructor of
`com.sun.org.apache.xerces.internal.impl.XMLStreamFilterImpl`
you already done it?
>
> Thanks,
> Joe
>
> On 11/5/20 1:35 PM, Michael Edgar wrote:
>
> The bug for this issue was accepted: JDK-8255918. I have made the change
> that I suggested in my original email and tested, but have not yet opened a
> pull request. Please let me
ease make sure to add a
> test case to illustrate the use case scenario.
>
> Thanks,
> Joe
>
> On 10/28/20 5:14 AM, Michael Edgar wrote:
> > Hi everyone,
> > I'm working on a project that makes use of the StAX API and an issue I
> have
> > encountered
Hi everyone,
I'm working on a project that makes use of the StAX API and an issue I have
encountered is that when wrapping an `XMLStreamReader` with a
`StreamFilter`, errors encountered in the setup are not thrown to the
caller. The source of the error could be any stream error that is triggered
as
13 matches
Mail list logo
