Re: RFEs implementing JEP 170

2013-05-08 Thread Neil Richards
May 2, 2013, at 7:13 AM, Neil Richards wrote: > > > > > Hi Lance, > > I've been trying to identify the Java bug ids for the RFEs which > > implement JEP 170 (which, from what I can tell, should be in OpenJDK 8 > > since milestone 6 [1]). > > The followi

RFEs implementing JEP 170

2013-05-02 Thread Neil Richards
Hi Lance, I've been trying to identify the Java bug ids for the RFEs which implement JEP 170 (which, from what I can tell, should be in OpenJDK 8 since milestone 6 [1]). Unlike most JEPs, the entry for 170 does not seem to hold references to these ids (only to the affected JSRs). Searching the m

Re: RFEs implementing JEP 170

2013-05-02 Thread Neil Richards
Oops, messed up my reply-to address. (I blame my newly upgraded system). Hopefully this should be better. Regards, Neil On Thu, 2013-05-02 at 12:02 +0100, Neil Richards wrote: > Hi Lance, > I've been trying to identify the Java bug ids for the RFEs which > implement JEP 170 (whic

Re: RFR: race with nested repos in hgforest.sh

2013-02-06 Thread Neil Richards
fwiw, I've always found the attempts by hg_forest to process things in parallel cause me more pain than it's worth. Marching through the repo locations serially in order might take a few moments longer elapsed time, but creates instantly understandable status / output / log and points for returnin

hg: jdk8/tl/jdk: 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour

2012-10-17 Thread neil . richards
Changeset: 5eed4a92ca8c Author:ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Ha

Re: RFR: 8000955: Hashtable.Entry.hashCode() no longer conforms to Map.Entry.hashCode()

2012-10-17 Thread Neil Richards
Now pushed to jdk8/tl/jdk [1]. Regards, Neil [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c On Wed, 2012-10-17 at 12:09 +0100, Alan Bateman wrote: > On 17/10/2012 00:12, Neil Richards wrote: > > Okay, you convinced me. :) > > > > Here's another webrev [

RFR: 8000955: Hashtable.Entry.hashCode() no longer conforms to Map.Entry.hashCode()

2012-10-16 Thread Neil Richards
-0700, Mike Duigou wrote: > On Oct 15 2012, at 20:53 , Neil Richards wrote: > > > Hi Mike, > > Thanks for the swift appraisal. > > > > Good suggestion to expand the test to cover other Map implementations - > > I'd toyed with the idea, but hadn't

Re: Hashtable.Entry.hashCode() no longer conforms to Map.Entry.hashCode()

2012-10-15 Thread Neil Richards
va > 7 backport. > > The code could be simplified by using Objects.hashCode() > > ie. > > return Objects.hashCode(key) ^ Objects.hashCode(value); > > Any objection to extending the test similar to Collisions.java to test other > Map classes? > > Mike >

Hashtable.Entry.hashCode() no longer conforms to Map.Entry.hashCode()

2012-10-15 Thread Neil Richards
Hi, I notice that the behaviour of java.util.Hashtable.Entry.hashCode() no longer conforms to the defined behaviour (in the Java API Javadoc [1]) for java.util.Map.Entry.hashCode() implementations. The code in Hashtable.Entry.hashCode() assumes that the value in Hashtable.Entry.hash will always be

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-16 Thread Neil Richards
On Thu, 2012-08-09 at 09:54 +0100, Alan Bateman wrote: > On 08/08/2012 17:10, Neil Richards wrote: > > : > > Hi Alan, > > Apologies, I confused myself about the Hotspot behaviour. > > (I was testing with 'nohup', but not checking the contents of > > &#

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-08 Thread Neil Richards
On Wed, 2012-08-08 at 13:28 +0100, Alan Bateman wrote: > On 07/08/2012 19:07, Neil Richards wrote: > > : > > Digging back into its history, I see that it all stems from running java > > under 'nohup' (e.g. 'nohup java ProgramWithShutdownHooks&'). >

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-07 Thread Neil Richards
On Tue, 2012-08-07 at 18:01 +0100, Alan Bateman wrote: > On 07/08/2012 15:02, Neil Richards wrote: > > : > > > From a Java Class Library point of view, it seems to me that the desire > > is to register shutdown hooks for any of these signals (HUP, INT and > >

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-07 Thread Neil Richards
On Tue, 2012-08-07 at 10:15 +0100, Alan Bateman wrote: > On 07/08/2012 04:35, David Holmes wrote: > > > > The change is harmless but as far as I can see you would have to > > customize the VM before this change would have any affect. The signals > > involved here are the SHUTDOWNn_SIGNAL values (

hg: jdk8/tl/jdk: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h

2012-01-31 Thread neil . richards
Changeset: 13978750cb87 Author:ngmr Date: 2012-01-31 10:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/l

Re: Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-31 Thread Neil Richards
On Tue, 2012-01-31 at 10:38 +, Alan Bateman wrote: > Thanks for getting this one fixed. One thing I notice is that your > change-set comment has you listed in the Contributed-by field and as the > author at the same time. Hi Alan, I had thought that always having "Contributed-by" was the cor

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-31 Thread Neil Richards
On Thu, 2012-01-26 at 17:45 +0800, Jonathan Lu wrote: > > > I think we forgot to create a bug for this, I've created it > now: > > 7133301: (process) UNIXProcess_md.c should include sys/wait.h > rather than wait.h > > Thanks a lot, Alan! > >

Re: Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-31 Thread Neil Richards
On Tue, 2012-01-24 at 10:15 +, Alan Bateman wrote: > Neil - are you still planning to push this to jdk8/tl? As it's > regression, albeit small, it seems like a good candidate for jdk7u too. > > -Alan. Hi Alan, Thanks to you and Mike for reviewing this change. I've now pushed this change up [

hg: jdk8/tl/jdk: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-31 Thread neil . richards
Contributed-by: Neil Richards ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/UniqueNullValue.java

Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-09 Thread Neil Richards
Hi all, When proposing the change for 6312706 [1], I erroneously managed to convince myself (and others!) that it would be safe to use 'new Integer(0)' for java.util.EnumMap.NULL (the object used to mark null values for entries in the map) [2]. This was on the basis that I thought it was only comp

Re: Add Look&Feel support for AIX platform

2011-12-13 Thread Neil Richards
On Tue, 2011-12-13 at 14:42 +, Neil Richards wrote: > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards > > wrote: > > On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wr

Re: Add Look&Feel support for AIX platform

2011-12-13 Thread Neil Richards
On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards > wrote: > On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote: > > Hi, > > > > > >I'm not sure what t

Re: Try to make OSInfo class recognize AIX platform

2011-12-12 Thread Neil Richards
On Fri, 2011-12-09 at 15:00 +0800, Sean Chou wrote: > Hi all, > > I reported a bug(rrf) to request that OSInfo class recognizes AIX > platform. > As we know there are more platforms supporting java than platforms supported > by openjdk. So I think OSInfo can add the feature to recognize these

hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH

2011-12-12 Thread neil . richards
Changeset: c508f38245f8 Author:ngmr Date: 2011-12-12 11:41 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/sola

Re: Add Look&Feel support for AIX platform

2011-12-12 Thread Neil Richards
On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote: > Hi, > > >I'm not sure what to do for it next, shall I create a bug for it > now ? But I > don't think the bug system support AIX platform. I remembered it > would > report something like "we are not supporting the platform". > Hi Sean,

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-28 Thread Neil Richards
On Thu, 2011-11-24 at 13:04 +, Alan Bateman wrote: > On 24/11/2011 11:15, Neil Richards wrote: > > : > > > > > > If I'm correct on this, then I think my suggested change [2] is still > > good to go. > > Please speak up if there remain issues with it.

hg: jdk8/tl/jdk: 7094995: Trailing daemon thread causes continuous GC in agentvm mode

2011-11-28 Thread neil . richards
, chegar, dholmes, darcy Contributed-by: Neil Richards ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java

hg: jdk8/tl/jdk: 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found

2011-11-28 Thread neil . richards
Changeset: 955aae8c1106 Author:ngmr Date: 2011-11-24 11:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/955aae8c1106 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solari

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-24 Thread Neil Richards
On Thu, 2011-11-24 at 11:22 +1000, David Holmes wrote: > Hi Joe, > > On 24/11/2011 2:33 AM, Joe Darcy wrote: > > On 11/22/2011 9:57 PM, David Holmes wrote: > >> On 22/11/2011 9:51 PM, Neil Richards wrote: > >>> I've also converted the t

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-23 Thread Neil Richards
On Tue, 2011-11-22 at 19:09 +, Chris Hegarty wrote: > On 11/22/11 06:56 PM, Alan Bateman wrote: > > On 22/11/2011 17:22, Neil Richards wrote: > >> : > >> > >> Can you tell me, when jtreg decides to fire an interrupt at a test, has > >> it already

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 17:22 +, Neil Richards wrote: > On Tue, 2011-11-22 at 16:56 +, Chris Hegarty wrote: > > This change does look good. > > > > Not directly related to your changes Neil, and I know we swallow > > InterruptedException in many tests, bu

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 16:56 +, Chris Hegarty wrote: > This change does look good. > > Not directly related to your changes Neil, and I know we swallow > InterruptedException in many tests, but does it make sense to set > keepRunning = false if the GcInducingThread is interrupted? > > jtreg

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 15:49 +, Alan Bateman wrote: > On 22/11/2011 11:51, Neil Richards wrote: > > Hi all, > > > > I've created a webrev [1] to address the problem reported in bug > > 7094995, where the ClearStaleZipFileInputStreams testcase leaves a > >

Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
Hi all, I've created a webrev [1] to address the problem reported in bug 7094995, where the ClearStaleZipFileInputStreams testcase leaves a lingering GC inducing thread running after the test ends (when run in agentvm mode), as spotted by Alan and mentioned in another conversation [2]. It modifie

hg: jdk8/tl/jdk: 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN)

2011-11-22 Thread neil . richards
Changeset: ee2fa62fb09f Author:ngmr Date: 2011-11-22 09:51 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil

hg: jdk8/tl/jdk: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo

2011-11-22 Thread neil . richards
Changeset: 81987765cb81 Author:ngmr Date: 2011-11-11 14:40 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/jav

Re: Code Review Request for 6578042

2011-11-14 Thread Neil Richards
On Mon, 2011-11-14 at 13:45 +, Alan Bateman wrote: > On 14/11/2011 13:19, Neil Richards wrote: > > : > > > > Of course, there are certain situations where the Java documentation > > guides you to specify property values which are not String objects. > > >

Re: Code Review Request for 6578042

2011-11-14 Thread Neil Richards
On Mon, 2011-11-14 at 10:28 +1000, David Holmes wrote: > On 12/11/2011 10:14 PM, Alan Bateman wrote: > > On 11/11/2011 19:37, Darryl Mocek wrote: > >> Returning null if the value is not a String gives the impression that > >> there was no property with that key when the property may have been > >>

Re: jcheck conflict in jdk8/tl/jdk and awt repos: same CR # 7100054 used in two different changesets (one in tl, the other in awt forest)

2011-10-27 Thread Neil Richards
On Tue, 2011-10-25 at 11:34 +0100, Alan Bateman wrote: > On 25/10/2011 01:21, Lana Steuck wrote: > > To: TL and Awt teams > > What: we have a jcheck conflict in jdk8/tl/jdk and jdk8/awt/jdk > > repos: > > same Bugid # 7100054 used in two different changesets (one in > > tl/jdk, the other in awt

Re: Request for review: [NEW BUG] Printer spoolers ignore result from spool process

2011-10-20 Thread Neil Richards
On Thu, 2011-10-20 at 11:40 -0700, Phil Race wrote: > Neil, > > Can you please redirect this over to 2d-dev. > Printing has nothing to do with core-libs. Its Java2D. > Oops, sorry folks. I'll move my suggestion onto a 2d base and go hassle them with it. Thanks for the pointer. Regards, Neil

Request for review: [NEW BUG] Printer spoolers ignore result from spool process

2011-10-20 Thread Neil Richards
Hi all, Whilst trying to debug a printing problem, I noticed that the (Unix and PostScript) printer spoolers in Java do not check what the result is of trying to launch the OS print spooler command (often 'lpr' or 'lp'). As a result, if that exec'd command fails for any reason, that result (and th

Re: Add Look&Feel support for AIX platform

2011-10-20 Thread Neil Richards
On Tue, 2011-10-18 at 15:53 +0800, Sean Chou wrote: > Hi all, > > > This is a simple patch to add LookAndFeel support for AIX platform > to help bring > up GUI application. > > > This is part of the series of AIX patches. > -- > Best Regards, > Sean Chou > > For ease of review, I'

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-20 Thread Neil Richards
On Thu, 2011-10-13 at 18:34 +0100, Chris Hegarty wrote: > Neil, > > All builds complete with your patches (on top of the latest JDK8 TL > repo) from : >http://cr.openjdk.java.net/~ngmr/ojdk-243.1/webrev.01/ >http://cr.openjdk.java.net/~ngmr/ojdk-243.2/webrev.00/ > > solaris_sparc_5.10-pr

hg: jdk8/tl/jdk: 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h

2011-10-20 Thread neil . richards
Changeset: c3da0672a882 Author:ngmr Date: 2011-10-13 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3da0672a882 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-13 Thread Neil Richards
On Thu, 2011-10-13 at 14:03 +0100, Chris Hegarty wrote: > I think I seen in a previous mail that you didn't have access to Solaris > machines? I'll grab your patch, apply to a latest jdk8 TL repo and do > some sanity builds on Solaris if you like? > > -Chris. > Hi Chris, Thank you, that would

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-13 Thread Neil Richards
On Thu, 2011-10-13 at 15:11 +1000, David Holmes wrote: > Hi Charles, > > On 13/10/2011 2:54 PM, Charles Lee wrote: > > Thanks Alan. Below is the patch I am failed to attach. It is trivial... > > Do you need someone to sponsor this for you, or are you able to drive > this via other IBM folk that

hg: jdk8/tl/jdk: 2 new changesets

2011-10-10 Thread neil . richards
Changeset: dd55467dd1f2 Author:ngmr Date: 2011-10-10 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2 7099119: Remove unused dlinfo local variable in launcher code Reviewed-by: ohair, chegar, ngmr Contributed-by: Steve Poole ! src/solaris/bin/java_md.c Cha

Re: Request for review - removal of unused dlinfo variable in java_md.c

2011-10-10 Thread Neil Richards
On Mon, 2011-10-10 at 16:27 +0200, Kelly O'Hair wrote: > This patch looks fine to me. > > Have you been working with anyone to get your contributions pushed in? > > -kto > Hi Kelly, I've been looking for something with which to test my untold *powers* as a committer, so can I swipe this one to

Re: Request for review - removal of unused dlinfo variable in java_md.c

2011-10-10 Thread Neil Richards
On Mon, 2011-10-10 at 13:58 +0100, Steve Poole wrote: > hi all, > > Please find attached a trivial patch to remove an unused variable in > jdk/src/solaris/bin/java_md.c > > The present of the variable causes the AIX build to fail since Dl_info > is not supported on AIX.The other use of Dl_inf

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-03 Thread Neil Richards
On Wed, 2011-08-03 at 11:03 -0700, Alexandre Boulgakov wrote: > Please see my responses inline. > > Thanks! > -Sasha > > On 8/2/2011 9:13 PM, Xuelei Fan wrote: > > . com/sun/jndi/toolkit/dir/SearchFilter.java > > 451 for (NamingEnumeration ve = attr.getAll(); > > 452 ve.

Request for review: #include ANSI headers for functions referred to in jli_util.h

2011-08-03 Thread Neil Richards
this change for committal. Thanks, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Ric

Re: Request for review: Make MethodHandleProxies.getSingleMethod() agnostic of ordering of methods returned from Class.getMethods()

2011-08-03 Thread Neil Richards
ed in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1311156497 -3600 # Branch ojdk-131 # Node ID e5e3c6df9f8b37e936c9cb00982c1cb92751f87e # Parent 8bbea505b060fc7c97d9c241f8531a

Request for review: Make MethodHandleProxies.isSingleMethod() agnostic of ordering of methods returned from Class.getMethods()

2011-07-20 Thread Neil Richards
email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1311156497 -3600 # Branc

Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

2011-04-29 Thread Neil Richards
On 28 April 2011 12:01, Alan Bateman wrote: > I skimmed through the webrev and I agree this is a better approach. I will > try to do a detailed review before Monday. It would be great if others on > the list could jump in and help too as we are running out of time. > > Neil - I don't know if you'v

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-26 Thread Neil Richards
On 18 April 2011 18:32, Xueming Shen wrote: >  Hi Neil, > > All tests passed. > > I'm starting to push your last patch. I generated the webrev at > > http://cr.openjdk.java.net/~sherman/7031076/webrev/ > > It should be exactly the same as your last patch. > > Thanks, > Sherman Hi Sherman, Thanks

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-26 Thread Neil Richards
d in a timely manner. Please get back to me with any comments, questions or suggestions on this, Thanks, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-04-26 Thread Neil Richards
ve: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1302196316 -3600 # Branch j6597112 # Node ID cfa1

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-26 Thread Neil Richards
On Mon, 2011-04-18 at 13:33 +0100, Neil Richards wrote: > I think it's worthwhile trying to clear 'streams' entries from a > finalize method in ZFIIS, to help ensure they are cleared in a timely > manner. In fact, it's probably clearer (more closely following the

Request for review: Optimize common-case UTF8 path for native ZipFile.getEntry calls

2011-04-25 Thread Neil Richards
om Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1303394058 -3600 # Branch ojdk-121 # Node ID e5c8d8da677bce826b6bafc379d67c5d7775e7f6 # Parent 60d3d5

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-18 Thread Neil Richards
On 18 April 2011 17:49, Xueming Shen wrote: > If you are now explicitly synchronize on "streams" everywhere, I don't think > we even need a copy > at close(). I thought that the copy is needed so that the Map being iterated over (in close()) is not able to be modified by the same thread via the c

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-18 Thread Neil Richards
Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1300289208 0 # Branch zi

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-04-14 Thread Neil Richards
Hi Alan, Thanks for making those modifications. I'm happy with how they look. I'm also happy with the suggested comment being added. I'm away from a computer until the weekend, so can't make the modification myself at the moment, but I'm happy if you want to proceed in getting it in. Thanks again

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-11 Thread Neil Richards
On Sun, 2011-04-10 at 18:28 +0100, Neil Richards wrote: > With releaseInflater() being driven from the cleanup of stale 'streams' > entries, it no longer needs to be called from ZFIIS.close(), so, > instead, only Inflater.reset() is called from there (providing the > i

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-08 Thread Neil Richards
Hi David, You are correct that the ZipFileInflaterInputStream code is not inherently thread-safe (without user synchronization), but then, the contract of InputStream does not require it to be (as Sherman previously observed on this thread). The previous suggested fix caused ZFIIS to interact wit

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-08 Thread Neil Richards
e suggestions (and rebased off jdk7-b136), Let me know if you need anything else to progress this fix forward, Thanks, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, Nort

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-07 Thread Neil Richards
advice in this, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 13002

Re: Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-04-05 Thread Neil Richards
On 31 March 2011 20:59, Mike Duigou wrote: > I will make the modification as Jason suggested and commit this issue today. > > Mike Can you point me to where the change is for this issue? (I can't see it in the jdk7/tl/jdk repository) Thanks, Neil -- Unless stated above: IBM email: neil_richar

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread Neil Richards
On Sat, 2011-04-02 at 09:17 +1000, David Holmes wrote: > Xueming Shen said the following on 04/02/11 05:07: > > On 04/01/2011 09:42 AM, Neil Richards wrote: > >> On Wed, 2011-03-30 at 13:31 -0700, Xueming Shen wrote: > >>> Isn't it true that when the fina

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-01 Thread Neil Richards
d Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1300289208 0 # Branch zip-heap # Node ID 4aa4844cd3b9ae747ad736469134a8828ebeb652 # Parent 554adc

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-03-30 Thread Neil Richards
case. Please find below an updated changeset, with this change made and the bug number filled in. Hope this helps to clarify things, Thanks again, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 74159

Re: Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-03-30 Thread Neil Richards
On Tue, 2011-03-29 at 15:09 -0700, Mike Duigou wrote: > I think your suspicion is correct that the anonymous inner Object is > used rather than new Object so that it can be distinguished more > easily in heap dumps or via other tools. I would be fine with using > Integer(0) as the sentinel value. I

Re: Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-03-26 Thread Neil Richards
ered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1298984147 0 # Branch j6312706 # Node ID bc07c38bac7cbd7ca47bbc382557831ec5c2100c # Parent 554adcfb615e63e62af530b1c10fcf7

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-03-24 Thread Neil Richards
eil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1298369045 0 # Branch j6597112 # Node ID 0c22e02a9016bd340e2182e96

Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-03-23 Thread Neil Richards
Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU # HG changeset patch # User Neil Richards , # Date 1298984147 0 # Branch j6312706 # Node ID 98616c2a19c4884bfadbc1dba032c

Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-03-23 Thread Neil Richards
bug_id=6735255 [2] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/49478a651a28 -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3A

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-03-09 Thread Neil Richards
Hi Alan, thanks for looking at this. On 9 March 2011 10:45, Alan Bateman wrote: > You've changed WeakRef so that an instance is initially "strong". Does this > have implications for other uses of WeakRef? I see one in > sun.rmi.transport.ObjectTable for example. You'll notice that the WeakRef co

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-03-08 Thread Neil Richards
mber 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -- # HG changeset patch # User Neil Richards , # Date 1298369045 0 # Branch j6597112 # Node ID 99d99bb9e27da0dccfbd7788682f31fb05a1b119 # Parent 6bbc7a4734952ae7604578f270e1566639fa8752 6597112: referential in

Request for review: 6597112: Referential integrity loophole during remote object export

2011-03-08 Thread Neil Richards
Bug 6597112 [1] reports that the implementation of java.rmi.server.UnicastRemoteObject.exportObject(Remote) has a window in which the Remote object given to the method is only weakly referenced by the implementation. Due to this window, an unfortunately timed GC cycle can free up the Remote object

Re: Making java.util.Iterator.remove() for the iterators for EnumSet more resilient

2011-03-03 Thread Neil Richards
On 3 March 2011 15:06, Alan Bateman wrote: > I think the main thing with this proposal is getting agreement that it is > the right thing to do. On one hand it avoids the set getting corrupted. On > the other hand it's masking a problem and really part of a bigger issue. > This isn't really my area

Re: Making java.util.Iterator.remove() for the iterators for EnumSet more resilient

2011-03-03 Thread Neil Richards
Please advise me on what steps remain for this change to be committed. Thanks, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6

Re: Making java.util.Iterator.remove() for the iterators for EnumSet more resilient

2011-02-11 Thread Neil Richards
Please find an updated webrev zip file with corrected license text and references to the RFE number, 7014637, in the testcases. Thanks, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered o

Re: Making java.util.Iterator.remove() for the iterators for EnumSet more resilient

2011-01-27 Thread Neil Richards
On 26 January 2011 01:57, Joshua Bloch wrote: > I have serious reservations about this. It would be the first time (to my > knowledge) that we deliberately swept a concurrent modification under the > rug.  If we go to the effort of detecting it (which you're doing), the least > we should do is to

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2010-12-22 Thread Neil Richards
On 22 December 2010 09:38, David Holmes wrote: > Hi Neil, > > Any chance you can generate webrevs as mentioned in: > > http://openjdk.java.net/guide/changePlanning.html Hi David, >From the documentation, I don't believe I can do so yet. http://cr.openjdk.java.net/ (referred to from the page you

Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2010-12-21 Thread Neil Richards
Please find attached a changeset to address the problem reported in bug 6927486, "Deadlock in legacy Hashtable writeObject()". The problem reported is similar to one found in java.util.Vector, for which a fix is also currently under review (http://mail.openjdk.java.net/pipermail/core-libs-dev/2010

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-21 Thread Neil Richards
On 16 December 2010 16:24, Neil Richards wrote: > On 16 December 2010 13:01, Alan Bateman wrote: >> On the test case, it needs the GPL header. There are templates in the >> repository and you'll also see tests contributed by RedHat and Google if >> that helps. > >

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-16 Thread Neil Richards
On 13 December 2010 20:04, Neil Richards wrote: > On 13 December 2010 18:46, Alan Bateman wrote: >> I haven't looked at your patch in detail yet but I suspect there may be >> similar issues in other places (like j.u.Hashtable) once you are done with >> Vector. >

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-16 Thread Neil Richards
On 16 December 2010 13:01, Alan Bateman wrote: > I've looked at the patch and don't see anything obviously wrong. I think > Mike might is looking at it too. It clearly comes with a performance cost of > course. I've tried to write the fix so that the cost is minimized. > One small comment is tha

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-13 Thread Neil Richards
On 13 December 2010 19:46, wrote: > (It would make things clearer if Neil had used an ibm.com address, but >  perhaps he has reasons not to do so.) I'm sorry for sowing confusion :-( I'm using a different email address is mainly for easy book-keeping (on my part) - to separate OpenJDK conversat

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-13 Thread Neil Richards
On 13 December 2010 18:46, Alan Bateman wrote: > This is the right place, welcome! > First we should probably establish if you are a contributer or not. Your > mail hints that you are in IBM but it's impossible to verify from the mail > address. Hi Alan, I've sent you and Mike a separate email fr

Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2010-12-13 Thread Neil Richards
@summary Serializing Vector objects which refer to each other should not be able to deadlock. + * @author Neil Richards + */ + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.ObjectOutputStream; +import java.io.Serializable; +import java.util.ArrayList; +i