Re: PPC Linux 64 needs -fsigned-char option for gcc

2013-01-11 Thread Sean Chou
UIRED_ppc64 += -m64 > LDFLAGS_COMMON_ppc64+= -m64 -L/lib64 -Wl,-melf64ppc > > Notice that we don't set '-D_BIG_ENDIAN' because it is the default. > > Didn't you observed your problems with jdk7 on Linux/PPC? I think we > should patch JDK7 first if this is really n

PPC Linux 64 needs -fsigned-char option for gcc

2012-12-21 Thread Sean Chou
) ifeq ($(ZERO_ENDIANNESS), little) -- Best Regards, Sean Chou

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-14 Thread Sean Chou
p; regards > Jonathan > > > On 11/14/2012 10:23 AM, Sean Chou wrote: > >> Thanks Alan and Chris. >> >> >> On Tue, Nov 13, 2012 at 7:21 PM, Chris Hegarty >> **wrote: >> >> Sean, >>> >>> Looks good to me. Thanks for updating

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-13 Thread Sean Chou
Thanks Alan and Chris. On Tue, Nov 13, 2012 at 7:21 PM, Chris Hegarty wrote: > Sean, > > Looks good to me. Thanks for updating the test. > > -Chris. > > > On 11/13/2012 03:17 AM, Sean Chou wrote: > >> Hi Alan, >> >> Here is the updated webrev: &g

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-12 Thread Sean Chou
Hi Alan, Here is the updated webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.03/ . On Mon, Nov 12, 2012 at 6:00 PM, Alan Bateman wrote: > On 12/11/2012 09:08, Sean Chou wrote: > >> Hi , >> >> I didn't realize that rt.jar would miss before. The testcase i

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-12 Thread Sean Chou
houyx/7201156/webrev.02/ . On Fri, Nov 9, 2012 at 10:13 PM, Alan Bateman wrote: > On 09/11/2012 04:31, Sean Chou wrote: > >> Hello Chris, Alan, and Xueming, >> >> I added the testcase, please take a look. >> >> webrev: >> http://cr.openjdk.java.net/~**zhouy

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-08 Thread Sean Chou
n test to verify > this change ( so an future regression in behavior gets caught early ). You > could call sun.tools.jar.Main directly passing suitable streams to check > the output. > > -Chris. > > > On 07/11/2012 08:31, Sean Chou wrote: > >> Hello, >> >>

Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-07 Thread Sean Chou
Hello, This is the suggested fix described in sun bug 7201156 page. Please take a look. sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156 webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/ -- Best Regards, Sean Chou

Re: RFR: 6519127 : user.home property not set correctly

2012-10-23 Thread Sean Chou
A txt file if the previous mail format is bad. Forget to attach with previous mail. On Tue, Oct 23, 2012 at 3:52 PM, Sean Chou wrote: > Hi Alan, > > I did some search and wrote a brief, hope it helps. > > = > > A brief about home di

Re: RFR: 6519127 : user.home property not set correctly

2012-10-23 Thread Sean Chou
similar to act as a user home. And the current implementation is using the user profile directory(the parent directory of Desktop, which is the profile directory by default settings). About the modified in webrev, I think it is just removing an old hack which is obsoleted since win95. On Fri, Oct 19

RFR: 6519127 : user.home property not set correctly

2012-10-19 Thread Sean Chou
/view_bug.do?bug_id=6519127 Webrev: http://cr.openjdk.java.net/~zhouyx/6519127/webrev.00/ Please take a look. -- Best Regards, Sean Chou

TreeMap.putAll has undocumented behavior which has different side effect based on parameter

2012-10-14 Thread Sean Chou
p(); TreeMap treeMap2 = new MyTreeMap(); System.out.println("putAll treemap:"); treeMap.putAll(tm); System.out.println("putAll hashmap:"); treeMap2.putAll(hm); } } -- Best Regards, Sean Chou

Request for review: updated 2 files to use generic type

2012-05-02 Thread Sean Chou
ev is: http://cr.openjdk.java.net/~zhouyx/OJDK-389/webrev.00/ Please take a look. -- Best Regards, Sean Chou

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-19 Thread Sean Chou
Thanks David and Alan, shall I find some one to commit it ? On Thu, Apr 19, 2012 at 8:53 AM, David Holmes wrote: > On 19/04/2012 4:05 AM, Alan Bateman wrote: > >> On 18/04/2012 14:02, David Holmes wrote: >> >>> On 18/04/2012 10:23 PM, Sean Chou wrote: >>>

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-18 Thread Sean Chou
Hi David, Alan, So is the patch acceptable ? It's webrev: http://cr.openjdk.java.net/~zhouyx/7159982/webrev.02/ On Wed, Apr 18, 2012 at 12:15 PM, David Holmes wrote: > On 18/04/2012 1:15 PM, Sean Chou wrote: > >> Hi David, >> >> The current implementation u

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread Sean Chou
> Hi Sean, > > > On 18/04/2012 12:37 PM, Sean Chou wrote: > >> To free the error string in ZIP_Open is a result of discussion with >> hotspot. They said the error string is never used and they do not want >> to do the free work in hotspot for ZIP_Open... >>

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread Sean Chou
as been lost in ZIP_Open > > David > > > On 13/04/2012 1:14 AM, Sean Chou wrote: > >> Hi Alan, >> >> I made a new webrev, added the comments and the 2 other modification. >> It's now : >> http://cr.openjdk.java.net/~**zhouyx/7159982/webrev.02/

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-12 Thread Sean Chou
Hi Alan, I made a new webrev, added the comments and the 2 other modification. It's now : http://cr.openjdk.java.net/~zhouyx/7159982/webrev.02/ On Thu, Apr 12, 2012 at 4:24 PM, Alan Bateman wrote: > On 12/04/2012 06:40, Sean Chou wrote: > >> Hi Alan, >> >>Ma

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-11 Thread Sean Chou
On 11/04/2012 15:58, Sean Chou wrote: > >> Hi hotspot guys, >> >>Would any one like to take a look at this? I'm trying to fix a >> potential race in ZIP_Open, it is found classLoader.cpp uses this function. >> So a webrev for hotspot is made as well, but I

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-11 Thread Sean Chou
s not exist in hotspot yet, shall I add it to the patch too ? On Tue, Apr 10, 2012 at 4:10 PM, Alan Bateman wrote: > On 10/04/2012 08:10, Sean Chou wrote: > >> >>And it is found that hotspot calls ZIP_Open through (*ZipOpen) in file >> classLoader.cpp .So I also made a

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-10 Thread Sean Chou
mx.de>, David Holmes > > ! src/share/classes/java/util/**AbstractCollection.java > + test/java/util/**AbstractCollection/**ToArrayTest.java > > Please verified it. > > Thank you all for contributing and reviewing this change. Thank you Mike > and Joe for helping my committing this patch. >

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-10 Thread Sean Chou
://mail.openjdk.java.net/pipermail/core-libs-dev/2012-April/009766.html Link to the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159982 On Mon, Apr 9, 2012 at 6:01 PM, Alan Bateman wrote: > On 09/04/2012 08:53, Sean Chou wrote: > >> Hi all, >> >> I

Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-09 Thread Sean Chou
string on stack and return a dup one. Please take a look and give some comments, thanks. -- Best Regards, Sean Chou

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-01 Thread Sean Chou
/2012-March/009512.html On Sun, Apr 1, 2012 at 11:25 AM, David Holmes wrote: > Simplified testcase below. > > Let's finalise this please. > > Thanks, > David > > > On 1/04/2012 1:08 PM, Sean Chou wrote: > >> Hi Ulf, >> >> This is a

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-31 Thread Sean Chou
Hi Ulf, This is a regression testcase, there is no performance issue or future refactoring. Please wait for David's comments. On Sun, Apr 1, 2012 at 7:22 AM, Ulf Zibis wrote: > Hi Sean, > > thanks for your effort. > > Am 31.03.2012 11:43, schrieb Sean Chou: &

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-31 Thread Sean Chou
;>> >>> Also in the name setPseudoConcurrentSizeCourse the word "Course" >>> doesn't fit. I'm not sure what you were meaning here? Perhaps just >>> modifySize or emulateConcurrentSizeChange ? >>> >>> Thanks, >>> David >>> >>> -- Best Regards, Sean Chou

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-30 Thread Sean Chou
etPseudoConcurrentSizeCourse the word "Course" doesn't >> fit. I'm not sure what you were meaning here? Perhaps just modifySize or >> emulateConcurrentSizeChange ? >> >> Thanks, >> David >> >> -- Best Regards, Sean Chou

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-28 Thread Sean Chou
gt; >>> Also in the name setPseudoConcurrentSizeCourse the word "Course" >>> doesn't fit. I'm not sure what you were meaning here? Perhaps just >>> modifySize or emulateConcurrentSizeChange ? >>> >>> Thanks, >>> David >>> >>> -- Best Regards, Sean Chou

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-25 Thread Sean Chou
Hi Ulf, Comment inlined. On Sat, Mar 24, 2012 at 5:09 AM, Ulf Zibis wrote: > Hi Sean, > > Am 23.03.2012 07:45, schrieb Sean Chou: > >> Hi Ulf, >> >>I'm sorry I didn't quite get your testcase. >> > This is not a testcase, just a draft

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-22 Thread Sean Chou
ike to modify. On Fri, Mar 23, 2012 at 5:57 AM, Ulf Zibis wrote: > Hi Sean, > > bad news ;-) ... > > Am 22.03.2012 08:28, schrieb Sean Chou: > >> Hi Ulf, >> >>I'm glad you agreed my suggestion. >> >> To all: >>Can this patch b

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-22 Thread Sean Chou
Hi Ulf, I'm glad you agreed my suggestion. To all: Can this patch be committed as it has been reviewed by David Holmes and Mike Duigou, and Ulf also says agreed ? On Thu, Mar 22, 2012 at 3:05 AM, Ulf Zibis wrote: > Am 19.03.2012 05:53, schrieb Sean Chou: > >> Hi

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-18 Thread Sean Chou
Hi Ulf, I hope following comments can help reduce your concern. On Thu, Mar 15, 2012 at 6:27 PM, Ulf Zibis wrote: > Thanks for your comments too. > > Am 14.03.2012 05:23, schrieb Sean Chou: > > Thanks for your comments, I have different opinions. >> >> About p

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-13 Thread Sean Chou
if (a.length < i), of cause it is not. This 2 cases will fail due to more serious bug, not 7121314 . On Wed, Mar 14, 2012 at 7:36 AM, Ulf Zibis wrote: > Am 13.03.2012 07:58, schrieb Sean Chou: > >> Hi Ulf and David, >> >>I modified the patch and added th

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-13 Thread Sean Chou
se, so the list is still Ulf's and my emails. Please take a look again. On Fri, Mar 9, 2012 at 8:45 PM, Ulf Zibis wrote: > Am 09.03.2012 09:16, schrieb Sean Chou: > >> Hi all, >> >>AbstractCollection.toArray(T[] ) might return a new array even if the >>

Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-09 Thread Sean Chou
make sure toArray is already called. Thread.sleep(1200); } catch (Exception e) { } threads[1].start(); } } -- Best Regards, Sean Chou

Re: LDAP URI (Re: Question about 6961765)

2012-03-02 Thread Sean Chou
java/net/**URLDecoder.html<http://docs.oracle.com/javase/7/docs/api/java/net/URLDecoder.html> > > On 03/02/2012 02:15 PM, Sean Chou wrote: > >> >> But UrlUtil.decode(DN, "UTF8") and URLDecoder.decode(DN, "UTF8") >> are returning >

Re: Question about 6961765

2012-03-01 Thread Sean Chou
. Copied here: > > The URL in the testcase has an invalid encoding. Its Unicode characters > must be encoded in UTF-8. For example, > >\u3070 -> \e3\81\b0 -> %5Ce3%5C81%5Cb0 > > -Weijun > > > On 03/01/2012 03:39 PM, Sean Chou wrote: > >> Hi all, >>

Question about 6961765

2012-02-29 Thread Sean Chou
Hi all, I just encountered this bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6961765 . But it is closed as "NOT A BUG" without any comments. Would anyone take a look and give it a comment ? Thanks. -- Best Regards, Sean Chou

Re: A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-14 Thread Sean Chou
Thank you as well~ I'll work on it. On Wed, Dec 14, 2011 at 4:02 PM, David Holmes wrote: > On 14/12/2011 5:05 PM, Sean Chou wrote: > >> Hi Mike, David, >> >> I reported this as a bug: >> http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7121

Re: Add Look&Feel support for AIX platform

2011-12-14 Thread Sean Chou
, Dr Andrew John Hughes wrote: > On 14:45 Tue 13 Dec , Neil Richards wrote: > > On Tue, 2011-12-13 at 14:42 +, Neil Richards wrote: > > > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: > > > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards > > > &g

Re: A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-13 Thread Sean Chou
. If the > collection shrinks then it is currently possible that the resulting array > could very unexpectedly hold nulls. > > Mike > > On Dec 13 2011, at 05:30 , Sean Chou wrote: > > > Sorry for the confuse. By "ok", I mean "compare the size of array which &g

Re: A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-13 Thread Sean Chou
n check and copy in their code. > > -Ulf > > Am 13.12.2011 14:30, schrieb Sean Chou: > > Sorry for the confuse. By "ok", I mean "compare the size of array which is >> going to be >> returned and the size of the specified array, and copy the elements

Re: A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-13 Thread Sean Chou
if people are relying on implementation, is this right? So it seems we can do nothing to the mismatch now... On Tue, Dec 13, 2011 at 8:06 PM, David Holmes wrote: > On 13/12/2011 9:18 PM, Sean Chou wrote: > >> Hi , >> >> Is it possible to change the spec ? I found it is

Re: A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-13 Thread Sean Chou
modifying toArray(T[]) method for an additional check, which would work for most subclasses of AbstractCollection... Is that ok ? On Tue, Dec 13, 2011 at 3:41 PM, David Holmes wrote: > Hi Sean, > > > On 13/12/2011 5:21 PM, Sean Chou wrote: > >> When I was reading the code of Abstr

A behavior mismatch in AbstractCollection.toArray(T[] )

2011-12-12 Thread Sean Chou
e the collection is modified during toArray is invoked. So the returned array fits in the specified array, but a new array is used because toArray checks the size before copying. Is this a bug ? -- Best Regards, Sean Chou

Re: Add Look&Feel support for AIX platform

2011-12-12 Thread Sean Chou
I tried once, and it was dropped because "the platform is not supported." On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards wrote: > On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote: > > Hi, > > > > > >I'm not sure what to do for it next, shall I cre

Re: Add Look&Feel support for AIX platform

2011-12-08 Thread Sean Chou
, 2011 at 11:14 AM, Sean Chou wrote: > Hi, > >I'm not sure what to do for it next, shall I create a bug for it now ? > But I > don't think the bug system support AIX platform. I remembered it would > report something like "we are not supporting the platform".

Try to make OSInfo class recognize AIX platform

2011-12-08 Thread Sean Chou
discussion links http://mail.openjdk.java.net/pipermail/swing-dev/2011-October/001795.html http://mail.openjdk.java.net/pipermail/swing-dev/2011-November/001847.html -- Best Regards, Sean Chou

Re: Add Look&Feel support for AIX platform

2011-12-05 Thread Sean Chou
rt for AIX platform > A: "Neil Richards" > Cc: "Java Core Libs" , < > swing-...@openjdk.java.net>, > > > On 10/20/2011 11:10 PM, Neil Richards wrote: > > On Tue, 2011-10-18 at 15:53 +0800, Sean Chou wrote: > >> Hi all, > >> > >>

Add Look&Feel support for AIX platform

2011-10-18 Thread Sean Chou
Hi all, This is a simple patch to add LookAndFeel support for AIX platform to help bring up GUI application. This is part of the series of AIX patches. -- Best Regards, Sean Chou

Focus lost after minimize and restore a window on linux

2011-06-13 Thread Sean Chou
d, the testcase fails too. I think the focus must be restored, it is very important for GUI applications. Can any body give some suggestion? -- Best Regards, Sean Chou

DnD fails with JTextArea and JTextField

2011-05-26 Thread Sean Chou
as in step 2, it works. Are there any comments? And can anyone file a bug for it please ? -- Best Regards, Sean Chou

TextArea's/TextField's enableInputMethods is not working on linux

2011-05-26 Thread Sean Chou
ary, however Java7's TextArea/TexField does not use Motif any more, so enableInputMethods doesn't work. I suppose we need to update the specification about the behavior. Any comments? -- Best Regards, Sean Chou

Re: Building nio libraries

2011-05-24 Thread Sean Chou
Hi, Have you made a softlink from $(topdir)/jdk/build to $(topdir)/build ? There are btjars and other requirements. 2011/5/19 David Holmes > Sean Chou said the following on 05/19/11 17:45: > >This is my practice. First, you need a complete build for jdk7. >> Then,

Re: Building nio libraries

2011-05-19 Thread Sean Chou
trying to find btjars/spp.jar which is > expected to be in the output directory. Is there some special import > setting, or must I build something else first? > > Thanks, > David > -- Best Regards, Sean Chou

Remove locks of type Object to help lock contention analysis

2011-03-08 Thread Sean Chou
bring some enhancement to performance tools if these modification can be applied. Any comments? -- Best Regards, Sean Chou

Questions about XJC tool.

2011-03-06 Thread Sean Chou
src/ share/classes/com/sun/tools/internal/" in my working copy(using hg fclone http://hg.openjdk.java.net/jdk7/jdk7/). Is there any other place I can find its source? Thanks. -- Best Regards, Sean Chou

Re: Behavior of java.io.FileOutputStream.getChannel() does not match the spec

2011-02-17 Thread Sean Chou
Oh, I should have done a little more investigation. Is there a plan to fix it? I can provide a patch if it is needed. 2011/2/17 Alan Bateman > Sean Chou wrote: > >> Hi, >> I find there is a mismatch between the spec and the behavior of >> java.io.FileOutputStream.g

Behavior of java.io.FileOutputStream.getChannel() does not match the spec

2011-02-17 Thread Sean Chou
Hi, I find there is a mismatch between the spec and the behavior of java.io.FileOutputStream.getChannel(). The spec reads: "The initial position of the returned channel will be equal to the number of bytes written to the file so far unless this stream is in append mode, in which case it will