Hi , I didn't realize that rt.jar would miss before. The testcase is updated to create a temp file as well as test the extract option. However, extract testing will create a directory if it passes, I just deleted it in testcase. Please take a look.
webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.02/ . On Fri, Nov 9, 2012 at 10:13 PM, Alan Bateman <alan.bate...@oracle.com>wrote: > On 09/11/2012 04:31, Sean Chou wrote: > >> Hello Chris, Alan, and Xueming, >> >> I added the testcase, please take a look. >> >> webrev: >> http://cr.openjdk.java.net/~**zhouyx/7201156/webrev.01/<http://cr.openjdk.java.net/~zhouyx/7201156/webrev.01/> >> >> Thanks for adding a test, I agree with Chris that it would be great if > the test didn't use rt.jar. As Chris mentions, rt.jar is only created for > images builds and most of it working on the JDK doesn't bother with images. > Also rt.jar will go away once we move to modules. > > One other comment on the test is that it only exercises the "t" option, I > think the issue that is being fixed also impacts the extract ("x") option. > > -Alan > -- Best Regards, Sean Chou
