complicate future
> >
> > tests backports.
> >
> > But that's my personal opinion. Others might disagree.
>
> I agree with you. Complete waste of time and effort for zero benefit
>
> IMO. Sorry Sergei.
>
> Cheers,
>
> David
>
> >
Hi all,
Some tests use StringBuffers instead of StringBuilders where additional
thread-safety
is not required as e.g. in
test/jdk/sun/util/resources/TimeZone/Bug4640234.java:82 :
...
StringBuffer errors
=
new
StringBuffer(
""
);
StringBuffer warnings
=
new
StringBuffer(
""
);
...
Th
On Wed, 25 Aug 2021 17:53:52 GMT, Sergei Ustimenko
wrote:
>> Change #3294 helps to avoid `AnnotaionFormatException` in
>> `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`.
>> While it fixes the case with e.g. `Runnable` that generates the sy
etic methods that
> have parameters e.g. `Function`, `BiFunction`, etc.
>
> This change removes the restriction on parameters count to be zero i.e.
> lambdas with parameters
> would be skipped from validation.
Sergei Ustimenko has updated the pull request with a new target base due t
On Mon, 16 Aug 2021 13:56:44 GMT, Sergei Ustimenko
wrote:
>> Change #3294 helps to avoid `AnnotaionFormatException` in
>> `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`.
>> While it fixes the case with e.g. `Runnable` that generates the sy
etic methods that
> have parameters e.g. `Function`, `BiFunction`, etc.
>
> This change removes the restriction on parameters count to be zero i.e.
> lambdas with parameters
> would be skipped from validation.
Sergei Ustimenko has updated the pull request with a new target base due t
Hi Joe,
Thanks, I appreciate your feedback very much!
There was one more thing I wanted to discuss: there is something that
might be improved in the AnnotationInvocationHandler#validateAnnotationMethods
and I wanted to know if it makes sense to go ahead with the change.
There are `if` statements
On Wed, 30 Jun 2021 20:08:27 GMT, Sergei Ustimenko
wrote:
> Change #3294 helps to avoid `AnnotaionFormatException` in
> `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`.
> While it fixes the case with e.g. `Runnable` that generates the synthetic
Change #3294 helps to avoid `AnnotaionFormatException` in
`sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`.
While it fixes the case with e.g. `Runnable` that generates the synthetic
method without parameters, validation still fails on synthetic methods that
have p
oses it.
So it seems a bit cumbersome, but I really need a bit of advise here.
If anyone wants to participate and has some time, your thoughts would
be of the great value!
Thanks,
Sergei
On Tue, 11 Dec 2018 at 08:20, David Holmes wrote:
> On 11/12/2018 4:27 pm, Sergei Ustimenko wrote:
>
Hi David,
Thanks for checking it, I'll continue working on it then.
Just wondering if you have any thoughts on how fix would
look like.
Regards,
Sergei
On Tue, 11 Dec 2018 at 02:34, David Holmes wrote:
> Hi Sergey,
>
> I've had a look and I don't think this issue is relevant to JDK-8171335.
>
11 matches
Mail list logo
