Integrated: JDK-8253936 Replace ... with {@code ...} for java.sql

On Fri, 16 Oct 2020 19:38:45 GMT, Vipin Sharma wrote: > ... is replaced with {@code ...} in java.sql classes. > Please review and sponsor this change. This pull request has now been integrated. Changeset: dee79d60 Author: Vipin Sharma Committer: Lance Andersen URL:

Re: RFR: JDK-8253936 Replace ... with {@code ...} for java.sql [v2]

On Wed, 4 Nov 2020 19:29:34 GMT, Lance Andersen wrote: >> Vipin Sharma has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated copyright year and other issues reporrted in review > > Marked as reviewed by l

Re: RFR: JDK-8253936 Replace ... with {@code ...} for java.sql [v2]

> ... is replaced with {@code ...} in java.sql classes. > Please review and sponsor this change. Vipin Sharma has updated the pull request incrementally with one additional commit since the last revision: Updated copyright year and other issues reporrted in review - C

Re: RFR: JDK-8253936 Replace ... with {@code ...} for java.sql

On Fri, 16 Oct 2020 19:38:45 GMT, Vipin Sharma wrote: > ... is replaced with {@code ...} in java.sql classes. > Please review and sponsor this change. Hi @LanceAndersen, I have generated javadoc before and after change. Following are 3 differences showing side by side compariso

RFR: JDK-8253936 Replace ... with {@code ...} for java.sql

... is replaced with {@code ...} in java.sql classes. Please review and sponsor this change. - Commit messages: - JDK-8253936 Replace ... with {@code ...} for java.sql Changes: https://git.openjdk.java.net/jdk/pull/707/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=707

Re: RFR: 8252537: Updated @exception with @throws [v4]

.java.net/pipermail/core-libs-dev/2020-September/068540.html Vipin Sharma has updated the pull request incrementally with one additional commit since the last revision: Replaced ... with {@code ...} for modified statement in java.sql - Changes: - all: https://git.openjdk.java.net

Re: RFR: 8252537: Updated @exception with @throws [v3]

On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen wrote: > Overall the changes look OK. in the java.sql set of classes, please updated > the modified statements to also use {@code} Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a separate bug JDK-8253612 to fix this for

Re: RFR: 8252537: Updated @exception with @throws [v3]

.java.net/pipermail/core-libs-dev/2020-September/068540.html Vipin Sharma has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8252537 Updated @exception with @throws, implemented review comments - Changes:

Re: RFR: 8252537: Updated @exception with @throws [v2]

ion". > I mnetioned 3 because that was the difference in length between > "exception" and "throws". > > Thanks for the followup, Roger > > > > On 9/15/20 3:14 PM, Vipin Sharma wrote: >> >> @RogerRiggs >> <https://urldefense

Re: RFR: 8252537: Updated @exception with @throws [v2]

.java.net/pipermail/core-libs-dev/2020-September/068540.html Vipin Sharma has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since t

Re: RFR: 8252537: Updated @exception with @throws

On Tue, 15 Sep 2020 18:14:58 GMT, Serguei Spitsyn wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversatio

RFR: 8252537: Updated @exception with @throws

Updated @exception with @throws for core-libs, it fixes all open sub-tasks of JDK-8252536. Open Subtasks part of this fix are: 1. JDK-8252537 2. JDK-8252539 3. JDK-8252540 4. JDK-8252541 - Commit messages: - JDK-8252537 Updated @exception with @throws Changes: https://git.openjdk.

Re: RFR 8252537: Replace @exception with @throws for core-libs

Hi, I have generated Javadoc for all updated packages and compared html files, before and after changes. All looks good, only generation time is different in html files. Regards, Vipin > On Sep 5, 2020, at 12:47 AM, Vipin Sharma wrote: > > Hi Pavel, > > >> On Sep 4, 20

Re: RFR 8252537: Replace @exception with @throws for core-libs

and >> after that patch: there's a possibility of non-local consequences, see >> JDK-6509045. There are ~ 1.5K lines, 86 files changed in this patch, do we have any tool to compare Javadoc or it should be done manually ? >> >> -Pavel >> >>> On 3 S

Re: RFR 8252537: Replace @exception with @throws for core-libs

\*[ ]{1}@since[ ]{2,} Occurrences 1826 \*[ ]{1}@author[ ]{2,} Occurrences 1156 \*[ ]{1}@deprecated [ ]{2,} 22 Occurrences \*[ ]{1}@serial[ ]{2,} 4 Occurrences \*[ ]{1}@serialData[ ]{2,} 3 Occurrences \*[ ]{1}@serialField[ ]{2,} 10 Occurrences \*[ ]{1}@version[ ]{2,} 1 Occurrence > On

RFR 8252537: Replace @exception with @throws for core-libs

Hi, Please review and sponsor the fix for replacing @exception with @throws for core-libs. Issue: https://bugs.openjdk.java.net/browse/JDK-8252537 Webrev: https://cr.openjdk.java.net/~vsharma/8252537 As suggested in the previous discussion

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Roger, On Thu, Sep 3, 2020 at 2:20 AM Roger Riggs wrote: > Hi Vipin, > > Looks fine. > > I see you filed separate tasks for the other packages in java.rmi. [1] > That's unnecessarily fine grained. > It would be more efficient to do them all in one code review, saving your > time and reviewers

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Roger, On Tue, Sep 1, 2020 at 10:49 PM Roger Riggs wrote: > Hi Vipin, > > Looks fine. > > Though I would also correct the indentation and join source lines in a > few cases. > > MasrshalledObject.java. Continuation lines should be indented. Lines > 110 and 164, 166. > Fixed. > > Naming.java

RFR 8252538: Replace @exception with @throws java.rmi package

Hi, Please review and sponsor the fix for replacing @exception with @throws in java.rmi package. Issue: https://bugs.openjdk.java.net/browse/JDK-8252538 Webrev: https://cr.openjdk.java.net/~vsharma/8252538/webrev.01/ Regards, Vipin

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Daniel, > On Aug 26, 2020, at 10:25 PM, Daniel Fuchs wrote: > > Hi Vipin, > > This looks good to me. > Make sure to generate the API docs locally and eyeball them to > double check that nothing is amiss. Checked API docs, it doesn’t have any change. Regards, Vipin

RFR 8252265: Replace @exception with @throws java.util.logging package

Hi, Please review and sponsor the fix for replacing @exception with @throws in java.util.logging package. Issue: https://bugs.openjdk.java.net/browse/JDK-8252265 Webrev: https://cr.openjdk.java.net/~vsharma/8252265/ It came up in the below discussion, starting this cleanup with java.util.logging

Re: Fix for Javadoc errors in java.base

Hi Sean, All 3 instances of @exception in DHPrivateKey are now replaced with @throws, added ProviderException similar to other constructor of DHPrivateKey. Updated patch: --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-08-14 23:55:40.921599987 +0530 +++ new

Re: Fix for Javadoc errors in java.base

rce=link&utm_campaign=sig-email&utm_content=webmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> On Tue, Jul 28, 2020 at 5:53 AM Joe Darcy wrote: > Hello Vipin, > > What tooling was used to find these errors? Running doclint against > private methods too? > > Th

Fix for Javadoc errors in java.base

Hi, This patch fixes Javadoc errors in java.base, please sponsor this patch and help to create a bug id for this. I have signed OCA, this is my third patch. --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:21.233726447 +0530 +++ new/src/java.base/shar

Re: Fix for warning related to stream api call chains in java.base

Hi All, Forgot to mention these are IDE warnings I am trying to fix, need a sponsor for this. Regards, Vipin > On May 3, 2020, at 8:40 PM, Vipin Sharma wrote: > > Hi All, > > I have fixed some warnings in java.base module, following are 3 type of code > changes in this pa

Fix for warning related to stream api call chains in java.base

(Collectors.joining(",")) replaced with String.join(",", stringList) This patch improves performance as well, jmh results available at https://gist.github.com/Vipin-Sharma/00f1d6da6b8e0e0bc7bec2e33bce85ed, end of gist file you can see results. Need a sponsor for this patch. Patch: -

Re: Need sponsor to fix Javadoc warnings

that incremental patch. That's good. >> >> I couldn't resist fixing a couple of typos in the already affected >> jdk.internal.icu >> (International Components for Unicode) package. Once this has been cleared by >> experts in that area, we are good to go. >>

Re: Need sponsor to fix Javadoc warnings

oded response. + * @param tsReply A buffer containing the ASN.1 BER encoded response. * @throws IOException The exception is thrown if a problem is encountered * parsing the timestamp response. */ >> On 8 Apr 2020, at 17:35, Vipin Sharma wrote: >> >>

Re: Need sponsor to fix Javadoc warnings

> On Apr 8, 2020, at 6:57 PM, Pavel Rappo wrote: > > Why assume something that sophisticated where it can be adequately explained > by > a simpler thing? :) I bet it was an IDE inspection. > > -Pavel Yes, it was IDE inspection in java.base, it looked like the best way to start contributing

Re: Need sponsor to fix Javadoc warnings

singResourceException if rule data or dictionary initialization failed */ public DictionaryBasedBreakIterator(String ruleFile, byte[] ruleData, >> On 6 Apr 2020, at 17:07, Vipin Sharma wrote: >> >> Hi David, >> >> I forgot to mention this is my second patch here. I a

Re: Need sponsor to fix Javadoc warnings

suggest if there is any way I can create my user id to upload this patch. This is ~300 line patch file. Regards, Vipin > On Apr 6, 2020, at 3:25 AM, David Holmes wrote: > > Hi Vipin, > > On 6/04/2020 6:42 am, Vipin Sharma wrote: >> Hi, >> I have fixed a few warnings wher

Need sponsor to fix Javadoc warnings

Hi, I have fixed a few warnings where the method parameter name is different in code and Javadoc, need a sponsor for this patch. Webrev is available at https://drive.google.com/open?id=1EXUXKqGxzSR7sW2LShy0sgvP4z-bPL0e Regards, Vipin

RFR 8240524: Removed warnings from test classes

Hi All, Please review patch to remove warnings from test classes. Bug : https://bugs.openjdk.java.net/browse/JDK-8240524 Webrev : http://cr.openjdk.java.net/~clanger/webrevs/8240524.0/

Need bug id to remove the explicit type argument in test class

Hi, My OCA has been processed recently and I want to start Contributing to OpenJDK. As a first fix, I would like to remove the explicit type argument in test class test/jdk/java/lang/Boolean/MakeBooleanComparable.java to fix one warning. The first line given below is the existing code and the se