On Sat, 8 Jan 2022 21:00:37 GMT, Yasser Bazzi wrote:
> Hi, could i get a review on this implementation proposed by Stuart Marks, i
> decided to use the
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
> interface to create the de
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Update full name
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- new: h
On Thu, 21 Apr 2022 03:48:21 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Update specs of setSeed() and next(bits).
-
Changes:
- all: https://git.openjdk.java.ne
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with two additional
commits since the last revision:
- Update setSeed docs on Random class
- Add nicer toString method to random wrapper
--
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Wed, 16 Mar 2022 06:51:37 GMT, Stuart Marks wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix SplittableRandomTest.
>
> src/java.base/share/classes/java/util/Random.java line
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
add since in javadoc
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- n
On Sat, 12 Mar 2022 01:26:24 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Fix SplittableRandomTest.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
On Fri, 11 Mar 2022 01:25:28 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
make changes proposed
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- n
On Sun, 6 Mar 2022 01:39:02 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'randomwrapper' of https://github.com/YShow/jdk.git into
randomwrapper
- Remove atomicL
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Update javadoc
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- new: h
On Sat, 5 Mar 2022 19:39:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Fix wrong whitespace
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- n
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with three additional
commits since the last revision:
- Change variable name
- Do not allow serialization
- Changes proposed by Stuart Marks, ExE Boss and li
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
fix wrong identation
Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com&g
On Fri, 25 Feb 2022 23:05:48 GMT, Marcono1234 wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use var instead of ArrayList raw
>>
>> Co-authored-by: liach <7806504+
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Update javadoc
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- new: h
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Use var instead of ArrayList raw
Co-authored-by: liach <7806504+li...@users.noreply.github.com&g
On Fri, 25 Feb 2022 01:13:41 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Wed, 23 Feb 2022 13:14:07 GMT, Jim Laskey wrote:
>> Yasser Bazzi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> check from master branch
>
> src/java.base/share/classes/java/util/Random.java line 259:
&
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with two additional
commits since the last revision:
- change wrong indentation
- change indentation
-
Changes:
- all: https://git.openjdk.java.ne
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
check from master branch
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Remove changes from RandomGenerator
-
Changes:
- all: https://git.openjdk.java.ne
On Sun, 20 Feb 2022 03:08:27 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
remove missed whitespace
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with one additional
commit since the last revision:
Remove whitespace and tabs
-
Changes:
- all: https://git.openjdk.java.ne
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with six additional
commits since the last revision:
- add tests and fix javadoc lint error
- Add static function from() and its javadoc
- Remove RandomWrapper
On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interfa
On Fri, 28 Jan 2022 16:01:56 GMT, Roger Riggs wrote:
> (For future reference: As tempting as it is to make other small improvements
> to the code such as missing but optional @ Overrides, it obscures the changes
> that are the subject of the PR.).
Oh sorry about that, my IDE probably did the
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with two additional
commits since the last revision:
- fix missing periods
- Use final on initialized variable
-
Changes:
- all: https://git.
On Wed, 26 Jan 2022 17:49:42 GMT, Stuart Marks wrote:
> This will also need a regression test. It should have a case to ensure that
> `asRandom` returns `this` if it's already an instance of `Random`. Maybe also
> a simple case of shuffling a list, similar to the gist. Also see if there are
>
On Wed, 26 Jan 2022 17:31:27 GMT, Stuart Marks wrote:
>> Yasser Bazzi has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - make sure setseed its initialized and throw
>> - remove tabs
>> - Change name
On Wed, 26 Jan 2022 17:43:09 GMT, Stuart Marks wrote:
>> Is something like this better?
>> /**
>> * Returns a {@link java.util.Random} from this {@link
>> java.util.RandomGenerator}.
>> * The resulting Random acts in all respects except that setSeed is not
>> available.
>> *
>>
> Small test done on
> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with four additional
commits since the last revision:
- make sure setseed its initialized and throw
- remove tabs
- Change name of function from wrapRa
On Wed, 26 Jan 2022 15:36:28 GMT, Roger Riggs wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
Hi, could i get a review on this implementation proposed by Stuart Marks, i
decided to use the
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
interface to create the default method `asRandom()` that wraps around the
newer algorithms to be
41 matches
Mail list logo
