On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
Marked as reviewed by kizune (Reviewer)
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote:
> Implementation of Mac App Support including three new mac specific CLI
> options.
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2716
On Thu, 4 Mar 2021 14:18:59 GMT, Andy Herrick wrote:
>> when the app modules have already been jlinked with the runtime, and there
>> is no need for module-path, jpackage was acting as if the module-path was
>> "." and picking up jars in the current directory.
>
> Andy Herrick has updated the p
On Thu, 25 Feb 2021 21:15:44 GMT, Andy Herrick wrote:
> …age-identifier
Looks fine.
-
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2730
On Wed, 3 Feb 2021 14:08:13 GMT, Andy Herrick wrote:
> Remove lines in WixSourceBuilder that adds directive to rm-rf the parent
> dir(s) of the install-dir. These directories get removed anyway if they are
> empty without these lines, and should be left alone if not empty after
> removing the
On Wed, 27 Jan 2021 12:43:40 GMT, Andy Herrick wrote:
> Fixing FileUtils.dirname() to skip over "/.".
Aside of small change requested by @alexeysemenyukoracle looks fine.
-
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2260
On Thu, 7 Jan 2021 16:40:26 GMT, Andy Herrick wrote:
> JDK-8259238: Clean up Log.java and remove usage of non-final static variables.
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1977
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2030
On Wed, 6 Jan 2021 15:52:07 GMT, Andy Herrick wrote:
> JDK-8259062: Remove MacAppStoreBundler
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1962
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote:
>> …n name.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8256475: Fix Behavior when Installer name differs from application name.
Looks good.
src/jdk.jpackage/s
On Mon, 23 Nov 2020 20:16:58 GMT, Andy Herrick wrote:
> When executing msiexec (possibly from batch script) retry on exitCode 1603 as
> well as 1618
Looks fine.
-
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1400
On Thu, 5 Nov 2020 18:18:16 GMT, Andy Herrick wrote:
>> JVM
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains three additional
> co
On Fri, 16 Oct 2020 17:59:14 GMT, Andy Herrick wrote:
> JDK-8254843: Exception launching app on windows in some cases
> loading splashscreen.dll in WinLaunchercpp would load java.dll from path
> instead of runtime/bin causing jni launcher to
> crash. instead we just use what used to be the fallb
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote:
> …from installer name
> JDK-8254783: jpackage fails on Windows when application name differs from
> installer name
> When using --app-image, to create MSI installer, use the application name
> from AppImageData instead of the Msi
> installe
On Fri, 25 Sep 2020 21:05:23 GMT, Andy Herrick wrote:
>> 8253426: jpackage is unable to generate working EXE for add-launcher
>> configurations.
>> secondary launchers ignored module, main-jar, and main-class in launcher
>> properties file because the LAUNCHER_DATA
>> param was not removed fro
On Wed, 23 Sep 2020 22:20:17 GMT, Alexander Matveev
wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8253149: Building an installer from invalid app image fails (revision
>
> Marked as reviewed by almatvee (Committ
On Wed, 23 Sep 2020 13:59:25 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then comple
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote:
> JDK-8230652
> Extracting the commands displayed by verbose output (including commands
> called thru ToolProvider) , to contain the the
> command, it's output, and it's return value on separate lines and formatted
> in a way that they can b
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote:
> JDK-8230652
> Extracting the commands displayed by verbose output (including commands
> called thru ToolProvider) , to contain the the
> command, it's output, and it's return value on separate lines and formatted
> in a way that they can b
Looks fine to me.
/Alex
On 2/26/20 20:48, Andy Herrick wrote:
Please review the fix to issue [1] at [2].
The initial concern with defaulting to the application or installer
name was that is might not be a valid mac package identifier (use only
alphanumeric, '.' , and '-' chars) but this can
Last version looks fine to me.
/Alex
On 2/21/20 20:10, Andy Herrick wrote:
After internal discussion of default values for mac-package-identifier
I have removed the fix for [3] from this main fix to issue [2].
please review the revised webrev at [1]
/Andy
On 2/18/2020 2:46 PM, Andy Herrick
Looks fine to me.
/Alex
On 02-Mar-20 22:38, Andy Herrick wrote:
I sent this in reply to Alexey, needed to send it to alias:
On 2/6/2020 4:54 PM, Andy Herrick wrote:
I had fixed that and failed to push the revised webrev [4]
[4] http://cr.openjdk.java.net/~herrick/8237967/webrev.03/
/Andy
O
Hello,
please, review my fix for the issue
JDK-8044206: LambdaMetafactory.altMetafactory javadoc refers to wrong
method
Link to the issue: https://bugs.openjdk.java.net/browse/JDK-8044206
Webrev: http://cr.openjdk.java.net/~kizune/8044206/webrev.00
The fix is trivial, the JavaDoc for
ms it's Ok.
The updated webrev can be found at:
http://cr.openjdk.java.net/~kizune/8029646/webrev.03
/Alex
Kumar
On 1/16/2014 8:21 AM, Alexander Zuev wrote:
Sherman, Kumar,
i have fixed the glitches you have found and changed the test so it
creates a new jar
based on the golden.jar
wrote:
On 1/15/14 7:01 AM, Alexander Zuev wrote:
Hello,
the new webrev with all the typos and comments fixed can be found
at http://cr.openjdk.java.net/~kizune/8029646/webrev.01/
/Alex
(1) jarmagic can be just a static constant somewhere or a stack
variable. not big deal though.
(2) the
On 1/15/14 21:34, Xueming Shen wrote:
On 1/15/14 7:01 AM, Alexander Zuev wrote:
Hello,
the new webrev with all the typos and comments fixed can be found
at http://cr.openjdk.java.net/~kizune/8029646/webrev.01/
/Alex
(1) jarmagic can be just a static constant somewhere or a stack
Hello,
the new webrev with all the typos and comments fixed can be found at
http://cr.openjdk.java.net/~kizune/8029646/webrev.01/
/Alex
ntical jar after we normalized it. If you think creating of large jar
file is necessary i can easily do so.
/Alex
Kumar
On 1/14/2014 10:04 AM, Alexander Zuev wrote:
Please review my fix for
JDK-8029646: [pack200] should support the new zip64 format.
The fix can be found at
http://cr.openjd
On 1/15/14 18:34, Alexander Zuev wrote:
Sherman et all,
self-correction regarding the flags, i misread the specification so
flags are: always support UTF-8 file encoding (bit 11) and using EOS
marker for the compressed files(bit 4).
Damn my fast fingers - not bit 4, bit 3 and it tells we are
Sherman et all,
self-correction regarding the flags, i misread the specification so
flags are: always support UTF-8 file encoding (bit 11) and using EOS
marker for the compressed files(bit 4).
/Alex
On 1/15/14 18:26, Alexander Zuev wrote:
Hi Sherman,
Thanks for comments, here are some
al entries. You guys might want to consider if
it is
also worth considering to have this flag supported in unpack200.
-Sherman
On 1/14/14 10:04 AM, Alexander Zuev wrote:
Please review my fix for
JDK-8029646: [pack200] should support the new zip64 format.
The fix can be found at
http://cr.openjdk.java.net/~kizune/8029646/webrev.00/
Bug description is: https://bugs.openjdk.java.net/browse/JDK-8029646
/Alex
Changeset: 53dd31d3c5d7
Author:chegar
Date: 2013-11-03 07:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53dd31d3c5d7
Merge
Changeset: aaea3a69fa6c
Author:kizune
Date: 2013-12-03 14:13 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aaea3
Changeset: b9fdc55a6e28
Author:chegar
Date: 2013-11-03 07:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b9fdc55a6e28
Merge
Changeset: c1049f63d4f5
Author:kizune
Date: 2013-12-03 14:13 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c1049f63d
Changeset: 75142ce752da
Author:malenkov
Date: 2013-12-23 16:24 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75142ce752da
8030118: Document listeners fired outside document lock
Reviewed-by: art, serb
! src/share/classes/javax/swing/text/AbstractDocument.java
- test/javax/s
Changeset: b0c2840e2513
Author:mkos
Date: 2013-11-22 21:11 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0c2840e2513
8010935: Better XML handling
8027378: Two closed/javax/xml/8005432 fails with jdk7u51b04
8028382: Two javax/xml/8005433 tests still fail after the fix JDK-
Changeset: 51bbdd517b93
Author:joehw
Date: 2013-08-26 21:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/51bbdd517b93
8022935: Enhance Apache resolver classes
Reviewed-by: alanb, mchung, skoivu
! src/com/sun/org/apache/xml/internal/resolver/CatalogManager.java
! src/com/s
Changeset: 7ccce1a6fa4d
Author:coleenp
Date: 2013-09-05 10:29 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ccce1a6fa4d
8021266: Better life cycle for objects
Summary: Improve life cycle for objects
Reviewed-by: art, hseigel
Contributed-by: gerard.ziem...@oracle.com
!
Changeset: 98a5caae1990
Author:chegar
Date: 2013-11-03 07:32 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/98a5caae1990
Merge
Changeset: 880514b576d5
Author:msheppar
Date: 2013-11-12 17:56 +
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/880514b576d
Changeset: ff1478785e43
Author:katleman
Date: 2014-01-03 11:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ff1478785e43
Added tag jdk8-b122 for changeset 347009c58816
! .hgtags
Changeset: c330fa67c4da
Author:katleman
Date: 2014-01-10 08:31 -0800
URL: http://hg
Please review my fix for
JDK-8029646: [pack200] should support the new zip64 format.
The fix can be found at
http://cr.openjdk.java.net/~kizune/8029646/webrev.00/
Bug description is: https://bugs.openjdk.java.net/browse/JDK-8029646
/Alex
Changeset: f42a22e2b2cd
Author:kizune
Date: 2013-11-19 22:14 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f42a22e2b2cd
6726154: javadoc generated with incorrect version in comment
Reviewed-by: jjg, bpatel, erikj, tbell
! make/BuildLangtools.gmk
! src/share/classes/co
Changeset: 5aa853ca08a8
Author:kizune
Date: 2013-11-19 22:05 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aa853ca08a8
8027900: pack200 option is broken due to the incorrect makefile definition for
its driver
Reviewed-by: ksrini, ihse
! make/CompileLaunchers.gmk
Changeset: c2b56fe61626
Author:kizune
Date: 2013-11-18 20:22 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2b56fe61626
8028197: tools/launcher/DiacriticTest.java failed on MacOSX: Input length = 1
Reviewed-by: ksrini
! test/tools/launcher/DiacriticTest.java
Changeset: 3cdf6ca3ef47
Author:kizune
Date: 2013-10-23 18:35 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cdf6ca3ef47
8020802: Need an ability to create jar files that are invariant to the pack200
packing/unpacking
Reviewed-by: alanb, ksrini
! src/share/classes/sun/tools
Alan,
i guess you're right, i have updated code to use the same method with
fallback for creation .pack temporary file.
New webrev can be found at
http://cr.openjdk.java.net/~kizune/8020802/webrev.05
/Alex
On 10/22/13 23:55, Alan Bateman wrote:
On 22/10/2013 17:08, Alexander Zuev
Changeset: 72c0f289a8cb
Author:kizune
Date: 2013-10-22 22:18 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72c0f289a8cb
8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini
Reviewed-by: ksrini
! test/tools/launcher/VersionCheck.java
umar
/Alex
On 10/22/13 24:33, Kumar Srinivasan wrote:
Alex,
The @test should be just TestNormal not TestNormal.java
if you need an alternate/small jar you can use one in $JDK/lib/
ex: jconsole.jar or dt.jar
Kumar
On 10/21/2013 7:41 AM, Alexander Zuev wrote:
Alan,
thanks for a review, se
TestNormal.java
if you need an alternate/small jar you can use one in $JDK/lib/
ex: jconsole.jar or dt.jar
Kumar
On 10/21/2013 7:41 AM, Alexander Zuev wrote:
Alan,
thanks for a review, see my comments inline.
On 10/20/13 23:15, Alan Bateman wrote:
On 19/10/2013 16:14, Kumar Srinivasan wrote
Alan,
thanks for a review, see my comments inline.
On 10/20/13 23:15, Alan Bateman wrote:
On 19/10/2013 16:14, Kumar Srinivasan wrote:
Hi Alex,
This looks good.
Hi Sherman, Alan,
Could one of you review this, please
The "-n" options seems okay but I wonder if there has any thought
given
Hi,
please review my fix for
8020802: Need an ability to create jar files that are invariant to the
pack200 packing/unpacking
The fix adds new option to the jar command which makes created jars
normalized without the need to invoke the
external program.
Bug description: https://bugs.openjdk
Changeset: c0d44b1e6b6a
Author:kizune
Date: 2013-10-04 19:38 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0d44b1e6b6a
7096170: should remove unused support for enabling javac logging
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
Changeset: 9c32a9490eac
Author:kizune
Date: 2013-10-03 17:40 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c32a9490eac
8025738: locale related test fails on langtools mac 10.7 test host
Reviewed-by: ksrini
! test/tools/launcher/DiacriticTest.java
Changeset: 1a3e8347f3dd
Author:kizune
Date: 2013-10-01 17:03 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1a3e8347f3dd
7118749: NPE in CreateSymbols caused by bad diagnostic
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java
Changeset: 2c24a04ebfb4
Author:kizune
Date: 2013-09-27 21:20 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2c24a04ebfb4
6978886: javadoc shows stacktrace after print error resulting from disk full
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html
Changeset: 64e79d38bd07
Author:kizune
Date: 2013-09-23 18:29 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64e79d38bd07
4881267: improve diagnostic for "instanceof T" for type parameter T
Reviewed-by: vromero, jjg
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Changeset: 809a50f24d6f
Author:kizune
Date: 2013-09-23 17:27 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/809a50f24d6f
7154966: CRs found to be in Fixed state with no test and no noreg- keyword.
Reviewed-by: ksrini
+ test/tools/javac/T7090499.java
+ test/tools/javac/
Naoto,
i just tested - jtreg has no issues with deleting files even in
non-unicode locales.
/Alex
On 9/20/13 18:45, Naoto Sato wrote:
Is it ok to let jtreg clean up the files that contain non ascii filenames? Does
it gracefully remove them?
Naoto
On Sep 20, 2013, at 3:43 AM, Alexander
Changeset: afe857b13b62
Author:kizune
Date: 2013-09-20 17:56 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afe857b13b62
8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales
Reviewed-by: naoto, ksrini
- test/tools/launcher/8017248/ClassAÌ.java
- test/
Hi Kumar,
thanks for suggestion - the corrected (and simplified) webrev can be
found at:
http://cr.openjdk.java.net/~kizune/8025076/webrev.05
With best regards,
/Alex
On 9/20/13 3:20, Kumar Srinivasan wrote:
Hi Alex,
The class can be compiled into the current directory (scratch), this
wi
the encoding of the platform? Does it work
> under the environment where the encoding is, say US-ASCII?
>
> Naoto
>
> On 9/19/13 9:43 AM, Alexander Zuev wrote:
>> Hi,
>>
>> please review my fix for 8025076: Fix for JDK-8017248 breaks jprt
>> submission
Hi,
please review my fix for 8025076: Fix for JDK-8017248 breaks jprt
submission for non-unicode locales
The idea of the fix is to replace test case with the complex file
name in it by the
test that generates and compiles such file at the run time.
The webrev can be found at:
http://
Changeset: 22e9f0067b5a
Author:kizune
Date: 2013-09-19 17:04 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22e9f0067b5a
8017248: Compiler Diacritics Issue
Reviewed-by: naoto
! src/share/classes/sun/launcher/LauncherHelper.java
+ test/tools/launcher/8017248/ClassAÌ.java
+ t
Changeset: 36e342dd57e2
Author:kizune
Date: 2013-09-19 17:05 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/36e342dd57e2
8017248: Compiler Diacritics Issue
Reviewed-by: naoto
! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java
I need a review for this simple change.
The problem here is that on Mac the file names with composite letters
(like letters with diacritic symbols)
are being kept in the Normalized Form Decomposed, so if file contains
class with the Composed name the
command-line utility or badly configured I
Changeset: 55da6b3a6940
Author:kizune
Date: 2013-08-20 17:34 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55da6b3a6940
7182350: Regression in wording of unchecked warning message
Reviewed-by: mcimadamore, jjg
! src/share/classes/com/sun/tools/javac/comp/Check.java
!
Changeset: aceae9ceebbe
Author:kizune
Date: 2013-06-25 20:08 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aceae9ceebbe
8006973: jtreg test fails:
test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java
Reviewed-by: ksrini
! test/tools/javac/warnings/Auxiliary
Changeset: 79fd9cfa55f2
Author:kizune
Date: 2013-06-05 16:58 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79fd9cfa55f2
7186887: Test T6567415.java can fail on a slow machine
Reviewed-by: jjg, ksrini
! test/tools/javac/6567415/T6567415.java
Kumar,
On 4/30/13 22:32, Kumar Srinivasan wrote:
Couple of nits:
I don't think you need the parens
j = (nextsemi < nextangl ? nextsemi : nextangl);
Here i tend to agree with John - the condition being a superposition of
two really closely named
variables might look confusing and since the worl
Please review this fix which by fine-tuning of just one method gives up
to 40% performance
improvement on packing and repacking of jar files.
Also removed unneeded local variable initialization from Code class -
not for performance gain,
just to make world a better place.
http://cr.openjdk.jav
Hi Ulf,
please see my comments inline.
On 3/20/13 18:09, Ulf Zibis wrote:
Hi Martin,
nice to see you again on board.
Am 19.03.2013 20:18, schrieb Martin Buchholz:
Thanks! Webrev updated.
Character:
Maybe I'm blind, is there any semantical difference between
char c1 = seq.charAt(in
72 matches
Mail list logo
