Re: RFR: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller

On Mon, 23 May 2022 22:11:47 GMT, Ioi Lam wrote: > This PR fixes a bug found on an Ubuntu host that's mostly running with > cgroupv2, but there's a controller (freezer) that is mounted in cgroupv1 mode. > > The container support code in the VM and JDK checks if we have simultaneously > mounted

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v9]

On Mon, 2 May 2022 06:24:21 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default an

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default a

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default a

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Fri, 29 Apr 2022 18:23:35 GMT, Mikhailo Seledtsov wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > > test/jdk/jdk/jfr/api/consume

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default a

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default a

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

On Wed, 1 Dec 2021 02:29:14 GMT, David Holmes wrote: >> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all >> tests not defined in the lower tiers. `hotspot:tier4` has lots of them, >> mostly long-running vmTestbase tests, which take many hours even on a very >> parallel

Re: RFR: 8277992: Add fast jdk_svc subtests to jdk:tier3

On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote: > OpenJDK tiered tests definitions have the catch-all `tier4` that runs all > tests not defined in the lower tiers. `hotspot:tier4` has lots of them, > mostly long-running vmTestbase tests, which take many hours even on a very > paralle

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]

On Tue, 17 Aug 2021 22:13:54 GMT, Mikhailo Seledtsov wrote: >> Please review this change that updates the buildJdkDockerImage() test >> library API. >> >> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l >> support for containers is

Integrated: 8272398: Update DockerTestUtils.buildJdkDockerImage()

On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov wrote: > Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested".

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v3]

g updated, I thought it would be a > good idea to also change the name to use more generic container terminology: > buildJdkDockerImage() --> buildJdkContainerImage() Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision: Fix

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

On Tue, 17 Aug 2021 20:30:04 GMT, Harold Seigel wrote: >> Mikhailo Seledtsov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Addressing review feedback > > test/lib/jdk/test/lib/containers/docker/DockerTest

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage() [v2]

g updated, I thought it would be a > good idea to also change the name to use more generic container terminology: > buildJdkDockerImage() --> buildJdkContainerImage() Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision: Address

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage()

On Mon, 16 Aug 2021 23:48:46 GMT, Igor Ignatyev wrote: >> Please review this change that updates the buildJdkDockerImage() test >> library API. >> >> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l >> support for containers is not tested". >> The initial intent was to

Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when path contains colon

On Mon, 16 Aug 2021 17:25:57 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8272124. The fix puts a limit of 3 when > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated > if they contain embedded ':'s. For example, an entry of > "11:memory:/user.sli

Re: RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage()

On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov wrote: > Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested".

RFR: 8272398: Update DockerTestUtils.buildJdkDockerImage()

Please review this change that updates the buildJdkDockerImage() test library API. This work originated while working on "8195809: [TESTBUG] jps and jcmd -l support for containers is not tested". The initial intent was to extend the buildJdkDockerImage() API of DockerTestUtils to accept custom

Re: [jdk17] RFR: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms

On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov wrote: > Now that "JDK-8268212 Build linux-aarch64 natively" added support for default > CDS archive, time to update test configuration for this platform. This is a > very small one-line change. Yumin, Ioi, thanks fo

[jdk17] Integrated: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms

On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov wrote: > Now that "JDK-8268212 Build linux-aarch64 natively" added support for default > CDS archive, time to update test configuration for this platform. This is a > very small one-line change. This pull request has

Re: [jdk17] RFR: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms

On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov wrote: > Now that "JDK-8268212 Build linux-aarch64 natively" added support for default > CDS archive, time to update test configuration for this platform. This is a > very small one-line change. Thanks Ioi. I hav

Re: [jdk17] RFR: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for Linux-aarch64

On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov wrote: > Now that "JDK-8268212 Build linux-aarch64 natively" added support for default > CDS archive, time to update test configuration for this platform. This is a > very small one-line change. Testing: Grepp

[jdk17] RFR: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for Linux-aarch64

Now that "JDK-8268212 Build linux-aarch64 natively" added support for default CDS archive, time to update test configuration for this platform. This is a very small one-line change. - Commit messages: - 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for Lin

Re: RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review the patch which moves `ClassFileInstaller` class to > `jdk.test.lib.helpers` package? > to reduce changes in the tests, `ClassFileInstaller` in the default package > is kept w/ just `main` method that

Re: RFR 15 8242462: Residual Cleanup of rmic removal

Runtime test changes look good to me, Misha On 4/10/20 11:44 AM, Igor Ignatyev wrote: Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm n

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Sounds good, Thank you, Misha On 7/17/19 6:45 PM, Igor Ignatev wrote: We definitely should do it as a separate RFE, I meant to write it in my email, but was interrupted by a fire drill, and forgot about it when returned. — Igor On Jul 17, 2019, at 6:38 PM, mikhailo.seledt...@oracle.com

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

On 7/17/19 11:37 AM, Igor Ignatyev wrote: Hi Severin, the updated webrev looks good to me, please see a couple comments below. Cheers, -- Igor On Jul 17, 2019, at 10:34 AM, Severin Gehwolf > wrote: Hi Misha, On Wed, 2019-07-17 at 10:22 -0700,mikhailo.seledt...

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

On 7/17/19 10:34 AM, Severin Gehwolf wrote: Hi Misha, On Wed, 2019-07-17 at 10:22 -0700, mikhailo.seledt...@oracle.com wrote: Hi Severin, On 7/17/19 5:44 AM, Severin Gehwolf wrote: Hi Igor, Misha, On Tue, 2019-07-16 at 11:49 -0700, Igor Ignatyev wrote: Hi Severin, I don't think that test

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi Severin, On 7/17/19 5:44 AM, Severin Gehwolf wrote: Hi Igor, Misha, On Tue, 2019-07-16 at 11:49 -0700, Igor Ignatyev wrote: Hi Severin, I don't think that tests (or test libraries for that matter) should be responsible for setting correct PATH value, it should be a part of host configurati

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

On 7/16/19 1:32 PM, Igor Ignatyev wrote: Hi Misha, I understand that it doesn't alter the host system. my concern is that we move problem of host-configuration into tests. let's say tomorrow a new container engine will require something from /usr/local/sbin, or /usr/local/Cellar/docker/bin o

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi Igor,    In both cases the environment variable is set for the Docker/Podman container process, not the host system. This will not affect the host system in any way. The docker process has its own namespace for environment variables. Does this alleviate your concerns? Thank you, Misha

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi Severin,   The change looks good to me. Thank you for adding support for Podman container technology. Testing: I ran both HotSpot and JDK container tests with your patch; tests executed on Oracle Linux 7.6 using default container engine (Docker):     test/hotspot/jtreg/containers/   AND

Re: RFR: 8224502 & 8224506 Container testbugs

Changes look good to me, Thank you for fixing, Misha On 6/20/19, 6:31 AM, Bob Vandette wrote: Please review these two Docker container test bugs that I’d like to get fixed in JDK13. Misha has already reviewed and approved these fixes. I’ve tested these changes by running all Docker container

Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

Changes look good to me, Misha On 5/7/19 5:56 AM, Bob Vandette wrote: Please review this change to the Container Metrics implementation. Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct the parsing of of the /proc/self/mountinfo file but corresponding changes to the Met

Re: RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Please make sure to update copyright year on the SubSystem.java before integration. Thank you, Misha On 5/7/19 1:51 PM, mikhailo.seledt...@oracle.com wrote: Looks good, Misha On 5/7/19 1:25 PM, Bob Vandette wrote: Please review this simple fix for a TestCgroupMetrics.java test failure.

Re: RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Looks good, Misha On 5/7/19 1:25 PM, Bob Vandette wrote: Please review this simple fix for a TestCgroupMetrics.java test failure. --- a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java +++ b/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java @@

Re: RFR(S) : 8219139 : move hotspot tests from test/jdk/vm

Looks good to me, Thank you, Misha On 3/14/19 2:38 PM, Igor Ignatyev wrote: Hi Misha, thanks for your suggestions, I have moved all runtime tests into subdirectories. here is the updated webrev: http://cr.openjdk.java.net/~iignatyev//8219139/webrev.01/index.html

Re: RFR(S) : 8219139 : move hotspot tests from test/jdk/vm

Hi Igor,   Sorry it took a while to get back to you on this one. See my comment below On 2/22/19 10:35 AM, mikhailo.seledt...@oracle.com wrote: Overall the change looks good; thank you Igor for doing this. I have couple of comments:   - I am in favor of the approach where we move tests fir

Re: RFR(S) : 8219139 : move hotspot tests from test/jdk/vm

  Overall the change looks good; thank you Igor for doing this. I have couple of comments:   - I am in favor of the approach where we move tests first under corresponding sub-component directories in     test/hotspot sub-tree, and then figure out whether to keep them. Even though in general I

Re: Ping!! Re: RFR: 8203357 Container Metrics

ERROR_MARGIN is exceeded. Thanks Harsha On Friday 08 June 2018 03:00 AM, Mikhailo Seledtsov wrote: Hi Bob,   I looked at the tests. In general they look good. I am a bit concerned about the use of ERROR_MARGIN in one of the tests. We need to make sure that the tests are stable, and do not produce

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Bob, I looked at the tests. In general they look good. I am a bit concerned about the use of ERROR_MARGIN in one of the tests. We need to make sure that the tests are stable, and do not produce intermittent failures. Thank you, Misha On 6/7/18, 10:43 AM, Bob Vandette wrote: Can I get

Re: [9] RFR (M) 8054386: Allow Java debugging when CDS is enabled

Changes look good to me. Misha On 6/2/2015 11:55 AM, Chris Plummer wrote: I'm going to have to separate out the ProcessTool.java changes into a separate changeset (and CR). In the meantime, feel free to review what I have below. The code won't be changing at all when I separate out the Proces