Paul,
I don't see why you changed the variable names in some cases.
See here where one change is only one line since you left it alone and
the other is 6 lines since you changed it
http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-media/webrev/src/share/classes/javax/pri
HI Phil,
Thanks for looking at this.
On May 13, 2014, at 11:15 PM, Phil Race wrote:
> Paul,
>
> I don't see why you changed the variable names in some cases.
Note it's not me :-) I am, mostly, the proxy.
> See here where one change is only one line since you left it alone and the
> other i
On 14/05/2014 09:15, Paul Sandoz wrote:
:
And here what could have been a 2 line change is 25 ..
http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-media/webrev/src/share/classes/sun/font/StandardTextSource.java.sdiff.html
So I would say leave the variable names alone unle
On May 14, 2014, at 11:05 AM, Alan Bateman wrote:
>
>> :
>>
>> This code is under src/share/classes, so it's not clear to me what classes i
>> can modify and push in the jdk9-dev/jdk repo or not. It's confusing! Is
>> there a list online somewhere?
>>
>> Out of all the classes here:
>>
>>
On 5/16/2014 5:13 AM, Paul Sandoz wrote:
On May 14, 2014, at 11:05 AM, Alan Bateman wrote:
:
This code is under src/share/classes, so it's not clear to me what classes i
can modify and push in the jdk9-dev/jdk repo or not. It's confusing! Is there a
list online somewhere?
Out of all the cla
On May 16, 2014, at 8:33 PM, Phil Race wrote:
> On 5/16/2014 5:13 AM, Paul Sandoz wrote:
>> On May 14, 2014, at 11:05 AM, Alan Bateman wrote:
:
This code is under src/share/classes, so it's not clear to me what classes
i can modify and push in the jdk9-dev/jdk repo or not. I
On 19/05/2014 07:53, Paul Sandoz wrote:
If i don't have permission to push to the client repo (which might be likely) i
will need to hand over the patch to yourself or Sergey to commit. And i presume
this will have to be a separate issue.
If you do decide to split this then it will require crea
On 5/19/2014 12:50 AM, Alan Bateman wrote:
On 19/05/2014 07:53, Paul Sandoz wrote:
If i don't have permission to push to the client repo (which might be
likely) i will need to hand over the patch to yourself or Sergey to
commit. And i presume this will have to be a separate issue.
If you do dec
On May 19, 2014, at 6:18 PM, Phil Race wrote:
> On 5/19/2014 12:50 AM, Alan Bateman wrote:
>> On 19/05/2014 07:53, Paul Sandoz wrote:
>>> If i don't have permission to push to the client repo (which might be
>>> likely) i will need to hand over the patch to yourself or Sergey to commit.
>>> An
After some further reflection i have decided to not separate this out and some
bits going to client and some bits going to dev, and have pushed all changes to
dev. I realise this might cause some friction but believe it the right thing to
do.
I remain unconvinced that the separate process for p
10 matches
Mail list logo
