Re: [PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-26 Thread Robert Stupp
Right, it's come a few times. In principle it seems reasonable but it will likely have a tail of issues. One concern is that it will cause issues with the attach mechanism as that depends on the tool side knowing the target VM's tmp dir. There's also the transition issue where old JDKs will b

Re: [PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-25 Thread Alan Bateman
On 26/04/2018 01:45, Brian Burkhalter wrote: On Apr 25, 2018, at 5:38 PM, Brian Burkhalter wrote: The attached patch changed the behavior to use the content of the environment variable TMPDIR, if present. Note that this does not change where the hsperf* folders are created. The source ch

Re: [PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-25 Thread Bernd Eckenfels
Burkhalter Sent: Donnerstag, April 26, 2018 5:09 AM Subject: Re: [PATCH] Prefer TMPDIR over hard coded /tmp To: Robert Stupp Cc: Hi Robert, On Apr 23, 2018, at 7:23 AM, Robert Stupp wrote: > For MacOS and Windows, Java prefers the user's temporary directory for > java.io.tmpdir,

Re: [PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-25 Thread Brian Burkhalter
On Apr 25, 2018, at 5:38 PM, Brian Burkhalter wrote: >> The attached patch changed the behavior to use the content of the >> environment variable TMPDIR, if present. Note that this does not change >> where the hsperf* folders are created. > > The source change looks OK to me aside from the co

Re: [PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-25 Thread Brian Burkhalter
Hi Robert, On Apr 23, 2018, at 7:23 AM, Robert Stupp wrote: > For MacOS and Windows, Java prefers the user's temporary directory for > java.io.tmpdir, but not for Linux, where it is always set to /tmp. The burden > with this is that if you want to use a different temp directory, you have to >

[PATCH] Prefer TMPDIR over hard coded /tmp

2018-04-23 Thread Robert Stupp
For MacOS and Windows, Java prefers the user's temporary directory for java.io.tmpdir, but not for Linux, where it is always set to /tmp. The burden with this is that if you want to use a different temp directory, you have to explicitly pass -Djava.io.tmpdir=... on the command line, which can b