Hi Naoto,
Historical indeed, and true, it was not exposed prior to JDK6. Just need
to make sure other classes within the package won't accidentally use its
set method or mark it if it's 'deprecated'. But it's a minor issue. I'm
fine with your changeset as is.
Best,
Joe
On 1/3/20 1:24 PM,
Hi Joe,
Thanks again for the review. The reason the way it is is all historical.
percent/perMill/minusSign all had public APIs for the 'char' version
since inception, and text version APIs were added later (JDK13). Thus
they had to be in sync (both fields are accessible through API). On the
Hi Naoto,
The change looks fine to me as only monetaryGroupingSeparator was added
to equals.
I can't help to note though that, all fields participated in the equals
calculation except exponential. Some of the other fields are in similar
situations (one is public and the other not), e.g.
Hi Joe,
I revised the changeset, as the cached hash code in DecimalFormatSymbols
needs to be recalculated when any of the relevant fields is mutated.
Here is the updated webrev:
http://cr.openjdk.java.net/~naoto/8227313/webrev.02/
Naoto
On 1/2/20 2:19 PM, Joe Wang wrote:
Happy New Year,
Happy New Year, Naoto!
Thanks for the explanation and changes. The changeset looks good to me.
-Joe
On 1/2/20 12:50 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Happy new year and thanks for your comments. Please see my replies below:
On 12/23/19 5:20 PM, Joe Wang wrote:
Hi Naoto,
Is there a
Hi Joe,
Happy new year and thanks for your comments. Please see my replies below:
On 12/23/19 5:20 PM, Joe Wang wrote:
Hi Naoto,
Is there a need for an APINote to note the relationship between the new
get/setMonetaryGroupingSeparator and get/setGroupingSeparator methods.
The new method did
Hi Naoto,
Is there a need for an APINote to note the relationship between the new
get/setMonetaryGroupingSeparator and get/setGroupingSeparator methods.
The new method did state it "May be different from {@code grouping
separator} in some locales", but that may be insufficient. For example,
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8227313
The proposed CSR and changeset are located at:
https://bugs.openjdk.java.net/browse/JDK-8235942
https://cr.openjdk.java.net/~naoto/8227313/webrev.00/
The change introduces the new monetary
