7021987: native2ascii file cannot be read error message is broken

2011-03-02 Thread Alan Bateman
I need a reviewer for a small regression in the native2ascii tool whereby its error messages aren't as expected. Early in the jdk7 this code appears to have been changed to address a non-varargs call of varargs method warning in a usage of MessgaeFormat.format. A cast was added to cast a

Re: 7021987: native2ascii file cannot be read error message is broken

2011-03-02 Thread Lance Andersen - Oracle
looks fine Alan On Mar 2, 2011, at 10:12 AM, Alan Bateman wrote: I need a reviewer for a small regression in the native2ascii tool whereby its error messages aren't as expected. Early in the jdk7 this code appears to have been changed to address a non-varargs call of varargs method warning

Re: 7021987: native2ascii file cannot be read error message is broken

2011-03-02 Thread Mandy Chung
Thumbs up. Mandy On 3/2/11 7:12 AM, Alan Bateman wrote: I need a reviewer for a small regression in the native2ascii tool whereby its error messages aren't as expected. Early in the jdk7 this code appears to have been changed to address a non-varargs call of varargs method warning in a

hg: jdk7/tl/jdk: 7021987: native2ascii file cannot be read error message is broken

2011-03-02 Thread alan . bateman
Changeset: 895687e879ca Author:alanb Date: 2011-03-02 16:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895687e879ca 7021987: native2ascii file cannot be read error message is broken Reviewed-by: lancea, mchung ! src/share/classes/sun/tools/native2ascii/Main.java ! test