Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 12/10/11 7:46 AM, Sebastian Sickelmann wrote: > Am 09.12.2011 17:07, schrieb Sean Mullan: >> On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: >>> Am 05.12.2011 19:06, schrieb Sean Mullan: On 12/2/11 11:02 AM, Sean Mullan wrote: >> [0] Solution 1 >> http://dl.dropbox.com/u/436926

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 09.12.2011 17:07, schrieb Sean Mullan: On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: Am 05.12.2011 19:06, schrieb Sean Mullan: On 12/2/11 11:02 AM, Sean Mullan wrote: [0] Solution 1 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html [1] So

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: > Am 05.12.2011 19:06, schrieb Sean Mullan: >> On 12/2/11 11:02 AM, Sean Mullan wrote: >> [0] Solution 1 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html [1] Solution 2 http://dl.d

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 05.12.2011 19:06, schrieb Sean Mullan: On 12/2/11 11:02 AM, Sean Mullan wrote: [0] Solution 1 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html [1] Solution 2 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 12/2/11 11:02 AM, Sean Mullan wrote: >> [0] Solution 1 >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >> [1] Solution 2 >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html I definitely

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 12/2/11 12:54 AM, Sebastian Sickelmann wrote: > The 3 solutions I mentioned are solutions that can be commonly discussed > for a solution choosing for all Exceptions in OpenJDK. > > Webrev[0] shows solution 1 for jx/x/s-Exceptions. From the users > perspective (outside view) solution 1 and 3

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 01.12.2011 16:12, schrieb Sean Mullan: On 11/22/2011 11:45 PM, Sebastian Sickelmann wrote: It's been a long time ago. Had someone had the time to think about this: Am 29.10.2011 13:17, schrieb Sebastian Sickelmann: Sorry i linked the wrong webrev for Solution 3. Am 27.10.2011 16:50, schrie

Re: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 11/22/2011 11:45 PM, Sebastian Sickelmann wrote: It's been a long time ago. Had someone had the time to think about this: Am 29.10.2011 13:17, schrieb Sebastian Sickelmann: Sorry i linked the wrong webrev for Solution 3. Am 27.10.2011 16:50, schrieb Sebastian Sickelmann: Some time ago (see

Re: Last Change for comment on 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Sorry, I have been very busy with some other things in the past few weeks, but I will try to find some time to look at your latest webrev this week. --Sean On 11/29/11 9:33 AM, Sebastian Sickelmann wrote: > Hi, > > I started some cleanup work a while ago and we got into short > discussions whil

Last Change for comment on 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Hi, I started some cleanup work a while ago and we got into short discussions while cleaning-up javax.xml.crypto. Unfortunately i got no relay for a long time. Tried to get some comments on 2011-10-27 [1] and 2011-11-23 [2] but nobody reacted. Maybe i have done something wrong, maybe i hav

Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

It's been a long time ago. Had someone had the time to think about this: Am 29.10.2011 13:17, schrieb Sebastian Sickelmann: Sorry i linked the wrong webrev for Solution 3. Am 27.10.2011 16:50, schrieb Sebastian Sickelmann: Some time ago (see below) i ask what would be the right solution to ref

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Sorry i linked the wrong webrev for Solution 3. Am 27.10.2011 16:50, schrieb Sebastian Sickelmann: Some time ago (see below) i ask what would be the right solution to refactor exception initialization to? Solution 1: Disallow calls to initCause after creation, if there was an exception-cause-f

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Some time ago (see below) i ask what would be the right solution to refactor exception initialization to? Solution 1: Disallow calls to initCause after creation, if there was an exception-cause-functionality in this class before it was introduced to Throwable. Solution 2: Disallow calls to initC

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 01.10.2011 18:19, schrieb Sean Mullan: On 9/30/11 2:15 PM, Sebastian Sickelmann wrote: I think I know the reason. If you allow initCause to be called when a cause is not initially provided, then getCause will still return null, which seems wrong. getCause() of Throwable and all classes that

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 9/30/11 2:15 PM, Sebastian Sickelmann wrote: >>> I think I know the reason. If you allow initCause to be called when a >>> cause is >>> not initially provided, then getCause will still return null, which >>> seems wrong. >>> >> getCause() of Throwable and all classes that doesn't had a chainin

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 28.09.2011 06:36, schrieb Sebastian Sickelmann: Am 27.09.2011 17:38, schrieb Sean Mullan: On 9/24/11 5:55 AM, Sebastian Sickelmann wrote: Am 23.09.2011 20:54, schrieb Sean Mullan: On 9/17/11 3:09 PM, Sebastian Sickelmann wrote: i have updated the webrev [0]. But i think that L69 and L72 o

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 27.09.2011 17:38, schrieb Sean Mullan: On 9/24/11 5:55 AM, Sebastian Sickelmann wrote: Am 23.09.2011 20:54, schrieb Sean Mullan: On 9/17/11 3:09 PM, Sebastian Sickelmann wrote: i have updated the webrev [0]. But i think that L69 and L72 of the test should be changed to checkMutable and the

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

On 9/24/11 5:55 AM, Sebastian Sickelmann wrote: > Am 23.09.2011 20:54, schrieb Sean Mullan: >> On 9/17/11 3:09 PM, Sebastian Sickelmann wrote: >> i have updated the webrev [0]. But i think that L69 and L72 of the test should be changed to checkMutable and the implementation of the ex

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Am 23.09.2011 20:54, schrieb Sean Mullan: On 9/17/11 3:09 PM, Sebastian Sickelmann wrote: i have updated the webrev [0]. But i think that L69 and L72 of the test should be changed to checkMutable and the implementation of the exceptions accordantly. That's an interesting question. The current

Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Sebastian Sickelmann wrote: : In a following post Alan writes that this should best be discussed here. What is the hg repository for patches in this mailinglist? I don't see any security-dev related repository for openjdk8 in http://hg.openjdk.java.net/ the patch is based on ***

7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

Hi, while making some change for using exception-chaining on RuntimeException in more cases, i found that javax.xml.crypto.NoSuchMechnismException had a private cause field that isn't necessary since throwable can handle it. But just removing isn't that simple as Alan pointed out[1]. First of