Pushed:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f78869c66d
Darryl, please update the bug report.
Thanks,
s'marks
On 7/17/12 9:08 AM, Stuart Marks wrote:
OK! Looks good!
I guess I have to push this for you. Can you commit the changeset in your repo,
with proper commit comments etc., and
OK! Looks good!
I guess I have to push this for you. Can you commit the changeset in your repo,
with proper commit comments etc., and send me the exported changeset? (Directly
to me is fine, it doesn't need to be on the open list.) I'll push it later today.
Thanks.
s'marks
On 7/16/12 3:54
Hi Alan. The reason we didn't go this route is that we want to be able
to create the RMI Registry on a random port which is not one of the
reserved ports (see TestLibrary.FIXED_PORT_MIN/MAX). To do this, we use
'new ServerSocket(0)', which creates a socket on a random port, then
close the por
Here's webrev.05
(http://cr.openjdk.java.net/~dmocek/7142596/webrev.05). Changes:
- Simplify createRegistryOnUnusedPort()
- Simplify getUnusedRandomPort()
- Add isReservedPort() method to determine if a port is a reserved port
# (not just one of the FIXED_PORT's, but also any port which should
After looking at it again, technically, we ought to remove the fixed
ports from the list of ports available to the RMI Registry (OK, so this
isn't a BIG deal). Using SocketFactory's as Alan suggests will solve
this problem as well.
Darryl
On 07/16/2012 08:42 AM, Stuart Marks wrote:
Hi Darry
Hi Darryl,
Sorry, I'm going to have to ask you to update this again. The issues are in
TestLibrary.java and are all related to catching exceptions and throwing new
exception instances, discarding the original exception (and probably relevant
diagnostic information) in the process.
Let's get
On 14/07/2012 00:09, Stuart Marks wrote:
There is at least one test case that wants to create two registries
within the same JVM. The first call to createRegistry(0) will usually
succeed. The second call from the same JVM will throw an
ExportException. So, we catch this and retry using a rand
On 7/13/12 1:59 AM, Alan Bateman wrote:
On 13/07/2012 01:13, Stuart Marks wrote:
But for creating a registry, createRegistry(0) will usually work the first
time. If it throws ExportException, it does so for a specific reason, so we
should retry once on an unused random port. But if this still fa
On 07/12/2012 05:13 PM, Stuart Marks wrote:
OK, I took a look at the revised webrev. Most stuff is good. A couple
changes are necessary though.
*** MultipleRegistries.java
Not a big deal, but the comment at lines 65-67 is no longer necessary.
Comment removed.
*** TestLibrary.java
I th
On 13/07/2012 01:13, Stuart Marks wrote:
But for creating a registry, createRegistry(0) will usually work the
first time. If it throws ExportException, it does so for a specific
reason, so we should retry once on an unused random port. But if this
still fails, don't think retrying repeatedly ma
OK, I took a look at the revised webrev. Most stuff is good. A couple changes
are necessary though.
*** MultipleRegistries.java
Not a big deal, but the comment at lines 65-67 is no longer necessary.
*** TestLibrary.java
I think the reserved port range stuff still needs to be fixed up.
Th
On 05/07/2012 22:22, Darryl Mocek wrote:
Hello core-libs. Please review this webrev to fix Bugs #7142596 and
7161503. Webrev can be found here:
http://cr.openjdk.java.net/~dmocek/7142596/webrev.02. This commit
fixes concurrency issues with the RMI tests.
- Added TestLibrary.createRegistryOn
On 06/07/2012 19:47, Stuart Marks wrote:
:
*** LookupNameWithColon.java
This test is missing an @run tag, thus it won't actually get run!
Since you've specified an @build tag, you have to specify a separate
@run tag to run the test. It's possible to deduce this with a careful
reading of th
On 07/09/2012 04:41 PM, Stuart Marks wrote:
OK, here's the review for the second half of the files in the webrev.
I saw your reply to the first half (to which I'll reply separately),
and I don't think there's anything here that's affected by them.
*** AppleUserImpl.java
*** ApplicationServer
On 7/9/12 5:04 PM, Darryl Mocek wrote:
I originally had getUnusedRandomPort/createRegistry(randomPort), but Alan felt
LocateRegistry.createRegistry(0) is a better choice. getUnusedRandomPort
creates a socket to ensure the port is available, then closes it and returns
the port number. It's possibl
On Mon 09 Jul 2012 05:02:23 PM PDT, Stuart Marks wrote:
On 7/9/12 11:14 AM, Darryl Mocek wrote:
*** SetChildEnv.java
The testing of the message string from the IOException causes me great
concern. This message is defined all the way over in
java.io.PipedInputStream, and while it's not loc
On 7/9/12 11:14 AM, Darryl Mocek wrote:
*** SetChildEnv.java
The testing of the message string from the IOException causes me great
concern. This message is defined all the way over in
java.io.PipedInputStream, and while it's not localized, it does seem
like a pretty fragile dependency. I mean,
OK, here's the review for the second half of the files in the webrev. I saw
your reply to the first half (to which I'll reply separately), and I don't
think there's anything here that's affected by them.
*** AppleUserImpl.java
*** ApplicationServer.java
REGISTRY_PORT should be a local variab
Stuart,
see inline...
On Fri 06 Jul 2012 11:47:54 AM PDT, Stuart Marks wrote:
Hi,
I've reviewed the first half of the files, thru
test/java/rmi/registry/reexport/Reexport.java. Basically things look
good and make sense, but there are some details to be ironed out and
some cleanups to be do
Hi,
I've reviewed the first half of the files, thru
test/java/rmi/registry/reexport/Reexport.java. Basically things look good and
make sense, but there are some details to be ironed out and some cleanups to be
done. Nothing major, I think, with the exception of SetChildEnv. See discussion
bel
Hello core-libs. Please review this webrev to fix Bugs #7142596 and
7161503. Webrev can be found here:
http://cr.openjdk.java.net/~dmocek/7142596/webrev.02. This commit fixes
concurrency issues with the RMI tests.
- Added TestLibrary.createRegistryOnUnusedPort method. This creates an
RMIRe
21 matches
Mail list logo
