Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-17 Thread Alan Bateman
On 16/07/2012 19:42, Xueming Shen wrote: Hi Alan, I gave the "continue ->else if " a try, it appears the server vm obviously likes the "continue" approach (it is consistent with what we experienced in the past when we did similar approach for ascii, in which we separate/singled the ascii pat

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-16 Thread Xueming Shen
Hi Alan, I gave the "continue ->else if " a try, it appears the server vm obviously likes the "continue" approach (it is consistent with what we experienced in the past when we did similar approach for ascii, in which we separate/singled the ascii path out). So I guess we probably want to kee

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-14 Thread Ulf Zibis
Am 13.07.2012 23:59, schrieb Dalibor Topic: Tim is going through then issues in Bugzilla and closing the already fixed ones, and migrating the rest over to bug.sun.com in preparation for the the JIRA migration, afaik. So if I understand Joe correct, the patches form bugs.openjdk.java.net have

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Joe Darcy
Hello, On 7/13/2012 2:59 PM, Dalibor Topic wrote: On 7/13/12 9:22 PM, Ulf Zibis wrote: Am 13.07.2012 14:19, schrieb Alan Bateman: Ulf - you've got several patches to the double byte charsets and I wonder if you have cycles to try Sherman's patch with jdk8 to see if there is any more to be ga

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Dalibor Topic
On 7/13/12 9:22 PM, Ulf Zibis wrote: > Am 13.07.2012 14:19, schrieb Alan Bateman: >> >> Ulf - you've got several patches to the double byte charsets and I wonder if >> you have cycles to try Sherman's patch with jdk8 to see if there is any more >> to be gained? > > First, most of those patches h

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Alan Bateman
On 13/07/2012 20:22, Ulf Zibis wrote: First, most of those patches have been closed from official side, don't really understand why: https://bugs.openjdk.java.net/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&long_desc_type=substring&long_desc=&bug_file_loc_type=a

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Ulf Zibis
Am 13.07.2012 14:19, schrieb Alan Bateman: Ulf - you've got several patches to the double byte charsets and I wonder if you have cycles to try Sherman's patch with jdk8 to see if there is any more to be gained? Additionally, I'm wondering, that EUC_TW is not part of the patch. I've worked on

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Ulf Zibis
Am 13.07.2012 14:19, schrieb Alan Bateman: Ulf - you've got several patches to the double byte charsets and I wonder if you have cycles to try Sherman's patch with jdk8 to see if there is any more to be gained? First, most of those patches have been closed from official side, don't really un

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Xueming Shen
On 07/13/2012 05:19 AM, Alan Bateman wrote: On 11/07/2012 00:11, Xueming Shen wrote: Hi, In JDK7, the decoder and encoder implementation of most of our single-byte charsets and UTF-8 charset are optimized to implement the internal interfce sun.nio.cs.ArrayDecoder/ Encoder to provide a fastpa

Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-13 Thread Alan Bateman
On 11/07/2012 00:11, Xueming Shen wrote: Hi, In JDK7, the decoder and encoder implementation of most of our single-byte charsets and UTF-8 charset are optimized to implement the internal interfce sun.nio.cs.ArrayDecoder/ Encoder to provide a fastpath for String.getBytes(...) and new String(b

Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])

2012-07-10 Thread Xueming Shen
Hi, In JDK7, the decoder and encoder implementation of most of our single-byte charsets and UTF-8 charset are optimized to implement the internal interfce sun.nio.cs.ArrayDecoder/ Encoder to provide a fastpath for String.getBytes(...) and new String(byte[]...) operations. I have an old blog