Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-29 Thread Joe Darcy
On 8/28/2019 9:23 AM, Martin Buchholz wrote: Should Serial.java have an @since 14 ? Yes; I'll fold that into another update. Thanks, -Joe

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-28 Thread Roger Riggs
Hi Joe, Looks fine, Roger On 8/27/19 9:28 PM, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-28 Thread Alan Bateman
On 28/08/2019 17:08, Joe Darcy wrote: The intention here is to be "mostly exhaustive" rather than "entirely exhaustive" in applying the annotation type so I'd prefer to defer updating generated exceptions to future work. Okay, although all you need is: $ hg diff make diff -r e17f768b3b71

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-28 Thread Martin Buchholz
Should Serial.java have an @since 14 ?

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-28 Thread Joe Darcy
Hi Alan, On 8/27/2019 11:39 PM, Alan Bateman wrote: On 28/08/2019 02:28, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-28 Thread Alan Bateman
On 28/08/2019 02:28, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related fields and methods to be

JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

2019-08-27 Thread Joe Darcy
Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related fields and methods to be marked as documentation and to allow