Hi Joe,
This looks fine.
Brian
On Sep 23, 2015, at 1:31 PM, joe darcy wrote:
> Thanks for the review; I plan to push a slightly amended version later today.
> The new version
>
> * rewords the paragraph you suggested
> * declares the method strictfp
> * fixes a comparison that mixes integer
Hi Brian,
Thanks for the review; I plan to push a slightly amended version later
today. The new version
* rewords the paragraph you suggested
* declares the method strictfp
* fixes a comparison that mixes integer and floating-point values
* add more test cases near the subnormal threshold
Dif
Hi Joe,
Overall this looks good. I only have a couple of minor observations related to
internal documentation.
1. FdLibm.java
Lines 158-166: The verbiage in the note might benefit from a little reworking.
2. HypotTests.java
Line 46: “Commutative” is misspelled.
Thanks,
Brian
On Sep 21, 201
On 9/21/2015 11:51 PM, Dawid Weiss wrote:
Not that I understand the math behind it, but out of curiosity I
looked and spotted a typo in:
muti-precision
(unless it's some kind of complex IEEE-approved jargon for something I
have no idea about :).
No; just a typo in the original pow sources :
Dawid,
Multi-precision is one of several more or less interchangeable terms to
indicate that the precision of a value is limited by the amount of memory
available as opposed to the size of the primitive data type. For example in the
case of Java, large integers are represented internally to the
Not that I understand the math behind it, but out of curiosity I
looked and spotted a typo in:
> muti-precision
(unless it's some kind of complex IEEE-approved jargon for something I
have no idea about :).
Dawid
On Tue, Sep 22, 2015 at 3:22 AM, Joseph D. Darcy wrote:
> Hello,
>
> Please review
Hello,
Please review the next portion of the port of fdlibm to Java:
JDK-7130085 Port fdlibm hypot to Java
http://cr.openjdk.java.net/~darcy/7130085.0/
As before with pow, this isn't necessarily the end state of the code
we'd like to stop at, but it should be sufficiently idiomatic Jav
